sr-dev May 2022

sr-dev@lists.kamailio.org

12 participants
291 discussions

[kamailio/kamailio] userblocklist: fix restart errors (PR #3102)
by Stefan Mititelu 08 May '22

08 May '22

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Spotted this ERRORs on kamailio restart: ``` ERROR: <core> [db.c:481]: db_use_table(): invalid connection parameter ERROR: userblocklist [db.c:123]: db_reload_source(): cannot use db table 'globalblocklist' ERROR: userblocklist [userblocklist.c:425]: load_source(): cannot load source from 'globalblocklist ``` Debugging it further, seen that the above ERRORs appear on ```check_allowlist()``` function fixup. This was happening because db connection is closed in mod_init and re-done in child_init. But the fixups happen before child_init and they need db connection. Decided to not close the db connection after mod_init because they are later, first closed and then re-opened, in each child. Figured out this fix after checked where each function of db_userblocklist.c is used. ERRORs no longer appear on restart. Thank you, Stefan You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3102 -- Commit Summary -- * userblocklist: fix restart errors -- File Changes -- M src/modules/userblocklist/db_userblocklist.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3102.patch https://github.com/kamailio/kamailio/pull/3102.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3102 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3102(a)github.com>

2 2

git:master:778374ab: userblocklist: fix restart errors
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: 778374aba27d81058869dba18b5dd0833893056a URL: https://github.com/kamailio/kamailio/commit/778374aba27d81058869dba18b5dd08… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:32:12+02:00 userblocklist: fix restart errors --- Modified: src/modules/userblocklist/db_userblocklist.c --- Diff: https://github.com/kamailio/kamailio/commit/778374aba27d81058869dba18b5dd08… Patch: https://github.com/kamailio/kamailio/commit/778374aba27d81058869dba18b5dd08… --- diff --git a/src/modules/userblocklist/db_userblocklist.c b/src/modules/userblocklist/db_userblocklist.c index 47469f5adc..e857178f25 100644 --- a/src/modules/userblocklist/db_userblocklist.c +++ b/src/modules/userblocklist/db_userblocklist.c @@ -91,7 +91,6 @@ int userblocklist_db_init(void) { userblocklist_db_close(); return -1; } - userblocklist_db_close(); return 0; }

1 0

git:master:97efd6a6: modules: readme files regenerated - acc ... [skip ci]
by Kamailio Dev 08 May '22

08 May '22

Module: kamailio Branch: master Commit: 97efd6a64380025f3b4ef45372180f7e61448c1c URL: https://github.com/kamailio/kamailio/commit/97efd6a64380025f3b4ef45372180f7… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-05-08T17:31:17+02:00 modules: readme files regenerated - acc ... [skip ci] --- Modified: src/modules/acc/README Modified: src/modules/ldap/README --- Diff: https://github.com/kamailio/kamailio/commit/97efd6a64380025f3b4ef45372180f7… Patch: https://github.com/kamailio/kamailio/commit/97efd6a64380025f3b4ef45372180f7… --- diff --git a/src/modules/acc/README b/src/modules/acc/README index 7c31188ac7..878623d24f 100644 --- a/src/modules/acc/README +++ b/src/modules/acc/README @@ -1129,7 +1129,7 @@ modparam("acc", "cdr_start_on_confirmed", 1) 6.34. cdr_facility (integer) Log facility to which CDR messages are issued to syslog. This allows to - easily seperate CDR-specific logging from the other log messages. + easily separate CDR-specific logging from the other log messages. Default value is LOG_DAEMON. diff --git a/src/modules/ldap/README b/src/modules/ldap/README index c7555ca3c6..921f45822f 100644 --- a/src/modules/ldap/README +++ b/src/modules/ldap/README @@ -533,7 +533,7 @@ ldap_result("telephoneNumber/$avp(s:tel_number)"); AVP. It can be either str for string, or int for integer. If avp_type is specified as int then ldap_result tries to convert the LDAP attribute values to integer. In this case, the values are only stored - as AVP if the conversion to integer is succesfull. + as AVP if the conversion to integer is successful. Function Parameters:

1 0

[kamailio/kamailio] Fix typos (PR #3103)
by Bastian Triller 08 May '22

08 May '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Fix typos. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3103 -- Commit Summary -- * doc: Fix typos * pkg: Fix typos * core: Fix typos * lib: Fix typos * acc: Fix typos * auth: Fix typos * ctl: Fix typos * ldap: Fix typos * pike: Fix typos * sanity: Fix typos * tls: Fix typos * uid_auth_db: Fix typos * utils: Fix typos -- File Changes -- M doc/misc/NEWS (2) M doc/tutorials/locking.txt (4) M pkg/kamailio/deb/bionic/rules (2) M pkg/kamailio/deb/bookworm/rules (2) M pkg/kamailio/deb/bullseye/rules (2) M pkg/kamailio/deb/buster/rules (2) M pkg/kamailio/deb/debian/rules (2) M pkg/kamailio/deb/focal/rules (2) M pkg/kamailio/deb/jessie/rules (2) M pkg/kamailio/deb/precise/rules (2) M pkg/kamailio/deb/sid/rules (2) M pkg/kamailio/deb/stretch/rules (2) M pkg/kamailio/deb/trusty/rules (2) M pkg/kamailio/deb/wheezy/rules (2) M pkg/kamailio/deb/xenial/rules (2) M src/core/atomic/atomic_mips2.h (2) M src/core/dns_cache.c (4) M src/core/forward.c (2) M src/core/resolve.c (4) M src/core/tcp_main.c (10) M src/lib/cds/dstring.h (2) M src/lib/srdb1/schema/uid_credentials.xml (2) M src/lib/srdb2/db_cmd.c (4) M src/lib/srdb2/schema/credentials.xml (2) M src/modules/acc/doc/acc_admin.xml (2) M src/modules/auth/challenge.c (2) M src/modules/auth/nonce.c (12) M src/modules/ctl/binrpc.h (4) M src/modules/ldap/doc/ldap_admin.xml (2) M src/modules/pike/ip_tree.c (2) M src/modules/sanity/sanity.c (2) M src/modules/sanity/sanity.h (2) M src/modules/tls/tls_server.c (2) M src/modules/uid_auth_db/authorize.c (2) M utils/kamctl/kamdbctl.pgsql (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3103.patch https://github.com/kamailio/kamailio/pull/3103.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3103 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3103(a)github.com>

2 2

git:master:c282b581: utils: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: c282b5812c9e9badb4c99fe8ce3bd5cce927044f URL: https://github.com/kamailio/kamailio/commit/c282b5812c9e9badb4c99fe8ce3bd5c… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 utils: Fix typos --- Modified: utils/kamctl/kamdbctl.pgsql --- Diff: https://github.com/kamailio/kamailio/commit/c282b5812c9e9badb4c99fe8ce3bd5c… Patch: https://github.com/kamailio/kamailio/commit/c282b5812c9e9badb4c99fe8ce3bd5c… --- diff --git a/utils/kamctl/kamdbctl.pgsql b/utils/kamctl/kamdbctl.pgsql index fa1fe1ada8..1eb5d88d2b 100644 --- a/utils/kamctl/kamdbctl.pgsql +++ b/utils/kamctl/kamdbctl.pgsql @@ -20,7 +20,7 @@ # 2006-10-19 Added address table (bogdan) # 2006-10-27 subscriber table cleanup; some columns are created only if # serweb is installed (bogdan) -# 2007-01-26 added seperate installation routine for presence related tables +# 2007-01-26 added separate installation routine for presence related tables # and fix permissions for the SERIAL sequences. # 2007-05-21 Move SQL database definitions out of this script (henning) # 2007-05-31 Move common definitions to kamdbctl.base file (henningw)

1 0

git:master:f72c5743: uid_auth_db: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: f72c574372abf4c0286799137896a247ed6269b6 URL: https://github.com/kamailio/kamailio/commit/f72c574372abf4c0286799137896a24… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 uid_auth_db: Fix typos --- Modified: src/modules/uid_auth_db/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/f72c574372abf4c0286799137896a24… Patch: https://github.com/kamailio/kamailio/commit/f72c574372abf4c0286799137896a24… --- diff --git a/src/modules/uid_auth_db/authorize.c b/src/modules/uid_auth_db/authorize.c index 0dd155adda..a71fd45793 100644 --- a/src/modules/uid_auth_db/authorize.c +++ b/src/modules/uid_auth_db/authorize.c @@ -216,7 +216,7 @@ static int generate_avps(db_res_t* result, db_rec_t *row) /* this is a dirty work around to check the credentials of all users, * if the database query returned more then one result * - * Fills res (which must be db_free'd afterwards if the call was succesfull) + * Fills res (which must be db_free'd afterwards if the call was successful) * returns 0 on success, 1 on no match (?) * and -1 on error (memory, db a.s.o). * WARNING: if -1 is returned res _must_ _not_ be freed (it's empty)

1 0

git:master:ff9b030b: tls: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: ff9b030be39f82d0e952301ddd0b61a0de5a8041 URL: https://github.com/kamailio/kamailio/commit/ff9b030be39f82d0e952301ddd0b61a… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 tls: Fix typos --- Modified: src/modules/tls/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/ff9b030be39f82d0e952301ddd0b61a… Patch: https://github.com/kamailio/kamailio/commit/ff9b030be39f82d0e952301ddd0b61a… --- diff --git a/src/modules/tls/tls_server.c b/src/modules/tls/tls_server.c index 7004096adf..00686a07dd 100644 --- a/src/modules/tls/tls_server.c +++ b/src/modules/tls/tls_server.c @@ -737,7 +737,7 @@ void tls_h_tcpconn_close_f(struct tcp_connection *c, int fd) tls_mbuf_init(&rd, 0, 0); /* no read */ tls_mbuf_init(&wr, wr_buf, sizeof(wr_buf)); if (tls_set_mbufs(c, &rd, &wr)==0) { - tls_shutdown(c); /* shudown only on succesfull set fd */ + tls_shutdown(c); /* shutdown only on successful set fd */ /* write as much as possible and update wr. * Since this is a close, we don't want to queue the write * (if it can't write immediately, just fail silently)

1 0

git:master:c5ff6d96: sanity: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: c5ff6d9638b1033d2536ed46a7d254c016d8b103 URL: https://github.com/kamailio/kamailio/commit/c5ff6d9638b1033d2536ed46a7d254c… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 sanity: Fix typos --- Modified: src/modules/sanity/sanity.c Modified: src/modules/sanity/sanity.h --- Diff: https://github.com/kamailio/kamailio/commit/c5ff6d9638b1033d2536ed46a7d254c… Patch: https://github.com/kamailio/kamailio/commit/c5ff6d9638b1033d2536ed46a7d254c… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 4264c2c190..f49d6e50c1 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -578,7 +578,7 @@ int check_cseq_value(sip_msg_t* msg) { return SANITY_CHECK_PASSED; } -/* compare the Content-Length value with the accutal body length */ +/* compare the Content-Length value with the actual body length */ int check_cl(sip_msg_t* msg) { char *body; diff --git a/src/modules/sanity/sanity.h b/src/modules/sanity/sanity.h index 339548edf4..0808cc99a5 100644 --- a/src/modules/sanity/sanity.h +++ b/src/modules/sanity/sanity.h @@ -48,7 +48,7 @@ int check_via_protocol(struct sip_msg* _msg); /* check if the SIP version in the Via header is 2.0 */ int check_via_sip_version(struct sip_msg* _msg); -/* compare the Content-Length value with the accutal body length */ +/* compare the Content-Length value with the actual body length */ int check_cl(struct sip_msg* _msg); /* compare the method in the CSeq header with the request line value */

1 0

git:master:4caf7e70: ctl: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: 4caf7e70c09a5b61f5c28b89fa1ea5c951e4cbc0 URL: https://github.com/kamailio/kamailio/commit/4caf7e70c09a5b61f5c28b89fa1ea5c… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 ctl: Fix typos --- Modified: src/modules/ctl/binrpc.h --- Diff: https://github.com/kamailio/kamailio/commit/4caf7e70c09a5b61f5c28b89fa1ea5c… Patch: https://github.com/kamailio/kamailio/commit/4caf7e70c09a5b61f5c28b89fa1ea5c… --- diff --git a/src/modules/ctl/binrpc.h b/src/modules/ctl/binrpc.h index bb34cd3be5..da4524878c 100644 --- a/src/modules/ctl/binrpc.h +++ b/src/modules/ctl/binrpc.h @@ -694,7 +694,7 @@ inline static int binrpc_bytes_needed(struct binrpc_parse_ctx *ctx) * known problems: no support for arrays inside STRUCT * param smode: allow simple vals inside struct (needed for * not-strict-formatted rpc responses) - * returns position after the record and *err==0 if succesfull + * returns position after the record and *err==0 if successful * original position and *err<0 if not */ inline static unsigned char* binrpc_read_record(struct binrpc_parse_ctx* ctx, unsigned char* buf, @@ -829,7 +829,7 @@ inline static unsigned char* binrpc_read_record(struct binrpc_parse_ctx* ctx, } break; case BINRPC_T_DOUBLE: /* FIXME: hack: represented as fixed point - inside an long long */ + inside a long long */ if (ctx->in_struct && smode==0) goto error_record; p=binrpc_read_llong(&ll, len, p, end, err); v->u.fval=((double)ll)/1000;

1 0

git:master:b94f8da5: pike: Fix typos
by Henning Westerholt 08 May '22

08 May '22

Module: kamailio Branch: master Commit: b94f8da598ef99d06a0db8f9bb2f9ca29a198740 URL: https://github.com/kamailio/kamailio/commit/b94f8da598ef99d06a0db8f9bb2f9ca… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-05-08T17:30:14+02:00 pike: Fix typos --- Modified: src/modules/pike/ip_tree.c --- Diff: https://github.com/kamailio/kamailio/commit/b94f8da598ef99d06a0db8f9bb2f9ca… Patch: https://github.com/kamailio/kamailio/commit/b94f8da598ef99d06a0db8f9bb2f9ca… --- diff --git a/src/modules/pike/ip_tree.c b/src/modules/pike/ip_tree.c index 1fe9227a5f..12e03055b0 100644 --- a/src/modules/pike/ip_tree.c +++ b/src/modules/pike/ip_tree.c @@ -92,7 +92,7 @@ static gen_lock_set_t* init_lock_set(int *size) lset = 0; continue; } - /* alloc and init succesfull */ + /* alloc and init successful */ break; }

1 0

← Newer
1
...
21
22
23
24
25
26
27
...
30
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2022