sr-dev March 2022

sr-dev@lists.kamailio.org

10 participants
244 discussions

git:master:5c774d6e: ims_auth: warn if the header type is not set properly
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 5c774d6eced2ad52cb341b9e36419aac6c0506cb URL: https://github.com/kamailio/kamailio/commit/5c774d6eced2ad52cb341b9e36419aa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:38:42+01:00 ims_auth: warn if the header type is not set properly --- Modified: src/modules/ims_auth/utils.c --- Diff: https://github.com/kamailio/kamailio/commit/5c774d6eced2ad52cb341b9e36419aa… Patch: https://github.com/kamailio/kamailio/commit/5c774d6eced2ad52cb341b9e36419aa… --- diff --git a/src/modules/ims_auth/utils.c b/src/modules/ims_auth/utils.c index 94d02e3fe7..b745af0275 100644 --- a/src/modules/ims_auth/utils.c +++ b/src/modules/ims_auth/utils.c @@ -71,8 +71,9 @@ int ims_find_credentials(struct sip_msg* _m, str* _realm, hdr_flags = HDR_PROXYAUTH_F; break; default: + LM_WARN("unexpected header type %d - using authorization\n", _hftype); hook = &(_m->authorization); - hdr_flags = HDR_T2F(_hftype); + hdr_flags = HDR_AUTHORIZATION_F; break; }

1 0

git:master:f9a38d6b: core: parser - catch special header types for get_hdr()
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: f9a38d6b621a2c3966a3c85dce6fdd2e6bb8d431 URL: https://github.com/kamailio/kamailio/commit/f9a38d6b621a2c3966a3c85dce6fdd2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:35:12+01:00 core: parser - catch special header types for get_hdr() --- Modified: src/core/parser/msg_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/f9a38d6b621a2c3966a3c85dce6fdd2… Patch: https://github.com/kamailio/kamailio/commit/f9a38d6b621a2c3966a3c85dce6fdd2… --- diff --git a/src/core/parser/msg_parser.c b/src/core/parser/msg_parser.c index a348503544..6455c9e539 100644 --- a/src/core/parser/msg_parser.c +++ b/src/core/parser/msg_parser.c @@ -1012,10 +1012,14 @@ hdr_field_t* get_hdr(const sip_msg_t* const msg, const enum _hdr_types_t ht) { hdr_field_t *hdr; - if (msg->parsed_flag & HDR_T2F(ht)) + if (ht == HDR_ERROR_T || ht == HDR_EOH_T) { + return NULL; + } + if (msg->parsed_flag & HDR_T2F(ht)) { for(hdr = msg->headers; hdr; hdr = hdr->next) { if(hdr->type == ht) return hdr; } + } return NULL; }

1 0

git:master:67e0fa5e: core: parser digest - warn if the header type is not set properly
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 67e0fa5e53ef5d4dd9802e3027b2bc7ff6dcb671 URL: https://github.com/kamailio/kamailio/commit/67e0fa5e53ef5d4dd9802e3027b2bc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:30:58+01:00 core: parser digest - warn if the header type is not set properly --- Modified: src/core/parser/digest/digest.c --- Diff: https://github.com/kamailio/kamailio/commit/67e0fa5e53ef5d4dd9802e3027b2bc7… Patch: https://github.com/kamailio/kamailio/commit/67e0fa5e53ef5d4dd9802e3027b2bc7… --- diff --git a/src/core/parser/digest/digest.c b/src/core/parser/digest/digest.c index ccc62a6551..83cce621f0 100644 --- a/src/core/parser/digest/digest.c +++ b/src/core/parser/digest/digest.c @@ -259,8 +259,9 @@ int find_credentials(struct sip_msg* msg, str* realm, hdr_flags=HDR_PROXYAUTH_F; break; default: + LM_WARN("unexpected header type %d - using authorization\n", hftype); hook = &(msg->authorization); - hdr_flags=HDR_T2F(hftype); + hdr_flags=HDR_AUTHORIZATION_F; break; }

1 0

git:master:8b20e604: core: parse - fix typo in comment of previous commit
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 8b20e6045dbebdb784a4e8f66d81fc79c0a17304 URL: https://github.com/kamailio/kamailio/commit/8b20e6045dbebdb784a4e8f66d81fc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:18:23+01:00 core: parse - fix typo in comment of previous commit --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/8b20e6045dbebdb784a4e8f66d81fc7… Patch: https://github.com/kamailio/kamailio/commit/8b20e6045dbebdb784a4e8f66d81fc7… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index 8f7a53f77b..edc46acea1 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -1238,7 +1238,7 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) /* common sanity checks */ if(uri->port.len>5) { - /* port value to large */ + /* port value too large */ goto error_invalid_port; } if(uri->host.len>0 && uri->host.s>buf && *(uri->host.s-1)=='@'

1 0

git:master:eda4b3c5: core: parse uri - sanity check for user part
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: eda4b3c51ce12d4fe052b7e9ad40be1ef6e56444 URL: https://github.com/kamailio/kamailio/commit/eda4b3c51ce12d4fe052b7e9ad40be1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:11:09+01:00 core: parse uri - sanity check for user part --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/eda4b3c51ce12d4fe052b7e9ad40be1… Patch: https://github.com/kamailio/kamailio/commit/eda4b3c51ce12d4fe052b7e9ad40be1… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index 6cbf22a7c7..8f7a53f77b 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -1236,8 +1236,16 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) break; /* do nothing, avoids a compilation warning */ } - if(uri->port.len>5) + /* common sanity checks */ + if(uri->port.len>5) { + /* port value to large */ goto error_invalid_port; + } + if(uri->host.len>0 && uri->host.s>buf && *(uri->host.s-1)=='@' + && uri->user.len<=0) { + /* '@' before host, but no user part */ + goto error_bad_uri; + } #ifdef EXTRA_DEBUG /* do stuff */

1 0

git:master:692d15ce: pua_reginfo: init uri buffer
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 692d15ce9bcc329fff55060dcdc8e5161f12c30e URL: https://github.com/kamailio/kamailio/commit/692d15ce9bcc329fff55060dcdc8e51… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:00:41+01:00 pua_reginfo: init uri buffer --- Modified: src/modules/pua_reginfo/notify.c --- Diff: https://github.com/kamailio/kamailio/commit/692d15ce9bcc329fff55060dcdc8e51… Patch: https://github.com/kamailio/kamailio/commit/692d15ce9bcc329fff55060dcdc8e51… --- diff --git a/src/modules/pua_reginfo/notify.c b/src/modules/pua_reginfo/notify.c index ee533a6a63..07fceba899 100644 --- a/src/modules/pua_reginfo/notify.c +++ b/src/modules/pua_reginfo/notify.c @@ -239,6 +239,7 @@ int process_body(str notify_body, udomain_t * domain) { /* Temporary */ int mem_only = 1; + uri[0] = '\0'; doc = xmlParseMemory(notify_body.s, notify_body.len); if(doc== NULL) { LM_ERR("Error while parsing the xml body message, Body is:\n%.*s\n",

1 0

git:master:0b684a5d: sipcapture: more init buffers content
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 0b684a5d9a2f5d17e64cb8cb5f4b53b06f180f06 URL: https://github.com/kamailio/kamailio/commit/0b684a5d9a2f5d17e64cb8cb5f4b53b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:00:41+01:00 sipcapture: more init buffers content --- Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/0b684a5d9a2f5d17e64cb8cb5f4b53b… Patch: https://github.com/kamailio/kamailio/commit/0b684a5d9a2f5d17e64cb8cb5f4b53b… --- diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index 4c032ab239..6ec37ffbd7 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -2569,6 +2569,8 @@ int receive_logging_json_msg(char *buf, unsigned int len, str corrtmp = STR_NULL; _capture_mode_data_t *c = NULL; + ipstr_dst[0] = '\0'; + ipstr_src[0] = '\0'; c = capture_def; if(!c) { LM_ERR("no connection mode available to store data\n");

1 0

git:master:0204232b: dmq: init peer structures
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 0204232ba1f229edb9c7e0080e98e9d3b2500672 URL: https://github.com/kamailio/kamailio/commit/0204232ba1f229edb9c7e0080e98e9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:00:41+01:00 dmq: init peer structures --- Modified: src/modules/dmq/dmq_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/0204232ba1f229edb9c7e0080e98e9d… Patch: https://github.com/kamailio/kamailio/commit/0204232ba1f229edb9c7e0080e98e9d… --- diff --git a/src/modules/dmq/dmq_funcs.c b/src/modules/dmq/dmq_funcs.c index aeea4a83e3..a71e0a85a3 100644 --- a/src/modules/dmq/dmq_funcs.c +++ b/src/modules/dmq/dmq_funcs.c @@ -300,8 +300,8 @@ int ki_dmq_send_message(sip_msg_t *msg, str *peer_str, str *to_str, dmq_peer_t *destination_peer = find_peer(*peer_str); if(!destination_peer) { + dmq_peer_t new_peer = {0}; LM_INFO("cannot find peer %.*s\n", peer_str->len, peer_str->s); - dmq_peer_t new_peer; new_peer.callback = empty_peer_callback; new_peer.description.s = ""; new_peer.description.len = 0; @@ -370,9 +370,9 @@ int ki_dmq_bcast_message(sip_msg_t *msg, str *peer_str, str *body_str, dmq_peer_t *destination_peer = find_peer(*peer_str); if(!destination_peer) { + dmq_peer_t new_peer = {0}; LM_INFO("cannot find peer %.*s - adding it.\n", peer_str->len, peer_str->s); - dmq_peer_t new_peer; new_peer.callback = empty_peer_callback; new_peer.description.s = ""; new_peer.description.len = 0;

1 0

git:master:9292b9f5: sipcapture: init buffers content
by Daniel-Constantin Mierla 15 Mar '22

15 Mar '22

Module: kamailio Branch: master Commit: 9292b9f5daacfa5340b5fe1a5f02469a7e597d9b URL: https://github.com/kamailio/kamailio/commit/9292b9f5daacfa5340b5fe1a5f02469… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-15T10:00:41+01:00 sipcapture: init buffers content --- Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/9292b9f5daacfa5340b5fe1a5f02469… Patch: https://github.com/kamailio/kamailio/commit/9292b9f5daacfa5340b5fe1a5f02469… --- diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index 9070e1e9fc..4c032ab239 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -2580,6 +2580,8 @@ int receive_logging_json_msg(char *buf, unsigned int len, return -1; } + ipstr_dst[0] = '\0'; + ipstr_src[0] = '\0'; memset(&sco, 0, sizeof(struct _sipcapture_object)); gettimeofday(&tvb, &tz);

1 0

git:5.5:19e3d173: pv-headers: ignore skip-header config on clone_branch
by Victor Seva 15 Mar '22

15 Mar '22

Module: kamailio Branch: 5.5 Commit: 19e3d173ab0bc30663c67874708c95469699d82a URL: https://github.com/kamailio/kamailio/commit/19e3d173ab0bc30663c67874708c954… Author: Sipwise Development Team <support(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-03-15T08:56:46+01:00 pv-headers: ignore skip-header config on clone_branch (cherry picked from commit 473e051bef688d9e78bc4c28abebbedfffd1f549) --- Modified: src/modules/pv_headers/pvh_xavp.c --- Diff: https://github.com/kamailio/kamailio/commit/19e3d173ab0bc30663c67874708c954… Patch: https://github.com/kamailio/kamailio/commit/19e3d173ab0bc30663c67874708c954… --- diff --git a/src/modules/pv_headers/pvh_xavp.c b/src/modules/pv_headers/pvh_xavp.c index b8e4f92e61..8b2acbf08b 100644 --- a/src/modules/pv_headers/pvh_xavp.c +++ b/src/modules/pv_headers/pvh_xavp.c @@ -515,8 +515,6 @@ int pvh_clone_branch_xavi(struct sip_msg *msg, str *xname) } do { - if(pvh_skip_header(&sub->name)) - continue; if(sub->val.type == SR_XTYPE_DATA) continue; if(pvh_xavi_append_value(&sub->name, &sub->val, &br_xavi->val.v.xavp)

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2022