March 2022 - sr-dev - kamailio.org

git:master:e3b9521a: siptrace: use msg_send_buffer() to skip send callbacks for uri duplicate
by Daniel-Constantin Mierla 02 Mar '22

02 Mar '22

Module: kamailio Branch: master Commit: e3b9521a150ac2245dee2afeac5d674768c7399a URL: https://github.com/kamailio/kamailio/commit/e3b9521a150ac2245dee2afeac5d674… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-02T09:29:06+01:00 siptrace: use msg_send_buffer() to skip send callbacks for uri duplicate - GH #3042 --- Modified: src/modules/siptrace/siptrace_send.c --- Diff: https://github.com/kamailio/kamailio/commit/e3b9521a150ac2245dee2afeac5d674… Patch: https://github.com/kamailio/kamailio/commit/e3b9521a150ac2245dee2afeac5d674… --- diff --git a/src/modules/siptrace/siptrace_send.c b/src/modules/siptrace/siptrace_send.c index 63fdd5c6cb..31d7f716ca 100644 --- a/src/modules/siptrace/siptrace_send.c +++ b/src/modules/siptrace/siptrace_send.c @@ -349,7 +349,7 @@ int trace_send_duplicate(char *buf, int len, dest_info_t *dst2) } } - if(msg_send(pdst, buf, len) < 0) { + if(msg_send_buffer(pdst, buf, len, 1) < 0) { LM_ERR("cannot send duplicate message\n"); goto error; }

1 0

git:master:3dc980d6: modules: readme files regenerated - jwt ... [skip ci]
by Kamailio Dev 02 Mar '22

02 Mar '22

Module: kamailio Branch: master Commit: 3dc980d66fc4caeea90bb95870394c8855b51dec URL: https://github.com/kamailio/kamailio/commit/3dc980d66fc4caeea90bb95870394c8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-03-02T08:46:19+01:00 modules: readme files regenerated - jwt ... [skip ci] --- Modified: src/modules/jwt/README --- Diff: https://github.com/kamailio/kamailio/commit/3dc980d66fc4caeea90bb95870394c8… Patch: https://github.com/kamailio/kamailio/commit/3dc980d66fc4caeea90bb95870394c8…

1 0

git:master:eee5068e: jwt: add missing tag in doc
by Victor Seva 02 Mar '22

02 Mar '22

Module: kamailio Branch: master Commit: eee5068e2f315b6d391e6fe7b6aef4875afcf574 URL: https://github.com/kamailio/kamailio/commit/eee5068e2f315b6d391e6fe7b6aef48… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-03-02T08:39:26+01:00 jwt: add missing tag in doc error instroduced at aaa142d293105ef27f7e4b6143fc3fb18c9a5a75 --- Modified: src/modules/jwt/doc/jwt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/eee5068e2f315b6d391e6fe7b6aef48… Patch: https://github.com/kamailio/kamailio/commit/eee5068e2f315b6d391e6fe7b6aef48… --- diff --git a/src/modules/jwt/doc/jwt_admin.xml b/src/modules/jwt/doc/jwt_admin.xml index 45d98c7689..a72c518efe 100644 --- a/src/modules/jwt/doc/jwt_admin.xml +++ b/src/modules/jwt/doc/jwt_admin.xml @@ -115,6 +115,7 @@ modparam("jwt", "key_mode", 1) added as string value. </para> </listitem> + <listitem> <para> headers - the list of headers to be added to JWT, in the format "name1=value1;name2=value2;..." (same as the SIP parameters format).

1 0

git:master:9d1f223c: modules: readme files regenerated - corex ... [skip ci]
by Kamailio Dev 01 Mar '22

01 Mar '22

Module: kamailio Branch: master Commit: 9d1f223c7705a7ed8d888f50f2611dea1649ffa5 URL: https://github.com/kamailio/kamailio/commit/9d1f223c7705a7ed8d888f50f2611de… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-03-01T14:01:17+01:00 modules: readme files regenerated - corex ... [skip ci] --- Modified: src/modules/corex/README --- Diff: https://github.com/kamailio/kamailio/commit/9d1f223c7705a7ed8d888f50f2611de… Patch: https://github.com/kamailio/kamailio/commit/9d1f223c7705a7ed8d888f50f2611de… --- diff --git a/src/modules/corex/README b/src/modules/corex/README index d1721ffa84..dc28b471ec 100644 --- a/src/modules/corex/README +++ b/src/modules/corex/README @@ -249,10 +249,13 @@ modparam("corex", "alias_subdomains", "udp:sip-router.org:5060") The format of the value follows the SIP params style: "attr1=val1;attr2=val2;...". The attributes can be: - * type - it can be "A" (IPv4) or "AAAA" (IPv6) + * type - it can be "A" (IPv4), "AAAA" (IPv6) or "SRV" * name - the domain name * addr - the IP address * ttl - TTL value + * priority - priority value for SRV record + * weight - weight value for SRV record + * port - port value for SRV record * flags - can be: 1 - the domain is unresolvable (like blocklisted); 2 - the record is permanent (never times out, never deleted, never overwritten)

1 0

git:master:c9d682fa: corex: docs extended for dns_cache parameter
by Daniel-Constantin Mierla 01 Mar '22

01 Mar '22

Module: kamailio Branch: master Commit: c9d682fa7fb52357c2ca3779b1d23d1d151f065a URL: https://github.com/kamailio/kamailio/commit/c9d682fa7fb52357c2ca3779b1d23d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-01T13:48:29+01:00 corex: docs extended for dns_cache parameter --- Modified: src/modules/corex/doc/corex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c9d682fa7fb52357c2ca3779b1d23d1… Patch: https://github.com/kamailio/kamailio/commit/c9d682fa7fb52357c2ca3779b1d23d1… --- diff --git a/src/modules/corex/doc/corex_admin.xml b/src/modules/corex/doc/corex_admin.xml index 5ae9bea44a..6a1b94e021 100644 --- a/src/modules/corex/doc/corex_admin.xml +++ b/src/modules/corex/doc/corex_admin.xml @@ -109,7 +109,7 @@ modparam("corex", "alias_subdomains", "udp:sip-router.org:5060") <itemizedlist> <listitem> <para> - <emphasis>type</emphasis> - it can be "A" (IPv4) or "AAAA" (IPv6) + <emphasis>type</emphasis> - it can be "A" (IPv4), "AAAA" (IPv6) or "SRV" </para> </listitem> <listitem> @@ -127,6 +127,21 @@ modparam("corex", "alias_subdomains", "udp:sip-router.org:5060") <emphasis>ttl</emphasis> - TTL value </para> </listitem> + <listitem> + <para> + <emphasis>priority</emphasis> - priority value for SRV record + </para> + </listitem> + <listitem> + <para> + <emphasis>weight</emphasis> - weight value for SRV record + </para> + </listitem> + <listitem> + <para> + <emphasis>port</emphasis> - port value for SRV record + </para> + </listitem> <listitem> <para> <emphasis>flags</emphasis> - can be: 1 - the domain is unresolvable

1 0

git:master:23c8ba29: corex: support adding dns srv records via dns_cache param
by Daniel-Constantin Mierla 01 Mar '22

01 Mar '22

Module: kamailio Branch: master Commit: 23c8ba29ac4cd0ccbc3012e87e48f289bfb9d200 URL: https://github.com/kamailio/kamailio/commit/23c8ba29ac4cd0ccbc3012e87e48f28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-01T13:45:54+01:00 corex: support adding dns srv records via dns_cache param --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/23c8ba29ac4cd0ccbc3012e87e48f28… Patch: https://github.com/kamailio/kamailio/commit/23c8ba29ac4cd0ccbc3012e87e48f28… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index b4e0b67a87..b2fc9c09b2 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -383,6 +383,10 @@ static int corex_dns_cache_param_add(str *pval) unsigned short dns_type = 0; int dns_ttl = 0; int dns_flags = 0; + int dns_priority = 0; + int dns_weight = 0; + int dns_port = 0; + if(pval==NULL) { LM_ERR("invalid parameter\n"); @@ -414,8 +418,11 @@ static int corex_dns_cache_param_add(str *pval) || (pit->body.s[0]=='A'))) { dns_type = T_A; } else if((pit->body.len == 4) - && strncasecmp(pit->name.s, "aaaa", 4)==0) { + && strncasecmp(pit->body.s, "aaaa", 4)==0) { dns_type = T_AAAA; + } else if((pit->body.len == 3) + && strncasecmp(pit->body.s, "srv", 3)==0) { + dns_type = T_SRV; } } else if(pit->name.len==3 && strncasecmp(pit->name.s, "ttl", 3)==0) { @@ -433,6 +440,30 @@ static int corex_dns_cache_param_add(str *pval) return -1; } } + } else if(pit->name.len==8 + && strncasecmp(pit->name.s, "priority", 8)==0) { + if(dns_flags==0) { + if (str2sint(&pit->body, &dns_priority) < 0) { + LM_ERR("invalid priority: %.*s\n", pit->body.len, pit->body.s); + return -1; + } + } + } else if(pit->name.len==6 + && strncasecmp(pit->name.s, "weight", 6)==0) { + if(dns_flags==0) { + if (str2sint(&pit->body, &dns_weight) < 0) { + LM_ERR("invalid weight: %.*s\n", pit->body.len, pit->body.s); + return -1; + } + } + } else if(pit->name.len==4 + && strncasecmp(pit->name.s, "port", 4)==0) { + if(dns_flags==0) { + if (str2sint(&pit->body, &dns_port) < 0) { + LM_ERR("invalid port: %.*s\n", pit->body.len, pit->body.s); + return -1; + } + } } } @@ -440,9 +471,9 @@ static int corex_dns_cache_param_add(str *pval) &dns_name, dns_ttl, &dns_addr, - 0 /* priority */, - 0 /* weight */, - 0 /* port */, + dns_priority, /* priority */ + dns_weight, /* weight */ + dns_port, /* port */ dns_flags) == 0) { return 0; }

1 0

git:master:78c8d084: db_redis: clean previous connection before trying to reconnect
by Victor Seva 01 Mar '22

01 Mar '22

Module: kamailio Branch: master Commit: 78c8d084e30373aacc456fd41062b68e6e82ea6f URL: https://github.com/kamailio/kamailio/commit/78c8d084e30373aacc456fd41062b68… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-03-01T10:35:23+01:00 db_redis: clean previous connection before trying to reconnect --- Modified: src/modules/db_redis/redis_connection.c --- Diff: https://github.com/kamailio/kamailio/commit/78c8d084e30373aacc456fd41062b68… Patch: https://github.com/kamailio/kamailio/commit/78c8d084e30373aacc456fd41062b68… --- diff --git a/src/modules/db_redis/redis_connection.c b/src/modules/db_redis/redis_connection.c index 1166117961..5cf36ffb36 100644 --- a/src/modules/db_redis/redis_connection.c +++ b/src/modules/db_redis/redis_connection.c @@ -124,6 +124,11 @@ int db_redis_connect(km_redis_con_t *con) { #endif reply = NULL; + if(con->con) { + LM_DBG("free old connection first\n"); + redisFree(con->con); + } + // TODO: introduce require_master mod-param and check if we're indeed master // TODO: on carrier, if we have db fail-over, the currently connected // redis server will become slave without dropping connections?

1 0

[kamailio/kamailio] add duk_module_node to module app_jsdt (PR #3038)
by Ian Carlson 01 Mar '22

01 Mar '22

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #3037 #### Description I can not remember the last time I wrote any C which was likely a class assignment last century. Anyways I came across this issue and it seemed in reach to get the ball rolling. I know this PR needs more work but my goal is to share my progress to help move this feature forward. Based on https://github.com/svaarala/duktape/tree/master/extras/module-node added: - duk_module_node.h - duk_module_node.c updated: - app_jsdt_api.h - app_jsdt_api.c Included the extra header and initialize the bindings after 'load JS context' was created. added `cb_resolve_module` to resolve the full file system path for requested_id and parent_id added `cb_load_module` function which uses `jsdt_load_file` to load resolved file With absolute and relative modules working I met my current requirements to allow breaking routing into multiple smaller files. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3038 -- Commit Summary -- * app_jsdt: add duk_module_node for JS module resolution -- File Changes -- M src/modules/app_jsdt/app_jsdt_api.c (65) M src/modules/app_jsdt/app_jsdt_api.h (3) A src/modules/app_jsdt/duk_module_node.c (333) A src/modules/app_jsdt/duk_module_node.h (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3038.patch https://github.com/kamailio/kamailio/pull/3038.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3038 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3038(a)github.com>

2 4