sr-dev March 2022

sr-dev@lists.kamailio.org

10 participants
242 discussions

[kamailio/kamailio] utils: fixed sinitiser error (PR #3057)

by sergey-safarov

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description fixed sinitizer memory leaks You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3057 -- Commit Summary -- * utils: fixed sinitiser error -- File Changes -- M utils/kamcmd/kamcmd.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3057.patch https://github.com/kamailio/kamailio/pull/3057.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3057 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3057(a)github.com>

2 years, 1 month

git:master:d28ca884: utils: fixed sinitiser error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d28ca884548b0f24a618ed9cbdc8e1b9538f2574 URL: https://github.com/kamailio/kamailio/commit/d28ca884548b0f24a618ed9cbdc8e1b… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-22T08:09:12+01:00 utils: fixed sinitiser error [root@localhost]# kamcmd cfg.seti param_group param_name value ================================================================= ==2409977==ERROR: LeakSanitizer: detected memory leaks Direct leak of 38 byte(s) in 1 object(s) allocated from: #0 0xffff98c250af in malloc (/lib64/libasan.so.5+0xd50af) #1 0x41549f in parse_listen_id /root/kamailio/utils/kamcmd/parse_listen_id.c:133 #2 0x4144fb in main /root/kamailio/utils/kamcmd/kamcmd.c:2075 #3 0xffff97dc0de3 in __libc_start_main (/lib64/libc.so.6+0x20de3) #4 0x40260b (/usr/local/sbin/kamcmd+0x40260b) --- Modified: utils/kamcmd/kamcmd.c --- Diff: https://github.com/kamailio/kamailio/commit/d28ca884548b0f24a618ed9cbdc8e1b… Patch: https://github.com/kamailio/kamailio/commit/d28ca884548b0f24a618ed9cbdc8e1b… --- diff --git a/utils/kamcmd/kamcmd.c b/utils/kamcmd/kamcmd.c index 141f309aaf..e940ab8ae1 100644 --- a/utils/kamcmd/kamcmd.c +++ b/utils/kamcmd/kamcmd.c @@ -2106,6 +2106,7 @@ int main(int argc, char** argv) fprintf(stderr, "ERROR: Bad socket type for %s\n", sock_name); goto error; } + free(sock_id->buf); /* not needed anymore */ free(sock_id); /* not needed anymore */ sock_id=0;

2 years, 1 month

[kamailio/kamailio] {param.value, name[, delimiter]}, and delimiter is comma (Issue #3060)

by hance2010

### Description  ### Expected behavior $var(s) = "a=1,b=2,c=3"; $var(s1) = $(var(s){param.value,b,,}); /* 2 */ #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio 5.5.4 ``` * **Operating System**:  ``` debian11 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3060 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3060(a)github.com>

2 years, 1 month

git:master:16a5234b: modules: readme files regenerated - auth_db ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 16a5234b11f139ec6b2be99499c970234dec90c3 URL: https://github.com/kamailio/kamailio/commit/16a5234b11f139ec6b2be99499c9702… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-03-21T15:16:26+01:00 modules: readme files regenerated - auth_db ... [skip ci] --- Modified: src/modules/auth_db/README --- Diff: https://github.com/kamailio/kamailio/commit/16a5234b11f139ec6b2be99499c9702… Patch: https://github.com/kamailio/kamailio/commit/16a5234b11f139ec6b2be99499c9702… --- diff --git a/src/modules/auth_db/README b/src/modules/auth_db/README index 287f1517c5..2825c58d2f 100644 --- a/src/modules/auth_db/README +++ b/src/modules/auth_db/README @@ -448,7 +448,8 @@ if (!proxy_authorize("$fd", "subscriber)) { user. All other requests: From header must match the authentication user. If bit 2 is set as well (flags==3), the ID check is skipped for INVITE, BYE, PRACK, UPDATE, MESSAGE - these requests can come - with anonymous caller id. + with anonymous caller id. If set to 0, then all user checks are + skipped. Additionally all domains in the checked URIs and the realm in the authentication header will be checked to match the provided realm parameter.

2 years, 1 month

git:master:c67c568a: auth_db: document flag 0 for auth_check function

by Henning Westerholt

Module: kamailio Branch: master Commit: c67c568ad476879529cd04f7a5b1b77401a8f428 URL: https://github.com/kamailio/kamailio/commit/c67c568ad476879529cd04f7a5b1b77… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-03-21T14:11:32Z auth_db: document flag 0 for auth_check function --- Modified: src/modules/auth_db/doc/auth_db_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c67c568ad476879529cd04f7a5b1b77… Patch: https://github.com/kamailio/kamailio/commit/c67c568ad476879529cd04f7a5b1b77… --- diff --git a/src/modules/auth_db/doc/auth_db_admin.xml b/src/modules/auth_db/doc/auth_db_admin.xml index 422738e869..e112332b40 100644 --- a/src/modules/auth_db/doc/auth_db_admin.xml +++ b/src/modules/auth_db/doc/auth_db_admin.xml @@ -549,7 +549,8 @@ if (!proxy_authorize("$fd", "subscriber)) { match the authentication user. All other requests: From header must match the authentication user. If bit 2 is set as well (flags==3), the ID check is skipped for INVITE, BYE, PRACK, UPDATE, MESSAGE - - these requests can come with anonymous caller id. + - these requests can come with anonymous caller id. If set to 0, + then all user checks are skipped. </para> <para> Additionally all domains in the checked URIs and the realm in the

2 years, 1 month

git:master:0b7a7107: ims_qos: free result of getaddrinfo()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0b7a71070f3845e4c7e89e149a80b3db8872bb1e URL: https://github.com/kamailio/kamailio/commit/0b7a71070f3845e4c7e89e149a80b3d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-17T09:34:56+01:00 ims_qos: free result of getaddrinfo() --- Modified: src/modules/ims_qos/ims_qos_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0b7a71070f3845e4c7e89e149a80b3d… Patch: https://github.com/kamailio/kamailio/commit/0b7a71070f3845e4c7e89e149a80b3d… --- diff --git a/src/modules/ims_qos/ims_qos_mod.c b/src/modules/ims_qos/ims_qos_mod.c index 18d111eb67..08018d9c45 100644 --- a/src/modules/ims_qos/ims_qos_mod.c +++ b/src/modules/ims_qos/ims_qos_mod.c @@ -649,10 +649,13 @@ uint16_t check_ip_version(str ip) return 0; } if (res->ai_family == AF_INET) { + freeaddrinfo(res); return AF_INET; } else if (res->ai_family == AF_INET6) { + freeaddrinfo(res); return AF_INET6; } else { + freeaddrinfo(res); LM_ERR("unknown IP format \n"); return 0; }

2 years, 2 months

git:master:782b4773: cdp: init the entire msg structure

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 782b4773119e21a9354d698c0f405d7162166a4a URL: https://github.com/kamailio/kamailio/commit/782b4773119e21a9354d698c0f405d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-17T09:00:36+01:00 cdp: init the entire msg structure --- Modified: src/modules/cdp/receiver.c --- Diff: https://github.com/kamailio/kamailio/commit/782b4773119e21a9354d698c0f405d7… Patch: https://github.com/kamailio/kamailio/commit/782b4773119e21a9354d698c0f405d7… --- diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c index 5aed0a36f4..0bff4131d3 100644 --- a/src/modules/cdp/receiver.c +++ b/src/modules/cdp/receiver.c @@ -346,6 +346,7 @@ static int receive_fd(int pipe_fd, int* fd,peer **p) char control[CMSG_SPACE(sizeof(new_fd))]; }control_un; + memset(&msg, 0, sizeof(struct msghdr)); msg.msg_control=control_un.control; msg.msg_controllen=sizeof(control_un.control); #else

2 years, 2 months

git:master:b32a9caf: core: parse uri - extra check when user part is missing before @

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b32a9caf4797370a4704b5f94d2d704b6e52fdef URL: https://github.com/kamailio/kamailio/commit/b32a9caf4797370a4704b5f94d2d704… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-16T10:11:43+01:00 core: parse uri - extra check when user part is missing before @ --- Modified: src/core/parser/parse_uri.c --- Diff: https://github.com/kamailio/kamailio/commit/b32a9caf4797370a4704b5f94d2d704… Patch: https://github.com/kamailio/kamailio/commit/b32a9caf4797370a4704b5f94d2d704… --- diff --git a/src/core/parser/parse_uri.c b/src/core/parser/parse_uri.c index edc46acea1..adc94fbc0a 100644 --- a/src/core/parser/parse_uri.c +++ b/src/core/parser/parse_uri.c @@ -1241,14 +1241,15 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) /* port value too large */ goto error_invalid_port; } - if(uri->host.len>0 && uri->host.s>buf && *(uri->host.s-1)=='@' - && uri->user.len<=0) { + if(uri->host.len>0 && uri->user.len<=0 &&uri->host.s>buf && (*(uri->host.s-1)=='@' + || *uri->host.s=='@')) { /* '@' before host, but no user part */ goto error_bad_uri; } #ifdef EXTRA_DEBUG /* do stuff */ + LM_DBG("state=%d\n", state); LM_DBG("parsed uri:\n type=%d user=<%.*s>(%d)\n passwd=<%.*s>(%d)\n" " host=<%.*s>(%d)\n port=<%.*s>(%d): %d\n params=<%.*s>(%d)\n" " headers=<%.*s>(%d)\n",

2 years, 2 months

git:master:dad44317: db_berkeley: covert blob values

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: dad443172628c3736b057fa24343c265ed3827b2 URL: https://github.com/kamailio/kamailio/commit/dad443172628c3736b057fa24343c26… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-16T09:12:03+01:00 db_berkeley: covert blob values --- Modified: src/modules/db_berkeley/km_bdb_val.c --- Diff: https://github.com/kamailio/kamailio/commit/dad443172628c3736b057fa24343c26… Patch: https://github.com/kamailio/kamailio/commit/dad443172628c3736b057fa24343c26… --- diff --git a/src/modules/db_berkeley/km_bdb_val.c b/src/modules/db_berkeley/km_bdb_val.c index d895a870c9..e75ad4dc3b 100644 --- a/src/modules/db_berkeley/km_bdb_val.c +++ b/src/modules/db_berkeley/km_bdb_val.c @@ -266,10 +266,10 @@ int km_bdb_val2str(db_val_t *_v, char *_s, int *_len) LM_ERR("Destination buffer too short for blob\n"); return -7; } else { - LM_DBG("Converting BLOB [%s]\n", _s); - _s = VAL_BLOB(_v).s; - *_len = 0; - return -8; + LM_DBG("Converted BLOB\n"); + memcpy(_s, VAL_BLOB(_v).s, l); + *_len = l; + return 0; } break;

2 years, 2 months

git:master:476d763d: core: 0-terminate string for very long local network interface names

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 476d763d8ee504b71c13063ca002ecfe158da94e URL: https://github.com/kamailio/kamailio/commit/476d763d8ee504b71c13063ca002ecf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-16T09:04:33+01:00 core: 0-terminate string for very long local network interface names --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/476d763d8ee504b71c13063ca002ecf… Patch: https://github.com/kamailio/kamailio/commit/476d763d8ee504b71c13063ca002ecf… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index afb1dd5603..00d7bdf289 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1333,6 +1333,7 @@ static int build_iface_list(void) case IFA_LABEL: LM_DBG("iface name is %s\n", (char*)RTA_DATA(rtap)); strncpy(name, (char*)RTA_DATA(rtap), MAX_IF_LEN-1); + name[MAX_IF_LEN-1] = '\0'; break; case IFA_BROADCAST: case IFA_ANYCAST:

2 years, 2 months

← Newer
1
...
10
11
12
13
14
15
16
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2022