sr-dev October 2021

sr-dev@lists.kamailio.org

19 participants
243 discussions

[kamailio/kamailio] Correcting rank value passed to fork_process #2809 (#2863)

by ErhanOnur

PROC_SIPINIT has a special meaning representing the first SIP worker.   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2863 -- Commit Summary -- * <a href="https://github.com/kamailio/kamailio/pull/2863/commits/df5f41ccc3c779848bdb…">Correcting rank value passed to fork_process #2809</a> -- File Changes -- M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2863.patch https://github.com/kamailio/kamailio/pull/2863.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2863

2 years, 7 months

git:master:25ef591f: Correcting rank value passed to fork_process #2809

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 25ef591f5c160515b2b8c4e53036fccf8a9671bc URL: https://github.com/kamailio/kamailio/commit/25ef591f5c160515b2b8c4e53036fcc… Author: 67456745 <erhan.sendag(a)i2i-systems.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T13:43:31+02:00 Correcting rank value passed to fork_process #2809 PROC_SIPINIT has a special meaning representing the first SIP worker --- Modified: src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/25ef591f5c160515b2b8c4e53036fcc… Patch: https://github.com/kamailio/kamailio/commit/25ef591f5c160515b2b8c4e53036fcc… --- diff --git a/src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c b/src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c index 8eb3c7b4a4..b5bb650098 100644 --- a/src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c +++ b/src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c @@ -325,7 +325,7 @@ static int child_init(int rank) LM_DBG("Initialization of module in child [%d] \n", rank); if ((subscribe_to_reginfo == 1) && (rank == PROC_MAIN)) { LM_DBG("Creating RegInfo Event Processor process\n"); - int pid = fork_process(PROC_SIPINIT, "RegInfo Event Processor", 1); + int pid = fork_process(PROC_NOCHLDINIT, "RegInfo Event Processor", 1); if (pid < 0) return -1; //error if (pid == 0) {

2 years, 7 months

git:master:3a042b99: modules: readme files regenerated - textops ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 3a042b99e0ae21c3127d69d41dcce8925dbaa185 URL: https://github.com/kamailio/kamailio/commit/3a042b99e0ae21c3127d69d41dcce89… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-10-05T10:01:29+02:00 modules: readme files regenerated - textops ... [skip ci] --- Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/3a042b99e0ae21c3127d69d41dcce89… Patch: https://github.com/kamailio/kamailio/commit/3a042b99e0ae21c3127d69d41dcce89… --- diff --git a/src/modules/textops/README b/src/modules/textops/README index 4f0097535d..5f6bf33867 100644 --- a/src/modules/textops/README +++ b/src/modules/textops/README @@ -252,9 +252,13 @@ Chapter 1. Admin Guide The module implements text based operations over the SIP message processed by Kamailio. SIP is a text based protocol and the module provides a large set of very useful functions to manipulate the message - at text level, e.g., regular expression search and replace, Perl-like + at text level, e.g., regular expression search, replace or substitutions, checks for method type, header presence, insert of new - header and date, etc. + header and date, string comparisons, multi-part body operations, etc. + + If not stated otherwise, the regular expressions parameters for search, + replace or substitute have to be in POSIX format. For PCRE regular + expression matching, see the pcre or dialplan modules. 2. Known Limitations @@ -602,7 +606,7 @@ replace_hdrs_str("Kamailio", "Kamailio SIP Proxy", "a"); 4.16. subst('/re/repl/flags') - Replaces re with repl (sed or perl like). + Replaces re with repl. Meaning of the parameters is as follows: * '/re/repl/flags' - sed like regular expression. flags can be a @@ -683,7 +687,7 @@ if (subst_user('/(.*)3642$/$avp(user_prefix)\13642/')){$ 4.19. subst_body('/re/repl/flags') - Replaces re with repl (sed or perl like) in the body of the message. + Replaces re with repl in the body of the message. Meaning of the parameters is as follows: * '/re/repl/flags' - sed like regular expression. flags can be a @@ -704,7 +708,7 @@ if ( subst_body('/^o=(.*) /o=$fU /') ) {}; 4.20. subst_hf(hf, subexp, flags) - Perl-like substitutions in the body of a header field. + Substitutions in the body of a header field. Meaning of the parameters is as follows: * hf - header field name.

2 years, 7 months

git:master:b19aab7f: textops: docs update to state regex params expect posix format

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b19aab7fe00f72d0c9e54a7a106ec7a065a3d02b URL: https://github.com/kamailio/kamailio/commit/b19aab7fe00f72d0c9e54a7a106ec7a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T09:57:40+02:00 textops: docs update to state regex params expect posix format --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b19aab7fe00f72d0c9e54a7a106ec7a… Patch: https://github.com/kamailio/kamailio/commit/b19aab7fe00f72d0c9e54a7a106ec7a… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 4427ee1e00..974fbf568c 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -19,9 +19,15 @@ The module implements text based operations over the SIP message processed by &kamailio;. SIP is a text based protocol and the module provides a large set of very useful functions to manipulate the - message at text level, e.g., regular expression search and replace, - Perl-like substitutions, checks for method type, header presence, - insert of new header and date, etc. + message at text level, e.g., regular expression search, replace + or substitutions, checks for method type, header presence, + insert of new header and date, string comparisons, multi-part body + operations, etc. + </para> + <para> + If not stated otherwise, the regular expressions parameters for search, + replace or substitute have to be in POSIX format. For PCRE regular + expression matching, see the pcre or dialplan modules. </para> </section> <section> @@ -591,7 +597,7 @@ replace_hdrs_str("&kamailio;", "&kamailio; SIP Proxy", "a"); <function moreinfo="none">subst('/re/repl/flags')</function> </title> <para> - Replaces re with repl (sed or perl like). + Replaces re with repl. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -728,7 +734,7 @@ if (subst_user('/(.*)3642$/$avp(user_prefix)\13642/')){$ <function moreinfo="none">subst_body('/re/repl/flags')</function> </title> <para> - Replaces re with repl (sed or perl like) in the body of the message. + Replaces re with repl in the body of the message. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -768,7 +774,7 @@ if ( subst_body('/^o=(.*) /o=$fU /') ) {}; <function moreinfo="none">subst_hf(hf, subexp, flags)</function> </title> <para> - Perl-like substitutions in the body of a header field. + Substitutions in the body of a header field. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist>

2 years, 7 months

git:5.5:2ce38e6c: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.5 Commit: 2ce38e6ca5e822210e47b7966a335adcf8df7e23 URL: https://github.com/kamailio/kamailio/commit/2ce38e6ca5e822210e47b7966a335ad… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-10-04T17:46:39+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/topos/README --- Diff: https://github.com/kamailio/kamailio/commit/2ce38e6ca5e822210e47b7966a335ad… Patch: https://github.com/kamailio/kamailio/commit/2ce38e6ca5e822210e47b7966a335ad… --- diff --git a/src/modules/topos/README b/src/modules/topos/README index 49b786ac13..ef7c0e9634 100644 --- a/src/modules/topos/README +++ b/src/modules/topos/README @@ -44,8 +44,8 @@ Frederic Gaisnon 3.11. contact_mode (int) 3.12. cparam_name (int) 3.13. xavu_cfg (str) - 3.14. xavu_filed_a_contact (str) - 3.15. xavu_filed_b_contact (str) + 3.14. xavu_field_a_contact (str) + 3.15. xavu_field_b_contact (str) 3.16. xavu_field_contact_host (str) 3.17. rr_update (int) 3.18. context (str) @@ -76,8 +76,8 @@ Frederic Gaisnon 1.11. Set contact_mode parameter 1.12. Set cparam_name parameter 1.13. Set xavu_cfg parameter - 1.14. Set xavu_filed_a_contact parameter - 1.15. Set xavu_filed_b_contact parameter + 1.14. Set xavu_field_a_contact parameter + 1.15. Set xavu_field_b_contact parameter 1.16. Set xavu_field_contact_host parameter 1.17. Set rr_update parameter 1.18. Set context parameter @@ -112,8 +112,8 @@ Chapter 1. Admin Guide 3.11. contact_mode (int) 3.12. cparam_name (int) 3.13. xavu_cfg (str) - 3.14. xavu_filed_a_contact (str) - 3.15. xavu_filed_b_contact (str) + 3.14. xavu_field_a_contact (str) + 3.15. xavu_field_b_contact (str) 3.16. xavu_field_contact_host (str) 3.17. rr_update (int) 3.18. context (str) @@ -182,8 +182,8 @@ Chapter 1. Admin Guide 3.11. contact_mode (int) 3.12. cparam_name (int) 3.13. xavu_cfg (str) - 3.14. xavu_filed_a_contact (str) - 3.15. xavu_filed_b_contact (str) + 3.14. xavu_field_a_contact (str) + 3.15. xavu_field_b_contact (str) 3.16. xavu_field_contact_host (str) 3.17. rr_update (int) 3.18. context (str) @@ -320,7 +320,7 @@ modparam("topos", "event_mode", 2) 3.10. contact_host (str) You may need to control the host part of the Contact header added by - topos. If the xavu_filed_contact_host parameter is set, this value is + topos. If the xavu_field_contact_host parameter is set, this value is ignored. For example when using TLS with TOPOS the remote UAS must be able to open a new TLS socket to the contact header. In this case, the contact header must contain a domain name with a trusted CA signed @@ -388,12 +388,12 @@ modparam("topos", "cparam_name", "xyz") Example 1.13. Set xavu_cfg parameter ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_a_contact", "a_contact") +modparam("topos", "xavu_field_a_contact", "a_contact") ... $xavu(_tps_=>a_contact) = "..."; ... -3.14. xavu_filed_a_contact (str) +3.14. xavu_field_a_contact (str) Name of the field inside root XAVU specifed by `xavu_cfg` to evaluate for the A-side Contact Header user part. This parameter is only @@ -401,15 +401,15 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") Default value is “NULL” (disabled). - Example 1.14. Set xavu_filed_a_contact parameter + Example 1.14. Set xavu_field_a_contact parameter ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_a_contact", "a_contact") +modparam("topos", "xavu_field_a_contact", "a_contact") ... $xavu(_tps_=>a_contact) = "..."; ... -3.15. xavu_filed_b_contact (str) +3.15. xavu_field_b_contact (str) Name of the field inside root XAVU specifed by `xavu_cfg` to evaluate for the B-side Contact Header user part. This parameter is only @@ -417,10 +417,10 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") Default value is “NULL” (disabled). - Example 1.15. Set xavu_filed_b_contact parameter + Example 1.15. Set xavu_field_b_contact parameter ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_b_contact", "b_contact") +modparam("topos", "xavu_field_b_contact", "b_contact") ... $xavu(_tps_=>b_contact) = "...";

2 years, 7 months

git:master:b163e40a: modules: readme files regenerated - topos ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: b163e40a8d13201cc07c1df69a58855cba0df540 URL: https://github.com/kamailio/kamailio/commit/b163e40a8d13201cc07c1df69a58855… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-10-04T17:46:22+02:00 modules: readme files regenerated - topos ... [skip ci] --- Modified: src/modules/topos/README --- Diff: https://github.com/kamailio/kamailio/commit/b163e40a8d13201cc07c1df69a58855… Patch: https://github.com/kamailio/kamailio/commit/b163e40a8d13201cc07c1df69a58855… --- diff --git a/src/modules/topos/README b/src/modules/topos/README index 49b786ac13..ef7c0e9634 100644 --- a/src/modules/topos/README +++ b/src/modules/topos/README @@ -44,8 +44,8 @@ Frederic Gaisnon 3.11. contact_mode (int) 3.12. cparam_name (int) 3.13. xavu_cfg (str) - 3.14. xavu_filed_a_contact (str) - 3.15. xavu_filed_b_contact (str) + 3.14. xavu_field_a_contact (str) + 3.15. xavu_field_b_contact (str) 3.16. xavu_field_contact_host (str) 3.17. rr_update (int) 3.18. context (str) @@ -76,8 +76,8 @@ Frederic Gaisnon 1.11. Set contact_mode parameter 1.12. Set cparam_name parameter 1.13. Set xavu_cfg parameter - 1.14. Set xavu_filed_a_contact parameter - 1.15. Set xavu_filed_b_contact parameter + 1.14. Set xavu_field_a_contact parameter + 1.15. Set xavu_field_b_contact parameter 1.16. Set xavu_field_contact_host parameter 1.17. Set rr_update parameter 1.18. Set context parameter @@ -112,8 +112,8 @@ Chapter 1. Admin Guide 3.11. contact_mode (int) 3.12. cparam_name (int) 3.13. xavu_cfg (str) - 3.14. xavu_filed_a_contact (str) - 3.15. xavu_filed_b_contact (str) + 3.14. xavu_field_a_contact (str) + 3.15. xavu_field_b_contact (str) 3.16. xavu_field_contact_host (str) 3.17. rr_update (int) 3.18. context (str) @@ -182,8 +182,8 @@ Chapter 1. Admin Guide 3.11. contact_mode (int) 3.12. cparam_name (int) 3.13. xavu_cfg (str) - 3.14. xavu_filed_a_contact (str) - 3.15. xavu_filed_b_contact (str) + 3.14. xavu_field_a_contact (str) + 3.15. xavu_field_b_contact (str) 3.16. xavu_field_contact_host (str) 3.17. rr_update (int) 3.18. context (str) @@ -320,7 +320,7 @@ modparam("topos", "event_mode", 2) 3.10. contact_host (str) You may need to control the host part of the Contact header added by - topos. If the xavu_filed_contact_host parameter is set, this value is + topos. If the xavu_field_contact_host parameter is set, this value is ignored. For example when using TLS with TOPOS the remote UAS must be able to open a new TLS socket to the contact header. In this case, the contact header must contain a domain name with a trusted CA signed @@ -388,12 +388,12 @@ modparam("topos", "cparam_name", "xyz") Example 1.13. Set xavu_cfg parameter ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_a_contact", "a_contact") +modparam("topos", "xavu_field_a_contact", "a_contact") ... $xavu(_tps_=>a_contact) = "..."; ... -3.14. xavu_filed_a_contact (str) +3.14. xavu_field_a_contact (str) Name of the field inside root XAVU specifed by `xavu_cfg` to evaluate for the A-side Contact Header user part. This parameter is only @@ -401,15 +401,15 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") Default value is “NULL” (disabled). - Example 1.14. Set xavu_filed_a_contact parameter + Example 1.14. Set xavu_field_a_contact parameter ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_a_contact", "a_contact") +modparam("topos", "xavu_field_a_contact", "a_contact") ... $xavu(_tps_=>a_contact) = "..."; ... -3.15. xavu_filed_b_contact (str) +3.15. xavu_field_b_contact (str) Name of the field inside root XAVU specifed by `xavu_cfg` to evaluate for the B-side Contact Header user part. This parameter is only @@ -417,10 +417,10 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") Default value is “NULL” (disabled). - Example 1.15. Set xavu_filed_b_contact parameter + Example 1.15. Set xavu_field_b_contact parameter ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_b_contact", "b_contact") +modparam("topos", "xavu_field_b_contact", "b_contact") ... $xavu(_tps_=>b_contact) = "...";

2 years, 7 months

[kamailio/kamailio] topos/topos_redis, error: "could not evaluate a_contact xavu" when in-dialog msg have Rexord-Rourte header. (#2852)

by Dennis

Hi ! topos+redis used in the folowing configuration: modparam("ndb_redis", "server", "REDIS_SERVER") modparam("ndb_redis", "init_without_redis", 1) modparam("topos", "storage", "redis") modparam("topos_redis", "serverid", "srv1") modparam("topos", "contact_mode", 2) modparam("topos", "xavu_cfg", "_tps_") modparam("topos", "xavu_field_a_contact", "a_contact") modparam("topos", "xavu_field_b_contact", "b_contact") modparam("topos", "xavu_field_contact_host", "contact_host") In the inital INVITE xavu variables a_contact and b_contact are set by script, topos work as expected at this point, but when the following in-dalog messages from upstream have Record-Route header, topos fails with error message: Sep 13 18:50:01 gw481 /usr/sbin/kamailio[29874]: ERROR: {1 1 ACK 1-20643(a)87.250.237.98} topos [tps_storage.c:331]: tps_storage_fill_contact(): could not evaluate a_contact xavu Sep 13 18:50:01 gw481 /usr/sbin/kamailio[29874]: ERROR: {1 1 ACK 1-20643(a)87.250.237.98} topos [tps_storage.c:604]: tps_storage_record(): failed to store In case of absent Record-Route headers the are no errors. #### Debugging Data Signaling dump and debug log in attachment. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio 5.5.1 (x86_64/linux) ``` * **Operating System**:  ``` Ubuntu 18.04.5 LTS ``` [dump.txt](https://github.com/kamailio/kamailio/files/7157118/dump.txt) [call.log](https://github.com/kamailio/kamailio/files/7157120/call.log) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2852

2 years, 7 months

git:5.5:11ae371e: topos: spelling fix in README for contact parameter

by Henning Westerholt

Module: kamailio Branch: 5.5 Commit: 11ae371e59496c6ea3036c15d44afcd3488ca9e9 URL: https://github.com/kamailio/kamailio/commit/11ae371e59496c6ea3036c15d44afcd… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-10-04T15:39:04Z topos: spelling fix in README for contact parameter (cherry picked from commit 0a9b039f79de90a45e263325cb247f49a31d9f36) --- Modified: src/modules/topos/doc/topos_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/11ae371e59496c6ea3036c15d44afcd… Patch: https://github.com/kamailio/kamailio/commit/11ae371e59496c6ea3036c15d44afcd… --- diff --git a/src/modules/topos/doc/topos_admin.xml b/src/modules/topos/doc/topos_admin.xml index 4218dae3fe..dee94df414 100644 --- a/src/modules/topos/doc/topos_admin.xml +++ b/src/modules/topos/doc/topos_admin.xml @@ -294,7 +294,7 @@ modparam("topos", "event_mode", 2) <title><varname>contact_host</varname> (str)</title> <para> You may need to control the host part of the Contact header added - by topos. If the xavu_filed_contact_host parameter is set, this value is + by topos. If the xavu_field_contact_host parameter is set, this value is ignored. For example when using TLS with TOPOS the remote UAS must be able to open @@ -397,7 +397,7 @@ modparam("topos", "cparam_name", "xyz") <programlisting format="linespecific"> ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_a_contact", "a_contact") +modparam("topos", "xavu_field_a_contact", "a_contact") ... $xavu(_tps_=>a_contact) = "..."; ... @@ -405,7 +405,7 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") </example> </section> <section id="topos.p.xavu_field_a_contact"> - <title><varname>xavu_filed_a_contact</varname> (str)</title> + <title><varname>xavu_field_a_contact</varname> (str)</title> <para> Name of the field inside root XAVU specifed by `xavu_cfg` to evaluate for the A-side Contact Header user part. This parameter @@ -417,11 +417,11 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") </emphasis> </para> <example> - <title>Set <varname>xavu_filed_a_contact</varname> parameter</title> + <title>Set <varname>xavu_field_a_contact</varname> parameter</title> <programlisting format="linespecific"> ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_a_contact", "a_contact") +modparam("topos", "xavu_field_a_contact", "a_contact") ... $xavu(_tps_=>a_contact) = "..."; ... @@ -429,7 +429,7 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") </example> </section> <section id="topos.p.xavu_field_b_contact"> - <title><varname>xavu_filed_b_contact</varname> (str)</title> + <title><varname>xavu_field_b_contact</varname> (str)</title> <para> Name of the field inside root XAVU specifed by `xavu_cfg` to evaluate for the B-side Contact Header user part. This parameter @@ -441,11 +441,11 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") </emphasis> </para> <example> - <title>Set <varname>xavu_filed_b_contact</varname> parameter</title> + <title>Set <varname>xavu_field_b_contact</varname> parameter</title> <programlisting format="linespecific"> ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_b_contact", "b_contact") +modparam("topos", "xavu_field_b_contact", "b_contact") ... $xavu(_tps_=>b_contact) = "...";

2 years, 7 months

git:master:0a9b039f: topos: spelling fix in README for contact parameter

by Henning Westerholt

Module: kamailio Branch: master Commit: 0a9b039f79de90a45e263325cb247f49a31d9f36 URL: https://github.com/kamailio/kamailio/commit/0a9b039f79de90a45e263325cb247f4… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-10-04T15:38:23Z topos: spelling fix in README for contact parameter --- Modified: src/modules/topos/doc/topos_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0a9b039f79de90a45e263325cb247f4… Patch: https://github.com/kamailio/kamailio/commit/0a9b039f79de90a45e263325cb247f4… --- diff --git a/src/modules/topos/doc/topos_admin.xml b/src/modules/topos/doc/topos_admin.xml index 4218dae3fe..dee94df414 100644 --- a/src/modules/topos/doc/topos_admin.xml +++ b/src/modules/topos/doc/topos_admin.xml @@ -294,7 +294,7 @@ modparam("topos", "event_mode", 2) <title><varname>contact_host</varname> (str)</title> <para> You may need to control the host part of the Contact header added - by topos. If the xavu_filed_contact_host parameter is set, this value is + by topos. If the xavu_field_contact_host parameter is set, this value is ignored. For example when using TLS with TOPOS the remote UAS must be able to open @@ -397,7 +397,7 @@ modparam("topos", "cparam_name", "xyz") <programlisting format="linespecific"> ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_a_contact", "a_contact") +modparam("topos", "xavu_field_a_contact", "a_contact") ... $xavu(_tps_=>a_contact) = "..."; ... @@ -405,7 +405,7 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") </example> </section> <section id="topos.p.xavu_field_a_contact"> - <title><varname>xavu_filed_a_contact</varname> (str)</title> + <title><varname>xavu_field_a_contact</varname> (str)</title> <para> Name of the field inside root XAVU specifed by `xavu_cfg` to evaluate for the A-side Contact Header user part. This parameter @@ -417,11 +417,11 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") </emphasis> </para> <example> - <title>Set <varname>xavu_filed_a_contact</varname> parameter</title> + <title>Set <varname>xavu_field_a_contact</varname> parameter</title> <programlisting format="linespecific"> ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_a_contact", "a_contact") +modparam("topos", "xavu_field_a_contact", "a_contact") ... $xavu(_tps_=>a_contact) = "..."; ... @@ -429,7 +429,7 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") </example> </section> <section id="topos.p.xavu_field_b_contact"> - <title><varname>xavu_filed_b_contact</varname> (str)</title> + <title><varname>xavu_field_b_contact</varname> (str)</title> <para> Name of the field inside root XAVU specifed by `xavu_cfg` to evaluate for the B-side Contact Header user part. This parameter @@ -441,11 +441,11 @@ modparam("topos", "xavu_filed_a_contact", "a_contact") </emphasis> </para> <example> - <title>Set <varname>xavu_filed_b_contact</varname> parameter</title> + <title>Set <varname>xavu_field_b_contact</varname> parameter</title> <programlisting format="linespecific"> ... modparam("topos", "xavu_cfg", "_tps_") -modparam("topos", "xavu_filed_b_contact", "b_contact") +modparam("topos", "xavu_field_b_contact", "b_contact") ... $xavu(_tps_=>b_contact) = "...";

2 years, 7 months

Syntax error

by Scherney Theodor

Hello, I have tested following scenario: Alice "calls" Bob. Call is established. At the end of the call, Bob disconnects (hangs up) first and generates a BYE message. If there is a syntax error in FROM Header of BYE message, a 400 “Bad From header” is responded by the Proxy. If there is a syntax error in TO Header of BYE message, the message is discarded. According RFC 3261 this is not correct. Is it okay, to implement the same logic for TO Header as done for FROM Header? RFC 3261: 16.2 Stateful Proxy ………. For all new requests, including any with unknown methods, an element intending to proxy the request MUST: 1. Validate the request (Section 16.3) 2. Preprocess routing information (Section 16.4) 3. Determine target(s) for the request (Section 16.5) +--------------------+ | | +---+ | | | C | | | | T | | | +---+ +---+ | Proxy | +---+ CT = Client Transaction | S | | "Higher" Layer | | C | | T | | | | T | ST = Server Transaction +---+ | | +---+ | | +---+ | | | C | | | | T | | | +---+ +--------------------+ Figure 3: Stateful Proxy Model 4. Forward the request to each target (Section 16.6) 5. Process all responses (Section 16.7) 16.3 Request Validation Before an element can proxy a request, it MUST verify the message’s validity. A valid message must pass the following checks: 1. Reasonable Syntax 2. URI scheme 3. Max-Forwards 4. (Optional) Loop Detection 5. Proxy-Require 6. Proxy-Authorization If any of these checks fail, the element MUST behave as a user agent server (see Section 8.2) and respond with an error code. LOGs: BYE with syntax error in FROM header: Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/parse_addr_spec.c:555]: parse_to_param(): unexpected end of header, status 20: [;transport=UDP;tag=b3af-8e5a-1e36-79340f18;#015] . Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/parse_addr_spec.c:881]: parse_addr_spec(): invalid To - unexpected end of header in state 11 Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/parse_from.c:75]: parse_from_header(): bad From header [sip:catt180@vict-ims.net;transport=UDP;tag=b3af-8e5a-1e36-79340f18;] Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="pv"] ERROR: pv [pv_core.c:468]: pv_get_from_attr(): cannot parse From header Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="xlog"] INFO: <script>: route BYE (<null> (193.154.113.40:5065) to sip:catt181@vict-ims.net, 1632235417904catt180, ) Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="xlog"] INFO: <script>: BYE (BYE sip:catt181@193.154.113.40:5065;transport=UDP;rinstance=317-catt181 SIP/2.0#015#012From: sip:catt180@vict-ims.net;transport=UDP;tag=b3af-8e5a-1e36-79340f18;#015#012To: sip:catt181@vict-ims.net;transport=UDP;tag=9d7b-d1c6-c06b-7a1dbec7#015#012Call-ID: 1632235417904catt180#015#012CSeq: 2 BYE#015#012Contact: sip:catt180@193.154.113.40:5065;transport=UDP;rinstance=317-catt180#015#012Content-Length: 0#015#012Max-Forwards: 70#015#012Route: sip:mo@172.29.21.60;r2=on;lr;ftag=b3af-8e5a-1e36-79340f18;rm=8;did=8ed.6e12#015#012Route: sip:mo@pcscf-1.vict-ims.net:5060;r2=on;lr;ftag=b3af-8e5a-1e36-79340f18;rm=8;did=8ed.6e12#015#012Route: sip:mo@vict-ims.net;lr;ftag=b3af-8e5a-1e36-79340f18;did=8ed.e7b1#015#012Route: sip:mt@vict-ims.net;lr;ftag=b3af-8e5a-1e36-79340f18;did=8ed.e7b1#015#012Route: sip:mt@pcscf-1.vict-ims.net;r2=on;lr;ftag=b3af-8e5a-1e36-79340f18;rm=7;did=8ed.7e12#015#012Route: sip:mt@172.29.21.60:5060;r2=on;lr;ftag=b3af-8e5a-1e36-79340f18;rm=7;did=8ed.7e12#015#012Via: SIP/2.0/UDP 193.154.113.40:5065;branch=z9hG4bKf7057b36-0#015#012#015#012) Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/parse_addr_spec.c:555]: parse_to_param(): unexpected end of header, status 20: [;transport=UDP;tag=b3af-8e5a-1e36-79340f18;#015] . Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/parse_addr_spec.c:881]: parse_addr_spec(): invalid To - unexpected end of header in state 11 Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="sanity"] WARNING: sanity [sanity.c:776]: check_parse_uris(): failed to parse From header [sip:catt180@vict-ims.net;transport=UDP;tag=b3af-8e5a-1e36-79340f18;] Sep 21 16:44:51 vict2-ims3 /usr/sbin/kamailio[12723]: [logSDID@20306 resource="xlog"] INFO: <script>: t_relay_send_reply_sl - BYE (SIP/2.0 400 Bad From header#015#012From: sip:catt180@vict-ims.net;transport=UDP;tag=b3af-8e5a-1e36-79340f18;#015#012To: sip:catt181@vict-ims.net;transport=UDP;tag=9d7b-d1c6-c06b-7a1dbec7#015#012Call-ID: 1632235417904catt180#015#012CSeq: 2 BYE#015#012Via: SIP/2.0/UDP 193.154.113.40:5065;branch=z9hG4bKf7057b36-0#015#012Server: Kamailio P-CSCF#015#012Content-Length: 0#015#012#015#012) BYE with syntax error in TO header: Sep 21 16:41:07 vict2-ims3 /usr/sbin/kamailio[12733]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/parse_addr_spec.c:555]: parse_to_param(): unexpected end of header, status 20: [;transport=UDP;tag=1ba4-ff0c-82af-415174d1;#015#012] . Sep 21 16:41:07 vict2-ims3 /usr/sbin/kamailio[12733]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/parse_addr_spec.c:881]: parse_addr_spec(): invalid To - unexpected end of header in state 13 Sep 21 16:41:07 vict2-ims3 /usr/sbin/kamailio[12733]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/msg_parser.c:167]: get_hdr_field(): bad to header Sep 21 16:41:07 vict2-ims3 /usr/sbin/kamailio[12733]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/msg_parser.c:337]: parse_headers(): bad header field [To: sip:catt181@vict] Sep 21 16:41:07 vict2-ims3 /usr/sbin/kamailio[12733]: [logSDID@20306 resource="core"] ERROR: <core> [core/parser/msg_parser.c:687]: parse_msg(): ERROR: parse_msg: message=<BYE sip:catt181@193.154.113.40:5065;transport=UDP;rinstance=317-catt181 SIP/2.0#015#012From: sip:catt180@vict-ims.net;transport=UDP;tag=b7fb-dd8f-30fd-2a93fc86#015#012To: sip:catt181@vict-ims.net;transport=UDP;tag=1ba4-ff0c-82af-415174d1;#015#012Call-ID: 1632235194213catt180#015#012CSeq: 2 BYE#015#012Contact: sip:catt180@193.154.113.40:5065;transport=UDP;rinstance=317-catt180#015#012Content-Length: 0#015#012Max-Forwards: 70#015#012Route: sip:mo@172.29.21.60;r2=on;lr;ftag=b7fb-dd8f-30fd-2a93fc86;rm=8;did=281.c9a1#015#012Route: sip:mo@pcscf-1.vict-ims.net:5060;r2=on;lr;ftag=b7fb-dd8f-30fd-2a93fc86;rm=8;did=281.c9a1#015#012Route: sip:mo@vict-ims.net;lr;ftag=b7fb-dd8f-30fd-2a93fc86;did=281.b871#015#012Route: sip:mt@vict-ims.net;lr;ftag=b7fb-dd8f-30fd-2a93fc86;did=281.b871#015#012Route: sip:mt@pcscf-1.vict-ims.net;r2=on;lr;ftag=b7fb-dd8f-30fd-2a93fc86;rm=7;did=281.d9a1#015#012Route: sip:mt@172.29.21.60:5060;r2=on;lr;ftag=b7fb-dd8f-30fd-2a93fc86;rm=7;did=281.d9a1#015#012Via: SIP/2.0/UDP 193.154.113.40:5065;branch=z9hG4bK0850615e-0#015#012#015#012> Sep 21 16:41:07 vict2-ims3 /usr/sbin/kamailio[12733]: [logSDID@20306 resource="core"] ERROR: <core> [core/receive.c:199]: receive_msg(): core parsing of SIP message failed (193.154.113.40:5065/1) BR Theo

2 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2021