sr-dev October 2021

sr-dev@lists.kamailio.org

19 participants
245 discussions

Timer handling broken in 5.5.2
by Markus Bönke 05 Oct '21

05 Oct '21

Hello all, the handling of timer events is broken in 5.5.2. I get the following error: ERROR: <core> [core/parser/msg_parser.c:748]: parse_msg(): ERROR: parse_msg: message=<GET /timer HTTP/0.9#012#012> I think it was introduced by https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be… <https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be…> ... skip: msg->unparsed=tmp; if(msg->headers==NULL) { /* nothing parsed - invalid input sip message */ goto error1; } … Should’t thy be handled different already in parse_msg in msg_parser.c? Thanks and regards Markus

2 3

git:5.5:a9c5f3e4: timer: extend internal static HTTP message to have one header
by Daniel-Constantin Mierla 05 Oct '21

05 Oct '21

Module: kamailio Branch: 5.5 Commit: a9c5f3e4d29dccda79eee8e594d4316e32196db5 URL: https://github.com/kamailio/kamailio/commit/a9c5f3e4d29dccda79eee8e594d4316… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T16:38:00+02:00 timer: extend internal static HTTP message to have one header (cherry picked from commit c3629f877500373028d2c7cdefd976cddda31c15) --- Modified: src/modules/timer/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/a9c5f3e4d29dccda79eee8e594d4316… Patch: https://github.com/kamailio/kamailio/commit/a9c5f3e4d29dccda79eee8e594d4316… --- diff --git a/src/modules/timer/timer.c b/src/modules/timer/timer.c index 9880a8420b..224a6bed57 100644 --- a/src/modules/timer/timer.c +++ b/src/modules/timer/timer.c @@ -159,7 +159,7 @@ static unsigned int timer_msg_no = 0; static ticks_t timer_handler(ticks_t ticks, struct timer_ln* tl, void* data) { /*?min length of first line of message is 16 char!?*/ -#define MSG "GET /timer HTTP/0.9\n\n" +#define MSG "GET /timer HTTP/0.9\r\nUser-Agent: internal\r\n\r\n" sip_msg_t* msg; timer_action_t *a; run_act_ctx_t ra_ctx;

1 0

git:5.5:a78acd8f: textops: docs update to state regex params expect posix format
by Daniel-Constantin Mierla 05 Oct '21

05 Oct '21

Module: kamailio Branch: 5.5 Commit: a78acd8f40ed38b161a075bef74febd93acb092c URL: https://github.com/kamailio/kamailio/commit/a78acd8f40ed38b161a075bef74febd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T16:37:38+02:00 textops: docs update to state regex params expect posix format (cherry picked from commit b19aab7fe00f72d0c9e54a7a106ec7a065a3d02b) --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a78acd8f40ed38b161a075bef74febd… Patch: https://github.com/kamailio/kamailio/commit/a78acd8f40ed38b161a075bef74febd… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 6f3ab09f9a..82f6d2495f 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -19,9 +19,15 @@ The module implements text based operations over the SIP message processed by &kamailio;. SIP is a text based protocol and the module provides a large set of very useful functions to manipulate the - message at text level, e.g., regular expression search and replace, - Perl-like substitutions, checks for method type, header presence, - insert of new header and date, etc. + message at text level, e.g., regular expression search, replace + or substitutions, checks for method type, header presence, + insert of new header and date, string comparisons, multi-part body + operations, etc. + </para> + <para> + If not stated otherwise, the regular expressions parameters for search, + replace or substitute have to be in POSIX format. For PCRE regular + expression matching, see the pcre or dialplan modules. </para> </section> <section> @@ -591,7 +597,7 @@ replace_hdrs_str("&kamailio;", "&kamailio; SIP Proxy", "a"); <function moreinfo="none">subst('/re/repl/flags')</function> </title> <para> - Replaces re with repl (sed or perl like). + Replaces re with repl. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -728,7 +734,7 @@ if (subst_user('/(.*)3642$/$avp(user_prefix)\13642/')){$ <function moreinfo="none">subst_body('/re/repl/flags')</function> </title> <para> - Replaces re with repl (sed or perl like) in the body of the message. + Replaces re with repl in the body of the message. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -768,7 +774,7 @@ if ( subst_body('/^o=(.*) /o=$fU /') ) {}; <function moreinfo="none">subst_hf(hf, subexp, flags)</function> </title> <para> - Perl-like substitutions in the body of a header field. + Substitutions in the body of a header field. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist>

1 0

git:5.5:37814e67: rtpengine: docs - note that rpc reload is limited to 10secs frequency
by Daniel-Constantin Mierla 05 Oct '21

05 Oct '21

Module: kamailio Branch: 5.5 Commit: 37814e67dac6772ff08e85133898182aea0f9de6 URL: https://github.com/kamailio/kamailio/commit/37814e67dac6772ff08e85133898182… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T16:37:02+02:00 rtpengine: docs - note that rpc reload is limited to 10secs frequency (cherry picked from commit a9c9b83c9dd1c09738b5a33362a8e339c20b786c) --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/37814e67dac6772ff08e85133898182… Patch: https://github.com/kamailio/kamailio/commit/37814e67dac6772ff08e85133898182… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index ef7d5a4fd7..9e8dee5d80 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -3188,7 +3188,7 @@ play_dtmf("code=1 volume=5 duration=300 pause=150"); <title>RPC Commands</title> <section id="rtpengine.r.reload"> - <title>rtpengine.reload</title> + <title><function moreinfo="none">rtpengine.reload</function></title> <para> Reloads the database node table content <emphasis>if configured</emphasis>. Returns specific message related to success, failure and no db_url configured. @@ -3198,6 +3198,9 @@ play_dtmf("code=1 volume=5 duration=300 pause=150"); hides old ones, based on the database content. If allow_op modparam is enabled, the sessions are still allowed to finish for the hidden old nodes. </para> + <para> + The execution of this command is limited to 10 seconds intervals. + </para> <example> <title> <function moreinfo="none">rtpengine.reload</function> usage</title>

1 0

git:5.5:4dd8c636: async: docs - added section ids for parameters
by Daniel-Constantin Mierla 05 Oct '21

05 Oct '21

Module: kamailio Branch: 5.5 Commit: 4dd8c636701c778f50d11a37265e9b6300f45ecb URL: https://github.com/kamailio/kamailio/commit/4dd8c636701c778f50d11a37265e9b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T16:36:45+02:00 async: docs - added section ids for parameters (cherry picked from commit ed3b2506e13214d25a3dd78e487ed35ed13053ac) --- Modified: src/modules/async/doc/async_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/4dd8c636701c778f50d11a37265e9b6… Patch: https://github.com/kamailio/kamailio/commit/4dd8c636701c778f50d11a37265e9b6… --- diff --git a/src/modules/async/doc/async_admin.xml b/src/modules/async/doc/async_admin.xml index 5e9277a194..a56c60d7d2 100644 --- a/src/modules/async/doc/async_admin.xml +++ b/src/modules/async/doc/async_admin.xml @@ -68,7 +68,7 @@ </section> <section> <title>Parameters</title> - <section> + <section id="async.p.workers"> <title><varname>workers</varname> (int)</title> <para> Number of worker processes to be started to handle the asynchronous @@ -88,7 +88,7 @@ modparam("async", "workers", 2) </programlisting> </example> </section> - <section> + <section id="async.p.ms_timer"> <title><varname>ms_timer</varname> (int)</title> <para> Enables millisecond timer for async_ms_sleep() and async_ms_route() functions.

1 0

git:5.5:a2aa9f66: core: jump to error in case of unexpected comma for parse addr spec
by Daniel-Constantin Mierla 05 Oct '21

05 Oct '21

Module: kamailio Branch: 5.5 Commit: a2aa9f66a3cb898d6cdfbf3aba6d3a8b8b804429 URL: https://github.com/kamailio/kamailio/commit/a2aa9f66a3cb898d6cdfbf3aba6d3a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T16:36:31+02:00 core: jump to error in case of unexpected comma for parse addr spec (cherry picked from commit 932e46b09176544cf6e085a32677980b26e4d2eb) --- Modified: src/core/parser/parse_addr_spec.c --- Diff: https://github.com/kamailio/kamailio/commit/a2aa9f66a3cb898d6cdfbf3aba6d3a8… Patch: https://github.com/kamailio/kamailio/commit/a2aa9f66a3cb898d6cdfbf3aba6d3a8… --- diff --git a/src/core/parser/parse_addr_spec.c b/src/core/parser/parse_addr_spec.c index 1ff5a16908..f003e5f31a 100644 --- a/src/core/parser/parse_addr_spec.c +++ b/src/core/parser/parse_addr_spec.c @@ -494,6 +494,7 @@ static char *parse_to_param(char *const buffer, const char *const end, } LM_ERR("invalid character ',' in status %d: [%.*s]\n", status, (int)(tmp - buffer), ZSW(buffer)); + goto error; } default: switch(status) {

1 0

git:master:c3629f87: timer: extend internal static HTTP message to have one header
by Daniel-Constantin Mierla 05 Oct '21

05 Oct '21

Module: kamailio Branch: master Commit: c3629f877500373028d2c7cdefd976cddda31c15 URL: https://github.com/kamailio/kamailio/commit/c3629f877500373028d2c7cdefd976c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T14:26:30+02:00 timer: extend internal static HTTP message to have one header --- Modified: src/modules/timer/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/c3629f877500373028d2c7cdefd976c… Patch: https://github.com/kamailio/kamailio/commit/c3629f877500373028d2c7cdefd976c… --- diff --git a/src/modules/timer/timer.c b/src/modules/timer/timer.c index 9880a8420b..224a6bed57 100644 --- a/src/modules/timer/timer.c +++ b/src/modules/timer/timer.c @@ -159,7 +159,7 @@ static unsigned int timer_msg_no = 0; static ticks_t timer_handler(ticks_t ticks, struct timer_ln* tl, void* data) { /*?min length of first line of message is 16 char!?*/ -#define MSG "GET /timer HTTP/0.9\n\n" +#define MSG "GET /timer HTTP/0.9\r\nUser-Agent: internal\r\n\r\n" sip_msg_t* msg; timer_action_t *a; run_act_ctx_t ra_ctx;

1 0

git:master:f23d48b9: modules: readme files regenerated - tm ... [skip ci]
by Kamailio Dev 05 Oct '21

05 Oct '21

Module: kamailio Branch: master Commit: f23d48b975bdfe06d3c07c4b65f60a2a19b38541 URL: https://github.com/kamailio/kamailio/commit/f23d48b975bdfe06d3c07c4b65f60a2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-10-05T14:16:12+02:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/f23d48b975bdfe06d3c07c4b65f60a2… Patch: https://github.com/kamailio/kamailio/commit/f23d48b975bdfe06d3c07c4b65f60a2… --- diff --git a/src/modules/tm/README b/src/modules/tm/README index 670cd7bb0b..2af6b9a703 100644 --- a/src/modules/tm/README +++ b/src/modules/tm/README @@ -1376,7 +1376,8 @@ modparam("tm", "callid_matching", 1) 3.33. callid_cseq_matching (int) If set to something other than 0, will do transaction matching using - callid and cseq header values instead of via branch md5 value. + callid and cseq header values instead of via branch md5 value. Note + that this behavior is non-RFC conpliant! Default value is 0.

1 0

git:master:fe3e6e7f: tm: update doc for callid_cseq_matching
by Stefan Mititelu 05 Oct '21

05 Oct '21

Module: kamailio Branch: master Commit: fe3e6e7f64199dd6d2f55d6762dbd17ca0160817 URL: https://github.com/kamailio/kamailio/commit/fe3e6e7f64199dd6d2f55d6762dbd17… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Date: 2021-10-05T15:05:17+03:00 tm: update doc for callid_cseq_matching --- Modified: src/modules/tm/doc/params.xml --- Diff: https://github.com/kamailio/kamailio/commit/fe3e6e7f64199dd6d2f55d6762dbd17… Patch: https://github.com/kamailio/kamailio/commit/fe3e6e7f64199dd6d2f55d6762dbd17… --- diff --git a/src/modules/tm/doc/params.xml b/src/modules/tm/doc/params.xml index d2e2f4db0e..8614fdac85 100644 --- a/src/modules/tm/doc/params.xml +++ b/src/modules/tm/doc/params.xml @@ -1002,6 +1002,10 @@ modparam("tm", "callid_matching", 1) <para> If set to something other than 0, will do transaction matching using callid and cseq header values instead of via branch md5 value. + + <emphasis> + Note that this behavior is non-RFC conpliant! + </emphasis> </para> <para> <emphasis>

1 0

[kamailio/kamailio] tm: Add callid_cseq_matching param (#2868)
by Stefan Mititelu 05 Oct '21

05 Oct '21

Enable transaction matching using callid and cseq values instead of via md5 value.   #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Hello, We had an issue with kamailio that the generated tm p_cell->md5 was not sent out in Via "branch=" parameter. Instead, other value was sent. Thus when comparing the replies Via "branch=" md5 value back to p_cell->md5, the transactions mismatched and dialogs were not setup. This happened for the most of the transactions/dialogs. We could not really figure out why the above was happening. Because this was an isolated system, we decided to do this workaround using callid and cseq matching for transactions, and it helped. Now most of the dialogs are setup. Let me know what you think, if other had this problem and if this PR helps. Thank you, Stefan You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2868 -- Commit Summary -- * <a href="https://github.com/kamailio/kamailio/pull/2868/commits/ab42c71fa814a9d2f3d8…">tm: Add callid_cseq_matching param</a> -- File Changes -- M src/modules/tm/config.c (3) M src/modules/tm/config.h (1) M src/modules/tm/doc/params.xml (23) M src/modules/tm/t_lookup.c (20) M src/modules/tm/tm.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2868.patch https://github.com/kamailio/kamailio/pull/2868.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2868

3 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2021