sr-dev October 2021

sr-dev@lists.kamailio.org

19 participants
243 discussions

[kamailio/kamailio] Ability to use Publish/subscribe mechanism for N-to-N media forwarding using kamailio (#2874)

by Naveen Khanna

### Description Recently rtpengine has introduced Publish/subscribe mechanism for N-to-N media forwarding and recording. Is it already on Kamailio? I have gone through the document or rtpengine module in Kamailio and could not find anything that suggests the feature has been incorporated.  ### Expected behavior #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.4.3 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**:  ``` Linux secondary 4.19.0-17-amd64 #1 SMP Debian 4.19.194-3 (2021-07-18) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2874

2 years, 6 months

[kamailio/kamailio] Memory leak in tcpconn_new() (#2875)

by Nacho G.

### Description  I found a memory leak which is causing some issues for us in our production. I think I was able to reproduce it and determine that this is happening when we set up an MSRP connection, and that connection is closed due to inactivity (for example when `tcp_connection_lifetime` is triggered). ### Troubleshooting #### Reproduction  In this environment we have a WebRTC SIP client, connected to Kamailio and a second party using SIP, both sending messages each via MSRP protocol. Web Client and SIP client establish a session normally, all fine here, they can communicate. At this point we have this status: ``` sudo netstat -natp | grep 10.22.22 tcp 0 0 10.22.22.21:5060 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:10000 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:8080 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:10001 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:10002 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:8080 10.22.22.1:58508 ESTABLISHED 28640/kamailio tcp 0 0 10.22.22.21:10000 10.22.22.190:32786 ESTABLISHED 28646/kamailio tcp 0 0 10.22.22.21:8080 10.22.22.1:58506 ESTABLISHED 28591/kamailio TESTER|centos8.4|tester21 [2021-10-06][16:23:57] [/home/vagrant]$ kamcmd -s udp:127.0.0.1:2046 mod.stats core all | grep tcp tcpconn_new(971): 198888 init_tcp(4700): 8192 init_tcp(4694): 32768 init_tcp(4686): 8 init_tcp(4679): 8 init_tcp(4672): 8 init_tcp(4666): 8 init_tcp(4654): 8 ``` In order to trigger this failure much faster, I set `tcp_connection_lifetime=60`. Then we just wait the required seconds to let the TCP connections closed. Then we finish the session, and stop our WebClient registering, so all connections are cleaned up. ``` TESTER|centos8.4|tester21 [2021-10-06][16:28:08] [/home/vagrant]$ sudo netstat -natp | grep 10.22.22 tcp 0 0 10.22.22.21:5060 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:10000 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:8080 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:10001 0.0.0.0:* LISTEN 28646/kamailio tcp 0 0 10.22.22.21:10002 0.0.0.0:* LISTEN 28646/kamailio TESTER|centos8.4|tester21 [2021-10-06][16:28:20] [/home/vagrant]$ kamcmd -s udp:127.0.0.1:2046 mod.stats core all | grep tcp tcpconn_new(971): 66296 init_tcp(4700): 8192 init_tcp(4694): 32768 init_tcp(4686): 8 init_tcp(4679): 8 init_tcp(4672): 8 init_tcp(4666): 8 init_tcp(4654): 8 ``` As you can see there are no connections but there is memory allocated by `tcpconn_new`. I know this is related to the MSRP because we noticed our SIP Web Client is not closing the socket, so we just wait for Kamailio to close it. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` 2021-07-25T23:54:41Z ERROR ERROR: <core> [mem/f_malloc.c:415]: fm_search_defrag(): fm_search_defrag(0x7f39a284c000, 66288); Free fragment not found! 2021-07-25T23:54:41Z ERROR ERROR: <core> [mem/f_malloc.c:498]: fm_malloc(): fm_malloc(0x7f39a284c000, 66288) called from core: tcp_main.c: tcpconn_new(957), module: core; Free fragment not found! 2021-07-25T23:54:41Z ERROR ERROR: <core> [tcp_main.c:959]: tcpconn_new(): mem. allocation failure 2021-07-25T23:54:41Z ERROR ERROR: <core> [tcp_main.c:3985]: handle_new_connect(): tcpconn_new failed, closing socket ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) 7d1964 flags: STATS: Off, EXTRA_DEBUG, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, DBG_QM_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 7d1964 compiled on 13:54:09 Oct 5 2021 with gcc 8.4.1 ``` Already tried with the latest stable Kamailio version, with the same issue. * **Operating System**:  ``` Linux tester21 4.18.0-305.17.1.el8_4.x86_64 #1 SMP Wed Sep 8 14:00:07 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux centos 8 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2875

2 years, 6 months

git:master:12f5376f: modules: readme files regenerated - htable ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 12f5376f3af8331c5f0bccfe04c96e7930bbeaa7 URL: https://github.com/kamailio/kamailio/commit/12f5376f3af8331c5f0bccfe04c96e7… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-10-08T10:01:20+02:00 modules: readme files regenerated - htable ... [skip ci] --- Modified: src/modules/htable/README --- Diff: https://github.com/kamailio/kamailio/commit/12f5376f3af8331c5f0bccfe04c96e7… Patch: https://github.com/kamailio/kamailio/commit/12f5376f3af8331c5f0bccfe04c96e7…

2 years, 6 months

git:master:c6b731ac: htable: added iterator function to remove current item

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c6b731ac1803a2a7fcbd2a9d00e74af576d3886c URL: https://github.com/kamailio/kamailio/commit/c6b731ac1803a2a7fcbd2a9d00e74af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-08T09:47:06+02:00 htable: added iterator function to remove current item --- Modified: src/modules/htable/doc/htable_admin.xml Modified: src/modules/htable/ht_api.c Modified: src/modules/htable/ht_api.h Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/c6b731ac1803a2a7fcbd2a9d00e74af… Patch: https://github.com/kamailio/kamailio/commit/c6b731ac1803a2a7fcbd2a9d00e74af…

2 years, 6 months

git:master:2e92a813: htable: use a function for finding the iterator

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 2e92a813cc0977e6f1e524bb8bafefb73efccba0 URL: https://github.com/kamailio/kamailio/commit/2e92a813cc0977e6f1e524bb8bafefb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-08T09:15:06+02:00 htable: use a function for finding the iterator --- Modified: src/modules/htable/ht_api.c --- Diff: https://github.com/kamailio/kamailio/commit/2e92a813cc0977e6f1e524bb8bafefb… Patch: https://github.com/kamailio/kamailio/commit/2e92a813cc0977e6f1e524bb8bafefb… --- diff --git a/src/modules/htable/ht_api.c b/src/modules/htable/ht_api.c index 7bade571c3..7eb7bfa0d7 100644 --- a/src/modules/htable/ht_api.c +++ b/src/modules/htable/ht_api.c @@ -1700,19 +1700,16 @@ void ht_iterator_init(void) memset(_ht_iterators, 0, HT_ITERATOR_SIZE*sizeof(ht_iterator_t)); } -int ht_iterator_start(str *iname, str *hname) +static inline int ht_iterator_find(str *iname) { int i; int k; k = -1; - for(i=0; i<HT_ITERATOR_SIZE; i++) - { - if(_ht_iterators[i].name.len>0) - { + for(i=0; i<HT_ITERATOR_SIZE; i++) { + if(_ht_iterators[i].name.len>0) { if(_ht_iterators[i].name.len==iname->len - && strncmp(_ht_iterators[i].name.s, iname->s, iname->len)==0) - { + && strncmp(_ht_iterators[i].name.s, iname->s, iname->len)==0) { k = i; break; } @@ -1720,6 +1717,14 @@ int ht_iterator_start(str *iname, str *hname) if(k==-1) k = i; } } + return k; +} + +int ht_iterator_start(str *iname, str *hname) +{ + int k; + + k = ht_iterator_find(iname); if(k==-1) { LM_ERR("no iterator available - max number is %d\n", HT_ITERATOR_SIZE); @@ -1759,24 +1764,9 @@ int ht_iterator_start(str *iname, str *hname) int ht_iterator_next(str *iname) { - int i; int k; - k = -1; - for(i=0; i<HT_ITERATOR_SIZE; i++) - { - if(_ht_iterators[i].name.len>0) - { - if(_ht_iterators[i].name.len==iname->len - && strncmp(_ht_iterators[i].name.s, iname->s, iname->len)==0) - { - k = i; - break; - } - } else { - if(k==-1) k = i; - } - } + k = ht_iterator_find(iname); if(k==-1) { LM_ERR("iterator not found [%.*s]\n", iname->len, iname->s); @@ -1819,47 +1809,38 @@ int ht_iterator_next(str *iname) int ht_iterator_end(str *iname) { - int i; + int k; - for(i=0; i<HT_ITERATOR_SIZE; i++) + k = ht_iterator_find(iname); + if(k==-1 || _ht_iterators[k].name.len<=0) { - if(_ht_iterators[i].name.len>0) + LM_ERR("iterator not found [%.*s]\n", iname->len, iname->s); + return -1; + } + + if(_ht_iterators[k].ht!=NULL && _ht_iterators[k].it!=NULL) + { + if(_ht_iterators[k].slot>=0 && _ht_iterators[k].slot<_ht_iterators[k].ht->htsize) { - if(_ht_iterators[i].name.len==iname->len - && strncmp(_ht_iterators[i].name.s, iname->s, iname->len)==0) - { - if(_ht_iterators[i].ht!=NULL && _ht_iterators[i].it!=NULL) - { - if(_ht_iterators[i].slot>=0 && _ht_iterators[i].slot<_ht_iterators[i].ht->htsize) - { - ht_slot_unlock(_ht_iterators[i].ht, _ht_iterators[i].slot); - } - } - memset(&_ht_iterators[i], 0, sizeof(ht_iterator_t)); - return 0; - } + ht_slot_unlock(_ht_iterators[k].ht, _ht_iterators[k].slot); } } - - return -1; + memset(&_ht_iterators[k], 0, sizeof(ht_iterator_t)); + return 0; } ht_cell_t* ht_iterator_get_current(str *iname) { - int i; + int k; + if(iname==NULL || iname->len<=0) return NULL; - for(i=0; i<HT_ITERATOR_SIZE; i++) - { - if(_ht_iterators[i].name.len>0) - { - if(_ht_iterators[i].name.len==iname->len - && strncmp(_ht_iterators[i].name.s, iname->s, iname->len)==0) - { - return _ht_iterators[i].it; - } - } + k = ht_iterator_find(iname); + if(k==-1 || _ht_iterators[k].name.len<=0) { + LM_DBG("iterator not found [%.*s]\n", iname->len, iname->s); + return NULL; } - return NULL; + + return _ht_iterators[k].it; }

2 years, 6 months

git:master:eaec3aaa: pv: {line.count} - count last line without \n

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: eaec3aaac227eb4a8c48f93b45565d15d4a0a991 URL: https://github.com/kamailio/kamailio/commit/eaec3aaac227eb4a8c48f93b45565d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-07T09:21:20+02:00 pv: {line.count} - count last line without \n --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/eaec3aaac227eb4a8c48f93b45565d1… Patch: https://github.com/kamailio/kamailio/commit/eaec3aaac227eb4a8c48f93b45565d1… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index b63ad022f8..330c70cb6f 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -2435,19 +2435,22 @@ int tr_eval_line(struct sip_msg *msg, tr_param_t *tp, int subtype, break; case TR_LINE_COUNT: - n=0; - for(i=0; i<val->rs.len; i++) - if(val->rs.s[i]=='\n') + n = 0; + if(val->rs.len>0) { + for(i=0; i<val->rs.len; i++) { + if(val->rs.s[i]=='\n') { + n++; + } + } + if(val->rs.s[val->rs.len-1]!='\n') { n++; - if(n==0 && val->rs.len>0) - n = 1; + } + } val->flags = PV_TYPE_INT|PV_VAL_INT|PV_VAL_STR; val->ri = n; val->rs.s = int2str(val->ri, &val->rs.len); break; - break; - default: LM_ERR("unknown subtype %d\n", subtype);

2 years, 6 months

[kamailio/kamailio] [FEATURE REQUEST] Add reload functionality for the configured database (path) in GeoIP2 module (#2870)

by Joel Serrano

### Description Currently there is no way to tell Kamailio to reload the GeoIP database that is configured without a restart. This feature request is for adding the possibility to hot-reload the GeoIP2 database. ### Possible Solutions Implement a RPC command to reload the database, similar to the way the TLS module implements `tls.reload` to reload the configured certificates without needing a restart. ### Example `kamcmd geoip2.reload` / `kamctl rpc geoip2.reload` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2870

2 years, 6 months

git:5.5:0d53d9a6: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.5 Commit: 0d53d9a676747cd6583c6cfcdf5b3e8593b6c84a URL: https://github.com/kamailio/kamailio/commit/0d53d9a676747cd6583c6cfcdf5b3e8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-10-05T16:46:33+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/rtpengine/README Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/0d53d9a676747cd6583c6cfcdf5b3e8… Patch: https://github.com/kamailio/kamailio/commit/0d53d9a676747cd6583c6cfcdf5b3e8… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index 24d02d1c5d..6f962d4aed 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -2669,6 +2669,8 @@ play_dtmf("code=1 volume=5 duration=300 pause=150"); is enabled, the sessions are still allowed to finish for the hidden old nodes. + The execution of this command is limited to 10 seconds intervals. + Example 1.100. rtpengine.reload usage ... $ kamcmd rtpengine.reload diff --git a/src/modules/textops/README b/src/modules/textops/README index e86ff275d8..08dd399246 100644 --- a/src/modules/textops/README +++ b/src/modules/textops/README @@ -249,9 +249,13 @@ Chapter 1. Admin Guide The module implements text based operations over the SIP message processed by Kamailio. SIP is a text based protocol and the module provides a large set of very useful functions to manipulate the message - at text level, e.g., regular expression search and replace, Perl-like + at text level, e.g., regular expression search, replace or substitutions, checks for method type, header presence, insert of new - header and date, etc. + header and date, string comparisons, multi-part body operations, etc. + + If not stated otherwise, the regular expressions parameters for search, + replace or substitute have to be in POSIX format. For PCRE regular + expression matching, see the pcre or dialplan modules. 2. Known Limitations @@ -598,7 +602,7 @@ replace_hdrs_str("Kamailio", "Kamailio SIP Proxy", "a"); 4.16. subst('/re/repl/flags') - Replaces re with repl (sed or perl like). + Replaces re with repl. Meaning of the parameters is as follows: * '/re/repl/flags' - sed like regular expression. flags can be a @@ -679,7 +683,7 @@ if (subst_user('/(.*)3642$/$avp(user_prefix)\13642/')){$ 4.19. subst_body('/re/repl/flags') - Replaces re with repl (sed or perl like) in the body of the message. + Replaces re with repl in the body of the message. Meaning of the parameters is as follows: * '/re/repl/flags' - sed like regular expression. flags can be a @@ -700,7 +704,7 @@ if ( subst_body('/^o=(.*) /o=$fU /') ) {}; 4.20. subst_hf(hf, subexp, flags) - Perl-like substitutions in the body of a header field. + Substitutions in the body of a header field. Meaning of the parameters is as follows: * hf - header field name.

2 years, 6 months

Timer handling broken in 5.5.2

by Markus Bönke

Hello all, the handling of timer events is broken in 5.5.2. I get the following error: ERROR: <core> [core/parser/msg_parser.c:748]: parse_msg(): ERROR: parse_msg: message=<GET /timer HTTP/0.9#012#012> I think it was introduced by https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be… <https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be…> ... skip: msg->unparsed=tmp; if(msg->headers==NULL) { /* nothing parsed - invalid input sip message */ goto error1; } … Should’t thy be handled different already in parse_msg in msg_parser.c? Thanks and regards Markus

2 years, 6 months

git:5.5:a9c5f3e4: timer: extend internal static HTTP message to have one header

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.5 Commit: a9c5f3e4d29dccda79eee8e594d4316e32196db5 URL: https://github.com/kamailio/kamailio/commit/a9c5f3e4d29dccda79eee8e594d4316… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-10-05T16:38:00+02:00 timer: extend internal static HTTP message to have one header (cherry picked from commit c3629f877500373028d2c7cdefd976cddda31c15) --- Modified: src/modules/timer/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/a9c5f3e4d29dccda79eee8e594d4316… Patch: https://github.com/kamailio/kamailio/commit/a9c5f3e4d29dccda79eee8e594d4316… --- diff --git a/src/modules/timer/timer.c b/src/modules/timer/timer.c index 9880a8420b..224a6bed57 100644 --- a/src/modules/timer/timer.c +++ b/src/modules/timer/timer.c @@ -159,7 +159,7 @@ static unsigned int timer_msg_no = 0; static ticks_t timer_handler(ticks_t ticks, struct timer_ln* tl, void* data) { /*?min length of first line of message is 16 char!?*/ -#define MSG "GET /timer HTTP/0.9\n\n" +#define MSG "GET /timer HTTP/0.9\r\nUser-Agent: internal\r\n\r\n" sip_msg_t* msg; timer_action_t *a; run_act_ctx_t ra_ctx;

2 years, 6 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2021