sr-dev May 2020

sr-dev@lists.kamailio.org

24 participants
394 discussions

[kamailio/kamailio] Segfault in openssl on Xenial (#2274)
by Nathan 27 May '20

27 May '20

### Description Segfault in Kamailio when using mysql (over ssl) and tls listeners. We have a reproducible segfault with Kamailio on Ubuntu Xenial. The problems is revealed when two modules (db_mysql and tls) and both using the openssl library. The mysql module is using openssl indirectly, because the connection is encrypted by default when the server supports it. ### Troubleshooting #### Reproduction Install Kamailio with - tls listeners enabled - dispatcher module enabled, from mysql db Example configuration attached: In this case, reproduction with: - start kamailio - let dispatcher reload, for example via jsonrpc - make connection on tls, for example with `openssl s_connect` Kamailio will crash. #### Debugging Data Stack trace, with `libssl1.0.0-dbg` installed: ``` #0 0x0000000000000000 in ?? () #1 0x00007ff862d07b0d in getrn (lh=lh@entry=0x7ff8641eb7e8, data=data@entry=0x7ffe1f36e750, rhash=rhash@entry=0x7ffe1f36e6f0) at lhash.c:396 #2 0x00007ff862d0817a in lh_retrieve (lh=0x7ff8641eb7e8, data=data@entry=0x7ffe1f36e750) at lhash.c:248 #3 0x00007ff862d0a651 in int_thread_get_item (d=0x7ffe1f36e750) at err.c:500 #4 0x00007ff862d0b024 in ERR_get_state () at err.c:1023 #5 0x00007ff862d0b25f in ERR_clear_error () at err.c:743 #6 0x00007ff86305c67e in ssl23_accept (s=0x7ff864a282d0) at s23_srvr.c:157 #7 0x00007ff860b70d86 in tls_accept (c=0x7ff864af8810, error=0x7ffe1f36eb30) at tls_server.c:422 #8 0x00007ff860b7a486 in tls_read_f (c=0x7ff864af8810, flags=0x7ffe1f38eedc) at tls_server.c:1116 #9 0x0000000000625ac2 in tcp_read_headers (c=0x7ff864af8810, read_flags=0x7ffe1f38eedc) at core/tcp_read.c:469 #10 0x000000000062d05d in tcp_read_req (con=0x7ff864af8810, bytes_read=0x7ffe1f38eed8, read_flags=0x7ffe1f38eedc) at core/tcp_read.c:1496 #11 0x0000000000631c42 in handle_io (fm=0x7ff885734520, events=1, idx=-1) at core/tcp_read.c:1804 #12 0x0000000000620500 in io_wait_loop_epoll (h=0xae0200 <io_w>, t=2, repeat=0) at core/io_wait.h:1065 #13 0x0000000000633adb in tcp_receive_loop (unix_sock=26) at core/tcp_read.c:1974 #14 0x000000000051a9a1 in tcp_init_children () at core/tcp_main.c:4853 #15 0x000000000042620e in main_loop () at main.c:1745 #16 0x000000000042ca76 in main (argc=7, argv=0x7ffe1f38f578) at main.c:2696 ``` #### Log Messages ``` 2020-04-05T01:27:37.965778+02:00 nathancmp01 kernel: [432825.787355] kamailio[6296]: segfault at 0 ip (null) sp 00007ffe4cdaf248 error 14 in kamailio[400000+47b000] ``` #### SIP Traffic No SIP traffic needed, just a TLS connection. ### Possible Solutions Could not reproduce with Kamailio 5.3.3 on Ubuntu Bionic nor Debian Buster. Both are using openssl 1.1.x, so I guess that fixes the problem. But Xenial is still on 1.0.2g... ### Additional Information Tested with Kamailio 5.2 and 5.3.3. * **Operating System**: Repro on: - Ubuntu Xenial No repro on: - Ubuntu Bionic - Debian Buster -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2274

2 19

git:master:9b6ec0a4: core: added --debug=val command line parameter
by Daniel-Constantin Mierla 27 May '20

27 May '20

Module: kamailio Branch: master Commit: 9b6ec0a4912a617239395563cdd29233f65cb57d URL: https://github.com/kamailio/kamailio/commit/9b6ec0a4912a617239395563cdd2923… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-27T13:36:42+02:00 core: added --debug=val command line parameter - set the value for debug global parameter from command line, allows negative values corresponding to L_XYZ levels - alternative to -d which operated by incresing debug level starting from 0 --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/9b6ec0a4912a617239395563cdd2923… Patch: https://github.com/kamailio/kamailio/commit/9b6ec0a4912a617239395563cdd2923… --- diff --git a/src/main.c b/src/main.c index 8926308ca5..e57bfa40f8 100644 --- a/src/main.c +++ b/src/main.c @@ -169,7 +169,8 @@ Options:\n\ -b nr Maximum receive buffer size which will not be exceeded by\n\ auto-probing procedure even if OS allows\n\ -c Check configuration file for syntax errors\n\ - -d Debugging mode (multiple -d increase the level)\n\ + -d Debugging level control (multiple -d to increase the level from 0)\n\ + --debug=val Debugging level value\n\ -D Control how daemonize is done:\n\ -D..do not fork (almost) anyway;\n\ -DD..do not daemonize creator;\n\ @@ -1931,6 +1932,7 @@ int main(int argc, char** argv) {"loadmodule", required_argument, 0, KARGOPTVAL + 5}, {"modparam", required_argument, 0, KARGOPTVAL + 6}, {"log-engine", required_argument, 0, KARGOPTVAL + 7}, + {"debug", required_argument, 0, KARGOPTVAL + 8}, {0, 0, 0, 0 } }; @@ -1992,6 +1994,14 @@ int main(int argc, char** argv) case KARGOPTVAL+7: ksr_slog_init(optarg); break; + case KARGOPTVAL+8: + debug_flag = 1; + default_core_cfg.debug=(int)strtol(optarg, &tmp, 10); + if ((tmp==0) || (*tmp)){ + LM_ERR("bad debug level value: %s\n", optarg); + goto error; + } + break; default: if (c == 'h' || (optarg && strcmp(optarg, "-h") == 0)) { @@ -2153,6 +2163,7 @@ int main(int argc, char** argv) case KARGOPTVAL+5: case KARGOPTVAL+6: case KARGOPTVAL+7: + case KARGOPTVAL+8: break; /* long options */

1 0

git:master:531e288b: evapi: use msg->ldv.vdata for local env data instead of hdr date workaround
by Daniel-Constantin Mierla 27 May '20

27 May '20

Module: kamailio Branch: master Commit: 531e288bc981de536023697e8181cc5589b4d14b URL: https://github.com/kamailio/kamailio/commit/531e288bc981de536023697e8181cc5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-27T09:21:24+02:00 evapi: use msg->ldv.vdata for local env data instead of hdr date workaround --- Modified: src/modules/evapi/evapi_dispatch.h --- Diff: https://github.com/kamailio/kamailio/commit/531e288bc981de536023697e8181cc5… Patch: https://github.com/kamailio/kamailio/commit/531e288bc981de536023697e8181cc5… --- diff --git a/src/modules/evapi/evapi_dispatch.h b/src/modules/evapi/evapi_dispatch.h index fa6135ae22..23b4c2565c 100644 --- a/src/modules/evapi/evapi_dispatch.h +++ b/src/modules/evapi/evapi_dispatch.h @@ -46,9 +46,9 @@ int pv_get_evapi(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); int pv_set_evapi(sip_msg_t *msg, pv_param_t *param, int op, pv_value_t *val); -/* set evapi env to shortcut of hdr date - not used in faked msg */ -#define evapi_set_msg_env(_msg, _evenv) do { _msg->date=(hdr_field_t*)_evenv; } while(0) -#define evapi_get_msg_env(_msg) ((evapi_env_t*)_msg->date) +/* set/get evapi env */ +#define evapi_set_msg_env(_msg, _evenv) do { _msg->ldv.vdata=(void*)_evenv; } while(0) +#define evapi_get_msg_env(_msg) ((evapi_env_t*)_msg->ldv.vdata) int evapi_cfg_close(sip_msg_t *msg); int evapi_set_tag(sip_msg_t* msg, str* stag);

1 0

git:master:5cb28a47: core: parser - added vdata void* field inside msg_ldata_t structure
by Daniel-Constantin Mierla 27 May '20

27 May '20

Module: kamailio Branch: master Commit: 5cb28a47cade4b3d20e37ed38c74e575f7343386 URL: https://github.com/kamailio/kamailio/commit/5cb28a47cade4b3d20e37ed38c74e57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-27T09:20:05+02:00 core: parser - added vdata void* field inside msg_ldata_t structure - useful to link to custom local data on message processing --- Modified: src/core/parser/msg_parser.h --- Diff: https://github.com/kamailio/kamailio/commit/5cb28a47cade4b3d20e37ed38c74e57… Patch: https://github.com/kamailio/kamailio/commit/5cb28a47cade4b3d20e37ed38c74e57… --- diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h index 973b5702b4..aa35fa5185 100644 --- a/src/core/parser/msg_parser.h +++ b/src/core/parser/msg_parser.h @@ -268,6 +268,7 @@ typedef struct ocd_flow { * - add to msg_ldata_reset() if a field uses dynamic memory */ typedef struct msg_ldata { ocd_flow_t flow; + void *vdata; } msg_ldata_t; /*! \brief The SIP message */

1 0

git:master:2a920bde: modules: readme files regenerated - corex ... [skip ci]
by Kamailio Dev 26 May '20

26 May '20

Module: kamailio Branch: master Commit: 2a920bde45b78d7f31942590ed76a3e7b509213e URL: https://github.com/kamailio/kamailio/commit/2a920bde45b78d7f31942590ed76a3e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-05-26T16:01:15+02:00 modules: readme files regenerated - corex ... [skip ci] --- Modified: src/modules/corex/README --- Diff: https://github.com/kamailio/kamailio/commit/2a920bde45b78d7f31942590ed76a3e… Patch: https://github.com/kamailio/kamailio/commit/2a920bde45b78d7f31942590ed76a3e…

1 0

git:master:35319cb5: corex: docs for dns_cache parameter
by Daniel-Constantin Mierla 26 May '20

26 May '20

Module: kamailio Branch: master Commit: 35319cb5c0cac7fd656d86e7419dbd3e497fcd92 URL: https://github.com/kamailio/kamailio/commit/35319cb5c0cac7fd656d86e7419dbd3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-26T15:59:01+02:00 corex: docs for dns_cache parameter --- Modified: src/modules/corex/doc/corex_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/35319cb5c0cac7fd656d86e7419dbd3… Patch: https://github.com/kamailio/kamailio/commit/35319cb5c0cac7fd656d86e7419dbd3… --- diff --git a/src/modules/corex/doc/corex_admin.xml b/src/modules/corex/doc/corex_admin.xml index f9572b54f0..203ada5d2f 100644 --- a/src/modules/corex/doc/corex_admin.xml +++ b/src/modules/corex/doc/corex_admin.xml @@ -93,6 +93,60 @@ modparam("corex", "alias_subdomains", "kamailio.org") modparam("corex", "alias_subdomains", "udp:sip-router.org:5060") ... +</programlisting> + </example> + </section> + <section id="corex.p.dns_cache"> + <title><varname>dns_cache</varname> (string)</title> + <para> + Add A or AAAA records to internal DNS cache at startup. It can be set + many times to add more than one record. + </para> + <para> + The format of the value follows the SIP params style: + "attr1=val1;attr2=val2;...". The attributes can be: + </para> + <itemizedlist> + <listitem> + <para> + <emphasis>type</emphasis> - it can be "A" (IPv4) or "AAAA" (IPv6) + </para> + </listitem> + <listitem> + <para> + <emphasis>name</emphasis> - the domain name + </para> + </listitem> + <listitem> + <para> + <emphasis>addr</emphasis> - the IP address + </para> + </listitem> + <listitem> + <para> + <emphasis>ttl</emphasis> - TTL value + </para> + </listitem> + <listitem> + <para> + <emphasis>flags</emphasis> - can be: 1 - the domain is unresolvable + (like blacklisted); 2 - the record is permanent (never times out, + never deleted, never overwritten) + </para> + </listitem> + </itemizedlist> + <para> + <emphasis> + Default value is <quote>NULL</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>dns_cache</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("corex", "dns_cache", "type=A;name=kamailio.org;addr=193.22.119.66;ttl=3600000;flags=0") +modparam("corex", "dns_cache", "type=AAAA;name=kamailio.org;addr=2a00:d60:0:400::2;ttl=3600000;flags=0") +... </programlisting> </example> </section>

1 0

git:master:12b8bf9a: corex: new param dns_cache to add values to internal dns cache
by Daniel-Constantin Mierla 26 May '20

26 May '20

Module: kamailio Branch: master Commit: 12b8bf9a9c6e84d9b1dadaa08195a9c56b24cbe4 URL: https://github.com/kamailio/kamailio/commit/12b8bf9a9c6e84d9b1dadaa08195a9c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-26T15:45:10+02:00 corex: new param dns_cache to add values to internal dns cache - it can be set many times - the value is a param-like string with the prototype "type=rectype;name=domain;addr=ip;ttl=ival;flags=ival" - type valye can be 'A' (IPv4) or 'AAAA' (IPv6) - flags can be: 1 - the domain is unresolvable (like blacklisted) 2 - the record is permanent (never times out, never deleted, never overwritten) --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/12b8bf9a9c6e84d9b1dadaa08195a9c… Patch: https://github.com/kamailio/kamailio/commit/12b8bf9a9c6e84d9b1dadaa08195a9c… --- diff --git a/src/modules/corex/corex_mod.c b/src/modules/corex/corex_mod.c index c0759e6ded..1f9abd497c 100644 --- a/src/modules/corex/corex_mod.c +++ b/src/modules/corex/corex_mod.c @@ -31,7 +31,9 @@ #include "../../core/pvar.h" #include "../../core/fmsg.h" #include "../../core/kemi.h" +#include "../../core/dns_cache.h" #include "../../core/parser/parse_uri.h" +#include "../../core/parser/parse_param.h" #include "corex_lib.h" #include "corex_rpc.h" @@ -67,6 +69,7 @@ static int w_is_faked_msg(sip_msg_t *msg, char *p1, char *p2); static int fixup_file_op(void** param, int param_no); int corex_alias_subdomains_param(modparam_t type, void *val); +int corex_dns_cache_param(modparam_t type, void *val); static int mod_init(void); static int child_init(int); @@ -141,6 +144,8 @@ static cmd_export_t cmds[]={ static param_export_t params[]={ {"alias_subdomains", STR_PARAM|USE_FUNC_PARAM, (void*)corex_alias_subdomains_param}, + {"dns_cache", PARAM_STR|USE_FUNC_PARAM, + (void*)corex_dns_cache_param}, {"nio_intercept", INT_PARAM, &nio_intercept}, {"nio_min_msg_len", INT_PARAM, &nio_min_msg_len}, {"nio_msg_avp", PARAM_STR, &nio_msg_avp_param}, @@ -304,9 +309,88 @@ int corex_alias_subdomains_param(modparam_t type, void *val) return corex_add_alias_subdomains((char*)val); error: return -1; +} + +int corex_dns_cache_param(modparam_t type, void *val) +{ + str sval; + param_t* params_list = NULL; + param_hooks_t phooks; + param_t *pit=NULL; + str dns_name = STR_NULL; + str dns_addr = STR_NULL; + unsigned short dns_type = 0; + int dns_ttl = 0; + int dns_flags = 0; + + if(val==NULL) { + LM_ERR("invalid parameter\n"); + goto error; + } + sval = *((str*)val); + if(sval.s==NULL || sval.len<=0) { + LM_ERR("invalid parameter value\n"); + goto error; + } + + if(sval.s[sval.len-1]==';') { + sval.len--; + } + if (parse_params(&sval, CLASS_ANY, &phooks, &params_list)<0) { + return -1; + } + + for (pit = params_list; pit; pit=pit->next) { + if (pit->name.len==4 + && strncasecmp(pit->name.s, "name", 4)==0) { + dns_name = pit->body; + } else if (pit->name.len==4 + && strncasecmp(pit->name.s, "addr", 4)==0) { + dns_addr = pit->body; + } else if (pit->name.len==4 + && strncasecmp(pit->name.s, "type", 4)==0) { + if((pit->body.len == 1) && ((pit->body.s[0]=='a') + || (pit->body.s[0]=='A'))) { + dns_type = T_A; + } else if((pit->body.len == 4) + && strncasecmp(pit->name.s, "aaaa", 4)==0) { + dns_type = T_AAAA; + } + } else if(pit->name.len==3 + && strncasecmp(pit->name.s, "ttl", 3)==0) { + if(dns_ttl==0) { + if (str2sint(&pit->body, &dns_ttl) < 0) { + LM_ERR("invalid ttl: %.*s\n", pit->body.len, pit->body.s); + return -1; + } + } + } else if(pit->name.len==5 + && strncasecmp(pit->name.s, "flags", 5)==0) { + if(dns_flags==0) { + if (str2sint(&pit->body, &dns_flags) < 0) { + LM_ERR("invalid flags: %.*s\n", pit->body.len, pit->body.s); + return -1; + } + } + } + } + + if (dns_cache_add_record(dns_type, + &dns_name, + dns_ttl, + &dns_addr, + 0 /* priority */, + 0 /* weight */, + 0 /* port */, + dns_flags) == 0) { + return 0; + } +error: + return -1; } + typedef struct _msg_iflag_name { str name; int value;

1 0

git:master:d2906da9: tls: better log messages when failing to create ssl ctx
by Daniel-Constantin Mierla 26 May '20

26 May '20

Module: kamailio Branch: master Commit: d2906da97d2429bfdff089203f933de2d282a86d URL: https://github.com/kamailio/kamailio/commit/d2906da97d2429bfdff089203f933de… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-26T15:05:15+02:00 tls: better log messages when failing to create ssl ctx --- Modified: src/modules/tls/tls_domain.c --- Diff: https://github.com/kamailio/kamailio/commit/d2906da97d2429bfdff089203f933de… Patch: https://github.com/kamailio/kamailio/commit/d2906da97d2429bfdff089203f933de… --- diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c index 3932141f0e..a8859c4a31 100644 --- a/src/modules/tls/tls_domain.c +++ b/src/modules/tls/tls_domain.c @@ -1036,7 +1036,11 @@ static int ksr_tls_fix_domain(tls_domain_t* d, tls_domain_t* def) d->ctx[i] = SSL_CTX_new((SSL_METHOD*)ssl_methods[d->method - 1]); } if (d->ctx[i] == NULL) { - ERR("%s: Cannot create SSL context\n", tls_domain_str(d)); + unsigned long e = 0; + e = ERR_peek_last_error(); + ERR("%s: Cannot create SSL context [%d] (%lu: %s / %s)\n", + tls_domain_str(d), i, e, ERR_error_string(e, NULL), + ERR_reason_error_string(e)); return -1; } if(d->method>TLS_USE_TLSvRANGE) { @@ -1046,7 +1050,11 @@ static int ksr_tls_fix_domain(tls_domain_t* d, tls_domain_t* def) /* libssl >= 1.1.0 */ d->ctx[i] = SSL_CTX_new(sr_tls_methods[d->method - 1].TLSMethod); if (d->ctx[i] == NULL) { - ERR("%s: Cannot create SSL context\n", tls_domain_str(d)); + unsigned long e = 0; + e = ERR_peek_last_error(); + ERR("%s: Cannot create SSL context [%d] (%lu: %s / %s)\n", + tls_domain_str(d), i, e, ERR_error_string(e, NULL), + ERR_reason_error_string(e)); return -1; } if(d->method>TLS_USE_TLSvRANGE) {

1 0

git:master:3e7278f2: tls: Makefile - option to link against libssl static libs
by Daniel-Constantin Mierla 26 May '20

26 May '20

Module: kamailio Branch: master Commit: 3e7278f28c43b830a197e2f7b212ec6f06e5acbf URL: https://github.com/kamailio/kamailio/commit/3e7278f28c43b830a197e2f7b212ec6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-26T14:56:47+02:00 tls: Makefile - option to link against libssl static libs --- Modified: src/modules/tls/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/3e7278f28c43b830a197e2f7b212ec6… Patch: https://github.com/kamailio/kamailio/commit/3e7278f28c43b830a197e2f7b212ec6… --- diff --git a/src/modules/tls/Makefile b/src/modules/tls/Makefile index 1505bc64ea..f3c15bb724 100644 --- a/src/modules/tls/Makefile +++ b/src/modules/tls/Makefile @@ -8,6 +8,13 @@ include ../../Makefile.defs auto_gen= NAME=tls.so +# set to yes when wanting to link with static libraries +LIBSSL_STATIC ?= no +# set to yes when wanting to link with static libraries compiled from source +LIBSSL_STATIC_SRCLIB ?= no +# set to the path of the folder with static libraries compiled from source +LIBSSL_STATIC_SRCPATH ?= /usr/local/src/openssl + ifeq ($(CROSS_COMPILE),) SSL_BUILDER=$(shell \ if pkg-config --exists libssl; then \ @@ -16,8 +23,21 @@ SSL_BUILDER=$(shell \ endif ifneq ($(SSL_BUILDER),) +ifneq ($(LIBSSL_STATIC),yes) DEFS += $(shell $(SSL_BUILDER) --cflags) LIBS += $(shell $(SSL_BUILDER) --libs) +else +ifneq ($(LIBSSL_STATIC_SRCLIB),yes) + ## when static libs (*.a) from packages are compiled with -fPIC + DEFS += $(shell $(SSL_BUILDER) --cflags) + LIBS += $(shell $(SSL_BUILDER) --libs-only-L) + LIBS += -l:libssl.a -l:libcrypto.a -l:libz.a -l:libdl.a +else + ## when linking against static libs compiled from sources + DEFS += -I$(LIBSSL_STATIC_SRCPATH)/include + LIBS += $(LIBSSL_STATIC_SRCPATH)/libssl.a $(LIBSSL_STATIC_SRCPATH)/libcrypto.a +endif # ifneq ($(LIBSSL_STATIC_SRCLIB),yes) +endif # ifneq ($(LIBSSL_STATIC),yes) else DEFS += -I$(LOCALBASE)/ssl/include LIBS += -L$(LOCALBASE)/lib -L$(LOCALBASE)/ssl/lib \

1 0

git:master:8893e6f2: core: async task logging on no callback
by Daniel-Constantin Mierla 26 May '20

26 May '20

Module: kamailio Branch: master Commit: 8893e6f2b30577b065f11a406faf5c5935714f78 URL: https://github.com/kamailio/kamailio/commit/8893e6f2b30577b065f11a406faf5c5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-26T09:24:17+02:00 core: async task logging on no callback --- Modified: src/core/async_task.c --- Diff: https://github.com/kamailio/kamailio/commit/8893e6f2b30577b065f11a406faf5c5… Patch: https://github.com/kamailio/kamailio/commit/8893e6f2b30577b065f11a406faf5c5… --- diff --git a/src/core/async_task.c b/src/core/async_task.c index ee50412790..1045e0ab41 100644 --- a/src/core/async_task.c +++ b/src/core/async_task.c @@ -280,6 +280,8 @@ int async_task_run(int idx) LM_DBG("task executed [%p] (%p/%p)\n", (void*)ptask, (void*)ptask->exec, (void*)ptask->param); ptask->exec(ptask->param); + } else { + LM_DBG("task with no callback function - ignoring\n"); } shm_free(ptask); }

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2020