sr-dev May 2020

sr-dev@lists.kamailio.org

24 participants
393 discussions

[kamailio/kamailio] core: do not return connection if port does not match (#2307)

by Donato Sciarra

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description If kamailio is behind a NAT only return connection if port matches. We observed this issue on an instance after ~10h of operation. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2307 -- Commit Summary -- * core: do not return connection if port does not match -- File Changes -- M src/core/tcp_main.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2307.patch https://github.com/kamailio/kamailio/pull/2307.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2307

4 years, 6 months

[kamailio/kamailio] 180 Ringing without Contact with TOPOS enabled (#1720)

by Sergey Basov

### Description Kamailio with TOPOS enabled acts as a proxy between SIP client and SBC. When client sends "180 Ringing" without Contact header - kamailio does not forward it to SBC. If Contact header exists in "180 Ringing" - all works as expected. ### Troubleshooting #### Reproduction Load and configure topos module Make call with "180 Ringing" without Contact header - kamailio will not forward it. #### Log Messages ``` ERROR: topos [tps_storage.c:340]: tps_storage_link_msg(): bad sip message or missing Contact hdr ``` #### SIP Traffic ``` SIP/2.0 180 Ringing Via: SIP/2.0/TLS 1.2.3.4:5061;branch=z9hG4bKef45.8c75f0bae8a59dfaec6ff533ff0f3b2d.0 From: <sip:1111@1.2.3.4:5061>;tag=02000879948559 To: <sip:2.2.2.2@5.6.7.8:5061;transport=tls;user=phone>;tag=SDbsq8499-y2pMOVV Call-ID: apdW7374315131g0bcGhEfDjFof CSeq: 988207425 INVITE User-Agent: agent Supported: replaces, outbound Content-Length: 0 ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select ``` * **Operating System**: ``` Red Hat Enterprise Linux Server 7.3 3.10.0-514.el7.x86_64 #1 SMP Wed Oct 19 11:24:13 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1720

4 years, 6 months

[kamailio/kamailio] core: PV_IDX_NONE to point that pv had no index (#2341)

by Victor Seva

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally #### Description  if index is 0 there were no way to know if the index was there $x_hdr(A) = "value" needs to append a value $(x_hdr(A)[0]) = "value" needs to set the value pv_parse_spec(str *s, pv_spec_p p) was always setting p->pvp.pvi.type to 0 == PV_IDX_INT You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2341 -- Commit Summary -- * core: PV_IDX_NONE to point that pv had no index -- File Changes -- M src/core/pvapi.c (7) M src/core/pvar.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2341.patch https://github.com/kamailio/kamailio/pull/2341.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2341

4 years, 6 months

[kamailio/kamailio] warning cleanup (#2298)

by sergey-safarov

**ld_fld.c:273** implicit-function-declaration ``` CC (gcc) [M db2_ldap.so] db2_ldap_mod.o CC (gcc) [M db2_ldap.so] ld_cfg.o CC (gcc) [M db2_ldap.so] ld_cmd.o CC (gcc) [M db2_ldap.so] ld_con.o CC (gcc) [M db2_ldap.so] ld_fld.o ld_fld.c: In function 'ldap_gentime2db_datetime': ld_fld.c:273:10: warning: implicit declaration of function 'timelocal' [-Wimplicit-function-declaration] 273 | *dst = timelocal(&time); | ^~~~~~~~~ CC (gcc) [M db2_ldap.so] ld_res.o CC (gcc) [M db2_ldap.so] ld_uri.o make[3]: 'libsrdb2.so.1.0' is up to date. ``` **redis_table.c:586** maybe-uninitialized ``` CC (gcc) [M db_redis.so] db_redis_mod.o CC (gcc) [M db_redis.so] redis_connection.o CC (gcc) [M db_redis.so] redis_dbase.o CC (gcc) [M db_redis.so] redis_table.o redis_table.c: In function 'db_redis_parse_keys': redis_table.c:586:38: warning: 'table' may be used uninitialized in this function [-Wmaybe-uninitialized] 586 | table->types = type_target = type; | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ make[3]: 'libsrdb2.so.1.0' is up to date. make[3]: 'libsrdb1.so.1.0' is up to date. LD (gcc) [M db_redis.so] db_redis.so ``` **app_python** strict-aliasing ``` CC (gcc) [M app_python.so] app_python_mod.o CC (gcc) [M app_python.so] apy_kemi.o In file included from /usr/include/python2.7/Python.h:83, from apy_kemi.c:25: apy_kemi.c: In function 'sr_kemi_apy_return_true': /usr/include/python2.7/object.h:769:6: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] 769 | ((PyObject*)(op))->ob_refcnt++) | ~^~~~~~~~~~~~~~~~ apy_kemi.c:121:2: note: in expansion of macro 'Py_INCREF' 121 | Py_INCREF(Py_True); | ^~~~~~~~~ apy_kemi.c: In function 'sr_kemi_apy_return_false': /usr/include/python2.7/object.h:769:6: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] 769 | ((PyObject*)(op))->ob_refcnt++) | ~^~~~~~~~~~~~~~~~ apy_kemi.c:130:2: note: in expansion of macro 'Py_INCREF' 130 | Py_INCREF(Py_False); | ^~~~~~~~~ CC (gcc) [M app_python.so] apy_kemi_export.o CC (gcc) [M app_python.so] mod_Core.o ``` **pdb.c:348** address-of-packed-member] ``` LD (gcc) [M p_usrloc.so] p_usrloc.so CC (gcc) [M path.so] path.o CC (gcc) [M path.so] path_mod.o LD (gcc) [M path.so] path.so CC (gcc) [M pdb.so] pdb.o pdb.c: In function 'pdb_query': pdb.c:348:60: warning: taking address of packed member of 'struct pdb_msg' may result in an unaligned pointer value [-Waddress-of-packed-member] 348 | _id = (short int *)&(msg.bdy.payload[reqlen]); /* make gcc happy */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ LD (gcc) [M pdb.so] pdb.so CC (gcc) [M pdt.so] pdt.o CC (gcc) [M pdt.so] pdtree.o make[3]: 'libsrdb1.so.1.0' is up to date. ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2298

4 years, 6 months

[kamailio/kamailio] Play media when Kamailio+rtpengine are as an end point(not proxy) (#2315)

by bshirazi

### Description  With rtpengine module play_media function it is possible to play media to one of the endpoints(Kamailio is normal proxy) but I like to use Kamailio+rtpengine as an end point playing music for caller(simple media server). ### Expected behavior Possible to use Kamailio+rtpengine as an end point playing media. ### Possible Solutions I see some efforts in mailing list trying to build/generate a 183 response inside script to simulate a dummy end point and then use rtpengine_play_media function.  Regards. Babak -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2315

4 years, 6 months

git:master:6fe4a35e: modules: readme files regenerated - pv ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 6fe4a35e977adf4195dfedf8db5efc02291180b3 URL: https://github.com/kamailio/kamailio/commit/6fe4a35e977adf4195dfedf8db5efc0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-05-29T23:46:12+02:00 modules: readme files regenerated - pv ... [skip ci] --- Modified: src/modules/pv/README --- Diff: https://github.com/kamailio/kamailio/commit/6fe4a35e977adf4195dfedf8db5efc0… Patch: https://github.com/kamailio/kamailio/commit/6fe4a35e977adf4195dfedf8db5efc0…

4 years, 6 months

[kamailio/kamailio] $xavi(...) (#2337)

by Victor Seva

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally #### Description This change introduces a new type of variable $xavi - eXtended Attribute Value Insensitive case. It's like a $xavp but keys are case insensitive: ``` $xavi(WhatEver=>fOo) = 1; if($xavi(whatever[0]=>foo) == 1) { .... } ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2337 -- Commit Summary -- * core: xavi api - like xavp but with insensitive case names * core: pv - define xavi types * core: receive - reset xavi list after message processing * tm: process xavi list in transaction contexts * pv: $xavi(...) config variables implementation -- File Changes -- M src/core/pvar.h (4) M src/core/receive.c (1) M src/core/xavp.c (987) M src/core/xavp.h (43) M src/modules/pv/pv.c (539) M src/modules/pv/pv_xavp.c (416) M src/modules/pv/pv_xavp.h (7) M src/modules/tm/h_table.c (12) M src/modules/tm/h_table.h (3) M src/modules/tm/t_hooks.c (6) M src/modules/tm/t_reply.c (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2337.patch https://github.com/kamailio/kamailio/pull/2337.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2337

4 years, 6 months

git:master:d61be421: pv: add documentation of xavi related functions [skip ci]

by Victor Seva

Module: kamailio Branch: master Commit: d61be4214850f5dd58a9a38ea19484e452745e86 URL: https://github.com/kamailio/kamailio/commit/d61be4214850f5dd58a9a38ea19484e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-05-29T23:31:55+02:00 pv: add documentation of xavi related functions [skip ci] --- Modified: src/modules/pv/doc/pv_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d61be4214850f5dd58a9a38ea19484e… Patch: https://github.com/kamailio/kamailio/commit/d61be4214850f5dd58a9a38ea19484e…

4 years, 6 months

git:master:bd013b47: pv: $xavi(...) config variables implementation

by Victor Seva

Module: kamailio Branch: master Commit: bd013b471ced4ed67428690354bf5e68826daaf4 URL: https://github.com/kamailio/kamailio/commit/bd013b471ced4ed67428690354bf5e6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-05-29T23:31:55+02:00 pv: $xavi(...) config variables implementation same as $xavp but case insensitive for keys --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_xavp.c Modified: src/modules/pv/pv_xavp.h --- Diff: https://github.com/kamailio/kamailio/commit/bd013b471ced4ed67428690354bf5e6… Patch: https://github.com/kamailio/kamailio/commit/bd013b471ced4ed67428690354bf5e6…

4 years, 6 months

git:master:dc468c6f: tm: process xavi list in transaction contexts

by Victor Seva

Module: kamailio Branch: master Commit: dc468c6f694471d981d69372bbd0989e7b1cd04f URL: https://github.com/kamailio/kamailio/commit/dc468c6f694471d981d69372bbd0989… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-05-29T23:31:55+02:00 tm: process xavi list in transaction contexts --- Modified: src/modules/tm/h_table.c Modified: src/modules/tm/h_table.h Modified: src/modules/tm/t_hooks.c Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/dc468c6f694471d981d69372bbd0989… Patch: https://github.com/kamailio/kamailio/commit/dc468c6f694471d981d69372bbd0989…

4 years, 6 months

← Newer
1
...
7
8
9
10
11
12
13
...
40
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2020