sr-dev May 2020

sr-dev@lists.kamailio.org

24 participants
393 discussions

[kamailio/kamailio] Kamailio dispatcher module reports incorrect values with Call-Load based dispatching algorithm(No.10) (#2322)
by hbilling 25 May '20

25 May '20

### Description While running a simple load with a UAC(Sipp) and two UAS(Both Sipp) , with Kamailio in the middle, acting as a Call Stateful Proxy, I observed that the Dispatcher Module reports one call stuck despite NO calls being reported as Active in the Dialog Module. Setup: ------- |------> UAS1(sipp) UAC(sipp) ----------------------Kamailio(Call Stateful Proxy)------------ |------> UAS2(sipp) Scenario: The scenario is simple INVITE----- 200OK------ACK , with BYE being sent after 60 secs by UAC. ### Troubleshooting Point noteworthy is that this is purely timing issue and happens generally with very long duration, like 24 hours or so, but can crop up withing a few hours also. #### Reproduction Just run the calls via sipp as described in the setup. #### Debugging Data **OUTPUT after cleanly stopping the test:** > Output of "kamctl stats dialog" command { "jsonrpc": "2.0", "result": [ "dialog:active_dialogs = 0", "dialog:early_dialogs = 0", "dialog:expired_dialogs = 0", "dialog:failed_dialogs = 959", "dialog:processed_dialogs = 1695662" ], "id": 21282 } > Output of "kamcmd dispatcher.list" { NRSETS: 1 RECORDS: { SET: { ID: 1 TARGETS: { DEST: { URI: sip:10.214.3.20:5060;transport=udp FLAGS: AP PRIORITY: 0 ATTRS: { BODY: duid=sample-cas-1;maxload=1000 DUID: sample-cas-1 MAXLOAD: 1000 WEIGHT: 0 RWEIGHT: 0 SOCKET: } LATENCY: { AVG: 2.409000 STD: 108.999000 EST: 1.124000 MAX: 9503 TIMEOUT: 22 } RUNTIME: { DLGLOAD: 997 } } DEST: { URI: sip:10.214.3.19:5060;transport=udp FLAGS: AP PRIORITY: 0 ATTRS: { BODY: duid=sample-cas-0;maxload=1000 DUID: sample-cas-0 MAXLOAD: 1000 WEIGHT: 0 RWEIGHT: 0 SOCKET: } LATENCY: { AVG: 1.429000 STD: 40.279000 EST: 0.999000 MAX: 3502 TIMEOUT: 22 } RUNTIME: { DLGLOAD: 985 } } } } } } NOTE: Please see that the dispatcher shows a lot of calls stuck after overnight load, and there by we started seeing 404's sent back by Kamailio dispatcher module for most of the calls. It is noteworthy that we have kept a close tab on the tests thereafter and caught an iteration where initially only call is stuck. ### Possible Solutions The problem most likely seems to be in the dispatcher module, which does not seem to be incrementing/decrementing the load variable for each UAS( 'dload' variable to be precise), due to which the concurrent incrementing/decrementing of the 'dload' parameter makes the dispatcher report spurious values. FIX: The following needs to be done. 1. File: **dispatch.c** Function: **ds_load_add()** Just before dset->dlist[dst].dload++; line, we must take a lock and release it thereafter. Like: **lock_get(&dset->lock)**; dset->dlist[dst].dload++; **lock_release(&dset->lock);** 2: File: **dispatch.c** Function: **ds_load_replace()** , the code needs a lock as well while decrementing. Like: **lock_get(&idx->lock);** if(idx->dlist[olddst].dload > 0) { idx->dlist[olddst].dload--; **lock_release(&idx->lock);** ...... } else { **lock_release(&idx->lock);** ...... } 3. File: **dispatch.c** Function: **ds_load_remove_byid** , the code needs a lock as well while decrementing. Like: **lock_get(&idx->lock);** if(idx->dlist[olddst].dload > 0) { idx->dlist[olddst].dload--; **lock_release(&idx->lock);** ........... } else { **lock_release(&idx->lock);** ........ } NOTE: I believe the lock should be taken also for the the API "ds_get_leastloaded()" in dispatch.c because otherwise, we may get select incorrect destination, especially when we are at just about the same load and that is almost close to the 'maxload' value configured in the dispatcher list file. But I will wait for the community comments for this. The above fix solved my issue, so please review the same and if you deem suitable, I could go ahead with the fix delivery. ### Additional Information Kamailio Version: [root@CPaaSVM ~]# kamailio -v version: kamailio 5.3.2 (x86_64/linux) 7ba545 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 7ba545 compiled on 19:01:39 May 1 2020 with gcc 4.8.5 NOTE: I do not think this is version specific and probably that it exists in the later versions also. * **Operating System**: Centos 7.7 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2322

4 10

git:5.3:5be2234d: pkg/kamailio/obs: packaged xhttp_prom (prometheus)
by Sergey Safarov 23 May '20

23 May '20

Module: kamailio Branch: 5.3 Commit: 5be2234db7992309d128e6b999771fb298c01fd5 URL: https://github.com/kamailio/kamailio/commit/5be2234db7992309d128e6b999771fb… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-05-23T23:16:07+03:00 pkg/kamailio/obs: packaged xhttp_prom (prometheus) (cherry picked from commit 3e77c574c340941f36ca8f9081a77c5b476f8c8c) --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/5be2234db7992309d128e6b999771fb… Patch: https://github.com/kamailio/kamailio/commit/5be2234db7992309d128e6b999771fb… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index aa5269e62c..175cfa2249 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1149,6 +1149,7 @@ make every-module skip_modules="app_mono db_cassandra db_oracle iptrtpproxy \ %if %{with http_async_client} khttp_async \ %endif + kxhttp_prom \ %if %{with ims} kims \ %endif @@ -1236,6 +1237,7 @@ make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ %if %{with http_async_client} khttp_async \ %endif + kxhttp_prom \ %if %{with ims} kims \ %endif

1 0

git:master:3e77c574: pkg/kamailio/obs: packaged xhttp_prom (prometheus)
by Sergey Safarov 23 May '20

23 May '20

Module: kamailio Branch: master Commit: 3e77c574c340941f36ca8f9081a77c5b476f8c8c URL: https://github.com/kamailio/kamailio/commit/3e77c574c340941f36ca8f9081a77c5… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-05-23T22:43:33+03:00 pkg/kamailio/obs: packaged xhttp_prom (prometheus) --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/3e77c574c340941f36ca8f9081a77c5… Patch: https://github.com/kamailio/kamailio/commit/3e77c574c340941f36ca8f9081a77c5… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 3c68a9a002..1eb7db7c30 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1153,6 +1153,7 @@ make every-module skip_modules="app_mono db_cassandra db_oracle iptrtpproxy \ %if %{with http_async_client} khttp_async \ %endif + kxhttp_prom \ %if %{with ims} kims \ %endif @@ -1244,6 +1245,7 @@ make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ %if %{with http_async_client} khttp_async \ %endif + kxhttp_prom \ %if %{with ims} kims \ %endif

1 0

[kamailio/kamailio] kamdbctl create Issue (#2328)
by rodrigocuadra 23 May '20

23 May '20

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` [root@localhost ~]# kamailio -version version: kamailio 5.3.4 (x86_64/linux) 117ff9 ``` * **Operating System**:  ``` MySQL password for root: INFO: test server charset INFO: creating database kamailio ... INFO: granting privileges to database kamailio ... INFO: creating standard tables into kamailio ... INFO: Core Kamailio tables succesfully created. Install presence related tables? (y/n): y INFO: creating presence tables into kamailio ... INFO: Presence tables succesfully created. Install tables for imc cpl siptrace domainpolicy carrierroute drouting userblacklist htable purple uac pipelimit mtree sca mohqueue rtpproxy rtpengine secfilter? (y/n): y INFO: creating extra tables into kamailio ... ERROR 1067 (42000) at line 1: Invalid default value for 'action' ERROR: Creating extra tables failed at secfilter! ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2328

3 4

git:master:77996f4b: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 22 May '20

22 May '20

Module: kamailio Branch: master Commit: 77996f4b8808f4950325e14861b6ac82c09a5eff URL: https://github.com/kamailio/kamailio/commit/77996f4b8808f4950325e14861b6ac8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-05-22T21:46:13+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/77996f4b8808f4950325e14861b6ac8… Patch: https://github.com/kamailio/kamailio/commit/77996f4b8808f4950325e14861b6ac8…

1 0

[kamailio/kamailio] Allow more options on dispatcher.set_state (#2085)
by duarterocha91 22 May '20

22 May '20

Greetings, Dispatcher RPC command allows to change the runtime state of a GW using its Group ID and the IP. In my implementation i have 2 Kamailio machines in an HA setup and, as such, i have the GW configured twice with same group_id and different sockets (Different HA adressess - one for each machine). I would like to be able to disable on runtime GWs that are configured with an HA adress that isn't present yet on that machine. To be able do that, the combination of GroupID + IP is not enough, but Socket + IP would be enough. Is this possible to implement ? Best Regards -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2085

2 2

git:master:e97ce9f9: dispatcher: docs for dispatcher.set_duid_state command
by Daniel-Constantin Mierla 22 May '20

22 May '20

Module: kamailio Branch: master Commit: e97ce9f952f8f867ae5718df1dd940e0fca33f3e URL: https://github.com/kamailio/kamailio/commit/e97ce9f952f8f867ae5718df1dd940e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-22T21:32:59+02:00 dispatcher: docs for dispatcher.set_duid_state command --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/e97ce9f952f8f867ae5718df1dd940e… Patch: https://github.com/kamailio/kamailio/commit/e97ce9f952f8f867ae5718df1dd940e… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 42dc66bb4a..c38988580c 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -1806,6 +1806,28 @@ onreply_route { &sercmd; dispatcher.set_state ip 2 sip:127.0.0.1:5080 &sercmd; dispatcher.set_state ip 3 all ... +</programlisting> + </section> + <section> + <section id="dispatcher.r.set_duid_state"> + <title> + <function moreinfo="none">dispatcher.set_duid_state</function> + </title> + <para> + Sets the state for a destination by matching on 'duid' attribute. The + parameters first two parameter 'state' and 'group' are the same like + for RPC command 'dispatcher.set_state'. The third parameter 'duid' is + the value to be matched against the 'duid' attribute of dispatcher + destinations. + </para> + <para> + Example: + </para> +<programlisting format="linespecific"> +... +# prototype: &sercmd; dispatcher.set_duid_state _state_ _group_ _duid_ +&sercmd; dispatcher.set_duid_state ip 2 xyz +... </programlisting> </section> <section id="dispatcher.r.list">

1 0

git:master:b7b0f258: dispatcher: new rpc command dispatcher.set_duid_state
by Daniel-Constantin Mierla 22 May '20

22 May '20

Module: kamailio Branch: master Commit: b7b0f25871fd99667db5f426cb7373deba7561ae URL: https://github.com/kamailio/kamailio/commit/b7b0f25871fd99667db5f426cb7373d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-22T21:25:48+02:00 dispatcher: new rpc command dispatcher.set_duid_state - set the state of a destination by matching on duid attribute kamctl rpc dispatcher.set_duid_state <state> <setid> <duid> - example: kamctl rpc dispatcher.set_duid_state i 1 xyz - GH #2085 --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/b7b0f25871fd99667db5f426cb7373d… Patch: https://github.com/kamailio/kamailio/commit/b7b0f25871fd99667db5f426cb7373d…

1 0

git:5.3:be32a089: rtpmanage: enable hadling of PRACK requests
by Daniel-Constantin Mierla 22 May '20

22 May '20

Module: kamailio Branch: 5.3 Commit: be32a0896187b385cb9f708abaf72089e5c35adb URL: https://github.com/kamailio/kamailio/commit/be32a0896187b385cb9f708abaf7208… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-22T09:10:22+02:00 rtpmanage: enable hadling of PRACK requests - they can have SDP - use more compact bitwise match for method types (cherry picked from commit de77beffb436e783031a6aa71c1887848cb2cc73) --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/be32a0896187b385cb9f708abaf7208… Patch: https://github.com/kamailio/kamailio/commit/be32a0896187b385cb9f708abaf7208… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 8f3c28a673..8b72e5b675 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3603,11 +3603,11 @@ rtpengine_manage(struct sip_msg *msg, const char *flags) method = get_cseq(msg)->method_id; - if (!(method==METHOD_INVITE || method==METHOD_ACK || method==METHOD_CANCEL - || method==METHOD_BYE || method==METHOD_UPDATE)) + if (!(method & (METHOD_INVITE|METHOD_ACK|METHOD_CANCEL|METHOD_BYE + |METHOD_UPDATE|METHOD_PRACK))) return -1; - if (method==METHOD_CANCEL || method==METHOD_BYE) + if (method & (METHOD_CANCEL|METHOD_BYE)) return rtpengine_delete(msg, flags); if (msg->msg_flags & FL_SDP_BODY) @@ -3616,7 +3616,7 @@ rtpengine_manage(struct sip_msg *msg, const char *flags) nosdp = parse_sdp(msg); if (msg->first_line.type == SIP_REQUEST) { - if(method==METHOD_ACK && nosdp==0) + if((method & (METHOD_ACK|METHOD_PRACK)) && nosdp==0) return rtpengine_offer_answer(msg, flags, OP_ANSWER, 0); if(method==METHOD_UPDATE && nosdp==0) return rtpengine_offer_answer(msg, flags, OP_OFFER, 0); @@ -3684,7 +3684,8 @@ rtpengine_answer1_f(struct sip_msg *msg, char *str1, char *str2) { if (msg->first_line.type == SIP_REQUEST) - if (msg->first_line.u.request.method_value != METHOD_ACK) + if (!(msg->first_line.u.request.method_value + & (METHOD_ACK | METHOD_PRACK))) return -1; return rtpengine_rtpp_set_wrap_fparam(msg, rtpengine_answer_wrap, str1, 2, OP_ANSWER);

1 0

[kamailio/kamailio] Kazoo: added basic kemi support (#2324)
by tao-communications 21 May '20

21 May '20

#### Pre-Submission Checklist    - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [*] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [*] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Added kemi support for Parameter: - event_callback Functions: - kazoo_subscribe(json_description) - kazoo_publish Documentation: - added section for event_callback parameter You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2324 -- Commit Summary -- * kazoo: added kemi support for kazoo_subscribe(json_description) and kazoo_publish * kazoo: added event_callback parameter in documentation * kazoo: added event_callback parameter in documentation * Merge branch 'master' of https://github.com/tao-communications/kamailio -- File Changes -- M src/modules/kazoo/doc/kazoo_admin.xml (22) M src/modules/kazoo/kazoo.c (105) M src/modules/kazoo/kz_amqp.c (100) M src/modules/kazoo/kz_amqp.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2324.patch https://github.com/kamailio/kamailio/pull/2324.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2324

3 25

← Newer
1
...
12
13
14
15
16
17
18
...
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2020