sr-dev September 2019

sr-dev@lists.kamailio.org

24 participants
368 discussions

[kamailio/kamailio] Phonenum module not working when invoked from other than cfg file (#2052)

by balajeesv

### Description I have kamailio.cfg file for configuration and Lua files for processing messages. What I observed is PHONUM module is not initialized during startup. And when using phonenum module it fails. I am invoking phonenum module in lua with "KSR.phonenum.match". This is in continuation to issue [1883](https://github.com/kamailio/kamailio/issues/1883), which i cannot reopen.Please check this and let me know any further logs required.  ### Troubleshooting #### Reproduction 1. cfg file only have configuration 2. Invoke phonemun module through KEMI "KSR.phonenum.match" in other file 3. Test to validate phonenum  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` Aug 29 08:33:27 ip-10-130-74-105 /usr/local/sbin/kamailio[2157]: DEBUG: app_lua [app_lua_sr.c:1655]: sr_kemi_lua_exec_func_ex(): param[0] for: isflagset is int: 1 Aug 29 08:33:27 ip-10-130-74-105 /usr/local/sbin/kamailio[2157]: DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[0] for: match is str: +919876543210 Aug 29 08:33:27 ip-10-130-74-105 /usr/local/sbin/kamailio[2157]: DEBUG: app_lua [app_lua_sr.c:1651]: sr_kemi_lua_exec_func_ex(): param[1] for: match is str: src Aug 29 08:33:27 ip-10-130-74-105 /usr/local/sbin/kamailio[2157]: DEBUG: phonenum [phonenum_pv.c:312]: phonenum_update_pv(): container not found: +919876543210 Aug 29 08:33:27 ip-10-130-74-105 /usr/local/sbin/kamailio[2157]: DEBUG: app_lua [app_lua_sr.c:934]: lua_sr_pv_get_val(): pv get: $rc Aug 29 08:33:27 ip-10-130-74-105 /usr/local/sbin/kamailio[2157]: DEBUG: [core/pvapi.c:371]: pv_cache_add(): pvar [$rc] added in cache Aug 29 08:33:27 ip-10-130-74-105 /usr/local/sbin/kamailio[2157]: DEBUG: app_lua [app_lua_sr.c:934]: lua_sr_pv_get_val(): pv get: $phn(src=>valid) Aug 29 08:33:27 ip-10-130-74-105 /usr/local/sbin/kamailio[2157]: DEBUG: phonenum [phonenum_pv.c:162]: pv_parse_phonenum_name(): phonenum [src] - key [valid] ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions In kamailio.cfg if I add some dummy route(as below) then Phonenum module is initialized and it is working as expected. route[PHONENUM] { if($phn(src=>valid)==1) { xlog("dummy route\n"); } }  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2052

4 years, 8 months

git:master:ac0a0d6f: pkg/kamailio/deb: version set 5.3.0~dev8 [skip ci]

by Victor Seva

Module: kamailio Branch: master Commit: ac0a0d6feebe738830efaa7bdcfae8ca7f41070d URL: https://github.com/kamailio/kamailio/commit/ac0a0d6feebe738830efaa7bdcfae8c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-09-05T08:46:10+02:00 pkg/kamailio/deb: version set 5.3.0~dev8 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/ac0a0d6feebe738830efaa7bdcfae8c… Patch: https://github.com/kamailio/kamailio/commit/ac0a0d6feebe738830efaa7bdcfae8c…

4 years, 8 months

git:master:101e7985: Makefile.defs: version set to 5.3.0-pre0

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 101e798573a0a971f1d0f07512cb6267186f1f23 URL: https://github.com/kamailio/kamailio/commit/101e798573a0a971f1d0f07512cb626… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-05T07:03:27+02:00 Makefile.defs: version set to 5.3.0-pre0 - start of pre-release phase (testing) for v5.3.x --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/101e798573a0a971f1d0f07512cb626… Patch: https://github.com/kamailio/kamailio/commit/101e798573a0a971f1d0f07512cb626… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 7cebfd53de..69416e8003 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 3 SUBLEVEL = 0 -EXTRAVERSION = -dev8 +EXTRAVERSION = -pre0 # memory manager switcher # 0 - f_malloc (fast malloc)

4 years, 8 months

git:master:303e07d6: Makefile.defs: version set to 5.3.0-dev8

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 303e07d66198fa3891b69fdcf3c71d68805c1558 URL: https://github.com/kamailio/kamailio/commit/303e07d66198fa3891b69fdcf3c71d6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-05T07:02:39+02:00 Makefile.defs: version set to 5.3.0-dev8 - end of development for v5.3.x --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/303e07d66198fa3891b69fdcf3c71d6… Patch: https://github.com/kamailio/kamailio/commit/303e07d66198fa3891b69fdcf3c71d6… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 62d8024c0d..7cebfd53de 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 3 SUBLEVEL = 0 -EXTRAVERSION = -dev7 +EXTRAVERSION = -dev8 # memory manager switcher # 0 - f_malloc (fast malloc)

4 years, 8 months

[kamailio/kamailio] jsonrpcs: fix double free crash (#1839)

by Federico Cabiddu

#### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description srjson_DeleteDoc(ctx->jreq) is already called in jsonrpc_clean_context(ctx). Calling it twice causes a crash due to a double free attempt. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1839 -- Commit Summary -- * jsonrpcs: fix double free crash -- File Changes -- M src/modules/jsonrpcs/jsonrpcs_mod.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1839.patch https://github.com/kamailio/kamailio/pull/1839.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1839

4 years, 8 months

Planning the next major release - v5.3.0

by Daniel-Constantin Mierla

Hello, it's about the time to set the milestones to the next major release - v5.3.0. There are 6 new modules and many other enhancements to existing components in git master branch, also during the last irc devel meeting it was proposed to freeze after summer holidays. At this moment I would propose Wednesday, September 4, 2019 to freeze the development. Then the release should be about one month later, after testing interval. In case there are people willing a bit more time for development, we can freeze one week later, September 11, or another date -- your suggestions here. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

4 years, 8 months

git:master:f828ad87: modules: readme files regenerated - nathelper ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: f828ad875f2cbb13303e59bb090071e5cc168487 URL: https://github.com/kamailio/kamailio/commit/f828ad875f2cbb13303e59bb090071e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-09-04T00:31:30+02:00 modules: readme files regenerated - nathelper ... [skip ci] --- Modified: src/modules/nathelper/README --- Diff: https://github.com/kamailio/kamailio/commit/f828ad875f2cbb13303e59bb090071e… Patch: https://github.com/kamailio/kamailio/commit/f828ad875f2cbb13303e59bb090071e…

4 years, 8 months

[kamailio/kamailio] module rr: KEMI expose record_route_preset (#2051)

by aalba6675

#### Pre-Submission Checklist    - [ X] Commit message has the format required by CONTRIBUTING guide - [ X] Commits are split per component (core, individual modules, libs, utils, ...) - [ X] Each component has a single commit (if not, squash them into one commit) - [ X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  rr module: expose record_route_preset to KEMI You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2051 -- Commit Summary -- * module rr: KEMI expose record_route_preset -- File Changes -- M src/modules/rr/rr_mod.c (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2051.patch https://github.com/kamailio/kamailio/pull/2051.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2051

4 years, 8 months

git:master:c556067b: Merge pull request #2051 from aalba6675/kemi-rr-preset

by GitHub

Module: kamailio Branch: master Commit: c556067bc3c0d99b7e81ee0bd1a97c1b416617d3 URL: https://github.com/kamailio/kamailio/commit/c556067bc3c0d99b7e81ee0bd1a97c1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-09-04T00:21:16+02:00 Merge pull request #2051 from aalba6675/kemi-rr-preset module rr: KEMI expose record_route_preset --- Modified: src/modules/rr/rr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/c556067bc3c0d99b7e81ee0bd1a97c1… Patch: https://github.com/kamailio/kamailio/commit/c556067bc3c0d99b7e81ee0bd1a97c1… --- diff --git a/src/modules/rr/rr_mod.c b/src/modules/rr/rr_mod.c index 6e9dda1318..31a6031a5f 100644 --- a/src/modules/rr/rr_mod.c +++ b/src/modules/rr/rr_mod.c @@ -291,6 +291,35 @@ static int ki_record_route(sip_msg_t *msg) return ki_record_route_params( msg, 0 ); } +/** + * wrapper for record_route_preset(msg, key1, key2) + */ +static int ki_record_route_preset(sip_msg_t *msg, str *key1, str *key2) +{ + if (msg->msg_flags & FL_RR_ADDED) { + LM_ERR("Double attempt to record-route\n"); + return -1; + } + if (key2 && !enable_double_rr) { + LM_ERR("Attempt to double record-route while 'enable_double_rr' param is disabled\n"); + return -1; + } + + if ( record_route_preset( msg, key1)<0 ) + return -1; + + if (!key2) + goto done; + + if ( record_route_preset( msg, key2)<0 ) + return -1; + +done: + msg->msg_flags |= FL_RR_ADDED; + return 1; + +} + /** * config wrapper for record_route(msg, params) */ @@ -317,7 +346,7 @@ static int w_record_route_preset(struct sip_msg *msg, char *key, char *key2) str s; if (msg->msg_flags & FL_RR_ADDED) { - LM_ERR("Duble attempt to record-route\n"); + LM_ERR("Double attempt to record-route\n"); return -1; } if (key2 && !enable_double_rr) { @@ -747,6 +776,11 @@ static sr_kemi_t sr_kemi_rr_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("rr"), str_init("record_route_preset"), + SR_KEMIP_INT, ki_record_route_preset, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

4 years, 8 months

git:master:e1ab977f: module rr: KEMI expose record_route_preset

by A Alba

Module: kamailio Branch: master Commit: e1ab977fd9a61864376782f2534cc0d932347d78 URL: https://github.com/kamailio/kamailio/commit/e1ab977fd9a61864376782f2534cc0d… Author: A Alba <ascanio.alba7(a)gmail.com> Committer: A Alba <ascanio.alba7(a)gmail.com> Date: 2019-09-02T01:28:48+08:00 module rr: KEMI expose record_route_preset --- Modified: src/modules/rr/rr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/e1ab977fd9a61864376782f2534cc0d… Patch: https://github.com/kamailio/kamailio/commit/e1ab977fd9a61864376782f2534cc0d… --- diff --git a/src/modules/rr/rr_mod.c b/src/modules/rr/rr_mod.c index 6e9dda1318..31a6031a5f 100644 --- a/src/modules/rr/rr_mod.c +++ b/src/modules/rr/rr_mod.c @@ -291,6 +291,35 @@ static int ki_record_route(sip_msg_t *msg) return ki_record_route_params( msg, 0 ); } +/** + * wrapper for record_route_preset(msg, key1, key2) + */ +static int ki_record_route_preset(sip_msg_t *msg, str *key1, str *key2) +{ + if (msg->msg_flags & FL_RR_ADDED) { + LM_ERR("Double attempt to record-route\n"); + return -1; + } + if (key2 && !enable_double_rr) { + LM_ERR("Attempt to double record-route while 'enable_double_rr' param is disabled\n"); + return -1; + } + + if ( record_route_preset( msg, key1)<0 ) + return -1; + + if (!key2) + goto done; + + if ( record_route_preset( msg, key2)<0 ) + return -1; + +done: + msg->msg_flags |= FL_RR_ADDED; + return 1; + +} + /** * config wrapper for record_route(msg, params) */ @@ -317,7 +346,7 @@ static int w_record_route_preset(struct sip_msg *msg, char *key, char *key2) str s; if (msg->msg_flags & FL_RR_ADDED) { - LM_ERR("Duble attempt to record-route\n"); + LM_ERR("Double attempt to record-route\n"); return -1; } if (key2 && !enable_double_rr) { @@ -747,6 +776,11 @@ static sr_kemi_t sr_kemi_rr_exports[] = { { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("rr"), str_init("record_route_preset"), + SR_KEMIP_INT, ki_record_route_preset, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

4 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2019