sr-dev September 2019

sr-dev@lists.kamailio.org

24 participants
368 discussions

git:master:a2e5e6e2: seas: remove a code block related to tag generation which was commented out since 2006
by Henning Westerholt 01 Sep '19

01 Sep '19

Module: kamailio Branch: master Commit: a2e5e6e267b15cad23bca8be15bca06383865ed7 URL: https://github.com/kamailio/kamailio/commit/a2e5e6e267b15cad23bca8be15bca06… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-01T22:55:59+02:00 seas: remove a code block related to tag generation which was commented out since 2006 --- Modified: src/modules/seas/seas_action.c --- Diff: https://github.com/kamailio/kamailio/commit/a2e5e6e267b15cad23bca8be15bca06… Patch: https://github.com/kamailio/kamailio/commit/a2e5e6e267b15cad23bca8be15bca06… --- diff --git a/src/modules/seas/seas_action.c b/src/modules/seas/seas_action.c index 7c963e6fe7..cd62848ab0 100644 --- a/src/modules/seas/seas_action.c +++ b/src/modules/seas/seas_action.c @@ -687,15 +687,6 @@ int ac_reply(as_p the_as,unsigned char processor_id,unsigned int flags,char *act }else{ totag.s=NULL; totag.len=0; - /*if(!(ttag=pkg_malloc(TOTAG_VALUE_LEN))){ - LM_ERR("Out of memory !!!\n"); - goto error; - } - totag.s=ttag; - calc_crc_suffix(c->uas.request,seas_tag_suffix); - LM_DBG("seas_tags = %.*s\n",TOTAG_VALUE_LEN,seas_tags); - memcpy(totag.s,seas_tags,TOTAG_VALUE_LEN); - totag.len=TOTAG_VALUE_LEN;*/ } LM_DBG("Using totag=[%.*s]\n",totag.len,totag.s); if(my_msg->content_length)

1 0

git:master:bc96f46f: CONTRIBUTING.md: removed garbage bullet from commit mesage details
by Daniel-Constantin Mierla 01 Sep '19

01 Sep '19

Module: kamailio Branch: master Commit: bc96f46f8a9f0beefffe281398671d216c839f20 URL: https://github.com/kamailio/kamailio/commit/bc96f46f8a9f0beefffe281398671d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-01T19:24:17+02:00 CONTRIBUTING.md: removed garbage bullet from commit mesage details --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/bc96f46f8a9f0beefffe281398671d2… Patch: https://github.com/kamailio/kamailio/commit/bc96f46f8a9f0beefffe281398671d2… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index d22cbc0ce2..ea6ba9cdd8 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -94,7 +94,6 @@ Please start always with the prefix of the component (subsystem) that is modifie * first line (subject line) has to contain meaningful text about what that commit does, do not put just a reference to bug tracker or pull request items - * t * commit message must describe the changes done by the patch * other details (e.g., how to reproduce, backtrace, sip packets, ...) belong to content (comments) of the pull request. Example:

1 0

git:master:059b8426: lost: a few bug fixes reported from source code analyzer
by Henning Westerholt 01 Sep '19

01 Sep '19

Module: kamailio Branch: master Commit: 059b8426397f2802ea51db44861387386f7109e5 URL: https://github.com/kamailio/kamailio/commit/059b8426397f2802ea51db448613873… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-01T17:04:07+02:00 lost: a few bug fixes reported from source code analyzer --- Modified: src/modules/lost/utilities.c --- Diff: https://github.com/kamailio/kamailio/commit/059b8426397f2802ea51db448613873… Patch: https://github.com/kamailio/kamailio/commit/059b8426397f2802ea51db448613873…

2 1

5.3 add rr record_route_preset to KEMI?
by Anthony Alba 01 Sep '19

01 Sep '19

Hi Daniel and Kamailio developers, Could you consider adding record_route_preset to KEMI in 5.3? If you like I can do the PR. Hope it is not too late. Regards Anthony Alba

2 1

git:master:e98a4ee5: nathelper: use portable kamailio rand() wrapper instead of direct library call
by Henning Westerholt 01 Sep '19

01 Sep '19

Module: kamailio Branch: master Commit: e98a4ee55253302144053704c26089f440d5d7ff URL: https://github.com/kamailio/kamailio/commit/e98a4ee55253302144053704c26089f… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-01T17:17:38+02:00 nathelper: use portable kamailio rand() wrapper instead of direct library call --- Modified: src/modules/nathelper/sip_pinger.h --- Diff: https://github.com/kamailio/kamailio/commit/e98a4ee55253302144053704c26089f… Patch: https://github.com/kamailio/kamailio/commit/e98a4ee55253302144053704c26089f… --- diff --git a/src/modules/nathelper/sip_pinger.h b/src/modules/nathelper/sip_pinger.h index 23ea633d03..e84ca6c648 100644 --- a/src/modules/nathelper/sip_pinger.h +++ b/src/modules/nathelper/sip_pinger.h @@ -30,6 +30,7 @@ #include "../../core/str.h" #include "../../core/ut.h" #include "../../core/ip_addr.h" +#include "../../core/rand/kam_rand.h" /* size of buffer used for building SIP PING req */ #define MAX_SIPPING_SIZE 65536 @@ -56,15 +57,15 @@ static void init_sip_ping(void) char *p; /* FROM tag - some random number */ - sipping_fromtag = rand(); + sipping_fromtag = kam_rand(); /* callid fix part - hexa string */ len = 8; p = sipping_callid_buf; - int2reverse_hex(&p, &len, rand()); + int2reverse_hex(&p, &len, kam_rand()); sipping_callid.s = sipping_callid_buf; sipping_callid.len = 8 - len; /* callid counter part */ - sipping_callid_cnt = rand(); + sipping_callid_cnt = kam_rand(); }

1 0

git:master:0e74c602: rtp_media_server: use portable kamailio rand() wrapper instead of direct library call
by Henning Westerholt 01 Sep '19

01 Sep '19

Module: kamailio Branch: master Commit: 0e74c602c0822393bc6032574f834e2a9030cc7b URL: https://github.com/kamailio/kamailio/commit/0e74c602c0822393bc6032574f834e2… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-01T17:14:05+02:00 rtp_media_server: use portable kamailio rand() wrapper instead of direct library call --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/0e74c602c0822393bc6032574f834e2… Patch: https://github.com/kamailio/kamailio/commit/0e74c602c0822393bc6032574f834e2… --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 37ddb1b998..8f2b2592aa 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -20,6 +20,7 @@ #include "rtp_media_server.h" #include "../../core/fmsg.h" +#include "../../core/rand/kam_rand.h" MODULE_VERSION @@ -169,7 +170,7 @@ static int mod_init(void) rms->udp_start_port = 50000; LM_INFO("RTP media server module init\n"); rms->udp_end_port = 60000; - rms->udp_last_port = 50000 + rand() % 10000; + rms->udp_last_port = 50000 + kam_rand() % 10000; rms_media_init(); if(!init_rms_dialog_list()) {

1 0

git:master:6cc563b1: lost: use portable kamailio rand() wrapper instead of direct library call
by Henning Westerholt 01 Sep '19

01 Sep '19

Module: kamailio Branch: master Commit: 6cc563b1b73bfa07911d3e6e3f35d744eb952fbf URL: https://github.com/kamailio/kamailio/commit/6cc563b1b73bfa07911d3e6e3f35d74… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-01T17:08:05+02:00 lost: use portable kamailio rand() wrapper instead of direct library call --- Modified: src/modules/lost/utilities.c --- Diff: https://github.com/kamailio/kamailio/commit/6cc563b1b73bfa07911d3e6e3f35d74… Patch: https://github.com/kamailio/kamailio/commit/6cc563b1b73bfa07911d3e6e3f35d74… --- diff --git a/src/modules/lost/utilities.c b/src/modules/lost/utilities.c index cfd2dbe3ab..966e93b033 100644 --- a/src/modules/lost/utilities.c +++ b/src/modules/lost/utilities.c @@ -45,6 +45,7 @@ #include "../../core/dprint.h" #include "../../core/mem/mem.h" #include "../../core/mem/shm_mem.h" +#include "../../core/rand/kam_rand.h" #include "pidf.h" #include "utilities.h" @@ -85,9 +86,9 @@ void lost_rand_str(char *dest, size_t lgth) char charset[] = "0123456789" "abcdefghijklmnopqrstuvwxyz" "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; - srand(time(NULL)); + kam_srand(time(NULL)); while(lgth-- > 0) { - index = (double)rand() / RAND_MAX * (sizeof charset - 1); + index = (double)kam_rand() / RAND_MAX * (sizeof charset - 1); *dest++ = charset[index]; } *dest = '\0';

1 0

git:master:06a17dbf: lib: add a comment that HA1 hash value is currently not used from uacreg module
by Henning Westerholt 01 Sep '19

01 Sep '19

Module: kamailio Branch: master Commit: 06a17dbf23d2b1d3cc1c7be69e7fb99825a534ee URL: https://github.com/kamailio/kamailio/commit/06a17dbf23d2b1d3cc1c7be69e7fb99… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-01T17:04:07+02:00 lib: add a comment that HA1 hash value is currently not used from uacreg module --- Modified: src/lib/srdb1/schema/uacreg.xml --- Diff: https://github.com/kamailio/kamailio/commit/06a17dbf23d2b1d3cc1c7be69e7fb99… Patch: https://github.com/kamailio/kamailio/commit/06a17dbf23d2b1d3cc1c7be69e7fb99… --- diff --git a/src/lib/srdb1/schema/uacreg.xml b/src/lib/srdb1/schema/uacreg.xml index d6257d0cf4..2ce0f1262b 100644 --- a/src/lib/srdb1/schema/uacreg.xml +++ b/src/lib/srdb1/schema/uacreg.xml @@ -102,7 +102,7 @@ <type>string</type> <size>&ha1_len;</size> <default/> - <description>Hashed (HA1) authentication password</description> + <description>Hashed (HA1) authentication password - currently unused</description> </column> <column id="auth_proxy">

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2019