sr-dev September 2019

sr-dev@lists.kamailio.org

24 participants
368 discussions

git:master:919dd727: core: improve error messages on permission problems for cfg/pid files and runtime dir
by Henning Westerholt 06 Sep '19

06 Sep '19

Module: kamailio Branch: master Commit: 919dd72712561f03bc0f303390c06366fe7acddb URL: https://github.com/kamailio/kamailio/commit/919dd72712561f03bc0f303390c0636… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-06T12:09:38+02:00 core: improve error messages on permission problems for cfg/pid files and runtime dir --- Modified: src/core/daemonize.c Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/… [View More]

1 0

git:master:ed10d769: core: improve error message related to a mismatch of #!ifdef/#!define statement
by Henning Westerholt 06 Sep '19

06 Sep '19

Module: kamailio Branch: master Commit: ed10d7692b99b1cd6d3975c06d8b0d9d3270779d URL: https://github.com/kamailio/kamailio/commit/ed10d7692b99b1cd6d3975c06d8b0d9… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-06T11:37:44+02:00 core: improve error message related to a mismatch of #!ifdef/#!define statement --- Modified: src/core/ppcfg.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

[kamailio/kamailio] $Au incorrectly contains domain or realm (#2056)
by Joel Serrano 06 Sep '19

06 Sep '19

### Description Testing on latest master deb nightly build (`5.3.0~dev7+0~20190904005559.1479+buster`) I've noticed that `$Au` is not being set correctly, at least according to my tests. >From the documentation (https://www.kamailio.org/wiki/cookbooks/devel/pseudovariables#au_-_acc_user…): _$Au - Acc username: username for accounting purposes. It's a selective pseudo variable (inherited from acc module). It returns auth username ($au) if exists or From username ($fU) otherwise._ I have … [View More]the following log statement in several places in a test box: xlog("L_NOTICE", "[DEBUG] Au=$Au au=$au aU=$aU ar=$ar fU=$fU fu=$fu - \n"); And when I run through them I get the following: Initial log (at the beginning of request_route): ``` Sep 5 01:54:39 csbc01 csbc[20380]: NOTICE: {1 1 REGISTER f597522fd7e52fe99f2a54a834101efa@0:0:0:0:0:0:0:0} <script>: [DEBUG] Au=1063362(a)some.domain au=<null> aU=<null> ar=<null> fU=1063362 fu=sip:1063362@some.domain - ``` After a 401 challenge, the following log statements look like this one: ``` Sep 5 01:54:40 csbc01 csbc[20385]: NOTICE: {1 2 REGISTER f597522fd7e52fe99f2a54a834101efa@0:0:0:0:0:0:0:0} <script>: [DEBUG] Au=1063362(a)some.domain au=1063362 aU=1063362 ar=custom-realm fU=1063362 fu=sip:1063362@some.domain - ``` At this point I would expect `$Au` to not have the `@domain` part in it. And strangely, after an `auth_check()`, it changes again: ``` Sep 5 01:54:40 csbc01 csbc[20385]: NOTICE: {1 2 REGISTER f597522fd7e52fe99f2a54a834101efa@0:0:0:0:0:0:0:0} <script>: [DEBUG] Au=1063362@custom-realm au=1063362 aU=1063362 ar=custom-realm fU=1063362 fu=sip:1063362@some.domain - ``` >From that point onward, it no longer has the domain and now contains the realm. I believe both these behaviors are incorrect, or at least they don't match what the documentation says. ### Troubleshooting @henningw commented about this in the email thread I started: _Hello Joel,_ _I did a quick look into the code, this is basically unchanged since 2008. I also tested 5.2.3, it shows the same behavior._ _NOTICE: {1 1 REGISTER 363545605-1445114084-1880652839} <script>: [DEBUG] Au=82621(a)116.203.XXX.XXX au=<null> aU=<null> fU=82621 fu=sip:82621@116.203.XXX.XXX - root@sip:~# kamcmd core.version kamailio 5.2.3 (x86_64/linux) I certainly would make more sense in a way like it is documented. Can you easily check an older version?_ _Cheers,_ _Henning_ ### Reproduction Print `$Au` in logs before challenge, after a successful auth, and after an `auth_check()` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` root@csbc01:/etc/kamailio# kamailio -v version: kamailio 5.3.0-dev7 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 root@csbc01:/etc/kamailio# ``` * **Operating System**:  ``` Distributor ID: Debian Description: Debian GNU/Linux 10 (buster) Release: 10 Codename: buster ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2056 [View Less]

4 12

git:master:e3774a8e: pv: add missing implementation for documented acc user pv (GH #2056)
by Henning Westerholt 06 Sep '19

06 Sep '19

Module: kamailio Branch: master Commit: e3774a8e40e4cbe57d286e0426a8fd4e0a4175f1 URL: https://github.com/kamailio/kamailio/commit/e3774a8e40e4cbe57d286e0426a8fd4… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-06T09:19:59+02:00 pv: add missing implementation for documented acc user pv (GH #2056) - add missing implementation for documented acc user pseudo-variable - it was documented as $Au, but it works differently … [View More]since a long time - as discussed in issue GH #2056 add a new pv $AU that works like intended --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c Modified: src/modules/pv/pv_core.h --- Diff: https://github.com/kamailio/kamailio/commit/e3774a8e40e4cbe57d286e0426a8fd4… Patch: https://github.com/kamailio/kamailio/commit/e3774a8e40e4cbe57d286e0426a8fd4… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index e629d66d10..310acf53d0 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -141,6 +141,9 @@ static pv_export_t mod_pvs[] = { {{"Au", (sizeof("Au")-1)}, /* */ PVT_OTHER, pv_get_acc_username, 0, 0, 0, pv_init_iname, 1}, + {{"AU", (sizeof("AU")-1)}, /* */ + PVT_OTHER, pv_get_acc_user, 0, + 0, 0, pv_init_iname, 1}, {{"bf", (sizeof("bf")-1)}, /* */ PVT_CONTEXT, pv_get_bflags, pv_set_bflags, 0, 0, 0, 0}, diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index c554ed0cde..18db915cfb 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -1572,6 +1572,37 @@ static inline str *cred_realm(struct sip_msg *rq) return realm; } + +int pv_get_acc_user(struct sip_msg *msg, pv_param_t *param, + pv_value_t *res) +{ + str* user; + struct sip_uri puri; + struct to_body* from; + + /* try to take it from credentials */ + user = cred_user(msg); + if (user) { + return pv_get_strval(msg, param, res, user); + } + + /* from from uri */ + if(parse_from_header(msg)<0) + { + LM_ERR("cannot parse FROM header\n"); + return pv_get_null(msg, param, res); + } + if (msg->from && (from=get_from(msg)) && from->uri.len) { + if (parse_uri(from->uri.s, from->uri.len, &puri) < 0 ) { + LM_ERR("bad From URI\n"); + return pv_get_null(msg, param, res); + } + return pv_get_strval(msg, param, res, &(puri.user)); + } + return pv_get_null(msg, param, res); +} + + int pv_get_acc_username(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { diff --git a/src/modules/pv/pv_core.h b/src/modules/pv/pv_core.h index 86629e66e0..ee45b915cd 100644 --- a/src/modules/pv/pv_core.h +++ b/src/modules/pv/pv_core.h @@ -223,6 +223,9 @@ int pv_get_body_size(struct sip_msg *msg, pv_param_t *param, int pv_get_authattr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); +int pv_get_acc_user(struct sip_msg *msg, pv_param_t *param, + pv_value_t *res); + int pv_get_acc_username(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); [View Less]

1 0

git:master:748f981c: Revert "pv: fix $Au pseudo-variable, it contains incorrectly domain or realm (GH #2056)"
by Henning Westerholt 05 Sep '19

05 Sep '19

Module: kamailio Branch: master Commit: 748f981c708ebeb8b0f4325060696fd58d152f54 URL: https://github.com/kamailio/kamailio/commit/748f981c708ebeb8b0f4325060696fd… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-05T21:31:16+02:00 Revert "pv: fix $Au pseudo-variable, it contains incorrectly domain or realm (GH #2056)" This reverts commit aa8f0820318762a393c41623cba3a5795225fb0a. --- Modified: src/modules/pv/pv_core.c --… [View More]

1 0

git:master:aa8f0820: pv: fix $Au pseudo-variable, it contains incorrectly domain or realm (GH #2056)
by Henning Westerholt 05 Sep '19

05 Sep '19

Module: kamailio Branch: master Commit: aa8f0820318762a393c41623cba3a5795225fb0a URL: https://github.com/kamailio/kamailio/commit/aa8f0820318762a393c41623cba3a57… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-05T19:24:01+02:00 pv: fix $Au pseudo-variable, it contains incorrectly domain or realm (GH #2056) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:20c9e35e: call_obj: fix Doxygen comments.
by Vicente Hernando 05 Sep '19

05 Sep '19

Module: kamailio Branch: master Commit: 20c9e35e811817377dba0290180ff23ee9749827 URL: https://github.com/kamailio/kamailio/commit/20c9e35e811817377dba0290180ff23… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: 2019-09-05T15:32:18+02:00 call_obj: fix Doxygen comments. --- Modified: src/modules/call_obj/call_obj_mod.c Modified: src/modules/call_obj/cobj.c Modified: src/modules/call_obj/cobj.h --- Diff: … [View More]

1 0

git:master:bda770e5: call_obj: software license.
by Vicente Hernando 05 Sep '19

05 Sep '19

Module: kamailio Branch: master Commit: bda770e57200aba4118803a6d332f2440fb0a540 URL: https://github.com/kamailio/kamailio/commit/bda770e57200aba4118803a6d332f24… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: 2019-09-05T15:32:04+02:00 call_obj: software license. --- Modified: src/modules/call_obj/call_obj_mod.c Modified: src/modules/call_obj/cobj.c Modified: src/modules/call_obj/cobj.h --- Diff: https:/… [View More]/github.com/kamailio/kamailio/commit/bda770e57200aba4118803a6d332f24… Patch: https://github.com/kamailio/kamailio/commit/bda770e57200aba4118803a6d332f24… --- diff --git a/src/modules/call_obj/call_obj_mod.c b/src/modules/call_obj/call_obj_mod.c index 72307e2d86..c136de58e8 100644 --- a/src/modules/call_obj/call_obj_mod.c +++ b/src/modules/call_obj/call_obj_mod.c @@ -1,3 +1,25 @@ +/* + * CALL_OBJ module + * + * Copyright (C) 2017-2019 - Sonoc + * + * This file is part of Kamailio, a free SIP server. + * + * Kamailio is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * Kamailio is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + * + */ #include <inttypes.h> diff --git a/src/modules/call_obj/cobj.c b/src/modules/call_obj/cobj.c index cf014b659f..e330a79978 100644 --- a/src/modules/call_obj/cobj.c +++ b/src/modules/call_obj/cobj.c @@ -1,3 +1,26 @@ +/* + * CALL_OBJ module + * + * Copyright (C) 2017-2019 - Sonoc + * + * This file is part of Kamailio, a free SIP server. + * + * Kamailio is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * Kamailio is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + * + */ + /** * Functionality of call_obj module. */ diff --git a/src/modules/call_obj/cobj.h b/src/modules/call_obj/cobj.h index 85aaab6a69..09417da203 100644 --- a/src/modules/call_obj/cobj.h +++ b/src/modules/call_obj/cobj.h @@ -1,3 +1,26 @@ +/* + * CALL_OBJ module + * + * Copyright (C) 2017-2019 - Sonoc + * + * This file is part of Kamailio, a free SIP server. + * + * Kamailio is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * Kamailio is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + * + */ + /** * Header for functionality of Call Object module. */ [View Less]

1 0

git:master:7f11960a: pkg/kamailio/deb: version set 5.3.0~pre0
by Victor Seva 05 Sep '19

05 Sep '19

Module: kamailio Branch: master Commit: 7f11960acfec8b182eadee1948f1cbd0e553faa1 URL: https://github.com/kamailio/kamailio/commit/7f11960acfec8b182eadee1948f1cbd… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-09-05T11:53:28+02:00 pkg/kamailio/deb: version set 5.3.0~pre0 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/… [View More]

1 0

Development for v5.3.x is frozen
by Daniel-Constantin Mierla 05 Sep '19

05 Sep '19

Hello, the formal notification that the development for the next major version 5.3.0 is now frozen. The focus has to be on testing the master branch. Also, the master branch should not get commits with new features till the branch 5.3 is created, expected to happen in 2-4 weeks, a matter of how testing goes on. Meanwhile, the commits with new features in the C code can be pushed to personal branches, pull requests can still be done, but they will be merged after branching 5.3. Can still be … [View More]

2 2

← Newer
1
...
30
31
32
33
34
35
36
37
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2019