sr-dev September 2019

sr-dev@lists.kamailio.org

24 participants
368 discussions

git:master:64a93405: ctl: spelling fix in comments (usefull -> useful)

by Henning Westerholt

Module: kamailio Branch: master Commit: 64a93405470569b098b6d1a45361a80bc5f82644 URL: https://github.com/kamailio/kamailio/commit/64a93405470569b098b6d1a45361a80… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-29T23:15:11+02:00 ctl: spelling fix in comments (usefull -> useful) --- Modified: src/modules/ctl/binrpc.h --- Diff: https://github.com/kamailio/kamailio/commit/64a93405470569b098b6d1a45361a80… Patch: https://github.com/kamailio/kamailio/commit/64a93405470569b098b6d1a45361a80… --- diff --git a/src/modules/ctl/binrpc.h b/src/modules/ctl/binrpc.h index 56a8e26cd6..29e06670ed 100644 --- a/src/modules/ctl/binrpc.h +++ b/src/modules/ctl/binrpc.h @@ -434,7 +434,7 @@ inline static int binrpc_add_str_type(struct binrpc_pkt* pkt, char* s, int len, -/* adds an avp (name, value) pair, usefull to add structure members */ +/* adds an avp (name, value) pair, useful to add structure members */ inline static int binrpc_addavp(struct binrpc_pkt* pkt, struct binrpc_val* avp) { int ret;

4 years, 7 months

git:master:76353873: lib: spelling fix in comments (usefull -> useful)

by Henning Westerholt

Module: kamailio Branch: master Commit: 76353873c63cf3115c05b2e188f36e5a2b0ce9bf URL: https://github.com/kamailio/kamailio/commit/76353873c63cf3115c05b2e188f36e5… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-29T23:14:24+02:00 lib: spelling fix in comments (usefull -> useful) --- Modified: src/lib/cds/cds.h --- Diff: https://github.com/kamailio/kamailio/commit/76353873c63cf3115c05b2e188f36e5… Patch: https://github.com/kamailio/kamailio/commit/76353873c63cf3115c05b2e188f36e5… --- diff --git a/src/lib/cds/cds.h b/src/lib/cds/cds.h index d1f3edd75b..d72e191b2a 100644 --- a/src/lib/cds/cds.h +++ b/src/lib/cds/cds.h @@ -36,7 +36,7 @@ * - many duplicated functions in modules (copy&pasted between modules) * without touching SER's core * - possibility to debug programs outside of SER due to its simplicity - * and many usefull tools + * and many useful tools * * @{ */

4 years, 7 months

git:master:68d1bdef: core: spelling fix in comments (usefull -> useful)

by Henning Westerholt

Module: kamailio Branch: master Commit: 68d1bdefb373798c740130b50602cdde2e70f876 URL: https://github.com/kamailio/kamailio/commit/68d1bdefb373798c740130b50602cdd… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-29T23:13:41+02:00 core: spelling fix in comments (usefull -> useful) --- Modified: src/Makefile.rules Modified: src/core/dset.h Modified: src/core/tcp_main.c Modified: src/core/timer.c --- Diff: https://github.com/kamailio/kamailio/commit/68d1bdefb373798c740130b50602cdd… Patch: https://github.com/kamailio/kamailio/commit/68d1bdefb373798c740130b50602cdd… --- diff --git a/src/Makefile.rules b/src/Makefile.rules index 10d04a1c33..57c955437f 100644 --- a/src/Makefile.rules +++ b/src/Makefile.rules @@ -207,7 +207,7 @@ all: $(NAME) every-module static: $(objs) # clean only the current directory (no modules or utils) -# (it's usefull to have it separated from clean for speeding up make proper) +# (it's useful to have it separated from clean for speeding up make proper) .PHONY: local-clean local-clean: -@rm -f $(objs) $(NAME) $(objs:.o=.il) *.a librpath.lst 2>/dev/null diff --git a/src/core/dset.h b/src/core/dset.h index 9a640da704..ccb0f669c9 100644 --- a/src/core/dset.h +++ b/src/core/dset.h @@ -223,7 +223,7 @@ inline static int get_request_uri(struct sip_msg* _m, str* _u) #define ruri_mark_consumed() (ruri_is_new = 0) /** returns whether or not ruri should be used when forking. - * (usefull for serial forking) + * (useful for serial forking) * @return 0 if already marked as consumed, 1 if not. */ #define ruri_get_forking_state() (ruri_is_new) diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index e86fc872a8..61a692af85 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -3553,7 +3553,7 @@ int _tcpconn_write_nb(int fd, struct tcp_connection* c, /* handles io from a tcp child process * params: tcp_c - pointer in the tcp_children array, to the entry for * which an io event was detected - * fd_i - fd index in the fd_array (usefull for optimizing + * fd_i - fd index in the fd_array (useful for optimizing * io_watch_deletes) * returns: handle_* return convention: -1 on error, 0 on EAGAIN (no more * io events queued), >0 on success. success/error refer only to @@ -3776,7 +3776,7 @@ inline static int handle_tcp_child(struct tcp_child* tcp_c, int fd_i) * * params: p - pointer in the ser processes array (pt[]), to the entry for * which an io event was detected - * fd_i - fd index in the fd_array (usefull for optimizing + * fd_i - fd index in the fd_array (useful for optimizing * io_watch_deletes) * returns: handle_* return convention: * -1 on error reading from the fd, diff --git a/src/core/timer.c b/src/core/timer.c index 8f6e305b24..1bcd036fda 100644 --- a/src/core/timer.c +++ b/src/core/timer.c @@ -765,7 +765,7 @@ return ret; -/* marks a timer as "to be deleted when the handler ends", usefull when +/* marks a timer as "to be deleted when the handler ends", useful when * the timer handler knows it won't prolong the timer anymore (it will * return 0) and will do some time consuming work. Calling this function * will cause simultaneous timer_dels to return immediately (they won't

4 years, 7 months

[kamailio/kamailio] uac: Crash on kamcmd uac.reg_reload using auth_ha1 field as password in database table (#2076)

by Alexandru Covalschi

### Description I was testing latest nightly build to test uacreg with auth_ha1 column. I have 1 record in database: ``` id: 1 l_uuid: 50b08f96-ee5d-44bb-8539-098268ad64d1 l_username: covalschi l_domain: test113.covalschi.reraldomain.com r_username: covalschi r_domain: sip.linphone.org realm: sip.linphone.org auth_username: covalschi auth_password: auth_ha1: f0e0dc4bf176fe8f41280b7b3758150d auth_proxy: sip.linphone.org expires: 3600 flags: 0 reg_delay: 0 socket: ``` When I execute kamcmd uac.reg_reload I get: ```ERROR: read reply failed: Success (0)``` as return code for kamcmd and Kamailio crashes.  ### Troubleshooting It repeats every time, Kamailio crashes with signal 11 #### Reproduction Basically do the same - create a record in database with auth_ha1 instead of password and try kamcmd uac.reg_reload  #### Debugging Data  ``` bt full: https://pastebin.com/by6Nxwhk info locals: https://pastebin.com/ZmEHnupn (gdb) list 1871 in main.c ``` [core.zip](https://github.com/kamailio/kamailio/files/3656555/core.zip) #### Log Messages  ``` 27(380) CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 5 0(1) ALERT: <core> [main.c:766]: handle_sigs(): child process 364 exited by a signal 11 0(1) ALERT: <core> [main.c:769]: handle_sigs(): core was generated ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.0-pre1 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**: ``` Debian stretch in docker Linux dev-covalschi 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3 (2019-09-02) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2076

4 years, 7 months

git:master:ac016795: uac: fix crash related to uacreg HA1 addition, commit 9b501c4945

by Henning Westerholt

Module: kamailio Branch: master Commit: ac016795dae5c0dcb5377fe9efa83fda240a6d17 URL: https://github.com/kamailio/kamailio/commit/ac016795dae5c0dcb5377fe9efa83fd… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-29T23:01:42+02:00 uac: fix crash related to uacreg HA1 addition, commit 9b501c4945 - fix crash related to uacreg HA1 addition, commit 9b501c4945 (GH #2076) - it's also necessary to add the new column to the queries --- Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/ac016795dae5c0dcb5377fe9efa83fd… Patch: https://github.com/kamailio/kamailio/commit/ac016795dae5c0dcb5377fe9efa83fd… --- diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index 5ede2458ef..fb45a4fd3d 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -1364,7 +1364,7 @@ int uac_reg_load_db(void) } if (DB_CAPABILITY(reg_dbf, DB_CAP_FETCH)) { - if(reg_dbf.query(reg_db_con, 0, 0, 0, db_cols, 0, 13, 0, 0) < 0) + if(reg_dbf.query(reg_db_con, 0, 0, 0, db_cols, 0, 14, 0, 0) < 0) { LM_ERR("Error while querying db\n"); return -1; @@ -1383,7 +1383,7 @@ int uac_reg_load_db(void) } } else { if((ret=reg_dbf.query(reg_db_con, NULL, NULL, NULL, db_cols, - 0, 13, 0, &db_res))!=0 + 0, 14, 0, &db_res))!=0 || RES_ROW_N(db_res)<=0 ) { reg_dbf.free_result(reg_db_con, db_res); @@ -1502,7 +1502,7 @@ int uac_reg_db_refresh(str *pl_uuid) db_vals[0].val.str_val.len = pl_uuid->len; if((ret=reg_dbf.query(reg_db_con, db_keys, NULL, db_vals, db_cols, - 1 /*nr keys*/, 13 /*nr cols*/, 0, &db_res))!=0 + 1 /*nr keys*/, 14 /*nr cols*/, 0, &db_res))!=0 || RES_ROW_N(db_res)<=0 ) { reg_dbf.free_result(reg_db_con, db_res);

4 years, 7 months

git:master:4ad1382a: modules: readme files regenerated - siptrace ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 4ad1382a6529f9d201a78280998f846dbbd3aa80 URL: https://github.com/kamailio/kamailio/commit/4ad1382a6529f9d201a78280998f846… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-09-29T21:47:11+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/4ad1382a6529f9d201a78280998f846… Patch: https://github.com/kamailio/kamailio/commit/4ad1382a6529f9d201a78280998f846… --- diff --git a/src/modules/siptrace/README b/src/modules/siptrace/README index 2be4f37a91..35b1dd78a3 100644 --- a/src/modules/siptrace/README +++ b/src/modules/siptrace/README @@ -145,7 +145,7 @@ Chapter 1. Admin Guide The SIPtrace module offer a possibility to store incoming and outgoing SIP messages in a database and/or duplicate to the capturing server (using HEP, the Homer encapsulation protocol, or plain SIP mode). Since - version 5.4 new levels of tracing are available. Transactions and + version 5.3.0 new levels of tracing are available. Transactions and dialogs can be traced. There are multiple ways of storing information:

4 years, 7 months

git:master:d3b0710a: siptrace: fix an error in the docs, new tracing functions will be available in 5.3.0

by Henning Westerholt

Module: kamailio Branch: master Commit: d3b0710a1bf0158a337636c6bb7132209320ef87 URL: https://github.com/kamailio/kamailio/commit/d3b0710a1bf0158a337636c6bb71322… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-29T21:41:59+02:00 siptrace: fix an error in the docs, new tracing functions will be available in 5.3.0 --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d3b0710a1bf0158a337636c6bb71322… Patch: https://github.com/kamailio/kamailio/commit/d3b0710a1bf0158a337636c6bb71322… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index a60b843831..875dc2348f 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -18,7 +18,7 @@ <para> The SIPtrace module offer a possibility to store incoming and outgoing SIP messages in a database and/or duplicate to the capturing server (using <acronym>HEP</acronym>, - the Homer encapsulation protocol, or plain SIP mode). Since version 5.4 new levels of tracing + the Homer encapsulation protocol, or plain SIP mode). Since version 5.3.0 new levels of tracing are available. Transactions and dialogs can be traced. </para> <para>

4 years, 7 months

git:master:a1a32a92: modules: readme files regenerated - dialog ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: a1a32a927203c8897c577618bb03ab543b5e71f9 URL: https://github.com/kamailio/kamailio/commit/a1a32a927203c8897c577618bb03ab5… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-09-27T18:31:50+02:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/a1a32a927203c8897c577618bb03ab5… Patch: https://github.com/kamailio/kamailio/commit/a1a32a927203c8897c577618bb03ab5… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 8f3f36a9c8..33b7d8cad6 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -1389,10 +1389,11 @@ modparam("dialog", "h_id_start", 5) selected at startup, then incremented by 1 for each new dialog. Setting h_id_start and h_id_step to non-default values should be done when using dlg_db_load_callid(...) or dlg_db_load_extra() to load dialog - records generated by another Kamailio instance, making also sure that - those Kamailio nstances are not going to generate overalapping dialog - hash id values by using different h_id_start and the same h_id_step - (h_id_step has to be greater than the maximum value of h_id_start). + records generated by another Kamailio instance. Pay attention to ensure + that those Kamailio instances are not going to generate overlapping + dialog hash id values by using different h_id_start and the same + h_id_step (h_id_step has to be greater than the maximum value of + h_id_start). Default value is “1”.

4 years, 7 months

git:5.2:dfe5422a: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.2 Commit: dfe5422a70c264af3428e27decf82ab05024b048 URL: https://github.com/kamailio/kamailio/commit/dfe5422a70c264af3428e27decf82ab… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-09-27T18:31:35+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/dfe5422a70c264af3428e27decf82ab… Patch: https://github.com/kamailio/kamailio/commit/dfe5422a70c264af3428e27decf82ab… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 18ea72d4f5..a0fa0ccdea 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -1375,10 +1375,11 @@ modparam("dialog", "h_id_start", 5) selected at startup, then incremented by 1 for each new dialog. Setting h_id_start and h_id_step to non-default values should be done when using dlg_db_load_callid(...) or dlg_db_load_extra() to load dialog - records generated by another Kamailio instance, making also sure that - those Kamailio nstances are not going to generate overalapping dialog - hash id values by using different h_id_start and the same h_id_step - (h_id_step has to be greater than the maximum value of h_id_start). + records generated by another Kamailio instance. Pay attention to ensure + that those Kamailio instances are not going to generate overlapping + dialog hash id values by using different h_id_start and the same + h_id_step (h_id_step has to be greater than the maximum value of + h_id_start). Default value is “1”.

4 years, 7 months

git:5.2:983f6436: dialog: two spelling fixes in docs, small rephrasing

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: 983f6436719f5cb388b165ec6474be631263e2fb URL: https://github.com/kamailio/kamailio/commit/983f6436719f5cb388b165ec6474be6… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-27T18:22:34+02:00 dialog: two spelling fixes in docs, small rephrasing (cherry picked from commit 21af49a8db75b80e6a910e6b6ed0412bbcf5608a) --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/983f6436719f5cb388b165ec6474be6… Patch: https://github.com/kamailio/kamailio/commit/983f6436719f5cb388b165ec6474be6… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 4b111fb27a..0a461185ee 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -1582,8 +1582,8 @@ modparam("dialog", "h_id_start", 5) dialog. Setting h_id_start and h_id_step to non-default values should be done when using dlg_db_load_callid(...) or dlg_db_load_extra() to load dialog records generated by another - &kamailio; instance, making also sure that those &kamailio; - nstances are not going to generate overalapping dialog hash id + &kamailio; instance. Pay attention to ensure that those &kamailio; + instances are not going to generate overlapping dialog hash id values by using different h_id_start and the same h_id_step (h_id_step has to be greater than the maximum value of h_id_start). </para>

4 years, 7 months

← Newer
1
...
9
10
11
12
13
14
15
...
37
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2019