sr-dev September 2019

sr-dev@lists.kamailio.org

24 participants
368 discussions

[kamailio/kamailio] Problem Parsing Route Header (#2079)

by duarterocha91

Problem : Route header doesn't seem to be behaving correctly when it contains more than one URI. This issue seems to affect uac_restore mechanics and routing mechanics. In order to test this i've created a test call with a in-dialog "OPTIONS" request. In one scenario, the OPTIONS contains two Route headers with one URI each. In the other scenario, the OPTIONS contains one Route header with two URIs. In the last scenario, there is a failure routing the request to it's destination (404 - Not here) [VTS_2.0.zip](https://github.com/kamailio/kamailio/files/3662292/VTS_2.0.zip) . In both scenarios the URIs used are the same and the remaining of the call beahviour is the same. Find attached to this report two pcap files with the two scenarios. 2Routes.pcap - Two Route headers with one URI each 2 [VTS_2.0.zip](https://github.com/kamailio/kamailio/files/3662287/VTS_2.0.zip) URIs.pcap - One Route Header with two URI. If needed i can do more testing. Best Regards, Duarte Rocha -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2079

4 years, 7 months

[kamailio/kamailio] kamctl: Update dbtextdb.py for Python3 (#2083)

by Anthony Messina

- reported by GH #1747   #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #1747 #### Description  Updated kamctl/dbtextdb to complie with either Python2 or Python3. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2083 -- Commit Summary -- * kamctl: Update dbtextdb.py for Python3 -- File Changes -- M utils/kamctl/dbtextdb/dbtextdb.py (2252) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2083.patch https://github.com/kamailio/kamailio/pull/2083.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2083

4 years, 7 months

git:master:de11e285: tm: removed async mutex define option

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: de11e2850314b12320cf8fed29f709a38a986709 URL: https://github.com/kamailio/kamailio/commit/de11e2850314b12320cf8fed29f709a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-30T09:07:58+02:00 tm: removed async mutex define option - it was disbaled due to conflict with reply processing, the reply mutex being used, t_continue() has same processing like a failure handling --- Modified: src/modules/tm/h_table.c Modified: src/modules/tm/h_table.h Modified: src/modules/tm/lock.c Modified: src/modules/tm/lock.h Modified: src/modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/de11e2850314b12320cf8fed29f709a… Patch: https://github.com/kamailio/kamailio/commit/de11e2850314b12320cf8fed29f709a… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index 3f10817013..d0ec6c8452 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -396,7 +396,6 @@ struct cell *build_cell(struct sip_msg *p_msg) init_synonym_id(p_msg, new_cell->md5); init_cell_lock(new_cell); - init_async_lock(new_cell); t_stats_created(); return new_cell; diff --git a/src/modules/tm/h_table.h b/src/modules/tm/h_table.h index cf0a4b549f..ef666e5955 100644 --- a/src/modules/tm/h_table.h +++ b/src/modules/tm/h_table.h @@ -406,11 +406,6 @@ typedef struct cell /* recursive reply lock count */ int reply_rec_lock_level; -#ifdef ENABLE_ASYNC_MUTEX - /* protect against concurrent async continues */ - ser_lock_t async_mutex; -#endif - ticks_t fr_timeout; /* final response interval for retr_bufs */ ticks_t fr_inv_timeout; /* final inv. response interval for retr_bufs */ retr_timeout_t rt_t1_timeout_ms; /* start retr. interval for retr_bufs */ diff --git a/src/modules/tm/lock.c b/src/modules/tm/lock.c index 45b267d064..c06bd4c16a 100644 --- a/src/modules/tm/lock.c +++ b/src/modules/tm/lock.c @@ -50,9 +50,6 @@ static int sem_nr; gen_lock_set_t *entry_semaphore = 0; gen_lock_set_t *reply_semaphore = 0; -#ifdef ENABLE_ASYNC_MUTEX -gen_lock_set_t *async_semaphore = 0; -#endif #endif @@ -82,12 +79,6 @@ int lock_initialize() lock_set_destroy(reply_semaphore); lock_set_dealloc(reply_semaphore); } -#ifdef ENABLE_ASYNC_MUTEX - if(async_semaphore != 0) { - lock_set_destroy(async_semaphore); - lock_set_dealloc(async_semaphore); - } -#endif if(i == 0) { LOG(L_CRIT, "lock_initialize: could not allocate semaphore" " sets\n"); @@ -139,20 +130,6 @@ int lock_initialize() i--; goto again; } -#ifdef ENABLE_ASYNC_MUTEX - i++; - if(((async_semaphore = lock_set_alloc(i)) == 0) - || (lock_set_init(async_semaphore) == 0)) { - if(async_semaphore) { - lock_set_dealloc(async_semaphore); - async_semaphore = 0; - } - LM_DBG("async semaphore initialization failure: %s\n", strerror(errno)); - probe_run = 1; - i--; - goto again; - } -#endif /* return success */ LM_INFO("semaphore arrays of size %d allocated\n", sem_nr); @@ -192,13 +169,6 @@ void lock_cleanup() lock_set_destroy(reply_semaphore); lock_set_dealloc(reply_semaphore); }; -#ifdef ENABLE_ASYNC_MUTEX - if(async_semaphore != 0) { - lock_set_destroy(async_semaphore); - lock_set_dealloc(async_semaphore); - } - async_semaphore = 0; -#endif entry_semaphore = reply_semaphore = 0; } #endif /*GEN_LOCK_T_PREFERED*/ @@ -232,22 +202,6 @@ int init_entry_lock(struct s_table *ht, struct entry *entry) return 0; } -int init_async_lock(struct cell *cell) -{ -#ifdef ENABLE_ASYNC_MUTEX - -#ifdef GEN_LOCK_T_PREFERED - lock_init(&cell->async_mutex); -#else - cell->async_mutex.semaphore_set = async_semaphore; - cell->async_mutex.semaphore_index = cell->hash_index % sem_nr; -#endif /* GEN_LOCK_T_PREFERED */ - -#endif /* ENABLE_ASYNC_MUTEX */ - - return 0; -} - int release_cell_lock(struct cell *cell) { #ifndef GEN_LOCK_T_PREFERED diff --git a/src/modules/tm/lock.h b/src/modules/tm/lock.h index 7e0bf58424..a44f4ebae0 100644 --- a/src/modules/tm/lock.h +++ b/src/modules/tm/lock.h @@ -56,7 +56,6 @@ void lock_cleanup(void); int init_cell_lock(struct cell *cell); int init_entry_lock(struct s_table *ht, struct entry *entry); -int init_async_lock(struct cell *cell); int release_cell_lock(struct cell *cell); diff --git a/src/modules/tm/t_suspend.c b/src/modules/tm/t_suspend.c index 20807a5cfd..be7b0a6842 100644 --- a/src/modules/tm/t_suspend.c +++ b/src/modules/tm/t_suspend.c @@ -41,13 +41,8 @@ #include "../../core/data_lump_rpl.h" -#ifdef ENABLE_ASYNC_MUTEX -#define LOCK_ASYNC_CONTINUE(_t) lock(&(_t)->async_mutex ) -#define UNLOCK_ASYNC_CONTINUE(_t) unlock(&(_t)->async_mutex ) -#else #define LOCK_ASYNC_CONTINUE(_t) LOCK_REPLIES(_t) #define UNLOCK_ASYNC_CONTINUE(_t) UNLOCK_REPLIES(_t) -#endif /* Suspends the transaction for later use. * Save the returned hash_index and label to get

4 years, 7 months

[kamailio/kamailio] download error on repos (#2082)

by nicoonline

Hello, Is there any problems on the repo's server ? (1/6): kamailio-5.2.4-6.el6.x86_64.rpm | 5.5 MB 00:00 http://download.opensuse.org/repositories/home%3A/kamailio%3A/v5.2.x-rpms/C…: [Errno -1] Package does not match intended download. Suggestion: run yum --enablerepo=home_kamailio_v5.2.x-rpms clean metadata Trying other mirror. http://download.opensuse.org/repositories/home%3A/kamailio%3A/v5.2.x-rpms/C…: [Errno 14] PYCURL ERROR 22 - "The requested URL returned error: 416 Requested Range Not Satisfiable" Trying other mirror. (3/6): kamailio-http_client-5.2.4-6.el6.x86_64.rpm | 68 kB 00:00 http://download.opensuse.org/repositories/home%3A/kamailio%3A/v5.2.x-rpms/C…: [Errno -1] Package does not match intended download. Suggestion: run yum --enablerepo=home_kamailio_v5.2.x-rpms clean metadata Trying other mirror. (4/6): kamailio-jansson-5.2.4-6.el6.x86_64.rpm | 90 kB 00:00 http://download.opensuse.org/repositories/home%3A/kamailio%3A/v5.2.x-rpms/C…: [Errno -1] Package does not match intended download. Suggestion: run yum --enablerepo=home_kamailio_v5.2.x-rpms clean metadata Trying other mirror. http://download.opensuse.org/repositories/home%3A/kamailio%3A/v5.2.x-rpms/C…: [Errno 14] PYCURL ERROR 22 - "The requested URL returned error: 416 Requested Range Not Satisfiable" Trying other mirror. http://download.opensuse.org/repositories/home%3A/kamailio%3A/v5.2.x-rpms/C…: [Errno 14] PYCURL ERROR 22 - "The requested URL returned error: 416 Requested Range Not Satisfiable" Trying other mirror. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2082

4 years, 7 months

git:master:a37f3fe8: Merge pull request #2083 from amessina/master

by GitHub

Module: kamailio Branch: master Commit: a37f3fe8e2c93adcbeaa91ace8b3bff6abc29ff5 URL: https://github.com/kamailio/kamailio/commit/a37f3fe8e2c93adcbeaa91ace8b3bff… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-09-30T08:36:40+02:00 Merge pull request #2083 from amessina/master kamctl: Update dbtextdb.py for Python3 --- Modified: utils/kamctl/dbtextdb/dbtextdb.py --- Diff: https://github.com/kamailio/kamailio/commit/a37f3fe8e2c93adcbeaa91ace8b3bff… Patch: https://github.com/kamailio/kamailio/commit/a37f3fe8e2c93adcbeaa91ace8b3bff…

4 years, 7 months

git:master:a44ade38: kamctl: Update dbtextdb.py for Python3

by Anthony Messina

Module: kamailio Branch: master Commit: a44ade38dc420d2699896930ededf54645837a22 URL: https://github.com/kamailio/kamailio/commit/a44ade38dc420d2699896930ededf54… Author: Anthony Messina <amessina(a)messinet.com> Committer: Anthony Messina <amessina(a)messinet.com> Date: 2019-09-29T11:09:26-05:00 kamctl: Update dbtextdb.py for Python3 - reported by GH #1747 --- Modified: utils/kamctl/dbtextdb/dbtextdb.py --- Diff: https://github.com/kamailio/kamailio/commit/a44ade38dc420d2699896930ededf54… Patch: https://github.com/kamailio/kamailio/commit/a44ade38dc420d2699896930ededf54…

4 years, 7 months

git:master:635cdbc1: lib: add missing debug output for srdb1, db_do_submit_query

by Henning Westerholt

Module: kamailio Branch: master Commit: 635cdbc17abd0d213cc0065dcbbb22f1c73ce61b URL: https://github.com/kamailio/kamailio/commit/635cdbc17abd0d213cc0065dcbbb22f… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-29T23:48:44+02:00 lib: add missing debug output for srdb1, db_do_submit_query --- Modified: src/lib/srdb1/db_query.c --- Diff: https://github.com/kamailio/kamailio/commit/635cdbc17abd0d213cc0065dcbbb22f… Patch: https://github.com/kamailio/kamailio/commit/635cdbc17abd0d213cc0065dcbbb22f… --- diff --git a/src/lib/srdb1/db_query.c b/src/lib/srdb1/db_query.c index 8510999aba..d2319446a6 100644 --- a/src/lib/srdb1/db_query.c +++ b/src/lib/srdb1/db_query.c @@ -69,6 +69,7 @@ static inline int db_do_submit_query(const db1_con_t* _h, const str *_query, } } + LM_DBG("submitted query: %.*s, result %d\n", _query->len, _query->s, ret); return ret; }

4 years, 7 months

git:master:671fc87c: modules: readme files regenerated - usrloc ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 671fc87ccd345f56e74a87e3ff599912631dcef3 URL: https://github.com/kamailio/kamailio/commit/671fc87ccd345f56e74a87e3ff59991… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-09-29T23:16:42+02:00 modules: readme files regenerated - usrloc ... [skip ci] --- Modified: src/modules/usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/671fc87ccd345f56e74a87e3ff59991… Patch: https://github.com/kamailio/kamailio/commit/671fc87ccd345f56e74a87e3ff59991… --- diff --git a/src/modules/usrloc/README b/src/modules/usrloc/README index fdf6b6f18b..ff466b0e78 100644 --- a/src/modules/usrloc/README +++ b/src/modules/usrloc/README @@ -1002,11 +1002,11 @@ modparam("usrloc", "rm_expired_delay", 30) 3.47. server_id_filter (int) Enable (1) or disable (0) filter records by server_id on load and - during cleaning of expired db records. It could be usefull when you - want to use the same location table for several kamailio instances - which are configured to work in db_mode=1 or db_mode=2 (cache modes). - Otherwise one instance of proxy cleans records made by another proxy - and that breaks its cache. + during cleaning of expired db records. It could be useful when you want + to use the same location table for several kamailio instances which are + configured to work in db_mode=1 or db_mode=2 (cache modes). Otherwise + one instance of proxy cleans records made by another proxy and that + breaks its cache. Default value is “0”.

4 years, 7 months

git:master:98e1eabc: tls: spelling fix in comments (usefull -> useful)

by Henning Westerholt

Module: kamailio Branch: master Commit: 98e1eabc676639b7e739d8641e3fa80f3c5b56dd URL: https://github.com/kamailio/kamailio/commit/98e1eabc676639b7e739d8641e3fa80… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-29T23:15:40+02:00 tls: spelling fix in comments (usefull -> useful) --- Modified: src/modules/tls/README.TLS --- Diff: https://github.com/kamailio/kamailio/commit/98e1eabc676639b7e739d8641e3fa80… Patch: https://github.com/kamailio/kamailio/commit/98e1eabc676639b7e739d8641e3fa80… --- diff --git a/src/modules/tls/README.TLS b/src/modules/tls/README.TLS index ef3a2ea1f5..3313c7f636 100644 --- a/src/modules/tls/README.TLS +++ b/src/modules/tls/README.TLS @@ -84,7 +84,7 @@ Copyright modification in Makefile.defs. The Makefile.defs file is where the library and include paths are set (where to locate Openssl) Read more on this below on the "external libraries" dependencies. - The cfg.XXX patch provide configuration features from the ser.cfg file, usefull and necessary. + The cfg.XXX patch provide configuration features from the ser.cfg file, useful and necessary. This core module has been compiled successfully with ser branch rel_0_9_0 (updated as of June 2005, ser-0.9.3). It should compile in HEAD too without problem. It has been tested for functionality (successfully) with rel_0_9_0 (ser-0.9.0).

4 years, 7 months

git:master:8d729f0d: usrloc: spelling fix in comments (usefull -> useful)

by Henning Westerholt

Module: kamailio Branch: master Commit: 8d729f0d218d84c0850ade47e5dbe28ba54a5c98 URL: https://github.com/kamailio/kamailio/commit/8d729f0d218d84c0850ade47e5dbe28… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-29T23:15:31+02:00 usrloc: spelling fix in comments (usefull -> useful) --- Modified: src/modules/usrloc/doc/usrloc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8d729f0d218d84c0850ade47e5dbe28… Patch: https://github.com/kamailio/kamailio/commit/8d729f0d218d84c0850ade47e5dbe28… --- diff --git a/src/modules/usrloc/doc/usrloc_admin.xml b/src/modules/usrloc/doc/usrloc_admin.xml index 3dd180b937..0f14209784 100644 --- a/src/modules/usrloc/doc/usrloc_admin.xml +++ b/src/modules/usrloc/doc/usrloc_admin.xml @@ -1202,7 +1202,7 @@ modparam("usrloc", "rm_expired_delay", 30) <title><varname>server_id_filter</varname> (int)</title> <para> Enable (1) or disable (0) filter records by server_id on load and during cleaning of expired db records. - It could be usefull when you want to use the same location table for several kamailio instances which are configured to work in db_mode=1 or db_mode=2 (cache modes). + It could be useful when you want to use the same location table for several kamailio instances which are configured to work in db_mode=1 or db_mode=2 (cache modes). Otherwise one instance of proxy cleans records made by another proxy and that breaks its cache. </para> <para>

4 years, 7 months

← Newer
1
...
8
9
10
11
12
13
14
...
37
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2019