sr-dev July 2019

sr-dev@lists.kamailio.org

20 participants
234 discussions

git:master:77b1b52f: uac: new modparam reg_gc_interval
by Daniel-Constantin Mierla 02 Jul '19

02 Jul '19

Module: kamailio Branch: master Commit: 77b1b52fee7939ec1fcd04952d34649569c7233d URL: https://github.com/kamailio/kamailio/commit/77b1b52fee7939ec1fcd04952d34649… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-07-02T18:30:48+02:00 uac: new modparam reg_gc_interval - defined value for garbage collection interval made configurable - default value 150 (secs) - what was so far --- Modified: src/modules/uac/uac.c Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/77b1b52fee7939ec1fcd04952d34649… Patch: https://github.com/kamailio/kamailio/commit/77b1b52fee7939ec1fcd04952d34649… --- diff --git a/src/modules/uac/uac.c b/src/modules/uac/uac.c index 53a1b13cdf..217d1628ab 100644 --- a/src/modules/uac/uac.c +++ b/src/modules/uac/uac.c @@ -107,6 +107,7 @@ static void mod_destroy(void); static int child_init(int rank); extern int reg_timer_interval; +extern int _uac_reg_gc_interval; static pv_export_t mod_pvs[] = { { {"uac_req", sizeof("uac_req")-1}, PVT_OTHER, pv_get_uac_req, pv_set_uac_req, @@ -170,6 +171,7 @@ static param_export_t params[] = { {"reg_keep_callid", INT_PARAM, &reg_keep_callid }, {"reg_random_delay", INT_PARAM, &reg_random_delay }, {"reg_active", INT_PARAM, &reg_active_param }, + {"reg_gc_interval", INT_PARAM, &_uac_reg_gc_interval }, {0, 0, 0} }; diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index f75c7cf38a..dfc595f020 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -58,9 +58,10 @@ #define UAC_REG_INIT (1<<4) /* registration initialized */ #define MAX_UACH_SIZE 2048 -#define UAC_REG_GC_INTERVAL 150 #define UAC_REG_TM_CALLID_SIZE 90 +int _uac_reg_gc_interval = 150; + typedef struct _reg_uac { unsigned int h_uuid; @@ -423,9 +424,10 @@ int uac_reg_ht_shift(void) tn = time(NULL); lock_get(_reg_htable_gc_lock); - if(_reg_htable_gc->stime > tn-UAC_REG_GC_INTERVAL) { + if(_reg_htable_gc->stime > tn - _uac_reg_gc_interval) { lock_release(_reg_htable_gc_lock); - LM_ERR("shifting the memory table is not possible in less than %d secs\n", UAC_REG_GC_INTERVAL); + LM_ERR("shifting in-memory table is not possible in less than %d secs\n", + _uac_reg_gc_interval); return -1; } uac_reg_reset_ht_gc(); @@ -1224,7 +1226,7 @@ void uac_reg_timer(unsigned int ticks) { lock_get(_reg_htable_gc_lock); if(_reg_htable_gc->stime!=0 - && _reg_htable_gc->stime < tn - UAC_REG_GC_INTERVAL) + && _reg_htable_gc->stime < tn - _uac_reg_gc_interval) uac_reg_reset_ht_gc(); lock_release(_reg_htable_gc_lock); }

1 0

[kamailio/kamailio] uac module documentation should be honor s: prefix for kamcmd (#1988)
by Karsten Horsmann 01 Jul '19

01 Jul '19

Many sr-users seems to have the same problem with the documentation of uac module for requesting the actuall state of upstream sip-registrations. ### Description kamcmd uac.reg_enable auth_username 12345678 Not working kamcmd uac.reg_enable auth_username s:12345678 Working ### Expected behavior Documentation should meantion the kamcmd s: prefix for converting - in the examples. Meanfull if you are using a mysql-db. Dont testet all backends that are possible. https://lists.kamailio.org/pipermail/sr-users/2019-June/105993.html https://lists.kamailio.org/pipermail/sr-users/2017-August/098168.html #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio -v version: kamailio 5.2.3 (x86_64/linux) c36229 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c36229 compiled on 11:28:11 May 22 2019 with gcc 4.8. ``` * **Operating System**: ``` lsb_release -a LSB Version: :core-4.1-amd64:core-4.1-noarch Distributor ID: CentOS Description: CentOS Linux release 7.6.1810 (Core) Release: 7.6.1810 Codename: Core ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1988

2 2

git:master:ec42a0b3: uac: docs - examples with rpc commands having params numbers converted to string
by Daniel-Constantin Mierla 01 Jul '19

01 Jul '19

Module: kamailio Branch: master Commit: ec42a0b36a10dec0852bd1ef2bf3ad7ab9ad8dbc URL: https://github.com/kamailio/kamailio/commit/ec42a0b36a10dec0852bd1ef2bf3ad7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-07-01T17:31:09+02:00 uac: docs - examples with rpc commands having params numbers converted to string - GH #1988 --- Modified: src/modules/uac/doc/uac_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ec42a0b36a10dec0852bd1ef2bf3ad7… Patch: https://github.com/kamailio/kamailio/commit/ec42a0b36a10dec0852bd1ef2bf3ad7… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index 6e514eeea1..e4971191a8 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -1113,6 +1113,7 @@ event_route[uac:reply] { <programlisting format="linespecific"> ... kamcmd uac.reg_info l_uuid account123 + kamcmd uac.reg_info l_uuid s:12345678 ... </programlisting> </example> @@ -1134,6 +1135,7 @@ event_route[uac:reply] { <programlisting format="linespecific"> ... kamcmd uac.reg_enable l_uuid account123 + kamcmd uac.reg_enable l_uuid s:12345678 ... </programlisting> </example> @@ -1155,6 +1157,7 @@ event_route[uac:reply] { <programlisting format="linespecific"> ... kamcmd uac.reg_disable l_uuid account123 + kamcmd uac.reg_disable l_uuid s:12345678 ... </programlisting> </example> @@ -1191,6 +1194,7 @@ event_route[uac:reply] { <programlisting format="linespecific"> ... kamcmd uac.reg_refresh account123 + kamcmd uac.reg_refresh s:12345678 ... </programlisting> </example>

1 0

[kamailio/kamailio] uri.param and param.value error when last character is delimiter (#1991)
by geejay101 01 Jul '19

01 Jul '19

### Description I am trying to extract a parameter with transformations from an URI in Kamailio 5.2.3, Centos 7 The problem occurs with uri.param and param.value transformation when the last character of the input string is the separator. I such case an error is thrown and no parameter value can be received. The code should be fixed so that empty parameters are simply skipped. # Example $var(someuri) = "sip:2660926042@23.26.41.95:65485;app-id=7537263245341023;"; # error with uri.param $var(appid) = $(var(someuri){uri.param,app-id}); # another error with param.value $var(appid) = $(var(someuri){param.value,app-id}); error: "Param name missing after ;" The problem is here where an error is thrown for zero length params: https://github.com/kamailio/kamailio/blob/master/src/core/parser/parse_para… if(_s->len == 0) { LM_ERR("Param name missing after %c\n", separator); goto error; } -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1991

2 4

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2019