sr-dev July 2019

sr-dev@lists.kamailio.org

20 participants
232 discussions

git:master:6a13f5f1: rtp_media_server: fix crash in sdp payload pasring

by Julien Chavanton

Module: kamailio Branch: master Commit: 6a13f5f1103e02ec6abd5fc6b4f77ca9087ce43b URL: https://github.com/kamailio/kamailio/commit/6a13f5f1103e02ec6abd5fc6b4f77ca… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-07-08T19:46:06Z rtp_media_server: fix crash in sdp payload pasring --- Modified: src/modules/rtp_media_server/rms_sdp.c --- Diff: https://github.com/kamailio/kamailio/commit/6a13f5f1103e02ec6abd5fc6b4f77ca… Patch: https://github.com/kamailio/kamailio/commit/6a13f5f1103e02ec6abd5fc6b4f77ca… --- diff --git a/src/modules/rtp_media_server/rms_sdp.c b/src/modules/rtp_media_server/rms_sdp.c index b243d1ec45..c313d13646 100644 --- a/src/modules/rtp_media_server/rms_sdp.c +++ b/src/modules/rtp_media_server/rms_sdp.c @@ -240,9 +240,7 @@ PayloadType *rms_sdp_check_payload_type(PayloadType *pt, rms_sdp_info_t *sdp) // } else if (pt->type == 18) { // pt->mime_type=rms_char_dup("g729", 1); // } - if (pt->mime_type) - return pt; - return NULL; + return pt; } PayloadType *rms_sdp_select_payload(rms_sdp_info_t *sdp) @@ -256,7 +254,7 @@ PayloadType *rms_sdp_select_payload(rms_sdp_info_t *sdp) while (payload_type_number) { pt->type = atoi(payload_type_number); pt = rms_sdp_check_payload_type(pt, sdp); - if (pt) return pt; + if (pt->mime_type) return pt; payload_type_number = strtok(NULL, " "); } if (!pt->mime_type) {

4 years, 10 months

git:master:675ab2da: rtp_media_server: drop in-dialog messages for

by Julien Chavanton

Module: kamailio Branch: master Commit: 675ab2daf819eb1eb1639e90ceba2cc3b29ab202 URL: https://github.com/kamailio/kamailio/commit/675ab2daf819eb1eb1639e90ceba2cc… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-07-08T19:45:10Z rtp_media_server: drop in-dialog messages for disconnected calls --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/675ab2daf819eb1eb1639e90ceba2cc… Patch: https://github.com/kamailio/kamailio/commit/675ab2daf819eb1eb1639e90ceba2cc… --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 47d5ffdc07..37ddb1b998 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -1072,7 +1072,15 @@ static int rms_sip_request_f(struct sip_msg *msg) LM_NOTICE("initial INVITE\n"); return 1; } else { - LM_NOTICE("in dialog message\n"); + LM_NOTICE("in dialog message, state [%d]\n", di->state); + if (di->state == RMS_ST_DISCONNECTING) { + return -1; // ignore in dialog message in this state + } else if (di->state == RMS_ST_DISCONNECTED) { + rms_create_trans(msg); + if (!tmb.t_reply(msg, 481, "Call/Transaction Does Not Exist")) + return -1; + return 1; + } } rms_sip_forward(di, msg, method);

4 years, 10 months

git:master:5e9e991c: kemix: added functions to get proto string and id

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5e9e991cb11c85ad5cf6b72802728a42d70edd4e URL: https://github.com/kamailio/kamailio/commit/5e9e991cb11c85ad5cf6b72802728a4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-07-08T17:28:46+02:00 kemix: added functions to get proto string and id --- Modified: src/modules/kemix/kemix_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/5e9e991cb11c85ad5cf6b72802728a4… Patch: https://github.com/kamailio/kamailio/commit/5e9e991cb11c85ad5cf6b72802728a4… --- diff --git a/src/modules/kemix/kemix_mod.c b/src/modules/kemix/kemix_mod.c index aef7fc75d1..fd27d47fca 100644 --- a/src/modules/kemix/kemix_mod.c +++ b/src/modules/kemix/kemix_mod.c @@ -450,6 +450,38 @@ static sr_kemi_xval_t* ki_kx_get_rcvport(sip_msg_t *msg) return &_sr_kemi_kx_xval; } +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_proto(sip_msg_t *msg) +{ + memset(&_sr_kemi_kx_xval, 0, sizeof(sr_kemi_xval_t)); + if(msg==NULL) { + sr_kemi_xval_null(&_sr_kemi_kx_xval, SR_KEMI_XVAL_NULL_EMPTY); + return &_sr_kemi_kx_xval; + } + + _sr_kemi_kx_xval.vtype = SR_KEMIP_STR; + if(get_valid_proto_string(msg->rcv.proto, 0, 0, &_sr_kemi_kx_xval.v.s)<0) { + sr_kemi_xval_null(&_sr_kemi_kx_xval, SR_KEMI_XVAL_NULL_EMPTY); + } + + return &_sr_kemi_kx_xval; +} + +/** + * + */ +static int ki_kx_get_protoid(sip_msg_t *msg) +{ + if(msg==NULL) { + return -1; + } + + _sr_kemi_kx_xval.vtype = SR_KEMIP_STR; + return (int)msg->rcv.proto; +} + /** * */ @@ -570,6 +602,16 @@ static sr_kemi_t sr_kemi_kx_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("kx"), str_init("get_proto"), + SR_KEMIP_XVAL, ki_kx_get_proto, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("kx"), str_init("get_protoid"), + SR_KEMIP_INT, ki_kx_get_protoid, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

4 years, 10 months

Kamailio new in devel for upcoming 5.3.0

by Henning Westerholt

Hello, I have updated the "new in devel" features document in our wiki. Pretty amazing stuff already in for the upcoming 5.3.0: * 5 new modules * Changes in 32 existing modules * Many changes in core, API refactoring and tools * About 1000 commits from 62 authors (development still ongoing!) Full list at: https://www.kamailio.org/wiki/features/new-in-devel A summary can be found in my today talk at COMMCON, slides 10,11: https://skalatan.de/de/archiv/presentations/commcon-2019-presentation.pdf Cheers, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://skalatan.de/services

4 years, 10 months

[kamailio/kamailio] Can anyone help me understanding basic SIP system? (#2002)

by mevanso01

I'm struggling to implement voice/video call to real phone number on website. If I use a SIP account of any VoIP provider as callee, will it be possible to call to phone number which is not registered to any SIP account? I hope someone help me on this issue. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2002

4 years, 10 months

[kamailio/kamailio] Update README (#1999)

by eddiemos

Remove unnecessary quotation marks in the examples.   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1999 -- Commit Summary -- * Update README -- File Changes -- M src/modules/usrloc/README (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1999.patch https://github.com/kamailio/kamailio/pull/1999.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1999

4 years, 10 months

git:master:91fa799e: usrloc: coherence for int type of parameters

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 91fa799e436de252e9f5aa5d8f09609f46db6e58 URL: https://github.com/kamailio/kamailio/commit/91fa799e436de252e9f5aa5d8f09609… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-07-06T09:00:06+02:00 usrloc: coherence for int type of parameters - it was combination of int and integer, now all int - fix examples for int params, related to GH #1999 --- Modified: src/modules/usrloc/doc/usrloc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/91fa799e436de252e9f5aa5d8f09609… Patch: https://github.com/kamailio/kamailio/commit/91fa799e436de252e9f5aa5d8f09609…

4 years, 10 months

git:master:d0919a00: uac: docs - note about frequency limit for rpc reload command

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d0919a004b3bab58c47d9842fc77c19c5a8fed31 URL: https://github.com/kamailio/kamailio/commit/d0919a004b3bab58c47d9842fc77c19… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-07-05T13:22:03+02:00 uac: docs - note about frequency limit for rpc reload command --- Modified: src/modules/uac/doc/uac_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d0919a004b3bab58c47d9842fc77c19… Patch: https://github.com/kamailio/kamailio/commit/d0919a004b3bab58c47d9842fc77c19… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index 097609f13f..d9fe2a1de2 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -1193,7 +1193,10 @@ event_route[uac:reply] { <function moreinfo="none">uac.reg_reload</function> </title> <para> - Reload the records from database for remote registrations. + Reload the records from database for remote registrations. There is + a limit of how often the reload command can be executed, by default + is 150 seconds between reloads -- see the reg_gc_interval parameter + for more details. </para> <example> <title><function>uac.reg_reload</function> usage</title>

4 years, 10 months

Question about connecting to rtpproxy , rtpengine and new LRE_Proxy module

by Mojtaba

Hello, In both rtpproxy and rtpengine modules, they use SOCK_DGRAM type to connect to their sockets. At some lines below, they use connect command to connect to RTP proxy,too. Why they use this command "connect" while their socket type are connectionless? Another question is at send_rtpp_command function, when both module want to send command to RTPProxy, why they create another stream socket (AF_LOCAL)? fd = socket(AF_LOCAL, SOCK_STREAM, 0); These question have raised because in LRE module which i have been developing on it, i need to found out the LRE module can't connect to LRE_Proxy. Actually when i want to send a command to LRE_Proxy with "write" command which it's socket had disconnected before, I didn't get any error! I have faced with this problem. It's strange why in both rtpengine and rtpproxy modules it works! do { len = writev(fd, v + 1, vcnt - 1); } while (len == -1 && errno == EINTR); if (len <= 0) { close(fd); LM_ERR("can't send command to a RTP proxy\n"); goto badproxy; } Would you please help me. With Best Regards. -- --Mojtaba Esfandiari.S

4 years, 10 months

git:5.2:c23ea82a: acc: extend description in docs for log_missed_calls flag

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: c23ea82a80c3e66a11b3c1f0bb0ea22e0e7985bb URL: https://github.com/kamailio/kamailio/commit/c23ea82a80c3e66a11b3c1f0bb0ea22… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-07-03T22:10:36+02:00 acc: extend description in docs for log_missed_calls flag (cherry picked from commit f7f3222ec03b2a1e9260a79e737cc55c7dac169f) --- Modified: src/modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c23ea82a80c3e66a11b3c1f0bb0ea22… Patch: https://github.com/kamailio/kamailio/commit/c23ea82a80c3e66a11b3c1f0bb0ea22… --- diff --git a/src/modules/acc/doc/acc_admin.xml b/src/modules/acc/doc/acc_admin.xml index a0d0710ccb..48e8c6ac31 100644 --- a/src/modules/acc/doc/acc_admin.xml +++ b/src/modules/acc/doc/acc_admin.xml @@ -688,6 +688,14 @@ modparam("acc", "log_flag", 2) <title><varname>log_missed_flag</varname> (integer)</title> <para> Request flag which needs to be set to account missed calls via syslog. + This can be used to e.g. account failures during the call setup phase + from the callee side, for example if you do forking to several + destinations. + </para> + <para> + Keep in mind that this flag is reset after processing. Therefore it is + necessary to set it again e.g. in a failure_route if you do serial + forking and want to log all attempts. </para> <para> Default value is not-set (no flag).

4 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2019