sr-dev July 2019

sr-dev@lists.kamailio.org

20 participants
232 discussions

[kamailio/kamailio] TCP ACK is going to different IP then original invite sent (#1998)

by Surendra Tiwari

### Description We are converting udp call to tcp call in kamailio. kamailio sending out an invite to a destination. Before sending, kamailio resolving that destination domain to IP. After receiving invite request, Destination send 180 and 200 OK . 200 Ok contact contains the domain name of destination. After this kamailio forward those request to next route. kamailio recieved the ack from upstream. After reciving the ack from upstream it resolves again the domain name to different IP, as domain name have 2 IP's behind.  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1998

5 years, 5 months

git:5.2:f9caee58: usrloc: fix memory leak on DB_ONLY mode on RPC commands

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: f9caee5851bfafe195ebf009bd6a51051394c7d5 URL: https://github.com/kamailio/kamailio/commit/f9caee5851bfafe195ebf009bd6a510… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-07-02T21:42:39+02:00 usrloc: fix memory leak on DB_ONLY mode on RPC commands (cherry picked from commit b97bb77265e7bfc5562a664e8a510692ed68b2f8) --- Modified: src/modules/usrloc/ul_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/f9caee5851bfafe195ebf009bd6a510… Patch: https://github.com/kamailio/kamailio/commit/f9caee5851bfafe195ebf009bd6a510… --- diff --git a/src/modules/usrloc/ul_rpc.c b/src/modules/usrloc/ul_rpc.c index 53031799ac..0277bd9595 100644 --- a/src/modules/usrloc/ul_rpc.c +++ b/src/modules/usrloc/ul_rpc.c @@ -421,6 +421,7 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) if (rpc->add(ctx, "{", &th) < 0) { + release_urecord(rec); unlock_udomain(dom, &aor); rpc->fault(ctx, 500, "Internal error creating outer rpc"); return; @@ -429,6 +430,7 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) "AoR", &aor, "Contacts", &ih)<0) { + release_urecord(rec); unlock_udomain(dom, &aor); rpc->fault(ctx, 500, "Internal error creating aor struct"); return; @@ -439,12 +441,13 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) if (VALID_CONTACT( con, act_time)) { rpl_tree++; if (rpc_dump_contact(rpc, ctx, ih, con) == -1) { + release_urecord(rec); unlock_udomain(dom, &aor); return; } } } - + release_urecord(rec); unlock_udomain( dom, &aor); if (rpl_tree==0) { @@ -533,17 +536,20 @@ static void ul_rpc_rm_contact(rpc_t* rpc, void* ctx) ret = get_ucontact( rec, &contact, &rpc_ul_cid, &rpc_ul_path, RPC_UL_CSEQ+1, &con); if (ret < 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 500, "Internal error (can't get contact)"); return; } if (ret > 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 404, "Contact not found"); return; } if (delete_ucontact(rec, con) < 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 500, "Internal error (can't delete contact)"); return;

5 years, 5 months

git:5.1:61b9f621: usrloc: fix memory leak on DB_ONLY mode on RPC commands

by Henning Westerholt

Module: kamailio Branch: 5.1 Commit: 61b9f621223c782a0710c7c589ebee9550b398f7 URL: https://github.com/kamailio/kamailio/commit/61b9f621223c782a0710c7c589ebee9… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-07-02T21:42:49+02:00 usrloc: fix memory leak on DB_ONLY mode on RPC commands (cherry picked from commit b97bb77265e7bfc5562a664e8a510692ed68b2f8) --- Modified: src/modules/usrloc/ul_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/61b9f621223c782a0710c7c589ebee9… Patch: https://github.com/kamailio/kamailio/commit/61b9f621223c782a0710c7c589ebee9… --- diff --git a/src/modules/usrloc/ul_rpc.c b/src/modules/usrloc/ul_rpc.c index b5522994d4..1398d9be2c 100644 --- a/src/modules/usrloc/ul_rpc.c +++ b/src/modules/usrloc/ul_rpc.c @@ -421,6 +421,7 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) if (rpc->add(ctx, "{", &th) < 0) { + release_urecord(rec); unlock_udomain(dom, &aor); rpc->fault(ctx, 500, "Internal error creating outer rpc"); return; @@ -429,6 +430,7 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) "AoR", &aor, "Contacts", &ih)<0) { + release_urecord(rec); unlock_udomain(dom, &aor); rpc->fault(ctx, 500, "Internal error creating aor struct"); return; @@ -439,12 +441,13 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) if (VALID_CONTACT( con, act_time)) { rpl_tree++; if (rpc_dump_contact(rpc, ctx, ih, con) == -1) { + release_urecord(rec); unlock_udomain(dom, &aor); return; } } } - + release_urecord(rec); unlock_udomain( dom, &aor); if (rpl_tree==0) { @@ -533,17 +536,20 @@ static void ul_rpc_rm_contact(rpc_t* rpc, void* ctx) ret = get_ucontact( rec, &contact, &rpc_ul_cid, &rpc_ul_path, RPC_UL_CSEQ+1, &con); if (ret < 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 500, "Internal error (can't get contact)"); return; } if (ret > 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 404, "Contact not found"); return; } if (delete_ucontact(rec, con) < 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 500, "Internal error (can't delete contact)"); return;

5 years, 5 months

[kamailio/kamailio] usrloc: fix memory leak on DB_ONLY mode on RPC commands (#1996)

by Victor Seva

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally #### Description  release_urecord() needs to be called in order to clean ucontacts created on get_urecord() when mode is DB_ONLY You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1996 -- Commit Summary -- * usrloc: fix memory leak on DB_ONLY mode on RPC commands -- File Changes -- M src/modules/usrloc/ul_rpc.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1996.patch https://github.com/kamailio/kamailio/pull/1996.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1996

5 years, 5 months

git:master:b97bb772: usrloc: fix memory leak on DB_ONLY mode on RPC commands

by Henning Westerholt

Module: kamailio Branch: master Commit: b97bb77265e7bfc5562a664e8a510692ed68b2f8 URL: https://github.com/kamailio/kamailio/commit/b97bb77265e7bfc5562a664e8a51069… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-07-02T21:41:59+02:00 usrloc: fix memory leak on DB_ONLY mode on RPC commands --- Modified: src/modules/usrloc/ul_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/b97bb77265e7bfc5562a664e8a51069… Patch: https://github.com/kamailio/kamailio/commit/b97bb77265e7bfc5562a664e8a51069… --- diff --git a/src/modules/usrloc/ul_rpc.c b/src/modules/usrloc/ul_rpc.c index 3afad823d9..0f87230697 100644 --- a/src/modules/usrloc/ul_rpc.c +++ b/src/modules/usrloc/ul_rpc.c @@ -421,6 +421,7 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) if (rpc->add(ctx, "{", &th) < 0) { + release_urecord(rec); unlock_udomain(dom, &aor); rpc->fault(ctx, 500, "Internal error creating outer rpc"); return; @@ -429,6 +430,7 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) "AoR", &aor, "Contacts", &ih)<0) { + release_urecord(rec); unlock_udomain(dom, &aor); rpc->fault(ctx, 500, "Internal error creating aor struct"); return; @@ -439,12 +441,13 @@ static void ul_rpc_lookup(rpc_t* rpc, void* ctx) if (VALID_CONTACT( con, act_time)) { rpl_tree++; if (rpc_dump_contact(rpc, ctx, ih, con) == -1) { + release_urecord(rec); unlock_udomain(dom, &aor); return; } } } - + release_urecord(rec); unlock_udomain( dom, &aor); if (rpl_tree==0) { @@ -533,17 +536,20 @@ static void ul_rpc_rm_contact(rpc_t* rpc, void* ctx) ret = get_ucontact( rec, &contact, &rpc_ul_cid, &rpc_ul_path, RPC_UL_CSEQ+1, &con); if (ret < 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 500, "Internal error (can't get contact)"); return; } if (ret > 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 404, "Contact not found"); return; } if (delete_ucontact(rec, con) < 0) { + release_urecord(rec); unlock_udomain( dom, &aor); rpc->fault(ctx, 500, "Internal error (can't delete contact)"); return;

5 years, 5 months

new child module for kamailio, is call "lre"

by Mojtaba

Hello Everyone, In the middle of developing hiops module, another child module has grown up. I've been developing another module for Kamailio, I called this "lre". It means light-rtp-engine. The concept of this module is using the capability of linux-Kernel packet forwarding to forward RTP packets between both parties in a session call. As far as we know, this new way has some advantage in large VoIP networks that are using Kamailio as Proxy or SBC. Regardless of transcoding, it could be done by other servers, By using this module, Kamailio could handle a lot of concurrent calls with RTP. For example in my test-bed scenario, with 2 core of CPU, Kamailio could handle more than 1000 concurrent calls, with no issue like one-way audio or etc. The consumption of resources was incredible. Although I countn't finish the test-bed scenario, because the resources of SIPP servers, that make the calls, were run out. When kamailio starts, this module tries to connect to daemon project. The daemon project could be running on the same server with kamailio or on another server. The connection between two processes is TCP/IP Socket. I have to use libnfnetlink library to control Linux-kernel forwarding on the server. This library is the low-level library for netfilter related kernel/userspace communication. Some configuration in kamailio cfg is like below: #!ifdef WITH_LRE modparam("lre", "lre_sock", "tcp:192.168.122.108:8080") modparam("lre", "start_port", 10000) modparam("lre", "end_port", 30000) #!endif In some parts of my code, I need some guides to optimize performance of my code. The module will be published soon on GitHub, but for some reason I need to remove my old pull-request of hiops module.I will publish it again. -- --Mojtaba Esfandiari.S

5 years, 5 months

[kamailio/kamailio] After commit ce8d36f latency_limit_db requires us instead of ms (#1956)

by Marco Capetta

Long time ago I have added in the configuration: latency_limit_db=500 After the upgrade from version 5.1.7 to version 5.1.8, kamailio started printing a lot of log lines related to db slow query: <core> [db_query.c:68]: db_do_submit_query(): alert - query execution too long [1136 us] <core> [db_query.c:68]: db_do_submit_query(): alert - query execution too long [914 us] <core> [db_query.c:68]: db_do_submit_query(): alert - query execution too long [741 us] <core> [db_query.c:68]: db_do_submit_query(): alert - query execution too long [621 us] It seems that after the upgrade the latency_limit_db parameter configuration changed from milliseconds to microseconds. Here the commit that probably caused the issue: https://github.com/kamailio/kamailio/commit/ce8d36f301d7688255597a67693e47d… If a fix is released, please backport it till 5.1 branch. Thank you. Marco -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1956

5 years, 5 months

git:master:bf0bafd1: uac: docs for reg_gc_interval param

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: bf0bafd1e63de3427ae7b411eb26fe8bb95eec26 URL: https://github.com/kamailio/kamailio/commit/bf0bafd1e63de3427ae7b411eb26fe8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-07-02T18:37:00+02:00 uac: docs for reg_gc_interval param --- Modified: src/modules/uac/doc/uac_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/bf0bafd1e63de3427ae7b411eb26fe8… Patch: https://github.com/kamailio/kamailio/commit/bf0bafd1e63de3427ae7b411eb26fe8… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index e4971191a8..097609f13f 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -537,6 +537,31 @@ modparam("uac", "reg_active", 0) </example> </section> + <section id="uac.p.reg_gc_interval"> + <title><varname>reg_gc_interval</varname> (int)</title> + <para> + Timer interval (in seconds) at which remote registrations are cleaned + up in case of failure or removed. When setting it take in consideration + the maximum value for retransmission timeout, this param should be greater + than it. This value also impacts how ofter the reload for remote + registrations table can be executed -- the RPC command will fail if + executed in less than reg_gc_interval value since the last reload. + </para> + <para> + <emphasis> + The default value is 150 seconds. + </emphasis> + </para> + + <example> + <title>Set <varname>reg_gc_interval</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("uac", "reg_gc_interval", 60) +... + </programlisting> + </example> + </section> </section>

5 years, 5 months

git:master:77b1b52f: uac: new modparam reg_gc_interval

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 77b1b52fee7939ec1fcd04952d34649569c7233d URL: https://github.com/kamailio/kamailio/commit/77b1b52fee7939ec1fcd04952d34649… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-07-02T18:30:48+02:00 uac: new modparam reg_gc_interval - defined value for garbage collection interval made configurable - default value 150 (secs) - what was so far --- Modified: src/modules/uac/uac.c Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/77b1b52fee7939ec1fcd04952d34649… Patch: https://github.com/kamailio/kamailio/commit/77b1b52fee7939ec1fcd04952d34649… --- diff --git a/src/modules/uac/uac.c b/src/modules/uac/uac.c index 53a1b13cdf..217d1628ab 100644 --- a/src/modules/uac/uac.c +++ b/src/modules/uac/uac.c @@ -107,6 +107,7 @@ static void mod_destroy(void); static int child_init(int rank); extern int reg_timer_interval; +extern int _uac_reg_gc_interval; static pv_export_t mod_pvs[] = { { {"uac_req", sizeof("uac_req")-1}, PVT_OTHER, pv_get_uac_req, pv_set_uac_req, @@ -170,6 +171,7 @@ static param_export_t params[] = { {"reg_keep_callid", INT_PARAM, &reg_keep_callid }, {"reg_random_delay", INT_PARAM, &reg_random_delay }, {"reg_active", INT_PARAM, &reg_active_param }, + {"reg_gc_interval", INT_PARAM, &_uac_reg_gc_interval }, {0, 0, 0} }; diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index f75c7cf38a..dfc595f020 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -58,9 +58,10 @@ #define UAC_REG_INIT (1<<4) /* registration initialized */ #define MAX_UACH_SIZE 2048 -#define UAC_REG_GC_INTERVAL 150 #define UAC_REG_TM_CALLID_SIZE 90 +int _uac_reg_gc_interval = 150; + typedef struct _reg_uac { unsigned int h_uuid; @@ -423,9 +424,10 @@ int uac_reg_ht_shift(void) tn = time(NULL); lock_get(_reg_htable_gc_lock); - if(_reg_htable_gc->stime > tn-UAC_REG_GC_INTERVAL) { + if(_reg_htable_gc->stime > tn - _uac_reg_gc_interval) { lock_release(_reg_htable_gc_lock); - LM_ERR("shifting the memory table is not possible in less than %d secs\n", UAC_REG_GC_INTERVAL); + LM_ERR("shifting in-memory table is not possible in less than %d secs\n", + _uac_reg_gc_interval); return -1; } uac_reg_reset_ht_gc(); @@ -1224,7 +1226,7 @@ void uac_reg_timer(unsigned int ticks) { lock_get(_reg_htable_gc_lock); if(_reg_htable_gc->stime!=0 - && _reg_htable_gc->stime < tn - UAC_REG_GC_INTERVAL) + && _reg_htable_gc->stime < tn - _uac_reg_gc_interval) uac_reg_reset_ht_gc(); lock_release(_reg_htable_gc_lock); }

5 years, 5 months

[kamailio/kamailio] uac module documentation should be honor s: prefix for kamcmd (#1988)

by Karsten Horsmann

Many sr-users seems to have the same problem with the documentation of uac module for requesting the actuall state of upstream sip-registrations. ### Description kamcmd uac.reg_enable auth_username 12345678 Not working kamcmd uac.reg_enable auth_username s:12345678 Working ### Expected behavior Documentation should meantion the kamcmd s: prefix for converting - in the examples. Meanfull if you are using a mysql-db. Dont testet all backends that are possible. https://lists.kamailio.org/pipermail/sr-users/2019-June/105993.html https://lists.kamailio.org/pipermail/sr-users/2017-August/098168.html #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio -v version: kamailio 5.2.3 (x86_64/linux) c36229 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c36229 compiled on 11:28:11 May 22 2019 with gcc 4.8. ``` * **Operating System**: ``` lsb_release -a LSB Version: :core-4.1-amd64:core-4.1-noarch Distributor ID: CentOS Description: CentOS Linux release 7.6.1810 (Core) Release: 7.6.1810 Codename: Core ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1988

5 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2019