sr-dev February 2019

sr-dev@lists.kamailio.org

23 participants
336 discussions

Re: [sr-dev] [SR-Users] Repository for automatic deployment of Kamailio

by Henning Westerholt

Am Montag, 11. Februar 2019, 18:55:02 CET schrieb Gholamreza Sabery: > A few years ago, I developed an Ansible repository for automatic deployment > of Kamailio. Recently, I added some new features, and now you can deploy > the playbooks on Docker containers. I think it is a good starting point for > anyone who wants to deploy and use Kamailio for the first time. Link of the > repository: > > https://github.com/ghrst/Kamailio-HA Hello Gholamreza, sounds great, thank you for sharing. If you like you can add it it as a link to our wiki (https://www.kamailio.org/wiki/) maybe in the "Installation On containers" section. If you want to maintain and extend it in the future, we could even think off to add this as sub-repository to github kamailio. Maybe some of the other developers can share their opinion on this as well (add sr-dev on CC). Best regards, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://skalatan.de/services Kamailio security assessment - https://skalatan.de/de/assessment

5 years, 10 months

git:master:44e48809: core: log printed size, current token size and buffer size for pv printf overflow

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 44e48809a608d4de46d61198137cd669c6a4763f URL: https://github.com/kamailio/kamailio/commit/44e48809a608d4de46d61198137cd66… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-13T09:42:08+01:00 core: log printed size, current token size and buffer size for pv printf overflow --- Modified: src/core/pvapi.c --- Diff: https://github.com/kamailio/kamailio/commit/44e48809a608d4de46d61198137cd66… Patch: https://github.com/kamailio/kamailio/commit/44e48809a608d4de46d61198137cd66… --- diff --git a/src/core/pvapi.c b/src/core/pvapi.c index 23d70ba6df..59a76831e8 100644 --- a/src/core/pvapi.c +++ b/src/core/pvapi.c @@ -1434,7 +1434,8 @@ int pv_printf(struct sip_msg* msg, pv_elem_p list, char *buf, int *len) n += it->text.len; cur += it->text.len; } else { - LM_ERR("no more space for text [%d]\n", it->text.len); + LM_ERR("no more space for text value - printed:%d token:%d buffer:%d\n", + n, it->text.len, *len); goto overflow; } } @@ -1453,7 +1454,8 @@ int pv_printf(struct sip_msg* msg, pv_elem_p list, char *buf, int *len) cur += tok.rs.len; } } else { - LM_ERR("no more space for spec value\n"); + LM_ERR("no more space for spec value - printed:%d token:%d buffer:%d\n", + n, tok.rs.len, *len); goto overflow; } }

5 years, 10 months

git:master:a21ae6ea: topos: fix typos in the debug messages

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a21ae6ea14de0f7db2a66d806ecab4888dec0093 URL: https://github.com/kamailio/kamailio/commit/a21ae6ea14de0f7db2a66d806ecab48… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-12T23:49:08+01:00 topos: fix typos in the debug messages --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/a21ae6ea14de0f7db2a66d806ecab48… Patch: https://github.com/kamailio/kamailio/commit/a21ae6ea14de0f7db2a66d806ecab48… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index 897f3b675e..3bb5f12f46 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -346,7 +346,7 @@ int tps_pack_message(sip_msg_t *msg, tps_data_t *ptsd) i++; vlen = tps_skip_rw(via->name.s, via->bsize); if(ptsd->cp + vlen + 2 >= ptsd->cbuf + TPS_DATA_SIZE) { - LM_ERR("no more spage to pack via headers\n"); + LM_ERR("no more space to pack via headers\n"); return -1; } if(i>1) { @@ -393,7 +393,7 @@ int tps_pack_message(sip_msg_t *msg, tps_data_t *ptsd) for(rr =(rr_t*)hdr->parsed; rr; rr=rr->next) { i++; if(ptsd->cp + rr->nameaddr.uri.len + 4 >= ptsd->cbuf + TPS_DATA_SIZE) { - LM_ERR("no more spage to pack rr headers\n"); + LM_ERR("no more space to pack rr headers\n"); return -1; } if(isreq==1) {

5 years, 10 months

[kamailio/kamailio] Problem with CANCEL handling (#1841)

by alkorik

Hello, I'm trying to set up kamailio as a simple load balancer proxy between VOIP Providers and a cluster of asterisk servers. I have started with the default kamailio.cfg. At the end, i got this up and running, but with one exception: if incoming call is not answered by the asterisk end (i.e. it is in ringing state), and then the gateway sends CANCEL request, kamailio is unable to recognize the transaction and is not forwarding the request to asterisk. The result is: the call is left "dangling" in the PBX and is not properly hang up. I have call flow: Provider 214.22.198.51 -> Kamailio 38.149.172.163 -> Asterisk 38.149.172.164. **Log from Provider 214.22.198.51** Reliably Transmitting (no NAT) to 38.149.172.163:5060: INVITE sip:100@38.149.172.163:5060 SIP/2.0 Via: SIP/2.0/UDP 214.22.198.51:5060;branch=z9hG4bK7d220dff Max-Forwards: 70 From: "testaccount" <sip:123456@214.22.198.51>;tag=as5a9816e5 To: <sip:100@38.149.172.163:5060> Contact: <sip:123456@214.22.198.51:5060> Call-ID: 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060 CSeq: 102 INVITE User-Agent: Asterisk PBX 14.6.2 Date: Thu, 07 Feb 2019 10:45:15 GMT Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE Supported: replaces, timer Content-Type: application/sdp Content-Length: 310 v=0 o=root 610375704 610375704 IN IP4 214.22.198.51 s=Asterisk PBX 14.6.2 c=IN IP4 214.22.198.51 t=0 0 m=audio 13076 RTP/AVP 18 8 0 101 a=rtpmap:18 G729/8000 a=fmtp:18 annexb=no a=rtpmap:8 PCMA/8000 a=rtpmap:0 PCMU/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-16 a=maxptime:150 a=sendrecv --- -- Called SIP/kamailio/100 <--- SIP read from UDP:38.149.172.163:5060 ---> SIP/2.0 100 Trying Via: SIP/2.0/UDP 214.22.198.51:5060;branch=z9hG4bK7d220dff From: "testaccount" <sip:123456@214.22.198.51>;tag=as5a9816e5 To: <sip:100@38.149.172.163:5060> Call-ID: 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060 CSeq: 102 INVITE Server: kamailio (5.2.0 (x86_64/linux)) Content-Length: 0 <-------------> --- (8 headers 0 lines) --- <--- SIP read from UDP:38.149.172.163:5060 ---> SIP/2.0 100 Trying Via: SIP/2.0/UDP 214.22.198.51:5060;branch=z9hG4bK7d220dff From: "testaccount" <sip:123456@214.22.198.51>;tag=as5a9816e5 To: <sip:100@38.149.172.163:5060> Call-ID: 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060 CSeq: 102 INVITE Server: Asterisk PBX 16.1.1 Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE Supported: replaces, timer Session-Expires: 1800;refresher=uas Contact: <sip:100@38.149.172.164:5060> Content-Length: 0 <-------------> --- (12 headers 0 lines) --- <--- SIP read from UDP:38.149.172.163:5060 ---> SIP/2.0 180 Ringing Via: SIP/2.0/UDP 214.22.198.51:5060;branch=z9hG4bK7d220dff From: "testaccount" <sip:123456@214.22.198.51>;tag=as5a9816e5 To: <sip:100@38.149.172.163:5060>;tag=as14e62645 Call-ID: 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060 CSeq: 102 INVITE Server: Asterisk PBX 16.1.1 Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE Supported: replaces, timer Session-Expires: 1800;refresher=uas Contact: <sip:100@38.149.172.164:5060> Content-Length: 0 <-------------> --- (12 headers 0 lines) --- sip_route_dump: route/path hop: <sip:100@38.149.172.164:5060> -- SIP/kamailio-0007f2d9 is ringing Scheduling destruction of SIP dialog '0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060' in 32000 ms (Method: INVITE) Reliably Transmitting (no NAT) to 38.149.172.163:5060: CANCEL sip:100@38.149.172.163:5060 SIP/2.0 Via: SIP/2.0/UDP 214.22.198.51:5060;branch=z9hG4bK7d220dff Max-Forwards: 70 From: "testaccount" <sip:123456@214.22.198.51>;tag=as5a9816e5 To: <sip:100@38.149.172.163:5060> Call-ID: 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060 CSeq: 102 CANCEL User-Agent: Asterisk PBX 14.6.2 Content-Length: 0 **Kamailio 38.149.172.163** Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/udp_server.c:492]: udp_rcv_loop(): received on udp socket: (106/100/359) [[CANCEL sip:100@38.149.172.163:5060 SIP/2.0 0D 0A Via: SIP/2.0/UDP 214.22.198.51:5060;branch=z9hG4bK7d220d]] Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:610]: parse_msg(): SIP Request: Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:612]: parse_msg(): method: <CANCEL> Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:614]: parse_msg(): uri: <sip:100@38.149.172.163:5060> Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:616]: parse_msg(): version: <SIP/2.0> Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/parse_via.c:1303]: parse_via_param(): Found param type 232, <branch> = <z9hG4bK7d220dff>; state=16 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/parse_via.c:2639]: parse_via(): end of header reached, state=5 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:498]: parse_headers(): Via found, flags=2 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:500]: parse_headers(): this is the first via Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/parse_addr_spec.c:864]: parse_addr_spec(): end of header reached, state=10 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:171]: get_hdr_field(): <To> [31]; uri=[sip:100@38.149.172.163:5060] Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:174]: get_hdr_field(): to body [<sip:100@38.149.172.163:5060> Feb 7 12:45:20 kamailion-ser kamailio: ], to tag [] Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:152]: get_hdr_field(): cseq <CSeq>: <102> <CANCEL> Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/receive.c:245]: receive_msg(): --- received sip message - request - call-id: [0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060] - cseq: [102 CANCEL] Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:185]: get_hdr_field(): content_length=0 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: <core> [core/parser/msg_parser.c:89]: get_hdr_field(): found end of header Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/receive.c:295]: receive_msg(): preparing to run routing scripts... Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} maxfwd [mf_funcs.c:74]: is_maxfwd_present(): value = 70 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:247]: check_ruri_sip_version(): check_ruri_sip_version entered Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:270]: check_ruri_sip_version(): check_ruri_sip_version passed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:277]: check_ruri_scheme(): check_ruri_scheme entered Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:297]: check_ruri_scheme(): check_ruri_scheme passed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:305]: check_required_headers(): check_required_headers entered Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:313]: check_required_headers(): check_required_headers passed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:321]: check_via1_header(): check via1 header Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:479]: check_cseq_method(): check_cseq_method entered Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:512]: check_cseq_method(): check_cseq_method passed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:521]: check_cseq_value(): check_cseq_value entered Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:549]: check_cseq_value(): check_cseq_value passed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:558]: check_cl(): check_cl entered Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:583]: check_cl(): check_cl passed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:595]: check_expires_value(): check_expires_value entered Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:632]: check_expires_value(): no expires header found Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:728]: check_parse_uris(): check_parse_uris entered Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:732]: check_parse_uris(): parsing ruri Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:746]: check_parse_uris(): looking up From header Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:760]: check_parse_uris(): parsing From header Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/parser/parse_addr_spec.c:185]: parse_to_param(): add param: tag=as5a9816e5 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/parser/parse_addr_spec.c:864]: parse_addr_spec(): end of header reached, state=29 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:786]: check_parse_uris(): parsing From URI Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:804]: check_parse_uris(): looking up To header Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:826]: check_parse_uris(): check_parse_uris(): parsing To URI Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity.c:871]: check_parse_uris(): check_parse_uris passed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} sanity [sanity_mod.c:254]: w_sanity_check(): sanity checks result: 1 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} tm [t_lookup.c:712]: t_lookupOriginalT(): searching on hash entry 23780 Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} tm [t_lookup.c:436]: matching_3261(): RFC3261 transaction matching failed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} tm [t_lookup.c:802]: t_lookupOriginalT(): no CANCEL matching found! Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} tm [t_lookup.c:804]: t_lookupOriginalT(): lookup completed Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} tm [tm.c:1093]: ki_t_lookup_cancel_flags(): lookup_original: t_lookupOriginalT returned: (nil) Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/receive.c:353]: receive_msg(): request-route executed in: 220 usec Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/xavp.c:495]: xavp_destroy_list(): destroying xavp list (nil) Feb 7 12:45:20 kamailion-ser kamailio: 24(22599) DEBUG: {1 102 CANCEL 0891a0e9592a055f2828c0f00af09783@214.22.198.51:5060} <core> [core/receive.c:457]: receive_msg(): cleaning up kamailio -v version: kamailio 5.2.0 (x86_64/linux) 535e13 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 535e13 compiled on 01:27:51 Dec 16 2018 with gcc 4.8.5 How can i fix this? Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1841

5 years, 10 months

[kamailio/kamailio] registrar : check xavp clone result (#1844)

by lazedo

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  if xavp_clone fails it is still inserted leading to crash You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1844 -- Commit Summary -- * registrar : check xavp clone result -- File Changes -- M src/modules/registrar/lookup.c (31) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1844.patch https://github.com/kamailio/kamailio/pull/1844.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1844

5 years, 10 months

git:5.2:e2b5fcb6: registrar : check xavp clone result

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: e2b5fcb60ab633715524d44698a09abc9b126537 URL: https://github.com/kamailio/kamailio/commit/e2b5fcb60ab633715524d44698a09ab… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-12T09:52:12+01:00 registrar : check xavp clone result (cherry picked from commit adc4493fa6861895bdcf8b459e5fbc76e80d0f1f) --- Modified: src/modules/registrar/lookup.c --- Diff: https://github.com/kamailio/kamailio/commit/e2b5fcb60ab633715524d44698a09ab… Patch: https://github.com/kamailio/kamailio/commit/e2b5fcb60ab633715524d44698a09ab… --- diff --git a/src/modules/registrar/lookup.c b/src/modules/registrar/lookup.c index 84c0f40208..f012d690ab 100644 --- a/src/modules/registrar/lookup.c +++ b/src/modules/registrar/lookup.c @@ -394,7 +394,15 @@ int lookup_helper(struct sip_msg* _m, udomain_t* _d, str* _uri, int _mode) if(ptr->xavp!=NULL) { xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_insert(xavp, 0, NULL)<0) { + if(xavp != NULL) { + if(xavp_insert(xavp, 0, NULL)<0) { + LM_ERR("error inserting xavp after clone\n"); + xavp_destroy_list(&xavp); + ret = -3; + goto done; + } + } else { + LM_ERR("error cloning xavp\n"); ret = -3; goto done; } @@ -461,7 +469,15 @@ int lookup_helper(struct sip_msg* _m, udomain_t* _d, str* _uri, int _mode) } if(ptr->xavp!=NULL) { xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_insert(xavp, nr_branches, NULL)<0) { + if(xavp != NULL) { + if(xavp_insert(xavp, nr_branches, NULL)<0) { + LM_ERR("error inserting xavp after clone\n"); + xavp_destroy_list(&xavp); + ret = -3; + goto done; + } + } else { + LM_ERR("error cloning xavp\n"); ret = -3; goto done; } @@ -784,10 +800,15 @@ int registered4(struct sip_msg* _m, udomain_t* _d, str* _uri, int match_flag, if((ptr->xavp!=NULL) && (match_action_flag & 1)) { sr_xavp_t *xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_add(xavp, NULL)<0) { - LM_ERR("error adding xavp for %.*s after successful match\n", + if(xavp != NULL) { + if(xavp_add(xavp, NULL)<0) { + LM_ERR("error adding xavp for %.*s after successful match\n", + aor.len, ZSW(aor.s)); + xavp_destroy_list(&xavp); + } + } else { + LM_ERR("error cloning xavp for %.*s after successful match\n", aor.len, ZSW(aor.s)); - xavp_destroy_list(&xavp); } }

5 years, 10 months

git:5.1:878c23cb: registrar : check xavp clone result

by Henning Westerholt

Module: kamailio Branch: 5.1 Commit: 878c23cbef8d0d32035ed4f438c61da7a5ffc815 URL: https://github.com/kamailio/kamailio/commit/878c23cbef8d0d32035ed4f438c61da… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-12T09:52:19+01:00 registrar : check xavp clone result (cherry picked from commit adc4493fa6861895bdcf8b459e5fbc76e80d0f1f) --- Modified: src/modules/registrar/lookup.c --- Diff: https://github.com/kamailio/kamailio/commit/878c23cbef8d0d32035ed4f438c61da… Patch: https://github.com/kamailio/kamailio/commit/878c23cbef8d0d32035ed4f438c61da… --- diff --git a/src/modules/registrar/lookup.c b/src/modules/registrar/lookup.c index 84c0f40208..f012d690ab 100644 --- a/src/modules/registrar/lookup.c +++ b/src/modules/registrar/lookup.c @@ -394,7 +394,15 @@ int lookup_helper(struct sip_msg* _m, udomain_t* _d, str* _uri, int _mode) if(ptr->xavp!=NULL) { xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_insert(xavp, 0, NULL)<0) { + if(xavp != NULL) { + if(xavp_insert(xavp, 0, NULL)<0) { + LM_ERR("error inserting xavp after clone\n"); + xavp_destroy_list(&xavp); + ret = -3; + goto done; + } + } else { + LM_ERR("error cloning xavp\n"); ret = -3; goto done; } @@ -461,7 +469,15 @@ int lookup_helper(struct sip_msg* _m, udomain_t* _d, str* _uri, int _mode) } if(ptr->xavp!=NULL) { xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_insert(xavp, nr_branches, NULL)<0) { + if(xavp != NULL) { + if(xavp_insert(xavp, nr_branches, NULL)<0) { + LM_ERR("error inserting xavp after clone\n"); + xavp_destroy_list(&xavp); + ret = -3; + goto done; + } + } else { + LM_ERR("error cloning xavp\n"); ret = -3; goto done; } @@ -784,10 +800,15 @@ int registered4(struct sip_msg* _m, udomain_t* _d, str* _uri, int match_flag, if((ptr->xavp!=NULL) && (match_action_flag & 1)) { sr_xavp_t *xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_add(xavp, NULL)<0) { - LM_ERR("error adding xavp for %.*s after successful match\n", + if(xavp != NULL) { + if(xavp_add(xavp, NULL)<0) { + LM_ERR("error adding xavp for %.*s after successful match\n", + aor.len, ZSW(aor.s)); + xavp_destroy_list(&xavp); + } + } else { + LM_ERR("error cloning xavp for %.*s after successful match\n", aor.len, ZSW(aor.s)); - xavp_destroy_list(&xavp); } }

5 years, 10 months

git:master:f60b6e45: topos_redis: print expires value in log messages

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f60b6e45d2b2f14a89e51eebe56e2ae857481c90 URL: https://github.com/kamailio/kamailio/commit/f60b6e45d2b2f14a89e51eebe56e2ae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-11T23:53:56+01:00 topos_redis: print expires value in log messages --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/f60b6e45d2b2f14a89e51eebe56e2ae… Patch: https://github.com/kamailio/kamailio/commit/f60b6e45d2b2f14a89e51eebe56e2ae… --- diff --git a/src/modules/topos_redis/topos_redis_storage.c b/src/modules/topos_redis/topos_redis_storage.c index ed8a7616dc..47ddad0c1a 100644 --- a/src/modules/topos_redis/topos_redis_storage.c +++ b/src/modules/topos_redis/topos_redis_storage.c @@ -279,7 +279,7 @@ int tps_redis_insert_dialog(tps_data_t *td) } return -1; } - LM_DBG("expire set on dialog record for [%.*s] with argc %d\n", + LM_DBG("expire %lu set on dialog record for [%.*s] with argc %d\n", lval, rkey.len, rkey.s, argc); freeReplyObject(rrpl); @@ -390,7 +390,7 @@ int tps_redis_insert_invite_branch(tps_data_t *td) } return -1; } - LM_DBG("expire set on branch record for [%.*s] with argc %d\n", + LM_DBG("expire %lu set on branch record for [%.*s] with argc %d\n", lval, rkey.len, rkey.s, argc); freeReplyObject(rrpl); @@ -518,7 +518,7 @@ int tps_redis_insert_branch(tps_data_t *td) } return -1; } - LM_DBG("expire set on branch record for [%.*s] with argc %d\n", + LM_DBG("expire %lu set on branch record for [%.*s] with argc %d\n", lval, rkey.len, rkey.s, argc); freeReplyObject(rrpl); @@ -1418,7 +1418,7 @@ int tps_redis_end_dialog(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd) } return -1; } - LM_DBG("expire set on branch record for [%.*s] with argc %d\n", + LM_DBG("expire %lu set on dialog record for [%.*s] with argc %d\n", lval, rkey.len, rkey.s, argc); freeReplyObject(rrpl);

5 years, 10 months

git:master:adc4493f: registrar : check xavp clone result

by Henning Westerholt

Module: kamailio Branch: master Commit: adc4493fa6861895bdcf8b459e5fbc76e80d0f1f URL: https://github.com/kamailio/kamailio/commit/adc4493fa6861895bdcf8b459e5fbc7… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-02-11T22:04:58+01:00 registrar : check xavp clone result --- Modified: src/modules/registrar/lookup.c --- Diff: https://github.com/kamailio/kamailio/commit/adc4493fa6861895bdcf8b459e5fbc7… Patch: https://github.com/kamailio/kamailio/commit/adc4493fa6861895bdcf8b459e5fbc7… --- diff --git a/src/modules/registrar/lookup.c b/src/modules/registrar/lookup.c index 84c0f40208..f012d690ab 100644 --- a/src/modules/registrar/lookup.c +++ b/src/modules/registrar/lookup.c @@ -394,7 +394,15 @@ int lookup_helper(struct sip_msg* _m, udomain_t* _d, str* _uri, int _mode) if(ptr->xavp!=NULL) { xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_insert(xavp, 0, NULL)<0) { + if(xavp != NULL) { + if(xavp_insert(xavp, 0, NULL)<0) { + LM_ERR("error inserting xavp after clone\n"); + xavp_destroy_list(&xavp); + ret = -3; + goto done; + } + } else { + LM_ERR("error cloning xavp\n"); ret = -3; goto done; } @@ -461,7 +469,15 @@ int lookup_helper(struct sip_msg* _m, udomain_t* _d, str* _uri, int _mode) } if(ptr->xavp!=NULL) { xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_insert(xavp, nr_branches, NULL)<0) { + if(xavp != NULL) { + if(xavp_insert(xavp, nr_branches, NULL)<0) { + LM_ERR("error inserting xavp after clone\n"); + xavp_destroy_list(&xavp); + ret = -3; + goto done; + } + } else { + LM_ERR("error cloning xavp\n"); ret = -3; goto done; } @@ -784,10 +800,15 @@ int registered4(struct sip_msg* _m, udomain_t* _d, str* _uri, int match_flag, if((ptr->xavp!=NULL) && (match_action_flag & 1)) { sr_xavp_t *xavp = xavp_clone_level_nodata(ptr->xavp); - if(xavp_add(xavp, NULL)<0) { - LM_ERR("error adding xavp for %.*s after successful match\n", + if(xavp != NULL) { + if(xavp_add(xavp, NULL)<0) { + LM_ERR("error adding xavp for %.*s after successful match\n", + aor.len, ZSW(aor.s)); + xavp_destroy_list(&xavp); + } + } else { + LM_ERR("error cloning xavp for %.*s after successful match\n", aor.len, ZSW(aor.s)); - xavp_destroy_list(&xavp); } }

5 years, 10 months

git:master:e50a2e4a: modules: readme files regenerated - sl ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: e50a2e4a17902f26ef82d4e399a73f16e088161c URL: https://github.com/kamailio/kamailio/commit/e50a2e4a17902f26ef82d4e399a73f1… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-02-11T21:46:46+01:00 modules: readme files regenerated - sl ... [skip ci] --- Modified: src/modules/sl/README Modified: src/modules/tm/README Modified: src/modules/uac_redirect/README --- Diff: https://github.com/kamailio/kamailio/commit/e50a2e4a17902f26ef82d4e399a73f1… Patch: https://github.com/kamailio/kamailio/commit/e50a2e4a17902f26ef82d4e399a73f1…

5 years, 10 months

← Newer
1
...
19
20
21
22
23
24
25
...
34
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2019