sr-dev February 2019

sr-dev@lists.kamailio.org

23 participants
336 discussions

git:master:34fb47f2: sipt: $sipt(redirection_number) evaluates the value as a numerical value

by GitHub

Module: kamailio Branch: master Commit: 34fb47f28948e701c3ea98c673c8fb324b2f790e URL: https://github.com/kamailio/kamailio/commit/34fb47f28948e701c3ea98c673c8fb3… Author: Sergey Basov <sergey.v.basov(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-01-15T13:54:13+02:00 sipt: $sipt(redirection_number) evaluates the value as a numerical value sipt: $sipt(redirection_number) evaluates the value as a numerical value --- Modified: src/modules/sipt/ss7_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/34fb47f28948e701c3ea98c673c8fb3… Patch: https://github.com/kamailio/kamailio/commit/34fb47f28948e701c3ea98c673c8fb3… --- diff --git a/src/modules/sipt/ss7_parser.c b/src/modules/sipt/ss7_parser.c index 90ff897d01..4d390c8341 100644 --- a/src/modules/sipt/ss7_parser.c +++ b/src/modules/sipt/ss7_parser.c @@ -384,8 +384,8 @@ int isup_get_redirection_number(unsigned char *buf, int len, char* sb_buf) sbparamlen = (buf[offset+1] & 0xFF) - 2; while ((sbparamlen > 0) && (buf[offset] != 0)) { - sb_buf[sb_i]=(buf[offset+4+sb_j] & 0x0F) + '\x30'; - sb_buf[sb_i+1]=(buf[offset+4+sb_j]>>4 & 0x0F) + '\x30'; + sb_buf[sb_i]="0123456789ABCDEF"[(buf[offset+4+sb_j] & 0x0F)]; + sb_buf[sb_i+1]="0123456789ABCDEF"[(buf[offset+4+sb_j] >>4 & 0x0F)]; sb_i=sb_i+2; sbparamlen--; sb_j++;

5 years, 10 months

[kamailio/kamailio] Topos CRASH Kamailio-lb (#1842)

by marekche

### Description I'm using sipwise that uses kamailio v5.1.6. When I activate topos function, the service kamailio-lb crashed. ### Troubleshooting #### Reproduction  #### Debugging Data  ``` root@sipwise:/var/lib/systemd/coredump# gdb /usr/sbin/kamailio core.kamailio.114.e2e9f644da934aa79dee789c15ca82ec.9647.1548426648000000 GNU gdb (Debian 7.12-6) 7.12.0.20161007-git Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/sbin/kamailio...Reading symbols from /usr/lib/debug/.build-id/9f/2ba82048cf1a75e75010b612f547a8938b4aeb.debug...done. done. [New LWP 9647] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /run/kamailio/kamailio.lb.pid -f /etc/kamailio/lb/kamaili'. Program terminated with signal SIGABRT, Aborted. #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 51 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) backtrace #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 #1 0x00007f66d5aab42a in __GI_abort () at abort.c:89 #2 0x00007f66d5ae7c00 in __libc_message (do_abort=do_abort@entry=2, fmt=fmt@entry=0x7f66d5bdb305 "*** %s ***: %s terminated\n") at ../sysdeps/posix/libc_fatal.c:175 #3 0x00007f66d5b701f7 in __GI___fortify_fail (msg=msg@entry=0x7f66d5bdb29c "buffer overflow detected") at fortify_fail.c:30 #4 0x00007f66d5b6e330 in __GI___chk_fail () at chk_fail.c:28 #5 0x00007f66b867e097 in memcpy (__len=<optimized out>, __src=<optimized out>, __dest=0x7f66b8892524 <_tps_redis_cbuf+4>) at /usr/include/x86_64-linux-gnu/bits/string3.h:53 #6 tps_redis_load_branch (msg=<optimized out>, md=<optimized out>, sd=0x7ffed3993d30, mode=<optimized out>) at topos_redis_storage.c:744 #7 0x00007f66b88b35c0 in tps_request_received (msg=msg@entry=0x7ffed3995f80, dialog=dialog@entry=1) at tps_msg.c:786 #8 0x00007f66b88b9255 in tps_msg_received (evp=<optimized out>) at topos_mod.c:332 #9 0x000055e1dc07da88 in sr_event_exec (type=<optimized out>, evp=<optimized out>) at core/events.c:211 #10 0x000055e1dc0415f5 in receive_msg ( buf=buf@entry=0x55e1dc511d40 <buf> "BYE sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5"..., len=381, rcv_info=rcv_info@entry=0x7ffed3996980) at core/receive.c:157 #11 0x000055e1dbf5e6e3 in udp_rcv_loop () at core/udp_server.c:554 #12 0x000055e1dbef3a9f in main_loop () at main.c:1619 #13 0x000055e1dbeea8cb in main (argc=<optimized out>, argv=0x7ffed3996f38) at main.c:2638 (gdb) bt full #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 set = {__val = {0, 3904965243653075002, 2314885530818457913, 2314885530818453536, 3395749441387372576, 6860733171187738988, 8679965255892022326, 7091318039360988973, 3329341198525361252, 7221018865173163891, 3256155514114093622, 3689070848804021815, 3276212736508309553, 3473172721157808240, 3472339519882145840, 2319698187989365536}} pid = <optimized out> tid = <optimized out> #1 0x00007f66d5aab42a in __GI_abort () at abort.c:89 save_stage = 2 act = {__sigaction_handler = {sa_handler = 0x343664363666372d, sa_sigaction = 0x343664363666372d}, sa_mask = {__val = {8606977229197423669, 3472328296226648109, 3475143045726351408, 3919881042301820976, 3472332715816543286, 3919317182990200112, 8223625903103882548, 3616443484039294253, 4207881715281047603, 4050479036606984240, 2314885530818453555, 2314885530818453536, 7795484802351636512, 3917909816998060649, 3276497845987585332, 140732448437520}}, sa_flags = 64, sa_restorer = 0x7ffed398f510} sigs = {__val = {32, 0 <repeats 15 times>}} #2 0x00007f66d5ae7c00 in __libc_message (do_abort=do_abort@entry=2, fmt=fmt@entry=0x7f66d5bdb305 "*** %s ***: %s terminated\n") at ../sysdeps/posix/libc_fatal.c:175 ap = {{gp_offset = 32, fp_offset = 0, overflow_arg_area = 0x7ffed398f520, reg_save_area = 0x7ffed398f4b0}} fd = 2 on_2 = <optimized out> list = <optimized out> nlist = <optimized out> cp = <optimized out> written = <optimized out> #3 0x00007f66d5b701f7 in __GI___fortify_fail (msg=msg@entry=0x7f66d5bdb29c "buffer overflow detected") at fortify_fail.c:30 No locals. #4 0x00007f66d5b6e330 in __GI___chk_fail () at chk_fail.c:28 No locals. #5 0x00007f66b867e097 in memcpy (__len=<optimized out>, __src=<optimized out>, __dest=0x7f66b8892524 <_tps_redis_cbuf+4>) at /usr/include/x86_64-linux-gnu/bits/string3.h:53 No locals. #6 tps_redis_load_branch (msg=<optimized out>, md=<optimized out>, sd=0x7ffed3993d30, mode=<optimized out>) at topos_redis_storage.c:744 argv = {0x0 <repeats 48 times>} argvlen = {0 <repeats 48 times>} argc = 0 rcmd = {s = 0x7f66b868b914 "HGETALL", len = 7} rkey = {s = 0x0, len = 0} rp = 0x7f66b8892520 <_tps_redis_cbuf> "b:x:INVITE:240827696@10.10.10.1:03D2CCF0-5C4B1D8B000137E9-D8ACC700" i = <optimized out> rsrv = 0x7f66d1b27108 rrpl = 0x0 skey = {s = 0x0, len = 0} sval = {s = 0x0, len = 0} xvbranch1 = 0x7ffed3991a08 id = {cbuf = '\000' <repeats 6224 times>..., cp = 0x4000000 <error: Cannot access memory at address 0x4000000>, a_uuid = { s = 0x3d47a30 <error: Cannot access memory at address 0x3d47a30>, len = 2090496}, b_uuid = { s = 0x2b85d0 <error: Cannot access memory at address 0x2b85d0>, len = 3688360}, a_callid = {s = 0x8 <error: Cannot access memory at address 0x8>, ---Type <return> to continue, or q <return> to quit--- len = 46}, a_rr = {s = 0x2a4d537a18c0e100 <error: Cannot access memory at address 0x2a4d537a18c0e100>, len = -775182280}, b_rr = { s = 0x55e1dc113a3f <qm_malloc+1215> "\353\"\017\037\200", len = 0}, s_rr = {s = 0x55e1dc1df604 "core", len = -601324824}, a_contact = { s = 0x44 <error: Cannot access memory at address 0x44>, len = 0}, b_contact = {s = 0x0, len = 0}, as_contact = {s = 0x7f66d1cba7f8 "", len = -775772584}, bs_contact = {s = 0x7ffed3995f80 "", len = -744941040}, a_tag = { s = 0x7ffed3991b40 "SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669", len = 10}, b_tag = { s = 0x55e1dc1898cd <parse_contacts+93> "H\205\300I\211\307\017\204\265$", len = 3688360}, a_uri = {s = 0x7f66d1cba800 "p\250\313\321f\177", len = 46}, b_uri = {s = 0x2a4d537a18c0e100 <error: Cannot access memory at address 0x2a4d537a18c0e100>, len = -775182400}, r_uri = { s = 0x55e1dc113a3f <qm_malloc+1215> "\353\"\017\037\200", len = 0}, a_srcaddr = {s = 0x55e1dc1df604 "core", len = -601323000}, b_srcaddr = { s = 0x53 <error: Cannot access memory at address 0x53>, len = 0}, a_socket = { s = 0x2a4d537a18c0e100 <error: Cannot access memory at address 0x2a4d537a18c0e100>, len = 0}, b_socket = {s = 0x7f66d1cba7f8 "", len = -775772584}, x_via1 = {s = 0x7ffed3995f80 "", len = 2}, x_via2 = {s = 0x7ffed3991b40 "SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669", len = 10}, x_vbranch1 = { s = 0x55e1dc18d034 <parse_contact+548> "\205\300y\300H\215=\305%\005", len = -598663560}, x_via = {s = 0x0, len = 0}, x_tag = { s = 0x2a4d537a18c0e100 <error: Cannot access memory at address 0x2a4d537a18c0e100>, len = 0}, x_rr = {s = 0x0, len = 0}, y_rr = { s = 0x7ffed3995f80 "", len = 2}, x_uri = {s = 0x2a4d537a18c0e100 <error: Cannot access memory at address 0x2a4d537a18c0e100>, len = 10}, s_method = { s = 0x7f66b88ac7e6 <tps_storage_link_msg+2262> "\203\370\002\017\216\207\374\377\377L\213%Jw!", len = 0}, s_cseq = {s = 0x0, len = 0}, iflags = 0, direction = 0, s_method_id = 0} __func__ = "tps_redis_load_branch" #7 0x00007f66b88b35c0 in tps_request_received (msg=msg@entry=0x7ffed3995f80, dialog=dialog@entry=1) at tps_msg.c:786 mtsd = {cbuf = "SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669", '\000' <repeats 8140 times>, cp = 0x7ffed3991b73 "", a_uuid = { s = 0x55e1dc511d48 <buf+8> "atpsh-5c4b0f6e-25b2-9(a)10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1D8B0"..., len = 21}, b_uuid = {s = 0x0, len = 0}, a_callid = { s = 0x55e1dc511e2b <buf+235> "240827696(a)10.10.10.1\r\nCSeq: 21 BYE\r\nContact: <sip:2972426338@10.10.10.1:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Synway/5.3.2.1\r\nContent-Length: 0\r\n\r\n", len = 20}, a_rr = {s = 0x0, len = 0}, b_rr = {s = 0x0, len = 0}, s_rr = {s = 0x0, len = 0}, a_contact = { s = 0x55e1dc511e59 <buf+281> "sip:2972426338@10.10.10.1:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Synway/5.3.2.1\r\nContent-Length: 0\r\n\r\n", len = 30}, b_contact = {s = 0x0, len = 0}, as_contact = {s = 0x0, len = 0}, bs_contact = {s = 0x0, len = 0}, a_tag = { s = 0x55e1dc511dd2 <buf+146> "3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1D8B000137E9-D8ACC700\r\nCall-ID: 240827696(a)10.10.10.1\r\nCSeq: 21 BYE\r\nContact: <sip:2972426338@10.10.10.1:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Sy"..., len = 10}, b_tag = { s = 0x55e1dc511dfe <buf+190> "03D2CCF0-5C4B1D8B000137E9-D8ACC700\r\nCall-ID: 240827696(a)10.10.10.1\r\nCSeq: 21 BYE\r\nContact: <sip:2972426338@10.10.10.1:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Synway/5.3.2.1\r\nContent-Length: 0\r\n\r\n", len = 34}, a_uri = {s = 0x0, len = 0}, b_uri = {s = 0x0, len = 0}, r_uri = {s = 0x0, len = 0}, a_srcaddr = {s = 0x0, len = 0}, b_srcaddr = {s = 0x0, len = 0}, a_socket = {s = 0x0, len = 0}, b_socket = {s = 0x0, len = 0}, x_via1 = {s = 0x7ffed3991b40 "SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669", len = 51}, x_via2 = {s = 0x0, len = 0}, x_vbranch1 = { s = 0x7ffed3991b63 "z9hG4bK898122669", len = 16}, x_via = {s = 0x0, len = 0}, x_tag = { s = 0x55e1dc511dd2 <buf+146> "3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1D8B000137E9-D8ACC700\r\nCall-ID: 240827696(a)10.10.10.1\r\nCSeq: 21 BYE\r\nContact: <sip:2972426338@10.10.10.1:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Sy"..., len = 10}, x_rr = {s = 0x0, len = 0}, y_rr = {s = 0x0, len = 0}, x_uri = {s = 0x0, len = 0}, s_method = { s = 0x55e1dc511e4a <buf+266> "BYE\r\nContact: <sip:2972426338@10.10.10.1:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Synway/5.3.2.1\r\nContent-Length: 0\r\n\r\n", len = 3}, s_cseq = { s = 0x55e1dc511e47 <buf+263> "21 BYE\r\nContact: <sip:2972426338@10.10.10.1:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Synway/5.3.2.1\r\nContent-Length: 0\r\n\r\n", len = 2}, iflags = 0, direction = 0, s_method_id = 8} stsd = {cbuf = '\000' <repeats 8191 times>, cp = 0x0, a_uuid = {s = 0x0, len = 0}, b_uuid = {s = 0x0, len = 0}, a_callid = {s = 0x0, len = 0}, a_rr = { s = 0x0, len = 0}, b_rr = {s = 0x0, len = 0}, s_rr = {s = 0x0, len = 0}, a_contact = {s = 0x0, len = 0}, b_contact = {s = 0x0, len = 0}, as_contact = { s = 0x0, len = 0}, bs_contact = {s = 0x0, len = 0}, a_tag = {s = 0x0, len = 0}, b_tag = {s = 0x0, len = 0}, a_uri = {s = 0x0, len = 0}, b_uri = { s = 0x0, len = 0}, r_uri = {s = 0x0, len = 0}, a_srcaddr = {s = 0x0, len = 0}, b_srcaddr = {s = 0x0, len = 0}, a_socket = {s = 0x0, len = 0}, b_socket = {s = 0x0, len = 0}, x_via1 = {s = 0x0, len = 0}, x_via2 = {s = 0x0, len = 0}, x_vbranch1 = {s = 0x0, len = 0}, x_via = {s = 0x0, len = 0}, x_tag = {s = 0x0, len = 0}, x_rr = {s = 0x0, len = 0}, y_rr = {s = 0x0, len = 0}, x_uri = {s = 0x0, len = 0}, s_method = {s = 0x0, len = 0}, s_cseq = { ---Type <return> to continue, or q <return> to quit--- s = 0x0, len = 0}, iflags = 0, direction = 0, s_method_id = 0} lkey = { s = 0x55e1dc511e2b <buf+235> "240827696(a)10.10.10.1\r\nCSeq: 21 BYE\r\nContact: <sip:2972426338@10.10.10.1:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Synway/5.3.2.1\r\nContent-Length: 0\r\n\r\n", len = 20} nuri = {s = 0x0, len = 0} direction = 0 ret = <optimized out> use_branch = 0 __func__ = "tps_request_received" #8 0x00007f66b88b9255 in tps_msg_received (evp=<optimized out>) at topos_mod.c:332 msg = {id = 0, pid = 0, tval = {tv_sec = 0, tv_usec = 0}, fwd_send_flags = {f = 0, blst_imask = 0}, rpl_send_flags = {f = 0, blst_imask = 0}, first_line = {type = 1, flags = 1, len = 50, u = {request = {method = { s = 0x55e1dc511d40 <buf> "BYE sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5"..., len = 3}, uri = { s = 0x55e1dc511d44 <buf+4> "sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1"..., len = 36}, version = { s = 0x55e1dc511d69 <buf+41> "SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1D8B000137E9-D8ACC700\r\nCall-ID: 240827"..., len = 7}, method_value = 8}, reply = {version = { s = 0x55e1dc511d40 <buf> "BYE sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5"..., len = 3}, status = { s = 0x55e1dc511d44 <buf+4> "sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1"..., len = 36}, reason = { s = 0x55e1dc511d69 <buf+41> "SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1D8B000137E9-D8ACC700\r\nCall-ID: 240827"..., len = 7}, statuscode = 8}}}, via1 = 0x7f66d1d04488, via2 = 0x0, headers = 0x7f66d1c2a0b8, last_header = 0x7f66d1cba478, parsed_flag = 18446744073709551615, h_via1 = 0x7f66d1c2a0b8, h_via2 = 0x0, callid = 0x7f66d1d04868, to = 0x7f66d1d04728, cseq = 0x7f66d1c2a518, from = 0x7f66d1d04680, contact = 0x7f66d1c2a658, maxforwards = 0x7f66d1c2a700, route = 0x0, record_route = 0x0, content_type = 0x0, content_length = 0x7f66d1cba478, authorization = 0x0, expires = 0x0, proxy_auth = 0x0, supported = 0x0, require = 0x0, proxy_require = 0x0, unsupported = 0x0, allow = 0x0, event = 0x0, accept = 0x0, accept_language = 0x0, organization = 0x0, priority = 0x0, subject = 0x0, user_agent = 0x7f66d1cba3d0, server = 0x0, content_disposition = 0x0, diversion = 0x0, rpid = 0x0, refer_to = 0x0, session_expires = 0x0, min_se = 0x0, sipifmatch = 0x0, subscription_state = 0x0, date = 0x0, identity = 0x0, identity_info = 0x0, pai = 0x0, ppi = 0x0, path = 0x0, privacy = 0x0, min_expires = 0x0, body = 0x0, eoh = 0x55e1dc511ebb <buf+379> "\r\n", unparsed = 0x55e1dc511ebb <buf+379> "\r\n", rcv = {src_ip = {af = 0, len = 0, u = {addrl = {0, 0}, addr32 = {0, 0, 0, 0}, addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, addr = '\000' <repeats 15 times>}}, dst_ip = {af = 0, len = 0, u = {addrl = {0, 0}, addr32 = {0, 0, 0, 0}, addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, addr = '\000' <repeats 15 times>}}, src_port = 0, dst_port = 0, proto_reserved1 = 0, proto_reserved2 = 0, src_su = {s = {sa_family = 0, sa_data = '\000' <repeats 13 times>}, sin = {sin_family = 0, sin_port = 0, sin_addr = {s_addr = 0}, sin_zero = "\000\000\000\000\000\000\000"}, sin6 = {sin6_family = 0, sin6_port = 0, sin6_flowinfo = 0, sin6_addr = {__in6_u = {__u6_addr8 = '\000' <repeats 15 times>, __u6_addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, bind_address = 0x0, proto = 0 '\000'}, buf = 0x55e1dc511d40 <buf> "BYE sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5"..., len = 381, new_uri = {s = 0x0, len = 0}, dst_uri = {s = 0x0, len = 0}, parsed_uri_ok = 1, parsed_uri = {user = { s = 0x55e1dc511d48 <buf+8> "atpsh-5c4b0f6e-25b2-9(a)10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1D8B0"..., len = 21}, passwd = {s = 0x0, len = 0}, host = { s = 0x55e1dc511d5e <buf+30> "10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5C4B1D8B000137E9-D8ACC700\r\nCall"..., len = 10}, port = {s = 0x0, len = 0}, params = {s = 0x0, len = 0}, sip_params = {s = 0x0, len = 0}, headers = {s = 0x0, len = 0}, port_no = 0, proto = 0, type = SIP_URI_T, flags = (unknown: 0), transport = {s = 0x0, ---Type <return> to continue, or q <return> to quit--- len = 0}, ttl = {s = 0x0, len = 0}, user_param = {s = 0x0, len = 0}, maddr = {s = 0x0, len = 0}, method = {s = 0x0, len = 0}, lr = {s = 0x0, len = 0}, r2 = {s = 0x0, len = 0}, gr = {s = 0x0, len = 0}, transport_val = {s = 0x0, len = 0}, ttl_val = {s = 0x0, len = 0}, user_param_val = { s = 0x0, len = 0}, maddr_val = {s = 0x0, len = 0}, method_val = {s = 0x0, len = 0}, lr_val = {s = 0x0, len = 0}, r2_val = {s = 0x0, len = 0}, gr_val = {s = 0x0, len = 0}}, parsed_orig_ruri_ok = 0, parsed_orig_ruri = {user = {s = 0x0, len = 0}, passwd = {s = 0x0, len = 0}, host = {s = 0x0, len = 0}, port = {s = 0x0, len = 0}, params = {s = 0x0, len = 0}, sip_params = {s = 0x0, len = 0}, headers = {s = 0x0, len = 0}, port_no = 0, proto = 0, type = ERROR_URI_T, flags = (unknown: 0), transport = {s = 0x0, len = 0}, ttl = {s = 0x0, len = 0}, user_param = {s = 0x0, len = 0}, maddr = {s = 0x0, len = 0}, method = {s = 0x0, len = 0}, lr = {s = 0x0, len = 0}, r2 = {s = 0x0, len = 0}, gr = {s = 0x0, len = 0}, transport_val = { s = 0x0, len = 0}, ttl_val = {s = 0x0, len = 0}, user_param_val = {s = 0x0, len = 0}, maddr_val = {s = 0x0, len = 0}, method_val = {s = 0x0, len = 0}, lr_val = {s = 0x0, len = 0}, r2_val = {s = 0x0, len = 0}, gr_val = {s = 0x0, len = 0}}, add_rm = 0x0, body_lumps = 0x0, reply_lump = 0x0, add_to_branch_s = '\000' <repeats 57 times>, add_to_branch_len = 0, hash_index = 0, msg_flags = 0, flags = 0, set_global_address = {s = 0x0, len = 0}, set_global_port = {s = 0x0, len = 0}, force_send_socket = 0x0, path_vec = {s = 0x0, len = 0}, instance = {s = 0x0, len = 0}, reg_id = 0, ruid = { s = 0x0, len = 0}, location_ua = {s = 0x0, len = 0}, ldv = {flow = {decoded = 0, rcv = {src_ip = {af = 0, len = 0, u = {addrl = {0, 0}, addr32 = {0, 0, 0, 0}, addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, addr = '\000' <repeats 15 times>}}, dst_ip = {af = 0, len = 0, u = {addrl = {0, 0}, addr32 = { 0, 0, 0, 0}, addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, addr = '\000' <repeats 15 times>}}, src_port = 0, dst_port = 0, proto_reserved1 = 0, proto_reserved2 = 0, src_su = {s = {sa_family = 0, sa_data = '\000' <repeats 13 times>}, sin = {sin_family = 0, sin_port = 0, sin_addr = { s_addr = 0}, sin_zero = "\000\000\000\000\000\000\000"}, sin6 = {sin6_family = 0, sin6_port = 0, sin6_flowinfo = 0, sin6_addr = {__in6_u = { __u6_addr8 = '\000' <repeats 15 times>, __u6_addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, bind_address = 0x0, proto = 0 '\000'}}}} obuf = 0x7ffed3996760 nbuf = 0x0 dialog = <optimized out> ret = 0 __func__ = "tps_msg_received" #9 0x000055e1dc07da88 in sr_event_exec (type=<optimized out>, evp=<optimized out>) at core/events.c:211 ret = 0 #10 0x000055e1dc0415f5 in receive_msg ( buf=buf@entry=0x55e1dc511d40 <buf> "BYE sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5"..., len=381, rcv_info=rcv_info@entry=0x7ffed3996980) at core/receive.c:157 msg = <optimized out> ctx = {rec_lev = 0, run_flags = 0, last_retcode = 1, jmp_env = {{__jmpbuf = {140732448466864, 404251807625349706, 140079583580320, 140079583296384, 904, 0, -404875561808065974, -5881834129312609718}, __mask_was_saved = 0, __saved_mask = {__val = {140079190344920, 140079190344872, 140079190344872, 140079190344904, 140079190344904, 4402341479424, 4410931414018, 140079570933248, 0, 140079583502920, 94428548119103, 0, 94428548953604, 94428549057192, 13, 17179869184}}}}} bctx = <optimized out> ret = <optimized out> tvb = {tv_sec = 0, tv_usec = 0} tve = {tv_sec = 280375465083135, tv_usec = 0} tz = {tz_minuteswest = 0, tz_dsttime = 0} diff = 0 inb = { s = 0x55e1dc511d40 <buf> "BYE sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5"..., len = 381} netinfo = {data = {s = 0xff00000000ff <error: Cannot access memory at address 0xff00000000ff>, len = 0}, rcv = 0x5b5b5b5b5b5b5b5b, dst = 0x5b5b5b5b5b5b5b5b} keng = 0x0 ---Type <return> to continue, or q <return> to quit--- evp = {data = 0x7ffed3996760, rcv = 0x7ffed3996980, dst = 0x0} errsipmsg = 0 __func__ = "receive_msg" #11 0x000055e1dbf5e6e3 in udp_rcv_loop () at core/udp_server.c:554 len = 381 buf = "BYE sip:atpsh-5c4b0f6e-25b2-9@10.10.10.2 SIP/2.0\r\nVia: SIP/2.0/UDP 10.10.10.1:5060;branch=z9hG4bK898122669\r\nFrom: <sip:2972426338@10.10.10.1>;tag=3296734298\r\nTo: <sip:414533@10.10.10.2>;tag=03D2CCF0-5"... from = <optimized out> fromlen = 16 ri = {src_ip = {af = 2, len = 4, u = {addrl = {206175865354, 140732448467576}, addr32 = {17435146, 48, 3550046840, 32766}, addr16 = {2570, 266, 48, 0, 27256, 54169, 32766, 0}, addr = "\n\n\n\001\060\000\000\000xj\231\323\376\177\000"}}, dst_ip = {af = 2, len = 4, u = {addrl = {34212362, 0}, addr32 = {34212362, 0, 0, 0}, addr16 = {2570, 522, 0, 0, 0, 0, 0, 0}, addr = "\n\n\n\002", '\000' <repeats 11 times>}}, src_port = 5060, dst_port = 5060, proto_reserved1 = 0, proto_reserved2 = 0, src_su = {s = {sa_family = 2, sa_data = "\023\304\n\n\n\001\000\000\000\000\000\000\000"}, sin = {sin_family = 2, sin_port = 50195, sin_addr = {s_addr = 17435146}, sin_zero = "\000\000\000\000\000\000\000"}, sin6 = {sin6_family = 2, sin6_port = 50195, sin6_flowinfo = 17435146, sin6_addr = {__in6_u = {__u6_addr8 = '\000' <repeats 15 times>, __u6_addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, bind_address = 0x7f66d1b05a38, proto = 1 '\001'} evp = {data = 0x0, rcv = 0x0, dst = 0x0} printbuf = '\000' <repeats 48 times>, "\005\000\000\000\000\000\000\000\000\341\300\030zSM*\005\000\000\000\000\000\000\000(_\262\321f\177\000\000\005\000\000\000\000\000\000\000\005\000\000\000\000\000\000\000\005\000\000\000\000\000\000\000\363\033\351\320f\177\000\000-\000\000\000\000\000\000\000\000\341\300\030zSM*-\000\000\000\000\000\000\000Z\035\351\320f\177\000\000\005\000\000\000\000\000\000\000\005\000\000\000\000\000\000\000\005\000\000\000\000\000\000\000\005\000\000\000\000\000\000\000\005\000\000\000\000\000\000\000\005\000\000\000\000\000\000\000\005\000\000\000\000\000\000\000"... i = <optimized out> j = <optimized out> __func__ = "udp_rcv_loop" #12 0x000055e1dbef3a9f in main_loop () at main.c:1619 i = <optimized out> pid = <optimized out> si = <optimized out> si_desc = "udp receiver child=4 sock=10.10.10.2:5060\000\000\000\001\000\000\000X\252!\334\341U\000\000\000\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\063\000\000\000\000\000\000\000#\000\000\000\000\000\000\000\000\341\300\030zSM*\000\000\000\000\000\000\000\000\000\341\300\030zSM*\250\351\\\334\341U\000\000\001\000\000\000\000\000\000" nrprocs = <optimized out> woneinit = <optimized out> __func__ = "main_loop" #13 0x000055e1dbeea8cb in main (argc=<optimized out>, argv=0x7ffed3996f38) at main.c:2638 cfg_stream = <optimized out> c = <optimized out> r = <optimized out> tmp = 0x7ffed3998ec6 "" tmp_len = -709000473 port = 32614 proto = 1700966438 options = 0x55e1dc1e27b8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 1164502589 ---Type <return> to continue, or q <return> to quit--- debug_save = <optimized out> debug_flag = <optimized out> dont_fork_cnt = <optimized out> p = <optimized out> st = {st_dev = 18, st_ino = 10861, st_nlink = 2, st_mode = 16877, st_uid = 114, st_gid = 120, __pad0 = 0, st_rdev = 0, st_size = 120, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1548342456, tv_nsec = 87921300}, st_mtim = {tv_sec = 1548422956, tv_nsec = 858936100}, st_ctim = { tv_sec = 1548422956, tv_nsec = 858936100}, __glibc_reserved = {0, 0, 0}} __func__ = "main" ``` #### Log Messages  ``` kamailio-lb Jan 24 10:53:36 sipwise lb[5118]: ERROR: ndb_redis [redis_client.c:903]: redisc_exec_argv(): Redis error: Server closed the connection Jan 24 10:54:20 sipwise lb[11283]: ERROR: topos [tps_storage.c:340]: tps_storage_link_msg(): bad sip message or missing Contact hdr Jan 24 10:54:27 sipwise lb[11311]: CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 21 Jan 24 10:54:27 sipwise lb[11261]: ALERT: <core> [main.c:738]: handle_sigs(): child process 11267 exited by a signal 6 Jan 24 10:54:27 sipwise lb[11261]: ALERT: <core> [main.c:741]: handle_sigs(): core was generated ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**:  ``` Welcome to Sipwise NGCP platform version 'mr6.5.3' _ _ ___(_)_ ____ _(_)___ ___ / __| | '_ \ \ /\ / / / __|/ _ \ \__ \ | |_) \ V V /| \__ \ __/ |___/_| .__/ \_/\_/ |_|___/\___| |_| Linux sipwise 4.9.0-8-amd64 #1 SMP Debian 4.9.130-2 (2018-10-27) x86_64 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1842

5 years, 10 months

[kamailio/kamailio] kamdbctl: added verification before drop command (#1858)

by Fred Posner

- add get_answer and warning that drop command will drop existing database   #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [X] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Added verification to drop command. Allows for someone to change their mind before dropping existing database similar to #1852 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1858 -- Commit Summary -- * kamdbctl: added verification before reinit * kamdbctl: added verification before reinit * Merge remote-tracking branch 'upstream/master' * kamdbctl: added verification before drop command -- File Changes -- M utils/kamctl/kamdbctl (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1858.patch https://github.com/kamailio/kamailio/pull/1858.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1858

5 years, 10 months

[kamailio/kamailio] listen option in cfg cannot contain `dns` in the advertise portion (#1854)

by niallmcandrew

### Description When setting `listen` with `advertise` in the configuration file the advertise section cannot contain an address that has the string `dns` within it. If at any point the domain used in advertise contains the three letters consecutively without being broken by a hypen or a dot it causes the parser to fail, see logging below. I tried quoting the string but it didn't seam to parse properly. It interpenetrated the full thing as the listen address portion. ### Troubleshooting #### Reproduction Add any advertise address to the config file with the string dns. e.g. ``` listen=tcp:127.0.0.1:5060 advertise sip.dns.example.com:5060 ``` Also using it in the `advertised_address` section without quotes causes the error. ``` advertised_address=sip.dns.example.com:5060 ``` #### Log Messages `````` 0(98) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 62, column 43-45: syntax error 0(98) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 62, column 43-45: invalid host or interface name 0(98) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 62, column 43-45: ip address, interface name or hostname expected 0(98) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 62, column 47-54: ERROR: bad config file (4 errors) ``` ### Possible Solutions A solution could be to use the a `advertised_address` though the cookbook states that this could be deprecated in future and that the `listen` config parameter is preferred. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.1 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**: Running in Debian container image. ``` PRETTY_NAME="Debian GNU/Linux 9 (stretch)" NAME="Debian GNU/Linux" VERSION_ID="9" VERSION="9 (stretch)" ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/" Linux 1498e1ef835d 4.20.6-arch1-1-ARCH #1 SMP PREEMPT Thu Jan 31 08:22:01 UTC 2019 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1854

5 years, 10 months

git:5.1:78043859: kamdbctl: warn that drop cmd will drop existing DB, ask for confirmation (GH #1858)

by Henning Westerholt

Module: kamailio Branch: 5.1 Commit: 780438599de627bfdc9406b7dd469767b35123f5 URL: https://github.com/kamailio/kamailio/commit/780438599de627bfdc9406b7dd46976… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-18T20:58:41+01:00 kamdbctl: warn that drop cmd will drop existing DB, ask for confirmation (GH #1858) - warn that the drop command will drop existing DB, ask for confirmation - manually merge pull request GH #1858 from fredposner, fred at qxork dot com --- Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/780438599de627bfdc9406b7dd46976… Patch: https://github.com/kamailio/kamailio/commit/780438599de627bfdc9406b7dd46976… --- diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index e66f3eb4ce..ea15329a19 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -398,6 +398,14 @@ case $1 in drop) # delete kamailio database # create new database structures + + # confirm dropping of database + echo -e "This will drop your current database.\nIt is recommended to first backup your database.\n" + get_answer ask "Continue with drop? (y/n): " + if [ "$ANSWER" != "y" ]; then + exit 1 + fi + shift if [ $# -eq 1 ] ; then DBNAME="$1"

5 years, 10 months

git:5.1:d0da5663: kamdbctl: added verification before reinit (#1852)

by Henning Westerholt

Module: kamailio Branch: 5.1 Commit: d0da5663bf5761a68c6e135c270ab637539f74a4 URL: https://github.com/kamailio/kamailio/commit/d0da5663bf5761a68c6e135c270ab63… Author: Fred Posner <fred(a)palner.com> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-18T20:58:14+01:00 kamdbctl: added verification before reinit (#1852) kamdbctl: added verification before reinit command (GH #1852) - add get_answer and warning that reinit command will drop existing database - even seasoned users forget and ther is no backing out, results in data loss (cherry picked from commit 39756fff5776bb1bf38215e90bd19a859a287b93) --- Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/d0da5663bf5761a68c6e135c270ab63… Patch: https://github.com/kamailio/kamailio/commit/d0da5663bf5761a68c6e135c270ab63… --- diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index 224111b9fb..e66f3eb4ce 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -409,6 +409,14 @@ case $1 in reinit) # delete database and create a new one # create new database structures + + # confirm dropping of database + echo -e "This will drop your current database and create a new one.\nIt is recommended to first backup your database.\n" + get_answer ask "Continue with reinit? (y/n): " + if [ "$ANSWER" != "y" ]; then + exit 1 + fi + shift if [ $# -eq 1 ] ; then DBNAME="$1"

5 years, 10 months

git:5.2:c07e85a8: kamdbctl: warn that drop cmd will drop existing DB, ask for confirmation (GH #1858)

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: c07e85a8031f771690f4da7f28ff31e265c98a60 URL: https://github.com/kamailio/kamailio/commit/c07e85a8031f771690f4da7f28ff31e… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-18T20:59:05+01:00 kamdbctl: warn that drop cmd will drop existing DB, ask for confirmation (GH #1858) - warn that the drop command will drop existing DB, ask for confirmation - manually merge pull request GH #1858 from fredposner, fred at qxork dot com --- Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/c07e85a8031f771690f4da7f28ff31e… Patch: https://github.com/kamailio/kamailio/commit/c07e85a8031f771690f4da7f28ff31e… --- diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index 62501a4420..ae44c5df45 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -375,6 +375,14 @@ case $1 in drop) # delete kamailio database # create new database structures + + # confirm dropping of database + echo -e "This will drop your current database.\nIt is recommended to first backup your database.\n" + get_answer ask "Continue with drop? (y/n): " + if [ "$ANSWER" != "y" ]; then + exit 1 + fi + shift if [ $# -eq 1 ] ; then DBNAME="$1"

5 years, 10 months

git:5.2:d0ee6bcd: kamdbctl: added verification before reinit (#1852)

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: d0ee6bcd902bf95486ed02ea21b234bcc978894a URL: https://github.com/kamailio/kamailio/commit/d0ee6bcd902bf95486ed02ea21b234b… Author: Fred Posner <fred(a)palner.com> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-18T20:58:09+01:00 kamdbctl: added verification before reinit (#1852) kamdbctl: added verification before reinit command (GH #1852) - add get_answer and warning that reinit command will drop existing database - even seasoned users forget and ther is no backing out, results in data loss (cherry picked from commit 39756fff5776bb1bf38215e90bd19a859a287b93) --- Modified: utils/kamctl/kamdbctl --- Diff: https://github.com/kamailio/kamailio/commit/d0ee6bcd902bf95486ed02ea21b234b… Patch: https://github.com/kamailio/kamailio/commit/d0ee6bcd902bf95486ed02ea21b234b… --- diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index cac33fd1ce..62501a4420 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -386,6 +386,14 @@ case $1 in reinit) # delete database and create a new one # create new database structures + + # confirm dropping of database + echo -e "This will drop your current database and create a new one.\nIt is recommended to first backup your database.\n" + get_answer ask "Continue with reinit? (y/n): " + if [ "$ANSWER" != "y" ]; then + exit 1 + fi + shift if [ $# -eq 1 ] ; then DBNAME="$1"

5 years, 10 months

git:master:c7c68bb5: utils: revert commit to two files accidentally introduced in commit 61eb1ac7

by Henning Westerholt

Module: kamailio Branch: master Commit: c7c68bb506661a7fd97a9e0b8487d074dbbb3ee1 URL: https://github.com/kamailio/kamailio/commit/c7c68bb506661a7fd97a9e0b8487d07… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-18T20:54:03+01:00 utils: revert commit to two files accidentally introduced in commit 61eb1ac7 --- Modified: utils/kamctl/kamctlrc Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/c7c68bb506661a7fd97a9e0b8487d07… Patch: https://github.com/kamailio/kamailio/commit/c7c68bb506661a7fd97a9e0b8487d07… --- diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index 0c00d793c3..d6e927fe84 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -15,7 +15,7 @@ # # If you want to setup a database with kamdbctl, you must at least specify # this parameter. -DBENGINE=MYSQL +# DBENGINE=MYSQL ## database host # DBHOST=localhost diff --git a/utils/kamctl/xhttp_pi/pi_framework.xml b/utils/kamctl/xhttp_pi/pi_framework.xml index 7993b4cc2f..81cda70f50 100644 --- a/utils/kamctl/xhttp_pi/pi_framework.xml +++ b/utils/kamctl/xhttp_pi/pi_framework.xml @@ -219,17 +219,6 @@ <column><field>attrs</field><type>DB1_STR</type></column> <column><field>description</field><type>DB1_STR</type></column> </db_table> -  - <db_table id="domainpolicy"> - <table_name>domainpolicy</table_name> - <db_url_id>mysql</db_url_id> - <column><field>id</field><type>DB1_INT</type></column> - <column><field>rule</field><type>DB1_STR</type></column> - <column><field>type</field><type>DB1_STR</type></column> - <column><field>att</field><type>DB1_STR</type></column> - <column><field>val</field><type>DB1_STR</type></column> - <column><field>description</field><type>DB1_STR</type></column> - </db_table>  <db_table id="domain"> <table_name>domain</table_name> @@ -250,6 +239,17 @@ <column><field>value</field><type>DB1_STR</type></column> <column><field>last_modified</field><type>DB1_DATETIME</type></column> </db_table> +  + <db_table id="domainpolicy"> + <table_name>domainpolicy</table_name> + <db_url_id>mysql</db_url_id> + <column><field>id</field><type>DB1_INT</type></column> + <column><field>rule</field><type>DB1_STR</type></column> + <column><field>type</field><type>DB1_STR</type></column> + <column><field>att</field><type>DB1_STR</type></column> + <column><field>val</field><type>DB1_STR</type></column> + <column><field>description</field><type>DB1_STR</type></column> + </db_table>  <db_table id="dr_gateways"> <table_name>dr_gateways</table_name>

5 years, 10 months

git:master:61eb1ac7: kamdbctl: warn that drop cmd will drop existing DB, ask for confirmation (GH #1858)

by Henning Westerholt

Module: kamailio Branch: master Commit: 61eb1ac798ba3023fc51373a3fa824c70e0ece0c URL: https://github.com/kamailio/kamailio/commit/61eb1ac798ba3023fc51373a3fa824c… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-18T20:44:29+01:00 kamdbctl: warn that drop cmd will drop existing DB, ask for confirmation (GH #1858) - warn that the drop command will drop existing DB, ask for confirmation - manually merge pull request GH #1858 from fredposner, fred at qxork dot com --- Modified: utils/kamctl/kamctlrc Modified: utils/kamctl/kamdbctl Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/61eb1ac798ba3023fc51373a3fa824c… Patch: https://github.com/kamailio/kamailio/commit/61eb1ac798ba3023fc51373a3fa824c… --- diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index d6e927fe84..0c00d793c3 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -15,7 +15,7 @@ # # If you want to setup a database with kamdbctl, you must at least specify # this parameter. -# DBENGINE=MYSQL +DBENGINE=MYSQL ## database host # DBHOST=localhost diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl index 45ed0f50d9..4597afe09b 100755 --- a/utils/kamctl/kamdbctl +++ b/utils/kamctl/kamdbctl @@ -375,6 +375,14 @@ case $1 in drop) # delete kamailio database # create new database structures + + # confirm dropping of database + echo -e "This will drop your current database.\nIt is recommended to first backup your database.\n" + get_answer ask "Continue with drop? (y/n): " + if [ "$ANSWER" != "y" ]; then + exit 1 + fi + shift if [ $# -eq 1 ] ; then DBNAME="$1" diff --git a/utils/kamctl/xhttp_pi/pi_framework.xml b/utils/kamctl/xhttp_pi/pi_framework.xml index 81cda70f50..7993b4cc2f 100644 --- a/utils/kamctl/xhttp_pi/pi_framework.xml +++ b/utils/kamctl/xhttp_pi/pi_framework.xml @@ -219,6 +219,17 @@ <column><field>attrs</field><type>DB1_STR</type></column> <column><field>description</field><type>DB1_STR</type></column> </db_table> +  + <db_table id="domainpolicy"> + <table_name>domainpolicy</table_name> + <db_url_id>mysql</db_url_id> + <column><field>id</field><type>DB1_INT</type></column> + <column><field>rule</field><type>DB1_STR</type></column> + <column><field>type</field><type>DB1_STR</type></column> + <column><field>att</field><type>DB1_STR</type></column> + <column><field>val</field><type>DB1_STR</type></column> + <column><field>description</field><type>DB1_STR</type></column> + </db_table>  <db_table id="domain"> <table_name>domain</table_name> @@ -239,17 +250,6 @@ <column><field>value</field><type>DB1_STR</type></column> <column><field>last_modified</field><type>DB1_DATETIME</type></column> </db_table> -  - <db_table id="domainpolicy"> - <table_name>domainpolicy</table_name> - <db_url_id>mysql</db_url_id> - <column><field>id</field><type>DB1_INT</type></column> - <column><field>rule</field><type>DB1_STR</type></column> - <column><field>type</field><type>DB1_STR</type></column> - <column><field>att</field><type>DB1_STR</type></column> - <column><field>val</field><type>DB1_STR</type></column> - <column><field>description</field><type>DB1_STR</type></column> - </db_table>  <db_table id="dr_gateways"> <table_name>dr_gateways</table_name>

5 years, 10 months

← Newer
1
...
17
18
19
20
21
22
23
...
34
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2019