sr-dev October 2019

sr-dev@lists.kamailio.org

22 participants
436 discussions

git:master:4ba14d2f: smsops: fix spelling error
by Victor Seva 22 Oct '19

22 Oct '19

Module: kamailio Branch: master Commit: 4ba14d2f6db6144870650398da6c07b07d23d64d URL: https://github.com/kamailio/kamailio/commit/4ba14d2f6db6144870650398da6c07b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-22T09:59:02+02:00 smsops: fix spelling error --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/4ba14d2f6db6144870650398da6c07b… Patch: https://github.com/kamailio/kamailio/commit/4ba14d2f6db6144870650398da6c07b… --- diff --git a/src/modules/smsops/smsops_impl.c b/src/modules/smsops/smsops_impl.c index 83d83a7a8e..5271444039 100644 --- a/src/modules/smsops/smsops_impl.c +++ b/src/modules/smsops/smsops_impl.c @@ -573,7 +573,7 @@ int decode_3gpp_sms(struct sip_msg *msg) { if(ie->identifier == TP_UDH_IE_CONCAT_SM_8BIT_REF) { if(contains_8bit_refnum) { pkg_free(ie); - LM_ERR("IE Concatenated Short Message 8bit Reference occured more than once in UDH\n"); + LM_ERR("IE Concatenated Short Message 8bit Reference occurred more than once in UDH\n"); return -1; }

1 0

git:master:4a657005: smsops: fix spelling error
by Victor Seva 22 Oct '19

22 Oct '19

Module: kamailio Branch: master Commit: 4a657005a5c4eff88e48dc2b8847d5800a90bead URL: https://github.com/kamailio/kamailio/commit/4a657005a5c4eff88e48dc2b8847d58… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-22T09:57:07+02:00 smsops: fix spelling error --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/4a657005a5c4eff88e48dc2b8847d58… Patch: https://github.com/kamailio/kamailio/commit/4a657005a5c4eff88e48dc2b8847d58… --- diff --git a/src/modules/smsops/smsops_impl.c b/src/modules/smsops/smsops_impl.c index 8dfe70163a..83d83a7a8e 100644 --- a/src/modules/smsops/smsops_impl.c +++ b/src/modules/smsops/smsops_impl.c @@ -543,7 +543,7 @@ int decode_3gpp_sms(struct sip_msg *msg) { // Check for malicious length, which might cause buffer overflow if(udh_len > body.len - p) { - LM_ERR("TP-User-Data-Lenght is bigger than the remaining message buffer!\n"); + LM_ERR("TP-User-Data-Length is bigger than the remaining message buffer!\n"); return -1; } @@ -564,7 +564,7 @@ int decode_3gpp_sms(struct sip_msg *msg) { // Check for malicious length, which might cause buffer overflow if(udh_read + ie->data.len + 2 /* two octets are read so far */ > udh_len) { - LM_ERR("IE Lenght for IE id %d is bigger than the remaining User-Data element!\n", + LM_ERR("IE Length for IE id %d is bigger than the remaining User-Data element!\n", ie->identifier); pkg_free(ie); return -1;

1 0

git:master:3c26ebe4: secfilter: fix spelling error
by Victor Seva 22 Oct '19

22 Oct '19

Module: kamailio Branch: master Commit: 3c26ebe4670eaffce4754bbd0cd76cbecf5bf590 URL: https://github.com/kamailio/kamailio/commit/3c26ebe4670eaffce4754bbd0cd76cb… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-22T09:52:42+02:00 secfilter: fix spelling error --- Modified: src/modules/secfilter/secfilter_db.c --- Diff: https://github.com/kamailio/kamailio/commit/3c26ebe4670eaffce4754bbd0cd76cb… Patch: https://github.com/kamailio/kamailio/commit/3c26ebe4670eaffce4754bbd0cd76cb… --- diff --git a/src/modules/secfilter/secfilter_db.c b/src/modules/secfilter/secfilter_db.c index 535b67922e..861f1a14bd 100644 --- a/src/modules/secfilter/secfilter_db.c +++ b/src/modules/secfilter/secfilter_db.c @@ -108,7 +108,7 @@ int secf_append_rule(int action, int type, str *value) char *v = NULL; if(action < 0 || action > 2) { - LM_ERR("Unkown action value %d", action); + LM_ERR("Unknown action value %d", action); return -1; } @@ -147,7 +147,7 @@ int secf_append_rule(int action, int type, str *value) last_node = &last->user; break; default: - LM_ERR("Unkown type value %d", type); + LM_ERR("Unknown type value %d", type); return -1; }

1 0

git:master:8a197dcc: seas: fix spelling error
by Victor Seva 22 Oct '19

22 Oct '19

Module: kamailio Branch: master Commit: 8a197dcc8d2d063d3615e8800ed8d2f7812cce0f URL: https://github.com/kamailio/kamailio/commit/8a197dcc8d2d063d3615e8800ed8d2f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-22T09:35:10+02:00 seas: fix spelling error --- Modified: src/modules/seas/event_dispatcher.c Modified: src/modules/seas/event_dispatcher.h --- Diff: https://github.com/kamailio/kamailio/commit/8a197dcc8d2d063d3615e8800ed8d2f… Patch: https://github.com/kamailio/kamailio/commit/8a197dcc8d2d063d3615e8800ed8d2f…

1 0

git:master:0944689d: domain: fix spelling error
by Victor Seva 22 Oct '19

22 Oct '19

Module: kamailio Branch: master Commit: 0944689db2eabbb531fc6daed9db3a9bcc1780b6 URL: https://github.com/kamailio/kamailio/commit/0944689db2eabbb531fc6daed9db3a9… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-22T09:32:48+02:00 domain: fix spelling error --- Modified: src/modules/domain/hash.c --- Diff: https://github.com/kamailio/kamailio/commit/0944689db2eabbb531fc6daed9db3a9… Patch: https://github.com/kamailio/kamailio/commit/0944689db2eabbb531fc6daed9db3a9… --- diff --git a/src/modules/domain/hash.c b/src/modules/domain/hash.c index b093dbc3e4..4cb968e458 100644 --- a/src/modules/domain/hash.c +++ b/src/modules/domain/hash.c @@ -137,7 +137,7 @@ int hash_table_install(struct domain_list **hash_table, str *did, str *domain) np->did.len = did->len; np->did.s = (char *)shm_malloc(did->len); if(np->did.s == NULL) { - LM_ERR("no shared memeory for did\n"); + LM_ERR("no shared memory for did\n"); shm_free(np); return -1; } @@ -210,4 +210,4 @@ void hash_table_free(struct domain_list **hash_table) hash_table[DOM_HASH_SIZE] = NULL; return; -} \ No newline at end of file +}

1 0

git:master:3c24dd27: modules: readme files regenerated - imc ... [skip ci]
by Kamailio Dev 22 Oct '19

22 Oct '19

Module: kamailio Branch: master Commit: 3c24dd27056c48528bc33bd90d680b9483785a18 URL: https://github.com/kamailio/kamailio/commit/3c24dd27056c48528bc33bd90d680b9… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-22T08:31:18+02:00 modules: readme files regenerated - imc ... [skip ci] --- Modified: src/modules/imc/README --- Diff: https://github.com/kamailio/kamailio/commit/3c24dd27056c48528bc33bd90d680b9… Patch: https://github.com/kamailio/kamailio/commit/3c24dd27056c48528bc33bd90d680b9… --- diff --git a/src/modules/imc/README b/src/modules/imc/README index 1e5f79ef55..e07a66276f 100644 --- a/src/modules/imc/README +++ b/src/modules/imc/README @@ -36,6 +36,8 @@ Anca-Maria Vamanu 3.5. imc_cmd_start_char (str) 3.6. outbound_proxy (str) 3.7. extra_hdrs (str) + 3.8. create_on_join (integer) + 3.9. check_on_create (integer) 4. Functions @@ -62,8 +64,10 @@ Anca-Maria Vamanu 1.5. Set imc_cmd_start_char parameter 1.6. Set outbound_proxy parameter 1.7. Set extra_hdrs parameter - 1.8. Usage of imc_manager() function - 1.9. List of commands + 1.8. Set create_on_join parameter + 1.9. Set check_on_create parameter + 1.10. Usage of imc_manager() function + 1.11. List of commands Chapter 1. Admin Guide @@ -84,6 +88,8 @@ Chapter 1. Admin Guide 3.5. imc_cmd_start_char (str) 3.6. outbound_proxy (str) 3.7. extra_hdrs (str) + 3.8. create_on_join (integer) + 3.9. check_on_create (integer) 4. Functions @@ -145,6 +151,8 @@ Chapter 1. Admin Guide 3.5. imc_cmd_start_char (str) 3.6. outbound_proxy (str) 3.7. extra_hdrs (str) + 3.8. create_on_join (integer) + 3.9. check_on_create (integer) 3.1. db_url (str) @@ -229,6 +237,31 @@ modparam("imc", "outbound_proxy", "sip:kamailio.org;transport=tcp") modparam("imc", "extra_hdrs", "P-Flags: 3\r\n") ... +3.8. create_on_join (integer) + + If set to 1 and user requests to join a non-existing room, the room + will be automatically created. If set to 0, joinin a non-existing room + returns an error. + + The default value is 1. + + Example 1.8. Set create_on_join parameter +... +modparam("imc", "create_on_join", 0) +... + +3.9. check_on_create (integer) + + If set to 1, the chat server will report an error if the user attempts + to create a room that already exists. + + The default value is 0. + + Example 1.9. Set check_on_create parameter +... +modparam("imc", "check_on_create", 1) +... + 4. Functions 4.1. imc_manager() @@ -242,7 +275,7 @@ modparam("imc", "extra_hdrs", "P-Flags: 3\r\n") This function can be used from REQUEST_ROUTE. See command description for error codes returned by this function. - Example 1.8. Usage of imc_manager() function + Example 1.10. Usage of imc_manager() function ... # the rooms will be named chat-xyz to avoid overlapping # with usernames @@ -305,7 +338,7 @@ kamcmd imc_list_members _room_ Next picture presents the list of commands and their parameters. - Example 1.9. List of commands + Example 1.11. List of commands ... 1.create @@ -377,10 +410,21 @@ kamcmd imc_list_members _room_ -only the owner of a room has the right to destroy it -error case: return codes: -110 -- -119 -9.list +9.members -list members in a room -error case: return codes: -100 -- -109 +10.add + -adds a user to a room + -takes 2 parameters: + 1)the complete address of the user + 2)the address of the room -if not present it will be considered + to be the address in the To header of the message + -only certain users have the right to add other users: the owner + and the administrators + -eg: #add sip:john@kamailio.org sip:chat-000@kamailio.org + or #add john(a)kamailio.org sent to sip:chat-000@kamailio.org + -error case: return codes: -50 -- -59 ... 8. Installation

1 0

git:master:6f9bb642: imc: docs - added section ids
by Daniel-Constantin Mierla 22 Oct '19

22 Oct '19

Module: kamailio Branch: master Commit: 6f9bb6427ce201863d60e3255debe31a6a7db776 URL: https://github.com/kamailio/kamailio/commit/6f9bb6427ce201863d60e3255debe31… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-22T08:28:09+02:00 imc: docs - added section ids --- Modified: src/modules/imc/doc/imc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/6f9bb6427ce201863d60e3255debe31… Patch: https://github.com/kamailio/kamailio/commit/6f9bb6427ce201863d60e3255debe31… --- diff --git a/src/modules/imc/doc/imc_admin.xml b/src/modules/imc/doc/imc_admin.xml index 3c654da6f3..85a31a844a 100644 --- a/src/modules/imc/doc/imc_admin.xml +++ b/src/modules/imc/doc/imc_admin.xml @@ -72,7 +72,7 @@ </section> <section> <title>Parameters</title> - <section> + <section id="imc.p.db_url"> <title><varname>db_url</varname> (str)</title> <para> The database url. @@ -91,7 +91,7 @@ modparam("imc", "db_url", "&exampledb;") </programlisting> </example> </section> - <section> + <section id="imc.p.rooms_table"> <title><varname>rooms_table</varname> (str)</title> <para> The name of the table storing IMC rooms. @@ -110,7 +110,7 @@ modparam("imc", "rooms_table", "rooms") </programlisting> </example> </section> - <section> + <section id="imc.p.members_table"> <title><varname>members_table</varname> (str)</title> <para> The name of the table storing IMC members. @@ -129,7 +129,7 @@ modparam("imc", "members_table", "members") </programlisting> </example> </section> - <section> + <section id="imc.p.hash_size"> <title><varname>hash_size</varname> (integer)</title> <para> The power of 2 to get the size of the hash table used for storing @@ -149,7 +149,7 @@ modparam("imc", "hash_size", 8) </programlisting> </example> </section> - <section> + <section id="imc.p.imc_cmd_start_char"> <title><varname>imc_cmd_start_char</varname> (str)</title> <para> The character which indicates that the body of the message is @@ -169,7 +169,7 @@ modparam("imc", "imc_cmd_start_char", "#") </programlisting> </example> </section> - <section> + <section id="imc.p.outbound_proxy"> <title><varname>outbound_proxy</varname> (str)</title> <para> The SIP address used as next hop when sending the message. Very @@ -193,7 +193,7 @@ modparam("imc", "outbound_proxy", "sip:kamailio.org;transport=tcp") </example> </section> - <section> + <section id="imc.p.extra_hdrs"> <title><varname>extra_hdrs</varname> (str)</title> <para> Extra headers (each ending with \r\n) to be added in @@ -213,7 +213,7 @@ modparam("imc", "extra_hdrs", "P-Flags: 3\r\n") </programlisting> </example> </section> - <section> + <section id="imc.p.create_on_join"> <title><varname>create_on_join</varname> (integer)</title> <para> If set to 1 and user requests to join a non-existing @@ -234,7 +234,7 @@ modparam("imc", "create_on_join", 0) </programlisting> </example> </section> - <section> + <section id="imc.p.check_on_create"> <title><varname>check_on_create</varname> (integer)</title> <para> If set to 1, the chat server will report an error if @@ -259,7 +259,7 @@ modparam("imc", "check_on_create", 1) <section> <title>Functions</title> <section> - <title> + <title id="imc.p.imc_manager"> <function moreinfo="none">imc_manager()</function> </title> <para>

1 0

[kamailio/kamailio] LCR stopper flag can't be used with multiple identical rules (#2105)
by pwakano 22 Oct '19

22 Oct '19

### Description Multiple rules with the same prefix and with the stopper flag are added. All the rules have the same priority in the target table. When routing calls to this prefix (load_gw + next_gw), the LCR module does not load balance the calls, it always sends to the same GW. #### Reproduction Scenario is the following, the LCR rules have one default GW which is reachable via an empty rule. However, a certain prefix must not be sent there, so a rule with the stopper flag is added pointing to another GW. This works fine and the default GW is never attempted. However, for load balance purposes, it is necessary to send calls to this prefix to 2 different GWs. So another rule with the same prefix is added with the stopper flag set too. The target table was updated accordingly and has the same priority. When we have all this setup, by calling "next_gw()" we always get the same GW (which is random depending on the DB situation I think). The other(s) GW is never attempted. This does not allow to load balance 2 GWs for rules with the stopper flag. Given the stopper flag should prevent selecting shorter prefixes, it should not restrict the routing for rules with the same prefix (same length). Having this, the load balance of stopper rules would be possible. ### Possible Solutions Apparently, there is no workaround, expect by not using the stopper flag, however then there is a risk of sending calls to GWs with shorter prefix length which is not desired. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio -v version: kamailio 5.2.2 (x86_64/linux) 67f967 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 67f967 compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5 ``` * **Operating System**: ``` uname -a Linux uat1-sbc-0002 3.10.0-1062.1.2.el7.x86_64 #1 SMP Mon Sep 30 14:19:46 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2105

2 3

removing 200-canceling response from kamailio
by vinod mn 18 Oct '19

18 Oct '19

Hi how to remove the "200-canceling" response from kamailio it is very urgent. -- Thanks and regards Vinod.M.N

2 1

how to get the correct dispacther value
by vinod mn 18 Oct '19

18 Oct '19

Hi I am using kamailio 4.4.2 for load-balancing modparam("dispatcher", "dst_avp", "$avp(dsdst)") $avp(dsdst) getting proper dispathcer value. But this value is null in request_route under iif (is_method("CANCEL")){ } How to get the correct dispatcher value for a particular call -- Thanks and regards Vinod.M.N

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
44
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2019