sr-dev October 2019

sr-dev@lists.kamailio.org

22 participants
436 discussions

git:5.3:67cd116c: statsc: free parsed params in case of error
by Daniel-Constantin Mierla 17 Oct '19

17 Oct '19

Module: kamailio Branch: 5.3 Commit: 67cd116cdb05511cbf889a6f4418830c35ec77c3 URL: https://github.com/kamailio/kamailio/commit/67cd116cdb05511cbf889a6f4418830… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-17T10:51:45+02:00 statsc: free parsed params in case of error - wrap some lines of codes in blocks (cherry picked from commit 27020d88b4d3206a8f193dc5343ea8bb5b39b5a1) --- Modified: src/modules/statsc/statsc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/67cd116cdb05511cbf889a6f4418830… Patch: https://github.com/kamailio/kamailio/commit/67cd116cdb05511cbf889a6f4418830… --- diff --git a/src/modules/statsc/statsc_mod.c b/src/modules/statsc/statsc_mod.c index 75c88c9cd5..0cbe246965 100644 --- a/src/modules/statsc/statsc_mod.c +++ b/src/modules/statsc/statsc_mod.c @@ -205,7 +205,7 @@ int statsc_nmap_add(str *sname, str *rname) return 0; } sl = _statsc_info->slist; - while(sl->next!=NULL) sl = sl->next; + while(sl->next!=NULL) { sl = sl->next; } sl->next = sm; _statsc_info->slots++; return 0; @@ -287,18 +287,23 @@ int statsc_track_param(modparam_t type, void* val) param_t *pit=NULL; str s; - if(val==NULL) + if(val==NULL) { return -1; - if(statsc_init()<0) + } + if(statsc_init()<0) { return -1; + } s.s = (char*)val; s.len = strlen(s.s); - if(s.s[s.len-1]==';') + if(s.s[s.len-1]==';') { s.len--; - if (parse_params(&s, CLASS_ANY, &phooks, &params_list)<0) + } + if (parse_params(&s, CLASS_ANY, &phooks, &params_list)<0) { return -1; + } for (pit = params_list; pit; pit=pit->next) { if(statsc_nmap_add(&pit->name, &pit->body)<0) { + free_params(params_list); LM_ERR("cannot enable tracking statistics\n"); return -1; } @@ -369,8 +374,9 @@ static void statsc_rpc_report(rpc_t* rpc, void* ctx) sname.s = NULL; } rpc->scan(ctx, "*d", &range); - if(range<0 || range>statsc_items) + if(range<0 || range>statsc_items) { range = 0; + } } tn = time(NULL);

1 0

git:5.3:e0de1a68: nathelper: removed exe flag from c file
by Daniel-Constantin Mierla 17 Oct '19

17 Oct '19

Module: kamailio Branch: 5.3 Commit: e0de1a6842b03b06c56f84ae2dfc153b18f3a7c1 URL: https://github.com/kamailio/kamailio/commit/e0de1a6842b03b06c56f84ae2dfc153… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-17T10:51:32+02:00 nathelper: removed exe flag from c file (cherry picked from commit 82195c2a51c5020ca0024f59492a4e2faef0e15a) --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/e0de1a6842b03b06c56f84ae2dfc153… Patch: https://github.com/kamailio/kamailio/commit/e0de1a6842b03b06c56f84ae2dfc153… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c old mode 100755 new mode 100644

1 0

git:5.3:195c0150: pkg/kamailio/deb: version set 5.3.0
by Victor Seva 17 Oct '19

17 Oct '19

Module: kamailio Branch: 5.3 Commit: 195c0150c83cdea3ec2f1dcd4c53f59d37280be7 URL: https://github.com/kamailio/kamailio/commit/195c0150c83cdea3ec2f1dcd4c53f59… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-17T09:16:28+02:00 pkg/kamailio/deb: version set 5.3.0 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/195c0150c83cdea3ec2f1dcd4c53f59… Patch: https://github.com/kamailio/kamailio/commit/195c0150c83cdea3ec2f1dcd4c53f59…

1 0

siptrace errors
by Juha Heinanen 16 Oct '19

16 Oct '19

Using 5.3 branch, I have sip-proxy_ctl> siptrace.status check Disabled but still these kind of errors appear in syslog: Oct 16 12:07:10 salmon /usr/bin/sip-proxy[26459]: ERROR: siptrace [siptrace.c:1250]: trace_onreq_out(): retransmission Oct 16 12:07:11 salmon /usr/bin/sip-proxy[26459]: ERROR: siptrace [siptrace.c:1250]: trace_onreq_out(): retransmission Oct 16 12:07:13 salmon /usr/bin/sip-proxy[26459]: ERROR: siptrace [siptrace.c:1250]: trace_onreq_out(): retransmission How is it possible? -- Juha

2 5

git:5.3:0ba475b8: siptrace: use debug for the log message about retrasmission
by Daniel-Constantin Mierla 16 Oct '19

16 Oct '19

Module: kamailio Branch: 5.3 Commit: 0ba475b82c640047060d49dab9768a5003eb5cf4 URL: https://github.com/kamailio/kamailio/commit/0ba475b82c640047060d49dab9768a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-16T12:18:11+02:00 siptrace: use debug for the log message about retrasmission (cherry picked from commit bf3c70e00b0d8252acca4b8d28f435819dd100b5) --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/0ba475b82c640047060d49dab9768a5… Patch: https://github.com/kamailio/kamailio/commit/0ba475b82c640047060d49dab9768a5… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 20c0c8a907..dbaefd40d7 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -1242,12 +1242,12 @@ static void trace_onreq_out(struct cell *t, int type, struct tmcb_params *ps) dest_info_t *dst; if(t == NULL || ps == NULL) { - LM_ERR("very weird\n"); + LM_ERR("unexpected parameter values\n"); return; } if(ps->flags & TMCB_RETR_F) { - LM_ERR("retransmission\n"); + LM_DBG("retransmission - ignoring\n"); return; } info = (siptrace_info_t *)(*ps->param);

1 0

git:master:bf3c70e0: siptrace: use debug for the log message about retrasmission
by Daniel-Constantin Mierla 16 Oct '19

16 Oct '19

Module: kamailio Branch: master Commit: bf3c70e00b0d8252acca4b8d28f435819dd100b5 URL: https://github.com/kamailio/kamailio/commit/bf3c70e00b0d8252acca4b8d28f4358… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-16T12:13:07+02:00 siptrace: use debug for the log message about retrasmission --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/bf3c70e00b0d8252acca4b8d28f4358… Patch: https://github.com/kamailio/kamailio/commit/bf3c70e00b0d8252acca4b8d28f4358… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 20c0c8a907..dbaefd40d7 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -1242,12 +1242,12 @@ static void trace_onreq_out(struct cell *t, int type, struct tmcb_params *ps) dest_info_t *dst; if(t == NULL || ps == NULL) { - LM_ERR("very weird\n"); + LM_ERR("unexpected parameter values\n"); return; } if(ps->flags & TMCB_RETR_F) { - LM_ERR("retransmission\n"); + LM_DBG("retransmission - ignoring\n"); return; } info = (siptrace_info_t *)(*ps->param);

1 0

Errored: kamailio/kamailio#7952 (master - 27020d8)
by Travis CI 15 Oct '19

15 Oct '19

Build Update for kamailio/kamailio ------------------------------------- Build: #7952 Status: Errored Duration: 28 secs Commit: 27020d8 (master) Author: Daniel-Constantin Mierla Message: statsc: free parsed params in case of error - wrap some lines of codes in blocks View the changeset: https://github.com/kamailio/kamailio/compare/33b174b979a0...27020d88b4d3 View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/598265482?utm_medium=notific… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

git:master:27020d88: statsc: free parsed params in case of error
by Daniel-Constantin Mierla 15 Oct '19

15 Oct '19

Module: kamailio Branch: master Commit: 27020d88b4d3206a8f193dc5343ea8bb5b39b5a1 URL: https://github.com/kamailio/kamailio/commit/27020d88b4d3206a8f193dc5343ea8b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-15T19:40:02+02:00 statsc: free parsed params in case of error - wrap some lines of codes in blocks --- Modified: src/modules/statsc/statsc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/27020d88b4d3206a8f193dc5343ea8b… Patch: https://github.com/kamailio/kamailio/commit/27020d88b4d3206a8f193dc5343ea8b… --- diff --git a/src/modules/statsc/statsc_mod.c b/src/modules/statsc/statsc_mod.c index 75c88c9cd5..0cbe246965 100644 --- a/src/modules/statsc/statsc_mod.c +++ b/src/modules/statsc/statsc_mod.c @@ -205,7 +205,7 @@ int statsc_nmap_add(str *sname, str *rname) return 0; } sl = _statsc_info->slist; - while(sl->next!=NULL) sl = sl->next; + while(sl->next!=NULL) { sl = sl->next; } sl->next = sm; _statsc_info->slots++; return 0; @@ -287,18 +287,23 @@ int statsc_track_param(modparam_t type, void* val) param_t *pit=NULL; str s; - if(val==NULL) + if(val==NULL) { return -1; - if(statsc_init()<0) + } + if(statsc_init()<0) { return -1; + } s.s = (char*)val; s.len = strlen(s.s); - if(s.s[s.len-1]==';') + if(s.s[s.len-1]==';') { s.len--; - if (parse_params(&s, CLASS_ANY, &phooks, &params_list)<0) + } + if (parse_params(&s, CLASS_ANY, &phooks, &params_list)<0) { return -1; + } for (pit = params_list; pit; pit=pit->next) { if(statsc_nmap_add(&pit->name, &pit->body)<0) { + free_params(params_list); LM_ERR("cannot enable tracking statistics\n"); return -1; } @@ -369,8 +374,9 @@ static void statsc_rpc_report(rpc_t* rpc, void* ctx) sname.s = NULL; } rpc->scan(ctx, "*d", &range); - if(range<0 || range>statsc_items) + if(range<0 || range>statsc_items) { range = 0; + } } tn = time(NULL);

1 0

git:5.3:fc91331a: tls: add TLSv1.2+ to example configuration
by Henning Westerholt 15 Oct '19

15 Oct '19

Module: kamailio Branch: 5.3 Commit: fc91331a92acdef0a17b0341b8d22f93bdbbc1db URL: https://github.com/kamailio/kamailio/commit/fc91331a92acdef0a17b0341b8d22f9… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-15T15:17:54+02:00 tls: add TLSv1.2+ to example configuration (cherry picked from commit aedd2c6470feb6410605110e8e31eca8b43feefb) --- Modified: src/modules/tls/tls.cfg --- Diff: https://github.com/kamailio/kamailio/commit/fc91331a92acdef0a17b0341b8d22f9… Patch: https://github.com/kamailio/kamailio/commit/fc91331a92acdef0a17b0341b8d22f9… --- diff --git a/src/modules/tls/tls.cfg b/src/modules/tls/tls.cfg index d8b20049ae..1bfdfc6919 100644 --- a/src/modules/tls/tls.cfg +++ b/src/modules/tls/tls.cfg @@ -8,12 +8,12 @@ # connections that do not match any other server # domain in this configuration file. # -# We do not enable anything else than TLSv1.2 +# We do not enable anything else than TLSv1.2+ # over the public internet. Clients do not have # to present client certificates by default. # [server:default] -method = TLSv1.2 +method = TLSv1.2+ verify_certificate = no require_certificate = no private_key = /usr/local/etc/kamailio/kamailio-selfsigned.key @@ -29,21 +29,21 @@ certificate = /usr/local/etc/kamailio/kamailio-selfsigned.pem # We require that servers present valid certificate. # [client:default] -#method = TLSv1.2 +#method = TLSv1.2+ verify_certificate = yes require_certificate = yes # --- # This is an example server domain for TLS connections # received from the loopback interface. We allow -# the use of TLSv1.2 protocols here, we do +# the use of TLSv1.2+ protocols here, we do # not require that clients present client certificates # but if they present it it must be valid. We also use # a special certificate and CA list for loopback # interface. # #[server:5.6.7.8:5061] -#method = TLSv1.2 +#method = TLSv1.2+ #verify_certificate = yes #require_certificate = no #private_key = /usr/local/etc/kamailio/tls/local_key.pem @@ -76,7 +76,7 @@ require_certificate = yes # - it requires to have 'server_name' to match on SNI (domain and subdomains) # #[server:any] -#method = TLSv1.2 +#method = TLSv1.2+ #verify_certificate = yes #require_certificate = no #private_key = /usr/local/etc/kamailio/tls/mysipserver_org_key.pem @@ -93,7 +93,7 @@ require_certificate = yes # - it requires to have 'server_name' to match on SNI (only subdomains) # #[server:any] -#method = TLSv1.2 +#method = TLSv1.2+ #verify_certificate = yes #require_certificate = no #private_key = /usr/local/etc/kamailio/tls/mysipserver_net_key.pem

1 0

git:5.1:15a0eda0: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 15 Oct '19

15 Oct '19

Module: kamailio Branch: 5.1 Commit: 15a0eda04c05a895255a3dd9df15ff83298a1910 URL: https://github.com/kamailio/kamailio/commit/15a0eda04c05a895255a3dd9df15ff8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-15T15:17:21+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/15a0eda04c05a895255a3dd9df15ff8… Patch: https://github.com/kamailio/kamailio/commit/15a0eda04c05a895255a3dd9df15ff8… --- diff --git a/src/modules/tls/README b/src/modules/tls/README index dcdbfed6de..10a9c2a27a 100644 --- a/src/modules/tls/README +++ b/src/modules/tls/README @@ -537,6 +537,8 @@ Revoking a certificate and using a CRL 9.1. tls_method (string) Sets the TLS protocol method. Possible values are: + * TLSv1.2+ - TLSv1.2 or newer (TLSv1.3, ...) connections are accepted + (available starting with openssl/libssl v1.1.1) * TLSv1.2 - only TLSv1.2 connections are accepted (available starting with openssl/libssl v1.0.1e) * TLSv1.1+ - TLSv1.1 or newer (TLSv1.2, ...) connections are accepted

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
44
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2019