sr-dev October 2019

sr-dev@lists.kamailio.org

22 participants
436 discussions

git:master:a463c53e: statsc: debug message when fetching stats values

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a463c53e767114567ff25f0fe50115da0e3d0045 URL: https://github.com/kamailio/kamailio/commit/a463c53e767114567ff25f0fe50115d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-24T12:38:51+02:00 statsc: debug message when fetching stats values --- Modified: src/modules/statsc/statsc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a463c53e767114567ff25f0fe50115d… Patch: https://github.com/kamailio/kamailio/commit/a463c53e767114567ff25f0fe50115d… --- diff --git a/src/modules/statsc/statsc_mod.c b/src/modules/statsc/statsc_mod.c index 0cbe246965..fcedfcdeef 100644 --- a/src/modules/statsc/statsc_mod.c +++ b/src/modules/statsc/statsc_mod.c @@ -257,6 +257,7 @@ void statsc_timer(unsigned int ticks, void *param) statsc_nmap_t *sm = NULL; time_t tn; int n; + int i; if(_statsc_info==NULL || _statsc_info->slist==NULL) { LM_ERR("statsc not initialized\n"); @@ -270,8 +271,12 @@ void statsc_timer(unsigned int ticks, void *param) LM_DBG("statsc timer - time: %lu - ticks: %u - index: %d - steps: %llu\n", (unsigned long)tn, ticks, n, (unsigned long long)_statsc_info->steps); + i = 0; for(sm=_statsc_info->slist->next; sm!=NULL; sm=sm->next) { + LM_DBG("fetching value for: [%.*s] - step [%d]\n", sm->rname.len, + sm->rname.s, i); statsc_svalue(&sm->rname, sm->vals + n); + i++; } _statsc_info->steps++; }

4 years, 8 months

git:master:fe693cc1: pkg/kamailio/deb: allow group write to RuntimeDirectory

by Victor Seva

Module: kamailio Branch: master Commit: fe693cc1178a9301cdb0be3941d9c70d720920e5 URL: https://github.com/kamailio/kamailio/commit/fe693cc1178a9301cdb0be3941d9c70… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-24T12:08:20+02:00 pkg/kamailio/deb: allow group write to RuntimeDirectory --- Modified: pkg/kamailio/deb/bionic/kamailio.service Modified: pkg/kamailio/deb/buster/kamailio.service Modified: pkg/kamailio/deb/debian/kamailio.service Modified: pkg/kamailio/deb/jessie/kamailio.service Modified: pkg/kamailio/deb/sid/kamailio.service Modified: pkg/kamailio/deb/stretch/kamailio.service Modified: pkg/kamailio/deb/xenial/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/fe693cc1178a9301cdb0be3941d9c70… Patch: https://github.com/kamailio/kamailio/commit/fe693cc1178a9301cdb0be3941d9c70… --- diff --git a/pkg/kamailio/deb/bionic/kamailio.service b/pkg/kamailio/deb/bionic/kamailio.service index 5c697f635d..a411114db9 100644 --- a/pkg/kamailio/deb/bionic/kamailio.service +++ b/pkg/kamailio/deb/bionic/kamailio.service @@ -19,7 +19,7 @@ ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_M Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio -RuntimeDirectoryMode=0750 +RuntimeDirectoryMode=0770 [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/buster/kamailio.service b/pkg/kamailio/deb/buster/kamailio.service index 5c697f635d..a411114db9 100644 --- a/pkg/kamailio/deb/buster/kamailio.service +++ b/pkg/kamailio/deb/buster/kamailio.service @@ -19,7 +19,7 @@ ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_M Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio -RuntimeDirectoryMode=0750 +RuntimeDirectoryMode=0770 [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/debian/kamailio.service b/pkg/kamailio/deb/debian/kamailio.service index 5c697f635d..a411114db9 100644 --- a/pkg/kamailio/deb/debian/kamailio.service +++ b/pkg/kamailio/deb/debian/kamailio.service @@ -19,7 +19,7 @@ ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_M Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio -RuntimeDirectoryMode=0750 +RuntimeDirectoryMode=0770 [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/jessie/kamailio.service b/pkg/kamailio/deb/jessie/kamailio.service index 5c697f635d..a411114db9 100644 --- a/pkg/kamailio/deb/jessie/kamailio.service +++ b/pkg/kamailio/deb/jessie/kamailio.service @@ -19,7 +19,7 @@ ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_M Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio -RuntimeDirectoryMode=0750 +RuntimeDirectoryMode=0770 [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/sid/kamailio.service b/pkg/kamailio/deb/sid/kamailio.service index 5c697f635d..a411114db9 100644 --- a/pkg/kamailio/deb/sid/kamailio.service +++ b/pkg/kamailio/deb/sid/kamailio.service @@ -19,7 +19,7 @@ ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_M Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio -RuntimeDirectoryMode=0750 +RuntimeDirectoryMode=0770 [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/stretch/kamailio.service b/pkg/kamailio/deb/stretch/kamailio.service index 5c697f635d..a411114db9 100644 --- a/pkg/kamailio/deb/stretch/kamailio.service +++ b/pkg/kamailio/deb/stretch/kamailio.service @@ -19,7 +19,7 @@ ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_M Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio -RuntimeDirectoryMode=0750 +RuntimeDirectoryMode=0770 [Install] WantedBy=multi-user.target diff --git a/pkg/kamailio/deb/xenial/kamailio.service b/pkg/kamailio/deb/xenial/kamailio.service index 5c697f635d..a411114db9 100644 --- a/pkg/kamailio/deb/xenial/kamailio.service +++ b/pkg/kamailio/deb/xenial/kamailio.service @@ -19,7 +19,7 @@ ExecStart=/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_M Restart=on-failure # /run/kamailio in tmpfs RuntimeDirectory=kamailio -RuntimeDirectoryMode=0750 +RuntimeDirectoryMode=0770 [Install] WantedBy=multi-user.target

4 years, 8 months

git:master:782c3259: kamdbctl: new option DBINITASK to control the steps for db init

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 782c3259a7afd0a0ea462a8ee17b95eacbfe3c81 URL: https://github.com/kamailio/kamailio/commit/782c3259a7afd0a0ea462a8ee17b95e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-23T08:47:19+02:00 kamdbctl: new option DBINITASK to control the steps for db init - if set DBINITASK=yes, then each step requires confirmation (e.g., database creation, users creation, standard tables creation) - can be useful when needing to run only some of the steps --- Modified: utils/kamctl/kamctlrc Modified: utils/kamctl/kamdbctl.mysql --- Diff: https://github.com/kamailio/kamailio/commit/782c3259a7afd0a0ea462a8ee17b95e… Patch: https://github.com/kamailio/kamailio/commit/782c3259a7afd0a0ea462a8ee17b95e… --- diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index 5306a6116d..a49c79f2ec 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -52,6 +52,9 @@ ## - known to work for: mysql # DBROOTPW="dbrootpw" +## option to ask confirmation for all database creation steps +# DBINITASK=yes + ## database character set (used by MySQL when creating database) #CHARSET="latin1" diff --git a/utils/kamctl/kamdbctl.mysql b/utils/kamctl/kamdbctl.mysql index e8f8d2e861..bdb8b98ab4 100644 --- a/utils/kamctl/kamdbctl.mysql +++ b/utils/kamctl/kamdbctl.mysql @@ -238,24 +238,45 @@ kamailio_create () # pars: <database name> exit 1 fi - kamailio_db_create $1 + if [ "$DBINITASK" = "yes" ]; then + get_answer "ask" "Create the database '$1'? (y/n): " + else + ANSWER="y" + fi + if [ "$ANSWER" = "y" ]; then + kamailio_db_create $1 + fi - kamailio_db_grant $1 + if [ "$DBINITASK" = "yes" ]; then + get_answer "ask" "Create database users with access privileges? (y/n): " + else + ANSWER="y" + fi + if [ "$ANSWER" = "y" ]; then + kamailio_db_grant $1 + fi - standard_create $1 + if [ "$DBINITASK" = "yes" ]; then + get_answer "ask" "Create the standard database tables? (y/n): " + else + ANSWER="y" + fi + if [ "$ANSWER" = "y" ]; then + standard_create $1 + fi - get_answer $INSTALL_PRESENCE_TABLES "Install presence related tables? (y/n): " + get_answer $INSTALL_PRESENCE_TABLES "Create the presence related tables? (y/n): " if [ "$ANSWER" = "y" ]; then presence_create $1 fi - get_answer $INSTALL_EXTRA_TABLES "Install tables for $EXTRA_MODULES? (y/n): " + get_answer $INSTALL_EXTRA_TABLES "Create the tables for $EXTRA_MODULES? (y/n): " if [ "$ANSWER" = "y" ]; then HAS_EXTRA="yes" extra_create $1 fi - get_answer $INSTALL_DBUID_TABLES "Install tables for $DBUID_MODULES? (y/n): " + get_answer $INSTALL_DBUID_TABLES "Create the tables for $DBUID_MODULES? (y/n): " if [ "$ANSWER" = "y" ]; then HAS_EXTRA="yes" dbuid_create $1

4 years, 8 months

[kamailio/kamailio] uac: uacreg send incorrect hash response (#2108)

by Vadim

### Description  ``` Installed new kamailio 5.3, setting the uac module to register trunk. The trunk has been added to the Mysql with an open password (or use ha1). When try to register and send authorization data, the provider's server always gives a 403 error. After the analysis, I found that the kamailio sends an incorrect hash in response header. ``` ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` Provider send "407 Proxy Authentication Required": Proxy-Authenticate: Digest nonce="MTU3MTY5Mzg2MTrbrxRPWP0AIkC7fowq+nZn", opaque="MTU3MTY5Mzg2MTrbrxRPWP0AIkC7fowq+nZn", algorithm=md5, realm="BREDBAND", qop="auth" Kamailio send new "Register": Proxy-Authorization: Digest username="79205615793", realm="BREDBAND", nonce="MTU3MTY5Mzg2MTrbrxRPWP0AIkC7fowq+nZn", uri="sip:sbc.megafon.ru", opaque="MTU3MTY5Mzg2MTrbrx WP0AIkC7fowq+nZn", qop=auth, nc=00000001, cnonce="3335441185", response="395830e40a92fd7d4564d82dfab1dac0", algorithm=MD5 If you calculate the hash manually: Correct response: "2cee0f5a35c0e4831455496ce040eaf4" ``` ### Possible Solutions  ``` Problem with code in auth_alg.c. He tries to verify that there is an encrypted password, even if it is not set in the database. Next, an uncorrect calculation of the hash for the answer 401 occurs. If you remove the block ``` if(UAC_FLCRED_HA1 & UAC_FLCRED_HA1) { memcpy(sess_key, crd->passwd.s, HASHHEXLEN); sess_key[HASHHEXLEN] = '\0'; if ( auth->flags& AUTHENTICATE_MD5SESS ) { cvt_bin(sess_key, HA1); } else { return; } ``` Password registration works. Maybe there are 2 problems. He constantly tries to calculate the hash for ha1 password (if used open password), and if it is, then the function cvt_bin incorrectly considers it. ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio 5.3.0 (x86_64/linux) 4cc67a ``` * **Operating System**:  ``` Linux refs4 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt9-3~deb8u1 (2015-04-24) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2108

4 years, 8 months

git:5.3:ad190539: uac: proper condition to chech if ha1 flag is set for uac reg authentication

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: ad1905397bd5bb7cca8c32f0f782fd340f07c68b URL: https://github.com/kamailio/kamailio/commit/ad1905397bd5bb7cca8c32f0f782fd3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-22T15:20:14+02:00 uac: proper condition to chech if ha1 flag is set for uac reg authentication - GH #2108 (cherry picked from commit 2a3186ee0f8a2989f8de154019fd0ad73b390d73) --- Modified: src/modules/uac/auth_alg.c --- Diff: https://github.com/kamailio/kamailio/commit/ad1905397bd5bb7cca8c32f0f782fd3… Patch: https://github.com/kamailio/kamailio/commit/ad1905397bd5bb7cca8c32f0f782fd3… --- diff --git a/src/modules/uac/auth_alg.c b/src/modules/uac/auth_alg.c index 07af9fc995..6b0b0d3bb3 100644 --- a/src/modules/uac/auth_alg.c +++ b/src/modules/uac/auth_alg.c @@ -96,7 +96,7 @@ void uac_calc_HA1( struct uac_credential *crd, MD5_CTX Md5Ctx; HASH HA1; - if(UAC_FLCRED_HA1 & UAC_FLCRED_HA1) { + if(crd->aflags & UAC_FLCRED_HA1) { memcpy(sess_key, crd->passwd.s, HASHHEXLEN); sess_key[HASHHEXLEN] = '\0'; if ( auth->flags& AUTHENTICATE_MD5SESS ) {

4 years, 8 months

git:master:2a3186ee: uac: proper condition to chech if ha1 flag is set for uac reg authentication

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 2a3186ee0f8a2989f8de154019fd0ad73b390d73 URL: https://github.com/kamailio/kamailio/commit/2a3186ee0f8a2989f8de154019fd0ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-22T15:16:30+02:00 uac: proper condition to chech if ha1 flag is set for uac reg authentication - GH #2108 --- Modified: src/modules/uac/auth_alg.c --- Diff: https://github.com/kamailio/kamailio/commit/2a3186ee0f8a2989f8de154019fd0ad… Patch: https://github.com/kamailio/kamailio/commit/2a3186ee0f8a2989f8de154019fd0ad… --- diff --git a/src/modules/uac/auth_alg.c b/src/modules/uac/auth_alg.c index 18e5601662..a140b07adf 100644 --- a/src/modules/uac/auth_alg.c +++ b/src/modules/uac/auth_alg.c @@ -96,7 +96,7 @@ void uac_calc_HA1( struct uac_credential *crd, MD5_CTX Md5Ctx; HASH HA1; - if(UAC_FLCRED_HA1 & UAC_FLCRED_HA1) { + if(crd->aflags & UAC_FLCRED_HA1) { memcpy(sess_key, crd->passwd.s, HASHHEXLEN); sess_key[HASHHEXLEN] = '\0'; if ( auth->flags& AUTHENTICATE_MD5SESS ) {

4 years, 8 months

git:5.3:d6a55699: domain: fix spelling error

by Victor Seva

Module: kamailio Branch: 5.3 Commit: d6a55699c56c5b298442d3bb10838304156d6850 URL: https://github.com/kamailio/kamailio/commit/d6a55699c56c5b298442d3bb1083830… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-22T11:14:46+02:00 domain: fix spelling error (cherry picked from commit 0944689db2eabbb531fc6daed9db3a9bcc1780b6) --- Modified: src/modules/domain/hash.c --- Diff: https://github.com/kamailio/kamailio/commit/d6a55699c56c5b298442d3bb1083830… Patch: https://github.com/kamailio/kamailio/commit/d6a55699c56c5b298442d3bb1083830… --- diff --git a/src/modules/domain/hash.c b/src/modules/domain/hash.c index b093dbc3e4..4cb968e458 100644 --- a/src/modules/domain/hash.c +++ b/src/modules/domain/hash.c @@ -137,7 +137,7 @@ int hash_table_install(struct domain_list **hash_table, str *did, str *domain) np->did.len = did->len; np->did.s = (char *)shm_malloc(did->len); if(np->did.s == NULL) { - LM_ERR("no shared memeory for did\n"); + LM_ERR("no shared memory for did\n"); shm_free(np); return -1; } @@ -210,4 +210,4 @@ void hash_table_free(struct domain_list **hash_table) hash_table[DOM_HASH_SIZE] = NULL; return; -} \ No newline at end of file +}

4 years, 8 months

git:master:c0879add: kamdbctl: split create user and grant access statements for mysql

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c0879add55bef77703f2259f224b4a1f954cd8bf URL: https://github.com/kamailio/kamailio/commit/c0879add55bef77703f2259f224b4a1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-22T10:49:18+02:00 kamdbctl: split create user and grant access statements for mysql - MySQL 8 doesn't support all in one statement --- Modified: utils/kamctl/kamdbctl.mysql --- Diff: https://github.com/kamailio/kamailio/commit/c0879add55bef77703f2259f224b4a1… Patch: https://github.com/kamailio/kamailio/commit/c0879add55bef77703f2259f224b4a1… --- diff --git a/utils/kamctl/kamdbctl.mysql b/utils/kamctl/kamdbctl.mysql index 6103705bc0..e8f8d2e861 100644 --- a/utils/kamctl/kamdbctl.mysql +++ b/utils/kamctl/kamdbctl.mysql @@ -160,8 +160,10 @@ kamailio_db_grant () # pars: <database name> minfo "granting privileges to database $1 ..." # Users: kamailio is the regular user, kamailioro only for reading - sql_query "" "GRANT ALL PRIVILEGES ON $1.* TO '${DBRWUSER}'@'$DBHOST' IDENTIFIED BY '$DBRWPW'; - GRANT SELECT ON $1.* TO '${DBROUSER}'@'$DBHOST' IDENTIFIED BY '$DBROPW';" + sql_query "" "CREATE USER '${DBRWUSER}'@'$DBHOST' IDENTIFIED BY '$DBRWPW'; + GRANT ALL PRIVILEGES ON $1.* TO '${DBRWUSER}'@'$DBHOST'; + CREATE USER '${DBROUSER}'@'$DBHOST' IDENTIFIED BY '$DBROPW'; + GRANT SELECT ON $1.* TO '${DBROUSER}'@'$DBHOST';" if [ $? -ne 0 ] ; then merr "granting privileges to database $1 failed!" @@ -169,8 +171,10 @@ kamailio_db_grant () # pars: <database name> fi if [ "$DBHOST" != "localhost" ] ; then - sql_query "" "GRANT ALL PRIVILEGES ON $1.* TO '$DBRWUSER'@'localhost' IDENTIFIED BY '$DBRWPW'; - GRANT SELECT ON $1.* TO '$DBROUSER'@'localhost' IDENTIFIED BY '$DBROPW';" + sql_query "" "CREATE USER '$DBRWUSER'@'localhost' IDENTIFIED BY '$DBRWPW'; + GRANT ALL PRIVILEGES ON $1.* TO '$DBRWUSER'@'localhost'; + CREATE USER '$DBROUSER'@'localhost' IDENTIFIED BY '$DBROPW'; + GRANT SELECT ON $1.* TO '$DBROUSER'@'localhost';" if [ $? -ne 0 ] ; then merr "granting localhost privileges to database $1 failed!" exit 1 @@ -178,8 +182,10 @@ kamailio_db_grant () # pars: <database name> fi if [ ! -z "$DBACCESSHOST" ] ; then - sql_query "" "GRANT ALL PRIVILEGES ON $1.* TO '$DBRWUSER'@'$DBACCESSHOST' IDENTIFIED BY '$DBRWPW'; - GRANT SELECT ON $1.* TO '$DBROUSER'@'$DBACCESSHOST' IDENTIFIED BY '$DBROPW';" + sql_query "" "CREATE USER '$DBRWUSER'@'$DBACCESSHOST' IDENTIFIED BY '$DBRWPW'; + GRANT ALL PRIVILEGES ON $1.* TO '$DBRWUSER'@'$DBACCESSHOST'; + CREATE USER '$DBROUSER'@'$DBACCESSHOST' IDENTIFIED BY '$DBROPW'; + GRANT SELECT ON $1.* TO '$DBROUSER'@'$DBACCESSHOST';" if [ $? -ne 0 ] ; then merr "granting access host privileges to database $1 failed!" exit 1

4 years, 8 months

git:5.3:09b3a82e: core: fix spelling error

by Victor Seva

Module: kamailio Branch: 5.3 Commit: 09b3a82e496dd6f45a8f55fb06ca8ff6d4582aa1 URL: https://github.com/kamailio/kamailio/commit/09b3a82e496dd6f45a8f55fb06ca8ff… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-22T10:27:37+02:00 core: fix spelling error (cherry picked from commit e35fe2d7b4ae79be6af9a70d8520620941960a72) --- Modified: src/core/ppcfg.c --- Diff: https://github.com/kamailio/kamailio/commit/09b3a82e496dd6f45a8f55fb06ca8ff… Patch: https://github.com/kamailio/kamailio/commit/09b3a82e496dd6f45a8f55fb06ca8ff… --- diff --git a/src/core/ppcfg.c b/src/core/ppcfg.c index 49065938af..584a491ba2 100644 --- a/src/core/ppcfg.c +++ b/src/core/ppcfg.c @@ -250,7 +250,7 @@ void pp_define_core(void) n = snprintf(p, 64 - (int)(p-defval), "_%d", VERSIONVAL/1000000); if(n<0 || n>=64 - (int)(p-defval)) { - LM_ERR("faild to build define token\n"); + LM_ERR("failed to build define token\n"); return; } pp_define_set_type(0); @@ -262,7 +262,7 @@ void pp_define_core(void) n = snprintf(p, 64 - (int)(p-defval), "_%d_%d", VERSIONVAL/1000000, (VERSIONVAL%1000000)/1000); if(n<0 || n>=64 - (int)(p-defval)) { - LM_ERR("faild to build define token\n"); + LM_ERR("failed to build define token\n"); return; } pp_define_set_type(0); @@ -274,7 +274,7 @@ void pp_define_core(void) n = snprintf(p, 64 - (int)(p-defval), "_%d_%d_%d", VERSIONVAL/1000000, (VERSIONVAL%1000000)/1000, VERSIONVAL%1000); if(n<0 || n>=64 - (int)(p-defval)) { - LM_ERR("faild to build define token\n"); + LM_ERR("failed to build define token\n"); return; } pp_define_set_type(0);

4 years, 8 months

git:5.3:81e39705: pua: fix spelling error

by Victor Seva

Module: kamailio Branch: 5.3 Commit: 81e39705affe8efe3e544ef34ae4e7649f745512 URL: https://github.com/kamailio/kamailio/commit/81e39705affe8efe3e544ef34ae4e76… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-10-22T10:27:33+02:00 pua: fix spelling error (cherry picked from commit d06e85d6fa9e75e8008bc422a7596671283054f7) --- Modified: src/modules/pua/send_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/81e39705affe8efe3e544ef34ae4e76… Patch: https://github.com/kamailio/kamailio/commit/81e39705affe8efe3e544ef34ae4e76… --- diff --git a/src/modules/pua/send_subscribe.c b/src/modules/pua/send_subscribe.c index 254e77e7fd..fd13836391 100644 --- a/src/modules/pua/send_subscribe.c +++ b/src/modules/pua/send_subscribe.c @@ -669,7 +669,7 @@ void subs_cback_func(struct cell *t, int cb_type, struct tmcb_params *ps) { LM_DBG("BLA_SUBSCRIBE FLAG inserted\n"); } - LM_DBG("record for subscribe from %.*s to %.*s inserted in datatbase\n", + LM_DBG("record for subscribe from %.*s to %.*s inserted in database\n", presentity->watcher_uri->len, presentity->watcher_uri->s, presentity->pres_uri->len, presentity->pres_uri->s);

4 years, 8 months

← Newer
1
...
15
16
17
18
19
20
21
...
44
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2019