sr-dev February 2015

sr-dev@lists.kamailio.org

39 participants
341 discussions

[kamailio] append_branch add to branch route first R_URI twice (#72)

by ovoshlook

Hello I use this version of kamailio kamailio -v version: kamailio 4.3.0-dev3 (x86_64/linux) 8cdbe7 flags: STATS: Off, USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, DBG_F_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 8cdbe7 compiled on 17:54:50 Jan 20 2015 with gcc 4.8.2 I hav an issue with append branches to branch route when I need fork call to one endpoint woth different destionations. I use my own algorithm for call to this devices because with lookup("location") I can not use RTPENGINE for different types of endpoints (web endoints and standart UDP endpoints) My alg is here: { sql_query("ca", "select contact from location where username='$tU'", "ra"); xlog("L_INFO","rows: $dbr(ra=>rows) cols: $dbr(ra=>cols)\n"); if($dbr(ra=>rows)>0){ $var(i)=0; while($var(i)<$dbr(ra=>rows)){ xlog("L_INFO","SQL query return contact {$dbr(ra=>[$var(i),0])} for {$tU} at step {$var(i)}\n"); if ($dbr(ra=>[$var(i),0])=~"transport=ws"){ xlog("L_INFO", "This is a Websocket call to endpoint"); sql_pvquery("ca", "select received from location where contact='$dbr(ra=>[$var(i),0])'","$var(recieved)"); $du=$var(recieved); xlog("L_INFO","SQL query return recieved {$var(recieved)} for {$tU}. Destination is {$du}\n"); append_branch("sip:$tU@$(du{s.select,1,:})"); } else { xlog("L_INFO", "This is a classic UDP call to endpoint"); $var(recieved)=''; sql_pvquery("ca", "select received from location where contact='$dbr(ra=>[$var(i),0])'","$var(recieved)"); xlog("L_INFO", "SQL query return RECIEVED {$var(recieved)}"); if ($var(recieved)==0){ xlog("L_INFO", "Recieved string is EMPTY"); $du="sip:"+$(dbr(ra=>[$var(i),0]){s.select,1,@}); } else { xlog("L_INFO", "Recieved string is {$var(recieved)}"); $du=$var(recieved); } $var(UDP_contact)="sip:"+$(dbr(ra=>[$var(i),0]){s.select,1,@}); append_branch("sip:$tU@$(du{s.select,1,:})"); xlog("L_INFO","Classic Destination URI is {$dbr(ra=>[$var(i),0])} for {$tU}}. Destination is {$du}\n"); } $var(i) = $var(i) + 1; } } else{ exit; } t_on_branch("1"); return; } } } branch_route[1]{ if($du=~"transport=ws"){ xlog("L_INFO","Websocket Branch is {$du} for {$tU}\n"); rtpengine_manage("internal extenal force trust-address replace-origin replace-session-connection ICE=force RTP/SAVPF"); t_on_reply("REPLY_FROM_WS"); } else{ xlog("L_INFO","UDP Branch is {$du)} for {$tU}\n"); rtpengine_manage("replace-origin replace-session-connection ICE=remove RTP/AVP"); t_on_reply("MANAGE_CLASSIC_REPLY"); } } So as you see I choose array of devices and then set its to branches. At the kamailio console I see output This is output of alg that above. I have 3 devices: 2 websocket devices and 1 udp But when you look at dump where rtpengine make changes with packets you can see that it runs for 4 devices and 1 and 4 devices is the same. You can see start of every branch from words of log "Websocket Branch is" or "UDP Branch is" So this bug gives a mistake because some of hardphones can not handlie double INVITE and kamilio response for this devices cancel with 200 cause because hardphone set 482 reply to kamialio. (you can see it reply at the log) Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: rows: 3 cols: 1 Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: SQL query return contact {sip:5ue13vsh@2t4iielj109h.invalid;transport=ws} for {123455678} at step {0} Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: This is a Websocket call to endpoint Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: SQL query return recieved {sip:85.6.14.8:4328;transport=WS} for {123455678}. Destination is {sip:85.6.14.8:4328;transport=WS} Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: SQL query return contact {sip:a7uo9vsq@7c0oo5kvc71e.invalid;transport=ws} for {123455678} at step {1} Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: This is a Websocket call to endpoint Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: SQL query return recieved {sip:85.2.10.3:58509;transport=WS} for {123455678}. Destination is {sip:85.2.10.3:58509;transport=WS} Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: SQL query return contact {sip:upsjchv2@5c88tisd29d4.invalid;transport=ws} for {123455678} at step {2} Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: This is a Websocket call to endpoint Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: SQL query return recieved {sip:18.9.18.10:56917;transport=WS} for {123455678}. Destination is {sip:18.9.18.10:56917;transport=WS} Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: Websocket Branch is {sip:18.9.18.10:56917;transport=WS} for {123455678} Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Got valid command from 127.0.0.1:52689: offer - { "sdp": "v=0#015#012o=root 1141861088 1141861088 IN IP4 12.34.56.78#015#012s=Asterisk PBX 13.1.0#015#012c=IN IP4 12.34.56.78#015#012t=0 0#015#012m=audio 12230 RTP/AVP 9 8 107 0 101#015#012a=rtpmap:9 G722/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:107 opus/48000/2#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=fmtp:101 0-16#015#012a=maxptime:60#015#012a=sendrecv#015#012", "ICE": "force", "direction": [ "internal" ], "flags": [ "extenal", "force", "trust-address" ], "replace": [ "origin", ... Feb 8 23:04:43 Kamailio2 rtpengine[55410]: ... "session-connection" ], "transport-protocol": "RTP/SAVPF", "call-id": "220725c425526bc941dff8e972bd9458@12.34.56.78:50600", "received-from": [ "IP4", "12.34.56.78" ], "from-tag": "as4f0c032f", "command": "offer" } Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Unknown flag encountered: 'extenal' Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Unknown flag encountered: 'force' Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] Creating new call Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] Returning to SIP proxy: d3:sdp747:v=0#015#012o=root 1141861088 1141861088 IN IP4 23.101.139.216#015#012s=Asterisk PBX 13.1.0#015#012c=IN IP4 23.101.139.216#015#012t=0 0#015#012a=ice-lite#015#012m=audio 38518 RTP/SAVPF 9 8 107 0 101#015#012a=rtpmap:9 G722/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:107 opus/48000/2#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=fmtp:101 0-16#015#012a=maxptime:60#015#012a=sendrecv#015#012a=rtcp:38519#015#012a=crypto:1 AES_CM_128_HMAC_SHA1_80 inline:f31jYQjjKBdYoqWYijx0V/ZtTfP17pTVW8NJGVQ4#015#012a=setup:actpass#015#012a=fingerprint:sh ... Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] ... a-1 00:E3:0F:B6:C0:9F:D4:16:52:D2:41:A8:01:24:51:CD:3F:FB:B2:55#015#012a=ice-ufrag:VfqUSGBP#015#012a=ice-pwd:t5bLzDaNcqWUwzh7iEtyAZfweGo6#015#012a=candidate:04GQy5683m4TP1Da 1 UDP 2130706431 23.101.139.216 38518 typ host#015#012a=candidate:04GQy5683m4TP1Da 2 UDP 2130706430 23.101.139.216 38519 typ host#015#0126:result2:oke Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: Websocket Branch is {sip:85.6.14.8:4328;transport=WS} for {123455678} Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Got valid command from 127.0.0.1:52689: offer - { "sdp": "v=0#015#012o=root 1141861088 1141861088 IN IP4 12.34.56.78#015#012s=Asterisk PBX 13.1.0#015#012c=IN IP4 12.34.56.78#015#012t=0 0#015#012m=audio 12230 RTP/AVP 9 8 107 0 101#015#012a=rtpmap:9 G722/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:107 opus/48000/2#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=fmtp:101 0-16#015#012a=maxptime:60#015#012a=sendrecv#015#012", "ICE": "force", "direction": [ "internal" ], "flags": [ "extenal", "force", "trust-address" ], "replace": [ "origin", ... Feb 8 23:04:43 Kamailio2 rtpengine[55410]: ... "session-connection" ], "transport-protocol": "RTP/SAVPF", "call-id": "220725c425526bc941dff8e972bd9458@12.34.56.78:50600", "received-from": [ "IP4", "12.34.56.78" ], "from-tag": "as4f0c032f", "command": "offer" } Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Unknown flag encountered: 'extenal' Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Unknown flag encountered: 'force' Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] Returning to SIP proxy: d3:sdp747:v=0#015#012o=root 1141861088 1141861088 IN IP4 23.101.139.216#015#012s=Asterisk PBX 13.1.0#015#012c=IN IP4 23.101.139.216#015#012t=0 0#015#012a=ice-lite#015#012m=audio 38518 RTP/SAVPF 9 8 107 0 101#015#012a=rtpmap:9 G722/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:107 opus/48000/2#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=fmtp:101 0-16#015#012a=maxptime:60#015#012a=sendrecv#015#012a=rtcp:38519#015#012a=crypto:1 AES_CM_128_HMAC_SHA1_80 inline:f31jYQjjKBdYoqWYijx0V/ZtTfP17pTVW8NJGVQ4#015#012a=setup:actpass#015#012a=fingerprint:sh ... Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] ... a-1 00:E3:0F:B6:C0:9F:D4:16:52:D2:41:A8:01:24:51:CD:3F:FB:B2:55#015#012a=ice-ufrag:VfqUSGBP#015#012a=ice-pwd:t5bLzDaNcqWUwzh7iEtyAZfweGo6#015#012a=candidate:04GQy5683m4TP1Da 1 UDP 2130706431 23.101.139.216 38518 typ host#015#012a=candidate:04GQy5683m4TP1Da 2 UDP 2130706430 23.101.139.216 38519 typ host#015#0126:result2:oke Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: Websocket Branch is {sip:85.2.10.3:58509;transport=WS} for {123455678} Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Got valid command from 127.0.0.1:52689: offer - { "sdp": "v=0#015#012o=root 1141861088 1141861088 IN IP4 12.34.56.78#015#012s=Asterisk PBX 13.1.0#015#012c=IN IP4 12.34.56.78#015#012t=0 0#015#012m=audio 12230 RTP/AVP 9 8 107 0 101#015#012a=rtpmap:9 G722/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:107 opus/48000/2#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=fmtp:101 0-16#015#012a=maxptime:60#015#012a=sendrecv#015#012", "ICE": "force", "direction": [ "internal" ], "flags": [ "extenal", "force", "trust-address" ], "replace": [ "origin", ... Feb 8 23:04:43 Kamailio2 rtpengine[55410]: ... "session-connection" ], "transport-protocol": "RTP/SAVPF", "call-id": "220725c425526bc941dff8e972bd9458@12.34.56.78:50600", "received-from": [ "IP4", "12.34.56.78" ], "from-tag": "as4f0c032f", "command": "offer" } Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Unknown flag encountered: 'extenal' Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Unknown flag encountered: 'force' Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] Returning to SIP proxy: d3:sdp747:v=0#015#012o=root 1141861088 1141861088 IN IP4 23.101.139.216#015#012s=Asterisk PBX 13.1.0#015#012c=IN IP4 23.101.139.216#015#012t=0 0#015#012a=ice-lite#015#012m=audio 38518 RTP/SAVPF 9 8 107 0 101#015#012a=rtpmap:9 G722/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:107 opus/48000/2#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=fmtp:101 0-16#015#012a=maxptime:60#015#012a=sendrecv#015#012a=rtcp:38519#015#012a=crypto:1 AES_CM_128_HMAC_SHA1_80 inline:f31jYQjjKBdYoqWYijx0V/ZtTfP17pTVW8NJGVQ4#015#012a=setup:actpass#015#012a=fingerprint:sh ... Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] ... a-1 00:E3:0F:B6:C0:9F:D4:16:52:D2:41:A8:01:24:51:CD:3F:FB:B2:55#015#012a=ice-ufrag:VfqUSGBP#015#012a=ice-pwd:t5bLzDaNcqWUwzh7iEtyAZfweGo6#015#012a=candidate:04GQy5683m4TP1Da 1 UDP 2130706431 23.101.139.216 38518 typ host#015#012a=candidate:04GQy5683m4TP1Da 2 UDP 2130706430 23.101.139.216 38519 typ host#015#0126:result2:oke Feb 8 23:04:43 Kamailio2 kamailio[59406]: INFO: <script>: Websocket Branch is {sip:18.9.18.10:56917;transport=WS} for {123455678} Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Got valid command from 127.0.0.1:52689: offer - { "sdp": "v=0#015#012o=root 1141861088 1141861088 IN IP4 12.34.56.78#015#012s=Asterisk PBX 13.1.0#015#012c=IN IP4 12.34.56.78#015#012t=0 0#015#012m=audio 12230 RTP/AVP 9 8 107 0 101#015#012a=rtpmap:9 G722/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:107 opus/48000/2#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=fmtp:101 0-16#015#012a=maxptime:60#015#012a=sendrecv#015#012", "ICE": "force", "direction": [ "internal" ], "flags": [ "extenal", "force", "trust-address" ], "replace": [ "origin", ... Feb 8 23:04:43 Kamailio2 rtpengine[55410]: ... "session-connection" ], "transport-protocol": "RTP/SAVPF", "call-id": "220725c425526bc941dff8e972bd9458@12.34.56.78:50600", "received-from": [ "IP4", "12.34.56.78" ], "from-tag": "as4f0c032f", "command": "offer" } Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Unknown flag encountered: 'extenal' Feb 8 23:04:43 Kamailio2 rtpengine[55410]: Unknown flag encountered: 'force' Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] Returning to SIP proxy: d3:sdp747:v=0#015#012o=root 1141861088 1141861088 IN IP4 23.101.139.216#015#012s=Asterisk PBX 13.1.0#015#012c=IN IP4 23.101.139.216#015#012t=0 0#015#012a=ice-lite#015#012m=audio 38518 RTP/SAVPF 9 8 107 0 101#015#012a=rtpmap:9 G722/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:107 opus/48000/2#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=fmtp:101 0-16#015#012a=maxptime:60#015#012a=sendrecv#015#012a=rtcp:38519#015#012a=crypto:1 AES_CM_128_HMAC_SHA1_80 inline:f31jYQjjKBdYoqWYijx0V/ZtTfP17pTVW8NJGVQ4#015#012a=setup:actpass#015#012a=fingerprint:sh ... Feb 8 23:04:43 Kamailio2 rtpengine[55410]: [220725c425526bc941dff8e972bd9458@12.34.56.78:50600] ... a-1 00:E3:0F:B6:C0:9F:D4:16:52:D2:41:A8:01:24:51:CD:3F:FB:B2:55#015#012a=ice-ufrag:VfqUSGBP#015#012a=ice-pwd:t5bLzDaNcqWUwzh7iEtyAZfweGo6#015#012a=candidate:04GQy5683m4TP1Da 1 UDP 2130706431 23.101.139.216 38518 typ host#015#012a=candidate:04GQy5683m4TP1Da 2 UDP 2130706430 23.101.139.216 38519 typ host#015#0126:result2:oke Feb 8 23:04:43 Kamailio2 kamailio[59438]: INFO: <script>: Reply from webrtc client {18.9.18.10:56917} for method {INVITE}: 100 Feb 8 23:04:43 Kamailio2 kamailio[59438]: INFO: <script>: Manage_Reply from webrtc client {18.9.18.10:56917} for method {INVITE}: 100 Feb 8 23:04:43 Kamailio2 kamailio[59438]: INFO: <script>: Reply from webrtc client {18.9.18.10:56917} for method {INVITE}: 180 Feb 8 23:04:43 Kamailio2 kamailio[59438]: INFO: <script>: Manage_Reply from webrtc client {18.9.18.10:56917} for method {INVITE}: 180 Feb 8 23:04:43 Kamailio2 kamailio[59438]: INFO: <script>: Reply from webrtc client {18.9.18.10:56917} for method {INVITE}: 482 Feb 8 23:04:43 Kamailio2 kamailio[59442]: INFO: <script>: Reply from webrtc client {85.2.10.3:58509} for method {INVITE}: 100 Feb 8 23:04:43 Kamailio2 kamailio[59442]: INFO: <script>: Manage_Reply from webrtc client {85.2.10.3:58509} for method {INVITE}: 100 --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/72

9 years, 2 months

[kamailio] presence_dialoginfo: rfc4235 in dummy dialog (#97)

by lazedo

according to rfc4235 the id element is mandatory. granstream phones are affected by this. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/97 -- Commit Summary -- * presence_dialoginfo: rfc4235 in dummy dialog -- File Changes -- M modules/presence_dialoginfo/notify_body.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/97.patch https://github.com/kamailio/kamailio/pull/97.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/97

9 years, 2 months

[kamailio] fix - dummy dialog rfc4235 (#96)

by lazedo

grandstream validates the dialog and according to rfc4235 the id element is mandatory You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/96 -- Commit Summary -- * fix - dummy dialog rfc4235 -- File Changes -- M modules/presence_dialoginfo/notify_body.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/96.patch https://github.com/kamailio/kamailio/pull/96.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/96

9 years, 2 months

deb.kamailio.org down?

by Peter Villeneuve

Hi, I think that deb.kamailio.org is down. All my ping requests timeout and I can't update the packages.

9 years, 2 months

git:master:20d0a188: tls: if port is 0 in tls client profile cfg definition, ignore matching port

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 20d0a188701127dae34dd40d7f14be0037d0b888 URL: https://github.com/kamailio/kamailio/commit/20d0a188701127dae34dd40d7f14be0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-24T12:29:51+01:00 tls: if port is 0 in tls client profile cfg definition, ignore matching port - tcp port can be randomly allocated by OS, making hard to guess it in advance --- Modified: modules/tls/tls_domain.c Modified: modules/tls/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/20d0a188701127dae34dd40d7f14be0… Patch: https://github.com/kamailio/kamailio/commit/20d0a188701127dae34dd40d7f14be0… --- diff --git a/modules/tls/tls_domain.c b/modules/tls/tls_domain.c index e31a4fe..0d95a62 100644 --- a/modules/tls/tls_domain.c +++ b/modules/tls/tls_domain.c @@ -1308,7 +1308,7 @@ tls_domain_t* tls_lookup_cfg(tls_domains_cfg_t* cfg, int type, p->server_name.len, ZSW(p->server_name.s), sname->len, ZSW(sname->s)); } - if ((p->port == port) && ip_addr_cmp(&p->ip, ip)) { + if ((p->port==0 || p->port == port) && ip_addr_cmp(&p->ip, ip)) { if(sname && sname->len>0) { if(p->server_name.len==sname->len && strncasecmp(p->server_name.s, sname->s, sname->len)==0) { diff --git a/modules/tls/tls_server.c b/modules/tls/tls_server.c index 28cf1a3..26872c9 100644 --- a/modules/tls/tls_server.c +++ b/modules/tls/tls_server.c @@ -196,16 +196,8 @@ static int tls_complete_init(struct tcp_connection* c) } else { state=S_TLS_CONNECTING; sname = tls_get_connect_server_name(); - if(&c->rcv.bind_address!=NULL) { - /* if there is a bind_address, use it, because the src port - * for connection can be randomly assigned by OS */ - dom = tls_lookup_cfg(cfg, TLS_DOMAIN_CLI, - &c->rcv.bind_address->address, - c->rcv.bind_address->port_no, sname); - } else { - dom = tls_lookup_cfg(cfg, TLS_DOMAIN_CLI, + dom = tls_lookup_cfg(cfg, TLS_DOMAIN_CLI, &c->rcv.dst_ip, c->rcv.dst_port, sname); - } } if (unlikely(c->state<0)) { BUG("Invalid connection (state %d)\n", c->state);

9 years, 2 months

git:master:5e3880fb: tls: clone tokens for ipv6 address in tls profile for parsing

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5e3880fb0f71821639610ea5b74cafe9a6675a4c URL: https://github.com/kamailio/kamailio/commit/5e3880fb0f71821639610ea5b74cafe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-24T12:25:38+01:00 tls: clone tokens for ipv6 address in tls profile for parsing - cfg parsing is moving the pointers, forgetting the previous parts --- Modified: modules/tls/tls_config.c --- Diff: https://github.com/kamailio/kamailio/commit/5e3880fb0f71821639610ea5b74cafe… Patch: https://github.com/kamailio/kamailio/commit/5e3880fb0f71821639610ea5b74cafe… --- diff --git a/modules/tls/tls_config.c b/modules/tls/tls_config.c index 3960c5f..e1dca1b 100644 --- a/modules/tls/tls_config.c +++ b/modules/tls/tls_config.c @@ -51,16 +51,19 @@ static int parse_ipv6(struct ip_addr* ip, cfg_token_t* token, cfg_token_t t; struct ip_addr* ipv6; str ip6_str; + char ip6_buff[IP_ADDR_MAX_STR_SIZE+3]; - ip6_str.s = t.val.s; + ip6_buff[0] = '\0'; while(1) { ret = cfg_get_token(&t, st, 0); if (ret != 0) goto err; if (t.type == ']') break; if (t.type != CFG_TOKEN_ALPHA && t.type != ':') goto err; + strncat(ip6_buff, t.val.s, t.val.len); } - ip6_str.len = (int)(long)(t.val.s - ip6_str.s); - + ip6_str.s = ip6_buff; + ip6_str.len = strlen(ip6_buff); + LM_DBG("found IPv6 address [%.*s]\n", ip6_str.len, ip6_str.s); ipv6 = str2ip6(&ip6_str); if (ipv6 == 0) goto err; *ip = *ipv6;

9 years, 2 months

git:master:c1bf2048: tls: try to lookup client profile via bind address

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c1bf2048de60c4abb9a5b8b343f50400deefa3bf URL: https://github.com/kamailio/kamailio/commit/c1bf2048de60c4abb9a5b8b343f5040… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-02-24T12:25:38+01:00 tls: try to lookup client profile via bind address - local address connection can have a randomly allocated port by os --- Modified: modules/tls/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/c1bf2048de60c4abb9a5b8b343f5040… Patch: https://github.com/kamailio/kamailio/commit/c1bf2048de60c4abb9a5b8b343f5040… --- diff --git a/modules/tls/tls_server.c b/modules/tls/tls_server.c index b7e3207..28cf1a3 100644 --- a/modules/tls/tls_server.c +++ b/modules/tls/tls_server.c @@ -196,8 +196,16 @@ static int tls_complete_init(struct tcp_connection* c) } else { state=S_TLS_CONNECTING; sname = tls_get_connect_server_name(); - dom = tls_lookup_cfg(cfg, TLS_DOMAIN_CLI, - &c->rcv.dst_ip, c->rcv.dst_port, sname); + if(&c->rcv.bind_address!=NULL) { + /* if there is a bind_address, use it, because the src port + * for connection can be randomly assigned by OS */ + dom = tls_lookup_cfg(cfg, TLS_DOMAIN_CLI, + &c->rcv.bind_address->address, + c->rcv.bind_address->port_no, sname); + } else { + dom = tls_lookup_cfg(cfg, TLS_DOMAIN_CLI, + &c->rcv.dst_ip, c->rcv.dst_port, sname); + } } if (unlikely(c->state<0)) { BUG("Invalid connection (state %d)\n", c->state);

9 years, 2 months

git:master:0506b989: kazoo - fix crashing on heavy load

by Luis Azedo

Module: kamailio Branch: master Commit: 0506b9898867c5d165defa0acf1501cad13513eb URL: https://github.com/kamailio/kamailio/commit/0506b9898867c5d165defa0acf1501c… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: 2015-02-24T09:33:53Z kazoo - fix crashing on heavy load --- Modified: modules/kazoo/kazoo.c Modified: modules/kazoo/kz_amqp.c Modified: modules/kazoo/kz_amqp.h --- Diff: https://github.com/kamailio/kamailio/commit/0506b9898867c5d165defa0acf1501c… Patch: https://github.com/kamailio/kamailio/commit/0506b9898867c5d165defa0acf1501c…

9 years, 2 months

[tracker] Task opened: [RTIMER] specified route block doesn't be executed...

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Jack Wang (GoGoJack) Attached to Project - sip-router Summary - [RTIMER] specified route block doesn't be executed... Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - Medium Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - Hello everyone, I got a little trouble on using the RTIMER module. Sometimes the route block I set using the "exec" parameter in RTIMER module doesn't be executed, this will happen from Kamailio server being started, and only work (not always) after restarting server. I have no idea why this happen, does anyone ever met this? Which part should I notice? Thx :) More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=506 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 2 months

Re: [sr-dev] aastra outbound support

by GG GG

Ok ! I keep the patch running. With the patch, the AOR is saved and the outbound routing works. Thank you. On Mon, Feb 23, 2015 at 4:25 PM, <sr-dev-request(a)lists.sip-router.org> wrote: > Send sr-dev mailing list submissions to > sr-dev(a)lists.sip-router.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev > or, via email, send a message with subject or body 'help' to > sr-dev-request(a)lists.sip-router.org > > You can reach the person managing the list at > sr-dev-owner(a)lists.sip-router.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of sr-dev digest..." > > > Today's Topics: > > 1. git:master:91596953: sdpops: safety check when location a= > line not to exceed end of message (Daniel-Constantin Mierla) > 2. Re: [kamailio] registrar - additional features (#91) (lazedo) > 3. aastra outbound support (GG GG) > 4. git:master:b9e5b918: kazoo - fix timeouts (Luis Azedo) > 5. git:4.2:449ba0c0: kazoo - fix timeouts (Luis Azedo) > 6. git:4.2:e24c9ff7: sdpops: safety check when location a= line > not to exceed end of message (Daniel-Constantin Mierla) > 7. Issue after tcpops enhancement for lifetime per connection > (Daniel-Constantin Mierla) > 8. Re: aastra outbound support (Daniel-Constantin Mierla) > 9. Re: [kamailio] registrar - additional features (#91) > (Daniel-Constantin Mierla) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Mon, 23 Feb 2015 14:31:19 +0100 > From: Daniel-Constantin Mierla <miconda(a)gmail.com> > To: sr-dev(a)lists.sip-router.org > Subject: [sr-dev] git:master:91596953: sdpops: safety check when > location a= line not to exceed end of message > Message-ID: <E1YPt6V-0004Hd-UP(a)www.kamailio.org> > > Module: kamailio > Branch: master > Commit: 91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285 > URL: > https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… > > Author: Daniel-Constantin Mierla <miconda(a)gmail.com> > Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> > Date: 2015-02-23T14:29:46+01:00 > > sdpops: safety check when location a= line not to exceed end of message > > --- > > Modified: modules/sdpops/sdpops_mod.c > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… > Patch: > https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d… > > --- > > diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c > index 3357bb2..2a4aa6b 100644 > --- a/modules/sdpops/sdpops_mod.c > +++ b/modules/sdpops/sdpops_mod.c > @@ -159,12 +159,17 @@ static int mod_init(void) > int sdp_locate_line(sip_msg_t* msg, char *pos, str *aline) > { > char *p; > + char *bend; > + > p = pos; > while(*p!='\n') p--; > aline->s = p + 1; > p = pos; > - while(*p!='\n') p++; > + bend = msg->buf+msg->len; > + while(*p!='\n' && p<bend) p++; > aline->len = p - aline->s + 1; > + if(unlikely(p==bend)) aline->len--; > + > return 0; > } > > > > > > ------------------------------ > > Message: 2 > Date: Mon, 23 Feb 2015 06:14:31 -0800 > From: lazedo <notifications(a)github.com> > To: Kamailio Devel List <sr-dev(a)lists.sip-router.org> > Subject: Re: [sr-dev] [kamailio] registrar - additional features (#91) > Message-ID: <kamailio/kamailio/pull/91/c75547064(a)github.com> > Content-Type: text/plain; charset="utf-8" > > @miconda can you check if this is acceptable ? thanks. > > --- > Reply to this email directly or view it on GitHub: > https://github.com/kamailio/kamailio/pull/91#issuecomment-75547064 >

9 years, 2 months

← Newer
1
...
4
5
6
7
8
9
10
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2015