24 Feb
2015
24 Feb
'15
5:05 a.m.
grandstream validates the dialog and according to rfc4235 the id element is mandatory
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/96
-- Commit Summary --
* fix - dummy dialog rfc4235
-- File Changes --
M modules/presence_dialoginfo/notify_body.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/96.patch
https://github.com/kamailio/kamailio/pull/96.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/96
24 Feb
24 Feb
9:56 a.m.
please @lazedo follow the https://www.kamailio.org/wiki/devel/git-commit-guidelines
Something like:
presence_dialoginfo: obey rfc4235 adding id element for dummy dialog
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/96#issuecomment-75770961
10:55 a.m.
you're right, missed the "presence_dialoginfo : "
________________________________
From: sr-dev [sr-dev-bounces(a)lists.sip-router.org] on behalf of Victor Seva
[notifications(a)github.com]
Sent: Tuesday, February 24, 2015 6:56 AM
To: Kamailio Devel List
Subject: Re: [sr-dev] [kamailio] fix - dummy dialog rfc4235 (#96)
please @lazedo<https://github.com/lazedo> follow the
https://www.kamailio.org/wiki/devel/git-commit-guidelines
Something like:
presence_dialoginfo: obey rfc4235 adding id element for dummy dialog
—
Reply to this email directly or view it on
GitHub<https://github.com/kamailio/kamailio/pull/96#issuecomment-7577096…61>.
11 a.m.
Closed #96.
---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/96#event-241010059
3381
days inactive
3381
days old
3 comments
3 participants
participants (3)
-
lazedo -
Luis Azedo -
Victor Seva