sr-dev November 2013

sr-dev@lists.kamailio.org

29 participants
220 discussions

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml
by sip-router 04 Nov '13

04 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Daniel-Constantin Mierla (miconda) ---------- I see that the patch doesn't handle trying and proceeding states, from what was before. Any reason for it? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=341#comment1149 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Dialog_ng database support
by Carlos Ruiz Díaz 04 Nov '13

04 Nov '13

Hi, I've added database support to the dialog_ng module and I wonder if I should push the changes to master or should I create a new branch to maintain these changes while the testing phase lasts. What would you recommend? Thanks, -- Carlos http://caruizdiaz.com +595981146623

2 2

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml (Attachment added)
by sip-router 04 Nov '13

04 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Devs Voicenter (voicenter) ---------- Sorry i was out for few weeks. Are this format(replaced spaces to tab with vim) and code ( got rid of extra for loop and put everything in one place) better? ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=341#comment1148 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: Makefile.defs: version set to 4.1.0-pre1
by Daniel-Constantin Mierla 04 Nov '13

04 Nov '13

Module: sip-router Branch: master Commit: 27a73a806cece55bc7c707735856770137c2d680 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=27a73a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 4 11:21:27 2013 +0100 Makefile.defs: version set to 4.1.0-pre1 --- Makefile.defs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index 1beb515..8b58f2b 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -165,7 +165,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 4 PATCHLEVEL = 1 SUBLEVEL = 0 -EXTRAVERSION = -pre0 +EXTRAVERSION = -pre1 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

[tracker] Task closed: pua_reginfo: Duplicate contacts in the location table
by sip-router 04 Nov '13

04 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#350 - pua_reginfo: Duplicate contacts in the location table User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=350 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: pua_reginfo: Duplicate contacts in the location table
by sip-router 04 Nov '13

04 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#350 - pua_reginfo: Duplicate contacts in the location table User who did this - Daniel-Constantin Mierla (miconda) ---------- Thanks. Patch was applied to master branch. It didn't work on branch 4.0, I guess some other patches will have to be backported first -- I will look over soon. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=350#comment1147 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: pua_reginfo: reflect use domain from usrloc
by Daniel-Constantin Mierla 04 Nov '13

04 Nov '13

Module: sip-router Branch: master Commit: 8a246b06838b99e63d86fe186b23a23f57347548 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8a246b0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 4 10:04:35 2013 +0100 pua_reginfo: reflect use domain from usrloc - avoid duplicate contacts if domain is not considered - patch by Wonbin Cho, FS#350 --- modules/pua_reginfo/notify.c | 24 ++++++++++++++++-------- modules/pua_reginfo/pua_reginfo.c | 7 +++++++ modules/pua_reginfo/pua_reginfo.h | 2 ++ 3 files changed, 25 insertions(+), 8 deletions(-) diff --git a/modules/pua_reginfo/notify.c b/modules/pua_reginfo/notify.c index 1187e34..c1ea699 100644 --- a/modules/pua_reginfo/notify.c +++ b/modules/pua_reginfo/notify.c @@ -208,6 +208,8 @@ int reginfo_parse_event(char * s) { int process_body(str notify_body, udomain_t * domain) { xmlDocPtr doc= NULL; xmlNodePtr doc_root = NULL, registrations = NULL, contacts = NULL, uris = NULL; + char uri[MAX_URI_SIZE]; + str aor_key = {0, 0}; str aor = {0, 0}; str callid = {0, 0}; str contact_uri = {0, 0}; @@ -260,14 +262,20 @@ int process_body(str notify_body, udomain_t * domain) { goto next_registration; } + if (reginfo_use_domain) { + aor_key.s = uri; + } else { + aor_key.s = parsed_aor.user.s; + } + aor_key.len = strlen(aor_key.s); /* Now let's lock that domain for this AOR: */ - ul.lock_udomain(domain, &aor); + ul.lock_udomain(domain, &aor_key); /* and retrieve the user-record for this user: */ - result = ul.get_urecord(domain, &aor, &ul_record); + result = ul.get_urecord(domain, &aor_key, &ul_record); if (result < 0) { - ul.unlock_udomain(domain, &aor); + ul.unlock_udomain(domain, &aor_key); LM_ERR("failed to query usrloc (AOR %.*s)\n", - aor.len, aor.s); + aor_key.len, aor_key.s); goto next_registration; } /* If no contacts found, then set the ul_record to NULL */ @@ -285,7 +293,7 @@ int process_body(str notify_body, udomain_t * domain) { } ul_contact = ul_contact->next; } - if (ul.delete_urecord(domain, &aor, ul_record) < 0) { + if (ul.delete_urecord(domain, &aor_key, ul_record) < 0) { LM_ERR("failed to remove record from usrloc\n"); } /* If already a registration with contacts was found, then keep that result. @@ -371,7 +379,7 @@ int process_body(str notify_body, udomain_t * domain) { contact_uri.len, contact_uri.s); /* Add to Usrloc: */ - result = process_contact(domain, &ul_record, parsed_aor.user, callid, cseq, expires, event, contact_uri); + result = process_contact(domain, &ul_record, aor_key, callid, cseq, expires, event, contact_uri); /* Process the result */ if (final_result != RESULT_CONTACTS_FOUND) final_result = result; @@ -385,8 +393,8 @@ next_contact: next_registration: // if (ul_record) ul.release_urecord(ul_record); /* Unlock the domain for this AOR: */ - if (aor.len > 0) - ul.unlock_udomain(domain, &aor); + if (aor_key.len > 0) + ul.unlock_udomain(domain, &aor_key); registrations = registrations->next; } diff --git a/modules/pua_reginfo/pua_reginfo.c b/modules/pua_reginfo/pua_reginfo.c index 73d7113..b3ddb26 100644 --- a/modules/pua_reginfo/pua_reginfo.c +++ b/modules/pua_reginfo/pua_reginfo.c @@ -46,6 +46,8 @@ int publish_reginfo = 1; sruid_t _reginfo_sruid; +int reginfo_use_domain = 0; + /** Fixup functions */ static int domain_fixup(void** param, int param_no); @@ -167,6 +169,11 @@ static int mod_init(void) if(sruid_init(&_reginfo_sruid, (char)'-', "regi", SRUID_INC)<0) return -1; + /* + * Import use_domain parameter from usrloc + */ + reginfo_use_domain = ul.use_domain; + return 0; } diff --git a/modules/pua_reginfo/pua_reginfo.h b/modules/pua_reginfo/pua_reginfo.h index 2ff8e54..972ae0b 100644 --- a/modules/pua_reginfo/pua_reginfo.h +++ b/modules/pua_reginfo/pua_reginfo.h @@ -34,4 +34,6 @@ str server_address; extern usrloc_api_t ul; /*!< Structure containing pointers to usrloc functions*/ extern pua_api_t pua; /*!< Structure containing pointers to PUA functions*/ +extern int reginfo_use_domain; + #endif

1 0

[tracker] Comment added: pua_reginfo: Duplicate contacts in the location table (Attachment added)
by sip-router 03 Nov '13

03 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#350 - pua_reginfo: Duplicate contacts in the location table User who did this - Wonbin Cho (wbcho) ---------- I edited from the git clone as you suggested. Looks much better to me. Hope it works this time. :) Thank you! ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=350#comment1146 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: tls: extended supportd tls methods
by Daniel-Constantin Mierla 03 Nov '13

03 Nov '13

Module: sip-router Branch: master Commit: ea32bf9d3cf36c3562ca34d572bbf07ed144e105 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ea32bf9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Nov 3 12:55:08 2013 +0100 tls: extended supportd tls methods - TLSv1.1 and TLSv1.2 (from openssl 1.0.1e on) added to the internal list --- modules/tls/tls_config.c | 18 ++++++++++++++---- modules/tls/tls_domain.h | 6 ++++++ modules/tls/tls_init.c | 16 +++++++++++++--- 3 files changed, 33 insertions(+), 7 deletions(-) diff --git a/modules/tls/tls_config.c b/modules/tls/tls_config.c index 411446c..8742021 100644 --- a/modules/tls/tls_config.c +++ b/modules/tls/tls_config.c @@ -119,10 +119,12 @@ static int parse_ipv4(struct ip_addr* ip, cfg_token_t* token, static cfg_option_t methods[] = { - {"SSLv2", .val = TLS_USE_SSLv2}, - {"SSLv3", .val = TLS_USE_SSLv3}, - {"SSLv23", .val = TLS_USE_SSLv23}, - {"TLSv1", .val = TLS_USE_TLSv1}, + {"SSLv2", .val = TLS_USE_SSLv2}, + {"SSLv3", .val = TLS_USE_SSLv3}, + {"SSLv23", .val = TLS_USE_SSLv23}, + {"TLSv1", .val = TLS_USE_TLSv1}, + {"TLSv1.1", .val = TLS_USE_TLSv1_1}, + {"TLSv1.2", .val = TLS_USE_TLSv1_2}, {0} }; @@ -458,5 +460,13 @@ int tls_parse_method(str* method) opt = cfg_lookup_token(methods, method); if (!opt) return -1; +#if OPENSSL_VERSION_NUMBER < 0x1000105fL + if(opt->val == TLS_USE_TLSv1_2) { + LM_ERR("tls v1.2 not supported by this libssl version: %ld\n", + OPENSSL_VERSION_NUMBER); + return -1; + } +#endif + return opt->val; } diff --git a/modules/tls/tls_domain.h b/modules/tls/tls_domain.h index e4d1319..18afe47 100644 --- a/modules/tls/tls_domain.h +++ b/modules/tls/tls_domain.h @@ -48,6 +48,12 @@ enum tls_method { TLS_USE_SSLv23_cli, TLS_USE_SSLv23_srv, TLS_USE_SSLv23, + TLS_USE_TLSv1_1_cli, + TLS_USE_TLSv1_1_srv, + TLS_USE_TLSv1_1, + TLS_USE_TLSv1_2_cli, + TLS_USE_TLSv1_2_srv, + TLS_USE_TLSv1_2, TLS_METHOD_MAX }; diff --git a/modules/tls/tls_init.c b/modules/tls/tls_init.c index b629afa..4b55c40 100644 --- a/modules/tls/tls_init.c +++ b/modules/tls/tls_init.c @@ -132,7 +132,7 @@ to compile on the _target_ system)" int openssl_kssl_malloc_bug=0; /* is openssl bug #1467 present ? */ #endif -const SSL_METHOD* ssl_methods[TLS_USE_SSLv23 + 1]; +const SSL_METHOD* ssl_methods[TLS_METHOD_MAX]; #ifdef NO_TLS_MALLOC_DBG #undef TLS_MALLOC_DBG /* extra malloc debug info from openssl */ @@ -350,14 +350,24 @@ static void init_ssl_methods(void) ssl_methods[TLS_USE_SSLv3_cli - 1] = SSLv3_client_method(); ssl_methods[TLS_USE_SSLv3_srv - 1] = SSLv3_server_method(); ssl_methods[TLS_USE_SSLv3 - 1] = SSLv3_method(); - + ssl_methods[TLS_USE_TLSv1_cli - 1] = TLSv1_client_method(); ssl_methods[TLS_USE_TLSv1_srv - 1] = TLSv1_server_method(); ssl_methods[TLS_USE_TLSv1 - 1] = TLSv1_method(); - + ssl_methods[TLS_USE_SSLv23_cli - 1] = SSLv23_client_method(); ssl_methods[TLS_USE_SSLv23_srv - 1] = SSLv23_server_method(); ssl_methods[TLS_USE_SSLv23 - 1] = SSLv23_method(); + + ssl_methods[TLS_USE_TLSv1_1_cli - 1] = TLSv1_1_client_method(); + ssl_methods[TLS_USE_TLSv1_1_srv - 1] = TLSv1_1_server_method(); + ssl_methods[TLS_USE_TLSv1_1 - 1] = TLSv1_1_method(); + +#if OPENSSL_VERSION_NUMBER >= 0x1000105fL + ssl_methods[TLS_USE_TLSv1_2_cli - 1] = TLSv1_2_client_method(); + ssl_methods[TLS_USE_TLSv1_2_srv - 1] = TLSv1_2_server_method(); + ssl_methods[TLS_USE_TLSv1_2 - 1] = TLSv1_2_method(); +#endif }

2 1

git:master: tls: listed TLSv1.1 and TLSv1. 2 as values for tls_method parameter
by Daniel-Constantin Mierla 03 Nov '13

03 Nov '13

Module: sip-router Branch: master Commit: 1e2bb79a135bef9936fb5d5e0fb9a708589452b9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1e2bb79… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Nov 3 13:14:31 2013 +0100 tls: listed TLSv1.1 and TLSv1.2 as values for tls_method parameter --- modules/tls/doc/params.xml | 25 ++++++++++++++++++++++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/modules/tls/doc/params.xml b/modules/tls/doc/params.xml index 46c9618..54c21e7 100644 --- a/modules/tls/doc/params.xml +++ b/modules/tls/doc/params.xml @@ -21,7 +21,20 @@ <itemizedlist> <listitem> <para> - <emphasis>TLSv1</emphasis> - only TLSv1 connections are accepted. This is the default and recommended method (if you want to be rfc3261 conformant don't change it). + <emphasis>TLSv1.1</emphasis> - only TLSv1.2 connections are accepted + (available starting with openssl/libssl v1.0.1e) + </para> + </listitem> + <listitem> + <para> + <emphasis>TLSv1.1</emphasis> - only TLSv1.1 connections are accepted + (available starting with openssl/libssl v1.0.0) + </para> + </listitem> + <listitem> + <para> + <emphasis>TLSv1</emphasis> - only TLSv1 connections are accepted. + This is the default value. </para> </listitem> <listitem> @@ -31,12 +44,18 @@ </listitem> <listitem> <para> - <emphasis>SSLv2</emphasis> - only SSLv2 connections, for old clients. Note: you shouldn't use SSLv2 for anything which should be highly secure. + <emphasis>SSLv2</emphasis> - only SSLv2 connections, for old clients. + Note: you shouldn't use SSLv2 for anything which should be highly secure. + Newer versions of libssl don't include support for it anymore. </para> </listitem> <listitem> <para> - <emphasis>SSLv23</emphasis> - any of the above methods will be accepted, with the following limitation: the initial SSL hello message must be V2 (in the initial hello all the supported protocols are advertised enabling switching to a higher and more secure version). This means connections from SSLv3 or TLSv1 clients will not be accepted. + <emphasis>SSLv23</emphasis> - any of the SSLv2, SSLv3 and TLSv1 methods + will be accepted, with the following limitation: the initial SSL hello + message must be V2 (in the initial hello all the supported protocols + are advertised enabling switching to a higher and more secure version). + This means connections from SSLv3 or TLSv1 clients will be accepted. </para> </listitem> </itemizedlist>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2013