sr-dev November 2013

sr-dev@lists.kamailio.org

29 participants
220 discussions

git:master: usrloc: db_update contact by instance + reg-id
by Victor Seva 01 Nov '13

01 Nov '13

Module: sip-router Branch: master Commit: f67171cf3be1ade0e1c9dd013d560c87b3fd4359 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f67171c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Thu Oct 10 15:21:47 2013 +0200 usrloc: db_update contact by instance + reg-id --- modules/usrloc/ucontact.c | 203 ++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 201 insertions(+), 2 deletions(-) diff --git a/modules/usrloc/ucontact.c b/modules/usrloc/ucontact.c index 9cc2e06..323dc4b 100644 --- a/modules/usrloc/ucontact.c +++ b/modules/usrloc/ucontact.c @@ -679,18 +679,21 @@ int db_update_ucontact_addr(ucontact_t* _c) vals1[n1].type = DB1_STR; vals1[n1].nul = 0; vals1[n1].val.str_val = *_c->aor; + LM_DBG("aor:%.*s\n", vals1[n1].val.str_val.len, vals1[n1].val.str_val.s); n1++; keys1[n1] = &contact_col; vals1[n1].type = DB1_STR; vals1[n1].nul = 0; vals1[n1].val.str_val = _c->c; + LM_DBG("contact:%.*s\n", vals1[n1].val.str_val.len, vals1[n1].val.str_val.s); n1++; keys1[n1] = &callid_col; vals1[n1].type = DB1_STR; vals1[n1].nul = 0; vals1[n1].val.str_val = _c->callid; + LM_DBG("callid:%.*s\n", vals1[n1].val.str_val.len, vals1[n1].val.str_val.s); n1++; vals2[0].type = DB1_DATETIME; @@ -866,6 +869,7 @@ int db_update_ucontact_ruid(ucontact_t* _c) vals1[n1].type = DB1_STR; vals1[n1].nul = 0; vals1[n1].val.str_val = _c->ruid; + LM_DBG("ruid:%.*s\n", vals1[n1].val.str_val.len, vals1[n1].val.str_val.s); n1++; n2 = 0; @@ -1008,7 +1012,197 @@ int db_update_ucontact_ruid(ucontact_t* _c) adomain.len = _c->aor->s + _c->aor->len - adomain.s; } - + + uldb_delete_attrs(_c->domain, &auser, + &adomain, &_c->ruid); + uldb_insert_attrs(_c->domain, &auser, + &adomain, &_c->ruid, _c->xavp); + } else { + uldb_delete_attrs(_c->domain, &auser, + NULL, &_c->ruid); + uldb_insert_attrs(_c->domain, &auser, + NULL, &_c->ruid, _c->xavp); + } + } + + return 0; +} + +/*! + * \brief Update contact in the database by instance reg_id + * \param _c updated contact + * \return 0 on success, -1 on failure + */ +int db_update_ucontact_instance(ucontact_t* _c) +{ + str auser; + str adomain; + db_key_t keys1[2]; + db_val_t vals1[2]; + int n1; + + db_key_t keys2[13]; + db_val_t vals2[13]; + int n2; + + + if (_c->flags & FL_MEM) { + return 0; + } + + if(_c->instance.len<=0) { + LM_ERR("updating record in database failed - empty instance\n"); + return -1; + } + + n1 = 0; + keys1[n1] = &instance_col; + vals1[n1].type = DB1_STR; + vals1[n1].nul = 0; + vals1[n1].val.str_val = _c->instance; + LM_DBG("instance:%.*s\n", vals1[n1].val.str_val.len, vals1[n1].val.str_val.s); + n1++; + + keys1[n1] = &reg_id_col; + vals1[n1].type = DB1_INT; + vals1[n1].nul = 0; + vals1[n1].val.int_val = (int)_c->reg_id; + LM_DBG("reg-id:%d\n", vals1[n1].val.int_val); + n1++; + + n2 = 0; + keys2[n2] = &expires_col; + vals2[n2].type = DB1_DATETIME; + vals2[n2].nul = 0; + vals2[n2].val.time_val = _c->expires; + n2++; + + keys2[n2] = &q_col; + vals2[n2].type = DB1_DOUBLE; + vals2[n2].nul = 0; + vals2[n2].val.double_val = q2double(_c->q); + n2++; + + keys2[n2] = &cseq_col; + vals2[n2].type = DB1_INT; + vals2[n2].nul = 0; + vals2[n2].val.int_val = _c->cseq; + n2++; + + keys2[n2] = &flags_col; + vals2[n2].type = DB1_INT; + vals2[n2].nul = 0; + vals2[n2].val.bitmap_val = _c->flags; + n2++; + + keys2[n2] = &cflags_col; + vals2[n2].type = DB1_INT; + vals2[n2].nul = 0; + vals2[n2].val.bitmap_val = _c->cflags; + n2++; + + keys2[n2] = &user_agent_col; + vals2[n2].type = DB1_STR; + vals2[n2].nul = 0; + vals2[n2].val.str_val = _c->user_agent; + n2++; + + keys2[n2] = &received_col; + vals2[n2].type = DB1_STR; + if (_c->received.s == 0) { + vals2[n2].nul = 1; + } else { + vals2[n2].nul = 0; + vals2[n2].val.str_val = _c->received; + } + n2++; + + keys2[n2] = &path_col; + vals2[n2].type = DB1_STR; + if (_c->path.s == 0) { + vals2[n2].nul = 1; + } else { + vals2[n2].nul = 0; + vals2[n2].val.str_val = _c->path; + } + n2++; + + keys2[n2] = &sock_col; + vals2[n2].type = DB1_STR; + if (_c->sock) { + vals2[n2].val.str_val = _c->sock->sock_str; + vals2[n2].nul = 0; + } else { + vals2[n2].nul = 1; + } + n2++; + + keys2[n2] = &methods_col; + vals2[n2].type = DB1_BITMAP; + if (_c->methods == 0xFFFFFFFF) { + vals2[n2].nul = 1; + } else { + vals2[n2].val.bitmap_val = _c->methods; + vals2[n2].nul = 0; + } + n2++; + + keys2[n2] = &last_mod_col; + vals2[n2].type = DB1_DATETIME; + vals2[n2].nul = 0; + vals2[n2].val.time_val = _c->last_modified; + n2++; + + keys2[n2] = &callid_col; + vals2[n2].type = DB1_STR; + vals2[n2].nul = 0; + vals2[n2].val.str_val = _c->callid; + n2++; + + keys2[n2] = &contact_col; + vals2[n2].type = DB1_STR; + vals2[n2].nul = 0; + vals2[n2].val.str_val.s = _c->c.s; + vals2[n2].val.str_val.len = _c->c.len; + LM_DBG("contact:%.*s\n", vals2[n2].val.str_val.len, vals2[n2].val.str_val.s); + n2++; + + if (ul_dbf.use_table(ul_dbh, _c->domain) < 0) { + LM_ERR("sql use_table failed\n"); + return -1; + } + + if (ul_dbf.update(ul_dbh, keys1, 0, vals1, keys2, vals2, n1, n2) < 0) { + LM_ERR("updating database failed\n"); + return -1; + } + + if (ul_db_check_update==1 && ul_dbf.affected_rows) { + LM_DBG("update affected_rows 0\n"); + /* supposed to be an UPDATE, but if affected rows is 0, then try + * to do an INSERT */ + if(ul_dbf.affected_rows(ul_dbh)==0) { + LM_DBG("affected rows by UPDATE was 0, doing an INSERT\n"); + if(db_insert_ucontact(_c)<0) + return -1; + } + } + + /* delete old db attrs and add the current list */ + if (ul_xavp_contact_name.s) { + auser = *_c->aor; + if (use_domain) { + adomain.s = memchr(_c->aor->s, '@', _c->aor->len); + if (adomain.s==0) { + auser.len = 0; + adomain = *_c->aor; + } else { + auser.len = adomain.s - _c->aor->s; + adomain.s++; + adomain.len = _c->aor->s + + _c->aor->len - adomain.s; + } + uldb_delete_attrs(_c->domain, &auser, &adomain, &_c->ruid); uldb_insert_attrs(_c->domain, &auser, @@ -1032,7 +1226,12 @@ int db_update_ucontact_ruid(ucontact_t* _c) int db_update_ucontact(ucontact_t* _c) { if(ul_db_ops_ruid==0) - return db_update_ucontact_addr(_c); + if (_c->instance.len<=0) { + return db_update_ucontact_addr(_c); + } + else { + return db_update_ucontact_instance(_c); + } else return db_update_ucontact_ruid(_c); }

1 0

[tracker] Comment added: registrar: memory and db get not synced
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: memory and db get not synced User who did this - Daniel-Constantin Mierla (miconda) ---------- Second patch doesn't seem good. The memset on &ci should set to 0 the instance and received. I think the fields that are are set out of the IF block: <code> if (_m!=0) { ... } </code> have to be reset. Like: <code> if (_m!=0) { ... +} else { + memset( &ci.instance, 0, sizeof(str)); } </code> I am not sure if received has to be reset. From a quick look over the code, it can be taken from and avp, which is done first time. If ci.received is reset, probably received_found has to be reset as well. That code about setting ci.received seems to need a bit of a review. I can do it once you do the patches about the issues you found (once they are ready). ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=351#comment1143 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: registrar: memory and db get not synced (Attachment added)
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: memory and db get not synced User who did this - Víctor Seva (linuxmaniac) ---------- This second patch fixes this issue. The static value was not properly cleaned. <code> U 127.0.0.1:50602 -> 127.0.0.1:5060 REGISTER sip:testuser1003@spce.test SIP/2.0..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5173-1-0..From: <sip:testuser1003@spce.test>;tag=517 3SIPpTag001..To: "TestBria" <sip:testuser1003@spce.test>..Call-ID: 1-5173@127.0.0.1..CSeq: 1 REGISTER..Contact: "TestBria" <sip:testuser1003@127. 0.0.1:6666;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>"..Expires: 600..Max-Forwards: 70..Content-Length: 0.... # U 127.0.0.1:5060 -> 127.0.0.1:50602 SIP/2.0 200 OK..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5173-1-0..From: <sip:testuser1003@spce.test>;tag=5173SIPpTag001..To: "TestBria" < sip:testuser1003@spce.test>;tag=b27e1a1d33761e85846fc98f5f3a7e58.30a0..Call-ID: 1-5173@127.0.0.1..CSeq: 1 REGISTER..Contact: <sip:testuser1003@12 7.0.0.1:6666;ob>;expires=600;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>";reg-id=1..Server: kamailio (4.1.0-pre0 (x86_64/linux ))..Content-Length: 0.... # U 127.0.0.1:50602 -> 127.0.0.1:5060 REGISTER sip:testuser1003@spce.test SIP/2.0..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5179-1-0..From: <sip:testuser1003@spce.test>;tag=517 9SIPpTag001..To: "TestBria" <sip:testuser1003@spce.test>..Call-ID: 1-5179@127.0.0.1..CSeq: 3 REGISTER..Contact: "TestBria" <sip:testuser1003@127. 0.0.1:50602;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>"..Contact: "TestBria" <sip:testuser1003@127.0.0.1:6666;ob >;expires=0..Expires: 600..Max-Forwards: 70..Content-Length: 0.... # U 127.0.0.1:5060 -> 127.0.0.1:50602 SIP/2.0 200 OK..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5179-1-0..From: <sip:testuser1003@spce.test>;tag=5179SIPpTag001..To: "TestBria" < sip:testuser1003@spce.test>;tag=b27e1a1d33761e85846fc98f5f3a7e58.ba64..Call-ID: 1-5179@127.0.0.1..CSeq: 3 REGISTER..Contact: <sip:testuser1003@12 7.0.0.1:50602;ob>;expires=600;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>";reg-id=1..Server: kamailio (4.1.0-pre0 (x86_64/linu x))..Content-Length: 0.... </code> ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=351#comment1142 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: presence_dialoginfo to send initial NOTIFY with body
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#355 - presence_dialoginfo to send initial NOTIFY with body User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you make the patch for master branch? In can be backported from there into the stable versions. Also, remove the code that is not used anymore -- putting it in comments or in between #if 0 ... #endif makes it unmanageable over the time. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=355#comment1141 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: registrar: memory and db get not synced
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: memory and db get not synced User who did this - Daniel-Constantin Mierla (miconda) ---------- Check the ci to see if has instance value set - maybe is kept from previous contact via pack_ci(), which uses some static variables. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=351#comment1140 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: registrar: memory and db get not synced
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: memory and db get not synced User who did this - Víctor Seva (linuxmaniac) ---------- <code> 3(5964) DEBUG: registrar [save.c:682]: update_contacts(): aor <testuser1003> expires:1383300931 3(5964) DEBUG: <core> [sruid.c:176]: sruid_next(): new sruid is [uloc-52737cde-174c-1] (1 / 20) 3(5964) DEBUG: registrar [save.c:408]: pack_ci(): generated ruid is: uloc-52737cde-174c-1 3(5964) DEBUG: usrloc [ucontact.c:1063]: db_update_ucontact_instance(): instance:<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4> 3(5964) DEBUG: usrloc [ucontact.c:1070]: db_update_ucontact_instance(): reg-id:1 3(5964) DEBUG: usrloc [ucontact.c:1167]: db_update_ucontact_instance(): contact:sip:testuser1003@127.0.0.1:50602;ob 3(5964) DEBUG: db_sqlite [dbase.c:183]: db_sqlite_submit_query(): submit_query: update location set expires=?1,q=?2,cseq=?3,flags=?4,cflags=?5,user_agent=?6,received=?7,path=?8,socket=?9,methods=?10,last_modified=?11,callid=?12,contact=?13 where instance=?14 AND reg_id=?15 3(5964) DEBUG: registrar [save.c:682]: update_contacts(): aor <testuser1003> expires:0 3(5964) DEBUG: <core> [sruid.c:176]: sruid_next(): new sruid is [uloc-52737cde-174c-2] (2 / 20) 3(5964) DEBUG: registrar [save.c:408]: pack_ci(): generated ruid is: uloc-52737cde-174c-2 3(5964) DEBUG: usrloc [ucontact.c:1497]: uldb_delete_attrs(): trying to delete location attributes 3(5964) DEBUG: db_sqlite [dbase.c:183]: db_sqlite_submit_query(): submit_query: delete from location where username=?1 AND contact=?2 AND callid=?3 </code> No that is not the problem. I think the problem is at registrar update_contacts: <code> _c = get_first_contact(_m); updated=0; for( ; _c ; _c = get_next_contact(_c) ) { /* calculate expires */ calc_contact_expires(_m, _c->expires, &expires); LM_DBG("aor <%.*s> expires:%d\n", _r->aor.len,_r->aor.s, expires); /* pack the contact info */ if ( (ci=pack_ci( 0, _c, expires, 0, _use_regid))==0 ) { LM_ERR("failed to pack contact specific info\n"); goto error; } /* search for the contact*/ LM_DBG("_c contact:%.*s\n", _c->uri.len, _c->uri.s); ret = ul.get_ucontact_by_instance( _r, &_c->uri, ci, &c); LM_DBG("c contact:%.*s\n", c->c.len, c->c.s); if (ret==-1) { LM_ERR("invalid cseq for aor <%.*s>\n",_r->aor.len,_r->aor.s); rerrno = R_INV_CSEQ; goto error; } else if (ret==-2) { if(expires!=0 && _mode) break; continue; } </code> ul.get_ucontact_by_instance returns the wrong contact for the second contact... <code> 3(6572) DEBUG: registrar [save.c:682]: update_contacts(): aor <testuser1003> expires:1383301645 3(6572) DEBUG: <core> [sruid.c:176]: sruid_next(): new sruid is [uloc-52737fb0-19ac-1] (1 / 20) 3(6572) DEBUG: registrar [save.c:408]: pack_ci(): generated ruid is: uloc-52737fb0-19ac-1 3(6572) DEBUG: registrar [save.c:691]: update_contacts(): _c contact:sip:testuser1003@127.0.0.1:50602;ob 3(6572) DEBUG: registrar [save.c:693]: update_contacts(): c contact:sip:testuser1003@127.0.0.1:6666;ob 3(6572) DEBUG: usrloc [ucontact.c:1063]: db_update_ucontact_instance(): instance:<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4> 3(6572) DEBUG: usrloc [ucontact.c:1070]: db_update_ucontact_instance(): reg-id:1 3(6572) DEBUG: usrloc [ucontact.c:1167]: db_update_ucontact_instance(): contact:sip:testuser1003@127.0.0.1:50602;ob 3(6572) DEBUG: db_sqlite [dbase.c:183]: db_sqlite_submit_query(): submit_query: update location set expires=?1,q=?2,cseq=?3,flags=?4,cflags=?5,user_agent=?6,received=?7,path=?8,socket=?9,methods=?10,last_modified=?11,callid=?12,contact=?13 where instance=?14 AND reg_id=?15 3(6572) DEBUG: registrar [save.c:682]: update_contacts(): aor <testuser1003> expires:0 3(6572) DEBUG: <core> [sruid.c:176]: sruid_next(): new sruid is [uloc-52737fb0-19ac-2] (2 / 20) 3(6572) DEBUG: registrar [save.c:408]: pack_ci(): generated ruid is: uloc-52737fb0-19ac-2 3(6572) DEBUG: registrar [save.c:691]: update_contacts(): _c contact:sip:testuser1003@127.0.0.1:6666;ob 3(6572) DEBUG: registrar [save.c:693]: update_contacts(): c contact:sip:testuser1003@127.0.0.1:50602;ob 3(6572) DEBUG: usrloc [ucontact.c:1497]: uldb_delete_attrs(): trying to delete location attributes 3(6572) DEBUG: db_sqlite [dbase.c:183]: db_sqlite_submit_query(): submit_query: delete from location where username=?1 AND contact=?2 AND callid=?3 </code> ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=351#comment1139 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: registrar: memory and db get not synced
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: memory and db get not synced User who did this - Daniel-Constantin Mierla (miconda) ---------- The problem can be in other place, because the Contact URI addresses don't match: <code> U 127.0.0.1:50602 -> 127.0.0.1:5060 REGISTER sip:testuser1003@spce.test SIP/2.0..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5438-1-0..From: <sip:testuser1003@spce.test>;tag=543 8SIPpTag001..To: "TestBria" <sip:testuser1003@spce.test>..Call-ID: 1-5438@127.0.0.1..CSeq: 3 REGISTER..Contact: "TestBria" <sip:testuser1003@127. 0.0.1:50602;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>"..Contact: "TestBria" <sip:testuser1003@127.0.0.1:6666;ob >;expires=0..Expires: 600..Max-Forwards: 70..Content-Length: 0.... </code> So even when updating by address, then the second contact should not affect the first one. Add some debug message to see if the first contact doesn't get expires=0 mistakenly. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=351#comment1138 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: registrar: memory and db get not synced
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: memory and db get not synced User who did this - Víctor Seva (linuxmaniac) ---------- But we still have the initial problem <code> U 127.0.0.1:50602 -> 127.0.0.1:5060 REGISTER sip:testuser1003@spce.test SIP/2.0..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5432-1-0..From: <sip:testuser1003@spce.test>;tag=543 2SIPpTag001..To: "TestBria" <sip:testuser1003@spce.test>..Call-ID: 1-5432@127.0.0.1..CSeq: 1 REGISTER..Contact: "TestBria" <sip:testuser1003@127. 0.0.1:6666;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>"..Expires: 600..Max-Forwards: 70..Content-Length: 0.... # U 127.0.0.1:5060 -> 127.0.0.1:50602 SIP/2.0 200 OK..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5432-1-0..From: <sip:testuser1003@spce.test>;tag=5432SIPpTag001..To: "TestBria" < sip:testuser1003@spce.test>;tag=b27e1a1d33761e85846fc98f5f3a7e58.841e..Call-ID: 1-5432@127.0.0.1..CSeq: 1 REGISTER..Contact: <sip:testuser1003@12 7.0.0.1:6666;ob>;expires=600;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>";reg-id=1..Server: kamailio (4.1.0-pre0 (x86_64/linux ))..Content-Length: 0.... # U 127.0.0.1:50602 -> 127.0.0.1:5060 REGISTER sip:testuser1003@spce.test SIP/2.0..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5438-1-0..From: <sip:testuser1003@spce.test>;tag=543 8SIPpTag001..To: "TestBria" <sip:testuser1003@spce.test>..Call-ID: 1-5438@127.0.0.1..CSeq: 3 REGISTER..Contact: "TestBria" <sip:testuser1003@127. 0.0.1:50602;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>"..Contact: "TestBria" <sip:testuser1003@127.0.0.1:6666;ob >;expires=0..Expires: 600..Max-Forwards: 70..Content-Length: 0.... # U 127.0.0.1:5060 -> 127.0.0.1:50602 SIP/2.0 200 OK..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5438-1-0..From: <sip:testuser1003@spce.test>;tag=5438SIPpTag001..To: "TestBria" < sip:testuser1003@spce.test>;tag=b27e1a1d33761e85846fc98f5f3a7e58.0eda..Call-ID: 1-5438@127.0.0.1..CSeq: 3 REGISTER..Server: kamailio (4.1.0-pre0 (x86_64/linux))..Content-Length: 0.... </code> Result on no location at all. But if I split the second register in two: <code> U 127.0.0.1:50602 -> 127.0.0.1:5060 REGISTER sip:testuser1003@spce.test SIP/2.0..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5460-1-0..From: <sip:testuser1003@spce.test>;tag=546 0SIPpTag001..To: "TestBria" <sip:testuser1003@spce.test>..Call-ID: 1-5460@127.0.0.1..CSeq: 1 REGISTER..Contact: "TestBria" <sip:testuser1003@127. 0.0.1:6666;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>"..Expires: 600..Max-Forwards: 70..Content-Length: 0.... # U 127.0.0.1:5060 -> 127.0.0.1:50602 SIP/2.0 200 OK..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5460-1-0..From: <sip:testuser1003@spce.test>;tag=5460SIPpTag001..To: "TestBria" < sip:testuser1003@spce.test>;tag=b27e1a1d33761e85846fc98f5f3a7e58.743e..Call-ID: 1-5460@127.0.0.1..CSeq: 1 REGISTER..Contact: <sip:testuser1003@12 7.0.0.1:6666;ob>;expires=600;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>";reg-id=1..Server: kamailio (4.1.0-pre0 (x86_64/linux ))..Content-Length: 0.... # U 127.0.0.1:50602 -> 127.0.0.1:5060 REGISTER sip:testuser1003@spce.test SIP/2.0..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5466-1-0..From: <sip:testuser1003@spce.test>;tag=546 6SIPpTag001..To: "TestBria" <sip:testuser1003@spce.test>..Call-ID: 1-5466@127.0.0.1..CSeq: 3 REGISTER..Contact: "TestBria" <sip:testuser1003@127. 0.0.1:50602;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>"..Expires: 600..Max-Forwards: 70..Content-Length: 0.... # U 127.0.0.1:5060 -> 127.0.0.1:50602 SIP/2.0 200 OK..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5466-1-0..From: <sip:testuser1003@spce.test>;tag=5466SIPpTag001..To: "TestBria" < sip:testuser1003@spce.test>;tag=b27e1a1d33761e85846fc98f5f3a7e58.fd8d..Call-ID: 1-5466@127.0.0.1..CSeq: 3 REGISTER..Contact: <sip:testuser1003@12 7.0.0.1:50602;ob>;expires=600;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>";reg-id=1..Server: kamailio (4.1.0-pre0 (x86_64/linu x))..Content-Length: 0.... # U 127.0.0.1:50602 -> 127.0.0.1:5060 REGISTER sip:testuser1003@spce.test SIP/2.0..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5472-1-0..From: <sip:testuser1003@spce.test>;tag=547 2SIPpTag001..To: "TestBria" <sip:testuser1003@spce.test>..Call-ID: 1-5472@127.0.0.1..CSeq: 4 REGISTER..Contact: "TestBria" <sip:testuser1003@127. 0.0.1:6666;ob>;expires=0..Expires: 600..Max-Forwards: 70..Content-Length: 0.... # U 127.0.0.1:5060 -> 127.0.0.1:50602 SIP/2.0 200 OK..Via: SIP/2.0/UDP 127.0.0.1:50602;branch=z9hG4bK-5472-1-0..From: <sip:testuser1003@spce.test>;tag=5472SIPpTag001..To: "TestBria" < sip:testuser1003@spce.test>;tag=b27e1a1d33761e85846fc98f5f3a7e58.4e1f..Call-ID: 1-5472@127.0.0.1..CSeq: 4 REGISTER..Contact: <sip:testuser1003@12 7.0.0.1:50602;ob>;expires=598;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>";reg-id=1..Server: kamailio (4.1.0-pre0 (x86_64/linu x))..Content-Length: 0.... </code> All is fine in memory and in db. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=351#comment1137 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: registrar: memory and db get not synced (Attachment added)
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: memory and db get not synced User who did this - Víctor Seva (linuxmaniac) ---------- Are you saying something like this? <code> @@ -1032,7 +1226,12 @@ int db_update_ucontact_ruid(ucontact_t* _c) int db_update_ucontact(ucontact_t* _c) { if(ul_db_ops_ruid==0) - return db_update_ucontact_addr(_c); + if (_c->instance.len<=0) { + return db_update_ucontact_addr(_c); + } + else { + return db_update_ucontact_instance(_c); + } else return db_update_ucontact_ruid(_c); } </code> ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=351#comment1136 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: pua_reginfo: Duplicate contacts in the location table
by sip-router 01 Nov '13

01 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#350 - pua_reginfo: Duplicate contacts in the location table User who did this - Daniel-Constantin Mierla (miconda) ---------- The patch doesn't look good. It removes and adds some files. Just clone the git repo, edit the file inside that source code directory, then do: git diff >/path/to/file.patch ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=350#comment1135 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2013