sr-dev November 2013

sr-dev@lists.kamailio.org

29 participants
220 discussions

[tracker] Comment added: send_reply() bug when called from branch route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#362 - send_reply() bug when called from branch route User who did this - Juha Heinanen (jh) ---------- for example, the some security violation is detected in the branch that would result in terminating the whole call. my original point, however, was that readme claims that send_reply() can be called from BRANCH_ROUTE, which currently results in error. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=362#comment1158 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 6 months

[tracker] Comment added: Unmet dependency for kamailio-perl-modules

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#361 - Unmet dependency for kamailio-perl-modules User who did this - Daniel-Constantin Mierla (miconda) ---------- It looks like the constraint is to have libperl greater than 5.10. Perhaps something wrong in the control file. I'll check ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=361#comment1157 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 6 months

[tracker] Comment added: send_reply() bug when called from branch route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#362 - send_reply() bug when called from branch route User who did this - Daniel-Constantin Mierla (miconda) ---------- send_reply() is just a wrapper, calls t_reply() if transaction was created and sl_send_reply() when there is no transaction yet. For branch route, it applies the rules of t_reply(). Probably the readme is wrong. What would be a reason to send a reply in branch route? Typically that should end the entire transaction. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=362#comment1156 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 6 months

git:master: tls: Fix minor typo in documentation

by Hugh Waite

Module: sip-router Branch: master Commit: 0fbdb8cf7a7687d6ecc8049dfdcb1244abd726af URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0fbdb8c… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Nov 6 10:34:01 2013 +0000 tls: Fix minor typo in documentation --- modules/tls/doc/params.xml | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/tls/doc/params.xml b/modules/tls/doc/params.xml index 54c21e7..5325f96 100644 --- a/modules/tls/doc/params.xml +++ b/modules/tls/doc/params.xml @@ -21,7 +21,7 @@ <itemizedlist> <listitem> <para> - <emphasis>TLSv1.1</emphasis> - only TLSv1.2 connections are accepted + <emphasis>TLSv1.2</emphasis> - only TLSv1.2 connections are accepted (available starting with openssl/libssl v1.0.1e) </para> </listitem>

10 years, 6 months

[tracker] Task opened: send_reply() bug when called from branch route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Juha Heinanen (jh) Attached to Project - sip-router Summary - send_reply() bug when called from branch route Task Type - Bug Report Category - Module Status - New Assigned To - Operating System - All Severity - Medium Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - i think this is still unresolved: according to sl readme, send_reply() can be called from branch route. however, when i tried with recent master i got: Oct 14 08:47:34 rautu /usr/sbin/sip-proxy[11203]: : tm [tm.c:1342]: w_t_reply(): BUG: w_t_reply entered in unsupported mode Oct 14 08:47:34 rautu /usr/sbin/sip-proxy[11203]: ERROR: sl [sl.c:277]: send_reply(): failed to reply stateful (tm) is this a bug in code or readme? -- juha More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=362 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 6 months

[tracker] Comment added: Dialog callback on pua_dialoginfo after restart (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#360 - Dialog callback on pua_dialoginfo after restart User who did this - Kristian Høgh (kfhdk) ---------- Hi Daniel, I took a look at it, but I am out of my comfort zone. Hope this is better. After second patch, existing dialogs are loaded after restart. If not using use_pubruri_avps, in-dialog (including BYE) publish are sent. If using use_pubruri_avps, the values are lost, so we have to store the values in database. That is what the third patch does, and I agree it is a feature. It also restores the values after restart. I tried to use dlg_var in script to set pubruri_avps instead of third patch, but the in-dialog callback is run right after loose_route. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=360#comment1155 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 6 months

git:master: modules/dialog_ng: Fix "CRITICAL bogus event 6 in state 2" problem

by Richard Good

Module: sip-router Branch: master Commit: fe914e16945caf6c5c11b81514dff89a0739b30e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fe914e1… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Wed Nov 6 09:14:45 2013 +0200 modules/dialog_ng: Fix "CRITICAL bogus event 6 in state 2" problem Use TM callback TMCB_RESPONSE_READY instead of TMCB_RESPONSE_OUT to prevent race condition resulting in bogus event --- modules/dialog_ng/dlg_handlers.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/dialog_ng/dlg_handlers.c b/modules/dialog_ng/dlg_handlers.c index 43b025b..262e923 100644 --- a/modules/dialog_ng/dlg_handlers.c +++ b/modules/dialog_ng/dlg_handlers.c @@ -380,12 +380,12 @@ static void dlg_onreply(struct cell* t, int type, struct tmcb_params *param) { return; } - if (type == TMCB_RESPONSE_READY) { - LM_DBG("TMCB_RESPONSE_READY\n"); + if (type == TMCB_RESPONSE_OUT) { + LM_DBG("TMCB_RESPONSE_OUT\n"); return; } - if (type == TMCB_RESPONSE_OUT) { + if (type == TMCB_RESPONSE_READY) { if (rpl == FAKED_REPLY) { LM_DBG("Faked reply\n"); return; @@ -426,7 +426,7 @@ static void dlg_onreply(struct cell* t, int type, struct tmcb_params *param) { LM_DBG("Calling next_state_dlg and event is %i\n", event); next_state_dlg(dlg, event, &old_state, &new_state, &unref, &to_tag); - if (type == TMCB_RESPONSE_OUT) { + if (type == TMCB_RESPONSE_READY) { LM_DBG("Checking if there is an existing dialog_out entry with same to-tag"); dlg_entry_out = &dlg->dlg_entry_out;

10 years, 6 months

git:master: kamctl: added shortcuts for dialog mi commands

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: cb66f43187ea3bcac36681b82630456deeabc64c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cb66f43… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 5 15:10:29 2013 +0100 kamctl: added shortcuts for dialog mi commands --- utils/kamctl/kamctl | 30 +++++++++++++++++++++++++++++- utils/kamctl/kamctl.base | 18 ++++++++++++++++++ 2 files changed, 47 insertions(+), 1 deletions(-) diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index 2e25d2e..b286d55 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -1550,7 +1550,6 @@ cr() { esac } - # ##### ------------------------------------------------ ##### ### DISPATCHER management @@ -1643,6 +1642,30 @@ dispatcher() { # ##### ------------------------------------------------ ##### +### DIALOG management +# +dialog() { + case $1 in + show|list) + require_ctlengine + mecho "dialog memory records" + $CTLCMD dlg_list + ;; + showdb) + require_dbengine + mecho "dialog database records" + QUERY="select * FROM $DIALOG_TABLE ORDER BY id; " + $DBROCMD "$QUERY" + ;; + *) + usage_dialog + exit 1 + + esac +} + +# +##### ------------------------------------------------ ##### ### DIALPLAN management # dialplan() { @@ -2732,6 +2755,11 @@ case $1 in dispatcher "$@" ;; + dialog) + shift + dialog "$@" + ;; + dialplan) shift dialplan "$@" diff --git a/utils/kamctl/kamctl.base b/utils/kamctl/kamctl.base index a5e6211..27532a3 100644 --- a/utils/kamctl/kamctl.base +++ b/utils/kamctl/kamctl.base @@ -314,6 +314,11 @@ DISPATCHER_PRIORITY_COLUMN=priority DISPATCHER_ATTRS_COLUMN=attrs DISPATCHER_DESCRIPTION_COLUMN=description +# dialog tables +if [ -z "$DIALOG_TABLE" ] ; then + DIALOG_TABLE=dialog +fi + # dialplan tables if [ -z "$DIALPLAN_TABLE" ] ; then DIALPLAN_TABLE=dialplan @@ -483,6 +488,19 @@ EOF } USAGE_FUNCTIONS="$USAGE_FUNCTIONS usage_dispatcher" +usage_dialog() { + echo + mecho " -- command 'dialog' - manage dialog records" + echo +cat <<EOF + * Examples: dialog show + * dialog showdb + dialog show ..................... show in-memory dialog records + dialog showdb ................... show database dialog records +EOF +} +USAGE_FUNCTIONS="$USAGE_FUNCTIONS usage_dialog" + usage_dialplan() { echo mecho " -- command 'dialplan' - manage dialplans"

10 years, 6 months

git:master: dialog: init cseq to 0 if not available yet for one side

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 082a6c43938cf8e3839d46fd070e391bd522d4ed URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=082a6c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 5 10:33:55 2013 +0100 dialog: init cseq to 0 if not available yet for one side - based on a report by Morten Isaksen --- modules/dialog/dlg_hash.c | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index 6f944e1..d346800 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -517,18 +517,24 @@ int dlg_set_leg_info(struct dlg_cell *dlg, str* tag, str *rr, str *contact, str *cseq, unsigned int leg) { char *p; + str cs = {"0", 1}; + + /* if we don't have cseq, set it to 0 */ + if(cseq->len>0) { + cs = *cseq; + } if(dlg->tag[leg].s) shm_free(dlg->tag[leg].s); dlg->tag[leg].s = (char*)shm_malloc( tag->len + rr->len + contact->len ); if(dlg->cseq[leg].s) { - if (dlg->cseq[leg].len < cseq->len) { + if (dlg->cseq[leg].len < cs.len) { shm_free(dlg->cseq[leg].s); - dlg->cseq[leg].s = (char*)shm_malloc(cseq->len); + dlg->cseq[leg].s = (char*)shm_malloc(cs.len); } } else { - dlg->cseq[leg].s = (char*)shm_malloc( cseq->len ); + dlg->cseq[leg].s = (char*)shm_malloc( cs.len ); } if ( dlg->tag[leg].s==NULL || dlg->cseq[leg].s==NULL) { @@ -564,8 +570,8 @@ int dlg_set_leg_info(struct dlg_cell *dlg, str* tag, str *rr, str *contact, } /* cseq */ - dlg->cseq[leg].len = cseq->len; - memcpy( dlg->cseq[leg].s, cseq->s, cseq->len); + dlg->cseq[leg].len = cs.len; + memcpy( dlg->cseq[leg].s, cs.s, cs.len); return 0; }

10 years, 6 months

[tracker] Comment added: Dialog callback on pua_dialoginfo after restart

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#360 - Dialog callback on pua_dialoginfo after restart User who did this - Daniel-Constantin Mierla (miconda) ---------- Thanks. First patch was applied. Second patch doesn't seem that it handles error cases, it returns NULL and dlginfo variable is lost - it was allocated in shared memory. The code seems to be like that from older versions, but it would be good to get fixed. Do you have time for it? If not, probably I will get back to it later when I get some spare time. Third patch - does it have relevance in the context of reported issue? It seems a feature enhancement. If yes, it will be pushed as we unfreeze from testing phase for v4.1 ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=360#comment1154 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 6 months

← Newer
1
...
14
15
16
17
18
19
20
21
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2013