sr-dev March 2010

sr-dev@lists.kamailio.org

24 participants
359 discussions

git:kamailio_3.0: nathelper(k): safety check for content length

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: 682ef1b6104ec62e4ec60eefa404c9403f6645c8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=682ef1b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Mar 17 20:00:59 2010 +0100 nathelper(k): safety check for content length - patch by Marcus Hunger, SF#2961414 (cherry picked from commit fb4f98a341322904a92c6f12396f5795a3275c08) --- modules_k/nathelper/nhelpr_funcs.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules_k/nathelper/nhelpr_funcs.c b/modules_k/nathelper/nhelpr_funcs.c index 07271f2..3fb5f65 100644 --- a/modules_k/nathelper/nhelpr_funcs.c +++ b/modules_k/nathelper/nhelpr_funcs.c @@ -196,7 +196,13 @@ int extract_body(struct sip_msg *msg, str *body ) LM_ERR("message body has length zero\n"); goto error; } - + + if (body->len + body->s > msg->buf + msg->len) { + LM_ERR("content-length exceeds packet-length by %d\n", + (body->len + body->s) - (msg->buf + msg->len)); + goto error; + } + /* no need for parse_headers(msg, EOH), get_body will * parse everything */ /*is the content type correct?*/

14 years, 3 months

git:master: nathelper(k): safety check for content length

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: fb4f98a341322904a92c6f12396f5795a3275c08 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fb4f98a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Mar 17 20:00:59 2010 +0100 nathelper(k): safety check for content length - patch by Marcus Hunger, SF#2961414 --- modules_k/nathelper/nhelpr_funcs.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules_k/nathelper/nhelpr_funcs.c b/modules_k/nathelper/nhelpr_funcs.c index 07271f2..3fb5f65 100644 --- a/modules_k/nathelper/nhelpr_funcs.c +++ b/modules_k/nathelper/nhelpr_funcs.c @@ -196,7 +196,13 @@ int extract_body(struct sip_msg *msg, str *body ) LM_ERR("message body has length zero\n"); goto error; } - + + if (body->len + body->s > msg->buf + msg->len) { + LM_ERR("content-length exceeds packet-length by %d\n", + (body->len + body->s) - (msg->buf + msg->len)); + goto error; + } + /* no need for parse_headers(msg, EOH), get_body will * parse everything */ /*is the content type correct?*/

14 years, 3 months

SF.net SVN: openser:[5995] branches/1.5/modules/nathelper/nhelpr_funcs.c

by Daniel-Constantin Mierla

Revision: 5995 http://openser.svn.sourceforge.net/openser/?rev=5995&view=rev Author: miconda Date: 2010-03-17 18:57:52 +0000 (Wed, 17 Mar 2010) Log Message: ----------- - safety check for content-lenght - patch by Marcus Hunger, SF #2961414 Modified Paths: -------------- branches/1.5/modules/nathelper/nhelpr_funcs.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 3 months

[ openser-Bugs-2963040 ] allow_source_address_group() not matching correctly

by SourceForge.net

Bugs item #2963040, was opened at 2010-03-04 04:04 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2963040&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: allow_source_address_group() not matching correctly Initial Comment: IP address subnet matching does not work properly when using the allow_source_address_group() function from the Permissions module. The problem comes from /modules_k/permissions/hash.c:568 in function find_group_in_subnet_table(). subnet = ip_addr << table[i].mask; should be subnet = htonl(ntohl(ip_addr) >> table[i].mask); Here is a git diff to fix it: diff --git a/modules_k/permissions/hash.c b/modules_k/permissions/hash.c index 7358225..7917d5a 100644 --- a/modules_k/permissions/hash.c +++ b/modules_k/permissions/hash.c @@ -565,7 +565,7 @@ int find_group_in_subnet_table(struct subnet* table, i = 0; while (i < count) { - subnet = ip_addr << table[i].mask; + subnet = htonl(ntohl(ip_addr) >> table[i].mask); //ip_addr << table[i].mask; if ((table[i].subnet == subnet) && ((table[i].port == port) || (table[i].port == 0))) return table[i].grp; ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 20:41 Message: Patch was applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2963040&group_…

14 years, 3 months

git:kamailio_3.0: * modules_k/permissions: subnet matching fix ( credits to anonymous)

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: ccef7b8729d0beb6ac2c55b7f68bab5a8650c546 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ccef7b8… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Mar 4 09:09:22 2010 +0200 * modules_k/permissions: subnet matching fix (credits to anonymous) (cherry picked from commit f5a29762b6155209721ba0dfc3f30b4a9764c191) --- modules_k/permissions/hash.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/permissions/hash.c b/modules_k/permissions/hash.c index 7358225..5c5c7a6 100644 --- a/modules_k/permissions/hash.c +++ b/modules_k/permissions/hash.c @@ -565,7 +565,7 @@ int find_group_in_subnet_table(struct subnet* table, i = 0; while (i < count) { - subnet = ip_addr << table[i].mask; + subnet = htonl(ntohl(ip_addr) >> table[i].mask); if ((table[i].subnet == subnet) && ((table[i].port == port) || (table[i].port == 0))) return table[i].grp;

14 years, 3 months

[ openser-Bugs-2947231 ] Makefile doesn't install mysql related stuff

by SourceForge.net

Bugs item #2947231, was opened at 2010-02-07 03:42 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947231&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: tools >Group: ver devel >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: veganimado (veganimado) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Makefile doesn't install mysql related stuff Initial Comment: Hi, after compiling with make group_include="standard mysql" all "make install" doesn't install some mysql related file, e.g. the directory /lib/kamailio/kamctl/mysql is missing. Best regards, Victor ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 20:27 Message: Previous comment shows the way to get mysql scripts installed. It is not a bug, but how makefile works. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-02-07 16:21 Message: do you install from tarball or git? Here is a git step by step turorial: http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-3.0.x-from-git kamctl mysql files are installed together with db_mysql if the flavour is kamailio. This is default on kamailio_3.0 branch, but for devel, one has to do: make FLAVOUR=kamailio cfg then: make all; make install ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947231&group_…

14 years, 3 months

[ openser-Bugs-2947193 ] mysql installation scripts missing

by SourceForge.net

Bugs item #2947193, was opened at 2010-02-07 00:49 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947193&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: packaging >Group: ver devel >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: veganimado (veganimado) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: mysql installation scripts missing Initial Comment: Hi, the INSTALL file of version 3.0 refers to sip-router_mysql.sh which isn't included in the source .tar.gz file. Best regards, Victor ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 20:23 Message: Related to another item - kamdbctl has to be used. Install file was updated with the right content. ---------------------------------------------------------------------- Comment By: veganimado (veganimado) Date: 2010-02-07 00:54 Message: Oh, the script is actually included but doesn't get installed using make install. So it seems it's an error in the installation script. Best regards, Victor ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947193&group_…

14 years, 3 months

[ openser-Bugs-2947225 ] sip-router_mysql.sh using old name

by SourceForge.net

Bugs item #2947225, was opened at 2010-02-07 03:08 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947225&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None >Group: ver devel >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: veganimado (veganimado) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: sip-router_mysql.sh using old name Initial Comment: Hi, sip-router_mysql.sh names the database ser by default, while the supplied tools expect openser. Additionally, the user names and passwords do not match. This error occurs with version 3.0 Best regards, Victor ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 20:21 Message: Install was updated. The tarball contains everything so you can use ser modules if you want. Binary packages have only kamailio 3.0 files. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2010-02-07 16:14 Message: install file was forgotten unbranded. should be fixed soon. you have to use kamdbctl to create the kamailio specific database. ---------------------------------------------------------------------- Comment By: veganimado (veganimado) Date: 2010-02-07 03:34 Message: Ah, I see, gotta use kamdbctl... sip-router_mysql.sh even creates a database structure the server doesn't understand... it should be removed from the .tar.gz Additionally, the INSTALL file should be updated as it still refers to sip-router_mysql.sh Best regards, Victor ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947225&group_…

14 years, 3 months

[ openser-Bugs-2968918 ] load_tm update for dispatcher

by SourceForge.net

Bugs item #2968918, was opened at 2010-03-11 23:05 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2968918&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules >Group: ver devel >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: load_tm update for dispatcher Initial Comment: The dispatcher module is still using find_export/load_tm instead of load_tm_api Without that the "probing" of gateways doesnt; work since the tm module can;t be pulled in. I manaully patched the code and now i can see the OPTIONS/INFO requests on the wire. my patch is too messy to submit. It's a simple patch though... -bill ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 20:19 Message: Fix committed. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2968918&group_…

14 years, 3 months

git:sr_3.0: dispatcher(k): use load_tm_api

by Daniel-Constantin Mierla

Module: sip-router Branch: sr_3.0 Commit: b6d626fcfd552653cdb528684be0a63bdae1dcf3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b6d626f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Mar 15 23:50:13 2010 +0100 dispatcher(k): use load_tm_api - import tm module api directly - patch by Stephen Young (styoung) (cherry picked from commit fd5ddfd12c25497aa859dafc2bf65e3c07fd4529) --- modules_k/dispatcher/dispatcher.c | 25 +++++++------------------ 1 files changed, 7 insertions(+), 18 deletions(-) diff --git a/modules_k/dispatcher/dispatcher.c b/modules_k/dispatcher/dispatcher.c index 4453221..5f9901c 100644 --- a/modules_k/dispatcher/dispatcher.c +++ b/modules_k/dispatcher/dispatcher.c @@ -337,26 +337,15 @@ static int mod_init(void) /***************************************************** * TM-Bindings *****************************************************/ - load_tm_f load_tm; - load_tm=(load_tm_f)find_export("load_tm", 0, 0); - - /* import the TM auto-loading function */ - if (load_tm) + if (load_tm_api( &tmb ) == -1) { - /* let the auto-loading function load all TM stuff */ - if (load_tm( &tmb ) == -1) - { - LM_ERR("could not load the TM-functions - disable DS ping\n"); - return -1; - } - /***************************************************** - * Register the PING-Timer - *****************************************************/ - register_timer(ds_check_timer, NULL, ds_ping_interval); - } else { - LM_WARN("could not bind to the TM-Module, automatic" - " re-activation disabled.\n"); + LM_ERR("could not load the TM-functions - disable DS ping\n"); + return -1; } + /***************************************************** + * Register the PING-Timer + *****************************************************/ + register_timer(ds_check_timer, NULL, ds_ping_interval); } return 0;

14 years, 3 months

← Newer
1
...
17
18
19
20
21
22
23
...
36
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2010