Revision: 5995
http://openser.svn.sourceforge.net/openser/?rev=5995&view=rev
Author: miconda
Date: 2010-03-17 18:57:52 +0000 (Wed, 17 Mar 2010)
Log Message:
-----------
- safety check for content-lenght
- patch by Marcus Hunger, SF #2961414
Modified Paths:
--------------
branches/1.5/modules/nathelper/nhelpr_funcs.c
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Bugs item #2963040, was opened at 2010-03-04 04:04
Message generated for change (Comment added) made by miconda
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2963040&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
…
[View More]Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: allow_source_address_group() not matching correctly
Initial Comment:
IP address subnet matching does not work properly when using the allow_source_address_group() function from the Permissions module.
The problem comes from /modules_k/permissions/hash.c:568 in function find_group_in_subnet_table().
subnet = ip_addr << table[i].mask;
should be
subnet = htonl(ntohl(ip_addr) >> table[i].mask);
Here is a git diff to fix it:
diff --git a/modules_k/permissions/hash.c b/modules_k/permissions/hash.c
index 7358225..7917d5a 100644
--- a/modules_k/permissions/hash.c
+++ b/modules_k/permissions/hash.c
@@ -565,7 +565,7 @@ int find_group_in_subnet_table(struct subnet* table,
i = 0;
while (i < count) {
- subnet = ip_addr << table[i].mask;
+ subnet = htonl(ntohl(ip_addr) >> table[i].mask); //ip_addr << table[i].mask;
if ((table[i].subnet == subnet) &&
((table[i].port == port) || (table[i].port == 0)))
return table[i].grp;
----------------------------------------------------------------------
>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2010-03-17 20:41
Message:
Patch was applied.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2963040&group_…
[View Less]
Bugs item #2947231, was opened at 2010-02-07 03:42
Message generated for change (Comment added) made by miconda
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947231&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: tools
>Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: …
[View More]No
Submitted By: veganimado (veganimado)
>Assigned to: Daniel-Constantin Mierla (miconda)
Summary: Makefile doesn't install mysql related stuff
Initial Comment:
Hi,
after compiling with
make group_include="standard mysql" all
"make install" doesn't install some mysql related file, e.g. the directory /lib/kamailio/kamctl/mysql is missing.
Best regards,
Victor
----------------------------------------------------------------------
>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2010-03-17 20:27
Message:
Previous comment shows the way to get mysql scripts installed. It is not a
bug, but how makefile works.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2010-02-07 16:21
Message:
do you install from tarball or git? Here is a git step by step turorial:
http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-3.0.x-from-git
kamctl mysql files are installed together with db_mysql if the flavour is
kamailio. This is default on kamailio_3.0 branch, but for devel, one has to
do:
make FLAVOUR=kamailio cfg
then:
make all; make install
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947231&group_…
[View Less]
Bugs item #2947193, was opened at 2010-02-07 00:49
Message generated for change (Comment added) made by miconda
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947193&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: packaging
>Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: …
[View More]No
Submitted By: veganimado (veganimado)
>Assigned to: Daniel-Constantin Mierla (miconda)
Summary: mysql installation scripts missing
Initial Comment:
Hi,
the INSTALL file of version 3.0 refers to sip-router_mysql.sh which isn't included in the source .tar.gz file.
Best regards,
Victor
----------------------------------------------------------------------
>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2010-03-17 20:23
Message:
Related to another item - kamdbctl has to be used. Install file was updated
with the right content.
----------------------------------------------------------------------
Comment By: veganimado (veganimado)
Date: 2010-02-07 00:54
Message:
Oh, the script is actually included but doesn't get installed using make
install. So it seems it's an error in the installation script.
Best regards,
Victor
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947193&group_…
[View Less]
Bugs item #2947225, was opened at 2010-02-07 03:08
Message generated for change (Comment added) made by miconda
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947225&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
…
[View More]Submitted By: veganimado (veganimado)
>Assigned to: Daniel-Constantin Mierla (miconda)
Summary: sip-router_mysql.sh using old name
Initial Comment:
Hi,
sip-router_mysql.sh names the database ser by default, while the supplied tools expect openser. Additionally, the user names and passwords do not match.
This error occurs with version 3.0
Best regards,
Victor
----------------------------------------------------------------------
>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2010-03-17 20:21
Message:
Install was updated. The tarball contains everything so you can use ser
modules if you want. Binary packages have only kamailio 3.0 files.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2010-02-07 16:14
Message:
install file was forgotten unbranded. should be fixed soon. you have to use
kamdbctl to create the kamailio specific database.
----------------------------------------------------------------------
Comment By: veganimado (veganimado)
Date: 2010-02-07 03:34
Message:
Ah, I see, gotta use kamdbctl...
sip-router_mysql.sh even creates a database structure the server doesn't
understand... it should be removed from the .tar.gz
Additionally, the INSTALL file should be updated as it still refers to
sip-router_mysql.sh
Best regards,
Victor
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2947225&group_…
[View Less]
Bugs item #2968918, was opened at 2010-03-11 23:05
Message generated for change (Comment added) made by miconda
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2968918&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
>Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
…
[View More]Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Daniel-Constantin Mierla (miconda)
Summary: load_tm update for dispatcher
Initial Comment:
The dispatcher module is still using
find_export/load_tm instead of load_tm_api
Without that the "probing" of gateways doesnt; work since the tm module can;t be pulled in.
I manaully patched the code and now i can see the OPTIONS/INFO requests on the wire.
my patch is too messy to submit. It's a simple patch though...
-bill
----------------------------------------------------------------------
>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2010-03-17 20:19
Message:
Fix committed. Thanks.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2968918&group_…
[View Less]