sr-dev March 2010

sr-dev@lists.kamailio.org

24 participants
359 discussions

git:refs/tags/sr_3.0.1: Tag sr_3.0.1: Mostly bugfixes & docs.

by Andrei Pelinescu-Onciul

Module: sip-router Branch: refs/tags/sr_3.0.1 Tag: 0bb837921570dcd05a412d40211919e1cd966084 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=tag;h=0bb8379215… Tagger: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Mar 17 20:16:48 2010 +0100 Mostly bugfixes & docs. Roughly synchronized with kamailio 3.0.1 (except for xavps).

14 years, 6 months

git:sr_3.0: modules_k/ permisssions Fixed a bug that caused a segmentation fault if the mi_fifo subnet_dump was issued

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: d4d88bef1cb8887d0e267be79d02625d2ac1f143 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d4d88be… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Mar 5 16:54:58 2010 +0200 modules_k/permisssions Fixed a bug that caused a segmentation fault if the mi_fifo subnet_dump was issued but the permissions module was not fully configured (no db url given) (cherry picked from commit d5da961b7ac62037fb1fb24c6ce3484584f5f972) --- modules_k/permissions/mi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/permissions/mi.c b/modules_k/permissions/mi.c index 9b4594a..c2f900f 100644 --- a/modules_k/permissions/mi.c +++ b/modules_k/permissions/mi.c @@ -116,7 +116,7 @@ struct mi_root* mi_subnet_dump(struct mi_root *cmd_tree, void *param) rpl_tree = init_mi_tree( 200, MI_SSTR(MI_OK)); if (rpl_tree==NULL) return 0; - if(subnet_table_mi_print(*subnet_table, &rpl_tree->node) < 0) { + if(subnet_table && subnet_table_mi_print(*subnet_table, &rpl_tree->node) < 0) { LM_ERR("failed to add a node\n"); free_mi_tree(rpl_tree); return 0;

14 years, 6 months

git:sr_3.0: sl(k): docs extension, merge README

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: 753967b9619a222aa0198a56de01a150d0c8af84 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=753967b… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Mon Mar 8 15:31:15 2010 +0100 sl(k): docs extension, merge README (cherry picked from commit 45af92ac46a1948b65133d78baaac046e2f7eb78) --- modules_k/sl/README | 13 +++++++++++++ modules_k/sl/doc/sl_admin.xml | 3 ++- 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/modules_k/sl/README b/modules_k/sl/README index 1f727e2..bf4b730 100644 --- a/modules_k/sl/README +++ b/modules_k/sl/README @@ -27,6 +27,7 @@ Bogdan Iancu 1.3. Exported Parameters 1.3.1. enable_stats (integer) + 1.3.2 bind_tm (integer) 1.4. Exported Functions @@ -113,6 +114,18 @@ Chapter 1. Admin Guide Example 1.1. enable_stats example modparam("sl", "enable_stats", 0) +1.3.1. bind_tm (integer) + + If the module should use transaction support for sending the + replies. A zero value means disabled. + + Module tm should be loaded before of this one + + Default value is 1 (enabled). + + Example 1.1. bind_tm example +modparam("sl", "bind_tm", 0) + 1.4. Exported Functions 1.4.1. sl_send_reply(code, reason) diff --git a/modules_k/sl/doc/sl_admin.xml b/modules_k/sl/doc/sl_admin.xml index d6a4702..59bcb74 100644 --- a/modules_k/sl/doc/sl_admin.xml +++ b/modules_k/sl/doc/sl_admin.xml @@ -55,7 +55,8 @@ <itemizedlist> <listitem> <para> - <emphasis>No dependencies on other &kamailio; modules</emphasis>. + <emphasis>TM - transaction module</emphasis>, if you want + to use the transactional send_reply functionality. </para> </listitem> </itemizedlist>

14 years, 6 months

git:sr_3.0: userblacklist(k): short term fix in the docs for redundant table definition

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: 56ca5cb4c864b024c124dc21e225a95cc5cead3f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=56ca5cb… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Feb 24 17:04:54 2010 +0100 userblacklist(k): short term fix in the docs for redundant table definition (cherry picked from commit 2372a7d5039a72f9cdb6b8bb7acb8a5ae2cb5c5f) --- modules_k/userblacklist/README | 4 +++- modules_k/userblacklist/doc/userblacklist_db.xml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/modules_k/userblacklist/README b/modules_k/userblacklist/README index c771760..5e0c242 100644 --- a/modules_k/userblacklist/README +++ b/modules_k/userblacklist/README @@ -399,7 +399,9 @@ modparam("userblacklist", "userblacklist_whitelist_col", "whitelist") 8. globalblacklist_table (String) - Name of the globalblacklist table for the userblacklist module. + Name of the globalblacklist table for the userblacklist module. Please + not that this table is currently ignored, the table needs to be given + as a parameter for the check_blacklist function. Default value is "globalblacklist". diff --git a/modules_k/userblacklist/doc/userblacklist_db.xml b/modules_k/userblacklist/doc/userblacklist_db.xml index f4d2585..5e8df9c 100644 --- a/modules_k/userblacklist/doc/userblacklist_db.xml +++ b/modules_k/userblacklist/doc/userblacklist_db.xml @@ -111,7 +111,9 @@ modparam("userblacklist", "userblacklist_whitelist_col", "whitelist") </section> <section> <title><varname>globalblacklist_table</varname> (String)</title> - <para>Name of the globalblacklist table for the userblacklist module.</para> + <para>Name of the globalblacklist table for the userblacklist module. + Please not that this table is currently ignored, the table needs to be + given as a parameter for the check_blacklist function.</para> <para> <emphasis>Default value is <quote>globalblacklist</quote>.</emphasis> </para>

14 years, 6 months

git:sr_3.0: ldap(k): fix ldapsearch with empty filter

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: 42c966bb0339e322c9b6938a9c35e9209785a1bb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=42c966b… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jan 21 19:26:08 2010 +0100 ldap(k): fix ldapsearch with empty filter * fix ldapsearch with empty filter * When in routing script ldapsearch() is executed on LDAP query URL without the ‘filter’ section, request forming fails: ERROR: ldap [ldap_api_fn.c:193]: vsnprintf failed * Workaround for administrators can be filling filter section with ‘(objectclass=*)’, what is anyway substituted by ldap library to request in case filter parameter set to NULL. * Please notice that va_end() call is missing in original code. * Patch FS#23 from andrey dot utkin at wildix dot com (cherry picked from commit 73655cc83851f1f406ce23b8d6130632d731ef2d) --- modules_k/ldap/ldap_api_fn.c | 44 +++++++++++++++++++++++------------------ 1 files changed, 25 insertions(+), 19 deletions(-) diff --git a/modules_k/ldap/ldap_api_fn.c b/modules_k/ldap/ldap_api_fn.c index c2176fc..20fd869 100644 --- a/modules_k/ldap/ldap_api_fn.c +++ b/modules_k/ldap/ldap_api_fn.c @@ -158,6 +158,7 @@ int ldap_params_search( { int rc; static char filter_str[LDAP_MAX_FILTER_LEN]; + char *filter_ptr = NULL; va_list filter_vars; /* @@ -174,24 +175,29 @@ int ldap_params_search( return -1; } - /* - * vsnprintf - */ - va_start(filter_vars, _filter); - rc = vsnprintf(filter_str, (size_t)LDAP_MAX_FILTER_LEN, _filter, - filter_vars); - if (rc >= LDAP_MAX_FILTER_LEN) - { - LM_ERR( "[%s]: filter string too long (len [%d], max len [%d])\n", - _lds_name, - rc, - LDAP_MAX_FILTER_LEN); - return -1; - } - else if (rc < 0) - { - LM_ERR("vsnprintf failed\n"); - return -1; + if (_filter) { + /* + * vsnprintf + */ + va_start(filter_vars, _filter); + rc = vsnprintf(filter_str, (size_t)LDAP_MAX_FILTER_LEN, _filter, + filter_vars); + va_end(filter_vars); + + if (rc >= LDAP_MAX_FILTER_LEN) + { + LM_ERR( "[%s]: filter string too long (len [%d], max len [%d])\n", + _lds_name, + rc, + LDAP_MAX_FILTER_LEN); + return -1; + } + else if (rc < 0) + { + LM_ERR("vsnprintf failed\n"); + return -1; + } + filter_ptr = filter_str; } /* @@ -200,7 +206,7 @@ int ldap_params_search( if (lds_search(_lds_name, _dn, _scope, - filter_str, + filter_ptr, _attrs, NULL, _ld_result_count,

14 years, 6 months

git:sr_3.0: reg(k): fix a (probably) copy and paste error

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: 2f9e34389130495b020d4e1db388507df2fda638 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2f9e343… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Jan 26 17:50:02 2010 +0100 reg(k): fix a (probably) copy and paste error (cherry picked from commit bf89ebf74025597c261b5b664e29fe0ab6bcfc25) --- modules_k/registrar/README | 4 ++-- modules_k/registrar/doc/registrar_admin.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules_k/registrar/README b/modules_k/registrar/README index 5344ffc..cbbaf89 100644 --- a/modules_k/registrar/README +++ b/modules_k/registrar/README @@ -110,7 +110,7 @@ Bogdan-Andre Iancu 1.25. registered usage 1.26. registered usage 1.27. registered usage - 1.28. $sht(name) usage + 1.28. $ulc(name) usage Chapter 1. Admin Guide @@ -786,7 +786,7 @@ reg_free_contacts("callee"); The pseudo-variable accepts positive index value to access a specific contact record. - Example 1.28. $sht(name) usage + Example 1.28. $ulc(name) usage ... if(reg_fetch_contacts("location", "$fu", "caller")) { diff --git a/modules_k/registrar/doc/registrar_admin.xml b/modules_k/registrar/doc/registrar_admin.xml index db28d6a..08bf610 100644 --- a/modules_k/registrar/doc/registrar_admin.xml +++ b/modules_k/registrar/doc/registrar_admin.xml @@ -1074,7 +1074,7 @@ reg_free_contacts("callee"); </para> <example> - <title><function moreinfo="none">$sht(name)</function> usage</title> + <title><function moreinfo="none">$ulc(name)</function> usage</title> <programlisting format="linespecific"> ... if(reg_fetch_contacts("location", "$fu", "caller"))

14 years, 6 months

git:sr_3.0: utils/sercmd: Fixed getopt() missing param

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: ac80f11893ab223f5464a23d1ea5635e959e41ee URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ac80f11… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jan 21 17:32:42 2010 +0200 utils/sercmd: Fixed getopt() missing param Getopt was missing the -U param (cherry picked from commit 7c701df1be3d71afe49e7d017a90fa10c081b790) --- utils/sercmd/sercmd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils/sercmd/sercmd.c b/utils/sercmd/sercmd.c index ada5ff6..1f1a721 100644 --- a/utils/sercmd/sercmd.c +++ b/utils/sercmd/sercmd.c @@ -1885,7 +1885,7 @@ int main(int argc, char** argv) port_no=0; sock_type=UNIXS_SOCK; opterr=0; - while((c=getopt(argc, argv, "Vhs:D:R:vf:"))!=-1){ + while((c=getopt(argc, argv, "UVhs:D:R:vf:"))!=-1){ switch(c){ case 'V': printf("version: %s\n", version);

14 years, 6 months

[ openser-Patches-2970838 ] Patch to dispatcher since API change

by SourceForge.net

Patches item #2970838, was opened at 2010-03-15 22:21 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2970838&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Stephen () >Assigned to: Daniel-Constantin Mierla (miconda) Summary: Patch to dispatcher since API change Initial Comment: Update of dispatcher.c to include the api change ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 21:07 Message: Patch applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2970838&group_…

14 years, 6 months

[ openser-Patches-2961414 ] fix for crash when Content-length too big - ID: 281827

by SourceForge.net

Patches item #2961414, was opened at 2010-03-01 20:20 Message generated for change (Settings changed) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) >Assigned to: Daniel-Constantin Mierla (miconda) Summary: fix for crash when Content-length too big - ID: 281827 Initial Comment: are there any valid use cases for a content-length being bigger than the rest of of the packet? i have not tested the issue with kamailio 3.0. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-17 21:05 Message: Patch applied. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-02 11:51 Message: i retried this with vanilla-kamailio 1.5.4 downloaded from kamailio.org and it crashs. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 21:11 Message: so there's already a fix? i tried this on 1.5.4, and it crashed. maybe i made a mistake merging it to my branch. i am going to check this tomorrow. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2010-03-01 20:51 Message: This should not happen, as both pairs (msg_buf,msg_len) and (body,body_len) are set internally. The issue with the nathelper was because the len was taken from content-lenght header, which can be wrong. The discussion ended in whether to auto-correct the content-lenght value or return 400 bad message. In 1.5 the fix to avoid crash was to return error to script, 400 can be sent by using sanity module. ---------------------------------------------------------------------- Comment By: Marcus Hunger (marcushunger) Date: 2010-03-01 20:22 Message: sorry, i was not logged in while posting. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=2961414&group_…

14 years, 6 months

git:sr_3.0: nathelper(k): safety check for content length

by Daniel-Constantin Mierla

Module: sip-router Branch: sr_3.0 Commit: e7d3e36a5fa22d54c3ed54726c6818c7ce9dab1f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e7d3e36… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Mar 17 20:00:59 2010 +0100 nathelper(k): safety check for content length - patch by Marcus Hunger, SF#2961414 (cherry picked from commit fb4f98a341322904a92c6f12396f5795a3275c08) --- modules_k/nathelper/nhelpr_funcs.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules_k/nathelper/nhelpr_funcs.c b/modules_k/nathelper/nhelpr_funcs.c index 07271f2..3fb5f65 100644 --- a/modules_k/nathelper/nhelpr_funcs.c +++ b/modules_k/nathelper/nhelpr_funcs.c @@ -196,7 +196,13 @@ int extract_body(struct sip_msg *msg, str *body ) LM_ERR("message body has length zero\n"); goto error; } - + + if (body->len + body->s > msg->buf + msg->len) { + LM_ERR("content-length exceeds packet-length by %d\n", + (body->len + body->s) - (msg->buf + msg->len)); + goto error; + } + /* no need for parse_headers(msg, EOH), get_body will * parse everything */ /*is the content type correct?*/

14 years, 6 months

← Newer
1
...
16
17
18
19
20
21
22
...
36
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2010