Hello all,
I have been working on the seas module to make it work on sip-router. I have
my own git branch locally, but I'd like to share it on the sip-router public
git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other
more tm-knowledgable coders before it can be finally merged.
where do I need to send my public ssh key to get commit access to the
sip-router git ?
thanks
Elias
Hello,
Here is a brief git crash course for those who are used to CVS or SVN. The
purpose of this crash course is to get you started, it describes basic
operations that you will need to do simple changes in the sip-router git
repository. You can find links to more documentation at the end.
First of all, you'll need to install git. The name of the corresponding Debian
package is git-core. Debian Lenny contains version 1.5.6.5 which is
sufficient. Newer git versions or packages for other distributions or
architectures can be obtained from http://git-scm.com/.
As the second step you need to configure the git client. I have attached
configuration files to this email for your convenience, save files .gitconfig
and .gitignore in your home directory. File sip-router.org_CA.pem is optional,
you will only need the file if you plan on accessing the repository over https
(that's not the case for developers with write access).
Edit file ~/.gitconfig and configure your name and email address there. This
is the name and email address that will be visible in git commits. Unlike CVS
or SVN commits, git commits contain full name and email address of the
commiter, this is the name and email that will be visible in git history. Note
that the email address to be used in From header of commit logs sent to the
development mailing list is configured separately on the server (there are
technical reasons for this). Here is how I configured my name in email address
in ~/.gitconfig:
[user]
name = Jan Janak
email = jan(a)iptel.org
The git configuration file in your home directory sets up a bunch of short
aliases for most common git commands, so you do not have to type
$ git checkout
every time you are checking out a branch, you can just type 'git co' instead,
and if you alias git to 'g' in your ~/.bashrc then it becomes just 'g co'
which is much more convenient.
Another setting that is particular to our repository is the number of
characters used for tabs in the git pager. Git uses less as the default pager
and less is configured to use 8 spaces for tabs by default. We use 4 spaces in
our sources and thus you might want to re-configure the git pager in your
~/.bashrc. The following setting makes the output of 'git diff' and friends
look prettier:
export GIT_PAGER="less --tabs=4"
Now you can start working with git. The first command that you need to run is
'git clone', this is the command that is used to retrieve the sip-router
repository from the server:
$ git clone ssh://<username>@git.sip-router.org/sip-router
Replace <username> with your real username. The contents of the repository
will be stored in 'sip-router' subdirectory of your current working directory.
This command is the git equivalent of cvs/svn checkout. Like cvs/svn it will
make the most recent version of the sources available in the
subdirectory.
UNLIKE cvs/svn, this command does not retrieve just the latest version of the
sources, it copies the whole history of the project to your local hard drive,
not just the latest revision, but all revisions that are stored in the
repository, since tday 1. You do not have to be worried about the size of
the repository, the full history of SER takes about 40MB only.
Also, you will need to run the command only once (or occassionally if you wipe
your local copy out entirely). There are other git commands (covered later)
that can be used to keep your local copy up-to-date. Those commands can figure
out the difference between your local version of the repository and the
version on the server and they will transfer only the data that has
changed. In other words, 'git clone' is similar to the scp command, it creates
a local identical copy of the remote repository by copying the whole remote
repository to the local machine.
Once you have a local copy of the sip-router repository, you can try to see
what is in there:
$ cd sip-router
$ git branch
The command above shows a list of branches that are present in your local copy
of the repository. Most likely you will see just one branch called 'master'
marked with an asterisk. This means that your local repository contains only
one branch called 'master' and the asterisk tells you that this is the branch
that is currently checked out. So the sources that you see in that directory
come from the master branch. The local master branch is an exact copy of the
'master' branch from the remote repository at git.sip-router.org and it
contains latest sip-router sources.
Typically, the branch with the most up-to-date code is called 'master' in
git. It is the git equivalent of CVS HEAD branch and SVN trunk branch.
NOTE: Branches are sometimes called 'heads' in git documentation, but you can
just remember that 'branch' and 'head' refers to the same thing.
If you look at the remote version of the repository with gitweb at
http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=heads you will
notice that there are more branches than the 'master' branch which was created
by 'git clone' in the local copy of the repository. The command 'git clone'
only makes the master branch directly available in the local copy of the
repository. For other branches it merely records the fact that the branches
exist in the remote repository. To display branches from both the local and
the remote repository you can run:
$ git branch -a
The output should look roughly like this:
* master
origin/HEAD
origin/MAIN
origin/Maintainer
origin/andrei/cvshead
origin/andrei/sctp
origin/andrei/sctp_fixes
origin/andrei/sctp_one_to_one
origin/andrei_sctp
origin/cancel_fix
origin/cvs-head
origin/janakj/cvshead
origin/janakj/doxygen
origin/master
Branches that start with "origin/" are branches that exist in the remote
repository. The string origin is just a short alias for the full URI of the
remote repository, such as ssh://git.sip-router.org/sip-router. It is a
convention that the repository you cloned from initially is called the origin.
Once you have the local repository, you can start making changes in it.
Modifying the code on the master branch directly is really easy, because git
clone already created the master branch for you in local repository and it
checked out the master branch by default. Here is how can you make a simple
change in one file and commit the result:
$ edit main.c
$ git add main.c
$ git commit
As you can see above you need to call 'git add' before you call 'git
commit'. 'git add' marks your changes to be commited during the next commit,
this is useful, for example, if you want to leave some local changes
uncommited while you make the commit. Unlike CVS or SVN, git does not assume
that all local changes should be commited during the next commit. It lets you
explicitly select a set of changes to be commited. You can avoid the need to
call two commands with 'git commit -a', see the git documentation for more
details.
When you are done with the commit, you can display the list of changes in the
repository with 'git log'. The command displays the history of changes in the
whole repository, if you want to limit the list to main.c only then you can
run 'git log main.c'.
If you look closely at the output of 'git log' then you will notice strange
lines starting with "commit" followed by a long string of characters:
commit 0253726f99ac151f748712a5d39d71f42d9defc6
The long string is how commits in git are represented. This string is a SHA1
checksum of the commit and it is the git equivalent SVN revision numbers. Like
SVN revision numbers and UNLIKE CVS versions, this identifier represents the
state of the whole repository, not just individual files. Because such long
identifier are tedious to type, git supports abbreviated format, you can type
just the beginning of the string as long as the beginning of the string is
unique. In other words, there must be at most one commit in the database of all
commits with this prefix. For example the following two commands refer to the
same commit:
$ git diff b0f6ec8784712e4c1436fc9a4a3b54296e94ba5c
$ git diff b0f6e
If somebody creates another commit with an SHA1 id starting with b0f6e later
then 'git diff b0f6e' would not longer work and git would complain that the
prefix is ambiguous.
All changes, such as the commit above, that you do affect the local repository
only. There is absolutely no communication with the the remote repository in
any of the commands above (git add, git commit, git log). This is possible
because we created a full copy of the remote repository with 'git clone'. This
is also the reason why all the commands are so fast, unlike their equivalents
in CVS or SVN.
The fact that you perform all actions/modifications on the local repository
only and then you instruct git to do its black magic and synchronize your
local changes with the remote repository is probably the biggest difference
from CVS/SVN and one of the things that is hard to understand for people who
are used to CVS/SVN. This is also why git falls into the category of
distributed revision control systems.
When you are satisfied with your local changes/commits, you can decide to make
them available to others. This can be done by uploading your local changes to
the remote repository (the one you initially cloned from). In git terminology
this operation is called 'push', so you can push your local changes to the
remote repository with 'git push':
$ git push origin master:master
The first parameter is the name of the remote repository, the second parameter
is the name of the local branch and the name of the remote branch, delimited
by ':'. You can omit the 2nd parameter:
$ git push origin
and then 'git push' will upload all local branches to the remote
repository. You can also omit the first parameter:
$ git push
and in that case repository 'origin' is used.
The opposite of 'git push' is 'git pull'. This is the operation that you can
use to synchronize your local repository with the remote repository. 'git
pull' downloads all changes (made by others) from the remote repository that
are not yet in your local repository and integrates them into your local
repository. You can run 'git pull' whenever you are online to fetch latest
changes and keep your local copy of the repository up-to-date.
'git push' and 'git pull' are similar to rsync, they update either the local
or the remote copy of the repository by tranferring only what is missing. 'git
push' is the git equivalent of 'cvs ci' and 'svn ci'. 'git pull' is the git
equivalent of 'cvs update' or 'svn update'.
If you make only small changes to the repository then you can modify the
master branch directly, as described above. This approach is suitable only for
small, trivial changes. If are working on a change which takes longer to
implement, consists of many commits, then it is better to create a separate
branch and do the development on a separate branch. Branches in git are cheap,
remember that all operations, including branch creation, are local
operations. You do not even have to push your local branches into the remote
repository, you can just keep them in the local copy for your own
purposes. You can create a new branch in your local repository with 'git checkout':
$ git checkout --track -b mybranch master
This command creates a new branch called 'mybranch', configures the branch to
track the master branch and checks the new branch out. The word 'track' in
this context means that the newly created branch will receive all updates from
the master branch whenever you run 'git pull' with this branch checked out. In
other words, the branch tracks another branch (master in this case) by merging
all changes from the original branch. Command line option -b instructs git to
to create a new branch. If this option was omitted then git would assume that
'mybranch' is an existing branch and it would try to check the branch out.
The newly created branch exists in the local repository only. If you want to
push the branch to the remote repository then you can use 'git push' again:
$ git push origin mybranch:janakj/mybranch
Because mybranch is a private topic branch of mine, I am pushing it as
janakj/mybranch to the remote repository at git.sip-router.org. The remote
repository only permits new "username" branches. In other words their name
must start with your username. If you try:
$ git push origin mybranch:mybranch
then git will report an error. The main reason why we have this restriction in
place is because we wanted to make sure that people do not push all local
branches to the remote repository by accident. This can easily happen if you
run 'git push' without any parameters.
You can also delete a local branch that is no longer needed by running
$ git branch -D mybranch
This will delete the local branch only. If you pushed the branch to the remote
repository then you might also want to delete the branch in the remote
repository with 'git push':
$ git push :janakj/mybranch
This is a special syntax of 'git push', if you omit the name of the local
branch then 'git push' deletes the remote branch whose name follows ':'.
Test Repository
===============
We have a test repository at git.sip-router.org which you can use to test
various git operations. Clone the repository with:
$ git clone ssh://username@git.sip-router.org/test
and there you can test whatever you want. The repository can also be browsed
with gitweb at
http://git.sip-router.org/cgi-bin/gitweb.cgi?p=test;a=summary
Further Reading
===============
[1] Git related pages in the wiki: http://sip-router.org/wiki/git
[2] http://eagain.net/articles/git-for-computer-scientists/
[3] Git SVN Crashcourse: http://git.or.cz/course/svn.html
[4] http://git-scm.com/documentation
Hi,
during a review i noticed that it seems that all the functionality in the
modules_s/dbg module is also provided from the modules_k/cfgutils module.
function mapping:
- dbg_msleep(n) -> usleep(n*1000)
- dbg_abort() -> abort()
- dbg_pkg_status() -> pkg_status()
- dbg_shm_status() -> shm_status()
It is ok when i remove this module? If this one additional multiplication is
not ok, i can of course also add a 'm_sleep' function to the cfgutils module
as well.
Regards,
Henning
Hello,
few weeks ago I uploaded a new module named app_lua, providing
functionality to execute Lua (http://www.lua.org) scripts in your
configuration file. Lua is small and fast, therefore fits very well in a
sip proxy environment. It has a lot of extensions, so when you cannot do
something with existing cfg functions, check this one as well.
The readme and the api are available at:
http://sip-router.org/wiki/api/lua/develhttp://sip-router.org/docbook/sip-router/branch/master/modules/app_lua/app_…
The API will be enhanced during this development cycle, your feedback
will help a lot in this direction. By now you get access to
pseudo-variables, sip headers, logging functions and sl module.
For new comers in community, if you are a Perl fan, then you can use the
perl module in a similar way. Also, another module was uploaded
recently, app_python, allowing to write python extensions. Module and
API for Python are not yet documented, but I think this is not a barrier
for a true Python fan, actually I hope will be a motivation to
contribute the docs :-)
Cheers,
Daniel
--
Daniel-Constantin Mierla
SIP Server Professional Solutions
* http://www.asipto.com/
Hello,
I propose to merge the users mailing lists, most of the traffic these
days is about 3.0 and even there are 2 stables branches now, they are
sync'ed, so same code more or less. For 3.1 will be one stable branch,
falvor selection will be only a matter of make command.
Lately common useful topics are discussed on those different mailing
lists, notifications and knowledge base building require cross-posting,
lot of overhead imo.
Any other opinion?
Like with devel mailing lists, existing email addresses for users ML can
still be used, just that end on same ML. Natural choice will be to have
users@kamailio and serusers@iptel to be directed to
sr-users(a)lists.sip-router.org
Cheers,
Daniel
--
Daniel-Constantin Mierla * http://www.asipto.com/
Hi list,
while thinking about the idea to build a recursive code block in
kamailio.cfg I noticed, that there are no route-specific avps available.
Of course you can convert a recursion to an iteration, but you need
something like a stack to save variables on it, which is not available
also.
Do you think it's reasonable to make route specific avps available in
future releases?
I also noticed, that it does not seem to be possible to get the number
of result rows of avp_db_query - may (in the case of an successful
query) can the function return the number of results for example?
Thank you very much...
Jasmin
Hello,
As kamailio and ser get more and more unified, sharing common modules
and core, one of the last remaining points is the intermixed usage of
kamctl and sercmd to setup specific parameters. One example is the cfg
framework changes (from ser) that Kamailio 3.1.0 will bring, that will
require the use of "sercmd" on setting specific module config params.
The issue is that the documentation also references the "kamctl" utility
to specify reload actions etc.
What I suggest is that we strip kamctl with its fifo capabilities and
leave it only with DB, ACL management and such(that sercmd doesn't
provide), and use only sercmd on examples in the documentation files.
This will require no changes to code (well some features from kamctl
will be deprecated), but only documentation changes. This will ensure
that documentation is kept well organized and coherent across modules.
These are the modules required to use sercmd (based on functionality),
the 4th case being the one that I am mostly interested (offers full
access to Kamailio commands)
1. basic (required for every case - basic ser commands) :
modules/ctl/ctl.so
2. configuration framework change : modules/cfg_rpc/cfg_rpc.so
3. fifo comands (kamctl fifo) : modules/mi_rpc/mi_rpc.so (does not
require modules_k/mi_fifo/mi_fifo.so) In this case no kamailio core
commands are available (like kamctl debug, kamctl uptime, kamctl which)
Because readline is based on the which command (lists all available
commands), no tab completion is available
4. all K commands : along with mi_rpc, module_k/kex/kex.so is required.
In this case sercmd has tab completion (because core commands like
which are available)
Of course the removal of kamctl fifo commands will mean that
module_k/mi_fifo/mi_fifo.so module will not be required anymore(But I
strongly suggest that we keep it to allow backwards compatibility)
Suggestions?!
Cheers
Marius
i tried to use some of the header field related selects listed on page
http://sip-router.org/wiki/cookbooks/selects/devel
but noticed that they are provided by s textops module. i also noticed
that s and k texops modules have functions whose names are the same.
should the two modules be merged or what in order to be able use stuff
from both?
-- juha
