<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1974
-- Commit Summary --
* ims_ipsec_pcscf: IPv6 support * ims_usrloc_pcscf: get_pcontact changes for IPv6
-- File Changes --
M src/modules/ims_ipsec_pcscf/README (80) M src/modules/ims_ipsec_pcscf/cmd.c (207) M src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (21) M src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c (93) M src/modules/ims_ipsec_pcscf/ipsec.c (14) M src/modules/ims_ipsec_pcscf/ipsec.h (2) M src/modules/ims_usrloc_pcscf/udomain.c (128)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1974.patch https://github.com/kamailio/kamailio/pull/1974.diff
Great work, just a small notice, there is a committed Readme file, please make the changes to the readme in the xml files in the doc folder.
Great work, just a small notice, there is a committed Readme file.
Thanks, The committed README file is regenerated, not manually changed.
tdimitrov commented on this pull request.
Great job!
Only one remark - could you please address my comment about the hardcoded PROTO_UDP in ipsec_forward function? If it is not an error - I'll merge it.
@@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
struct pcontact_info ci; pcontact_t* pcontact = NULL; int ret = IPSEC_CMD_FAIL; // FAIL by default + unsigned char dst_proto = PROTO_UDP;
Is this hardcoded to PROTO_UDP on purpose?
Great work, just a small notice, there is a committed Readme file.
Thanks, The committed README file is regenerated, not manually changed.
Yes, but please remove the changes to the README file from your pull request. :-) This is not needed, the README is autogenerated from a script in our infrastructure after every change.
@alexyosifov pushed 1 commit.
71e8bf1e99e830800f379ea8ceabbc37d048cdd6 Delete README
alexyosifov commented on this pull request.
Great work, just a small notice, there is a committed Readme file.
Thanks, The committed README file is regenerated, not manually changed.
Yes, but please remove the changes to the README file from your pull request. :-) This is not needed, the README is autogenerated from a script in our infrastructure after every change.
Done.
@@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
struct pcontact_info ci; pcontact_t* pcontact = NULL; int ret = IPSEC_CMD_FAIL; // FAIL by default + unsigned char dst_proto = PROTO_UDP;
It's not an error, just default value.
Merged #1974 into master.
Pay attention next time because the README file was removed completely with this PR (I just added it back).
The README file must stay in the git tree, just not edited directly, because it is updated from kamailio.org to keep consistency in the format.
I understand.
Best Regards, Aleksandar Yosifov
On Wed, 5 Jun 2019 at 13:25, Daniel-Constantin Mierla < notifications@github.com> wrote:
Pay attention next time because the README file was removed completely with this PR (I just added it back).
The README file must stay in the git tree, just not edited directly, because it is updated from kamailio.org to keep consistency in the format.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/1974?email_source=notifications&email_token=ALKTZBZFHX57MQ2W3EQJLRDPY6IABA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW7I6DI#issuecomment-499027725, or mute the thread https://github.com/notifications/unsubscribe-auth/ALKTZB7NUHCRXTZG5GSZAD3PY6IABANCNFSM4HSZHHVQ .
-
alexyosifov -
Daniel-Constantin Mierla
-
Henning Westerholt
-
Rick
-
Tsvetomir Dimitrov