Hello,
I would like to set a timeout in milliseconds when using Kamailio module http_client. From what I read, the module is accepting a parameter "connection_timeout":
https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_cl...
This is used to set curl option "CURLOPT_TIMEOUT". I would like to set instead curl option "CURLOPT_TIMEOUT_MS".
I think changing the parameter "connection_timeout" from seconds to milliseconds is not a good idea, since it would break existing configurations. What about adding a new parameter "connection_timeout_ms" to the module ?
Curl documentation says that: "If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS are set, the value set last is used." The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so that the current behaviour is kept if the new parameter is not configured.
What do you think ?
Regards, Nicolas.
This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
Hello Nicolas,
sounds good, an additional parameter while keeping the existing functionality for the existing timeout would work.
Just create a pull request, then developers can review it and maybe some smaller adjustments could be done before a merge.
Thanks,
Henning
-- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.comhttps://gilawa.com/
From: Chaigneau, Nicolas via sr-dev sr-dev@lists.kamailio.org Sent: Dienstag, 17. Oktober 2023 18:11 To: Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org Cc: Chaigneau, Nicolas nicolas.chaigneau@capgemini.com Subject: [sr-dev] Kamailio module http_client - setting timeout in ms - new parameter ?
Hello,
I would like to set a timeout in milliseconds when using Kamailio module http_client. From what I read, the module is accepting a parameter "connection_timeout":
https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_cl...
This is used to set curl option "CURLOPT_TIMEOUT". I would like to set instead curl option "CURLOPT_TIMEOUT_MS".
I think changing the parameter "connection_timeout" from seconds to milliseconds is not a good idea, since it would break existing configurations. What about adding a new parameter "connection_timeout_ms" to the module ?
Curl documentation says that: "If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS are set, the value set last is used." The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so that the current behaviour is kept if the new parameter is not configured.
What do you think ?
Regards, Nicolas.
This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
Hello Henning,
Here is a pull request for this :
https://github.com/kamailio/kamailio/pull/3609
Let me know if it's ok. If it can be merged, I would like to backport the changes to 5.7.x branch. (should I also do a pull request for this branch ?)
Regards, Nicolas.
De : Henning Westerholt hw@gilawa.com Envoyé : mardi 17 octobre 2023 19:23 À : Kamailio (SER) - Development Mailing List Cc : Chaigneau, Nicolas Objet : RE: Kamailio module http_client - setting timeout in ms - new parameter ?
Hello Nicolas,
sounds good, an additional parameter while keeping the existing functionality for the existing timeout would work.
Just create a pull request, then developers can review it and maybe some smaller adjustments could be done before a merge.
Thanks,
Henning
-- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.comhttps://gilawa.com/
From: Chaigneau, Nicolas via sr-dev <sr-dev@lists.kamailio.orgmailto:sr-dev@lists.kamailio.org> Sent: Dienstag, 17. Oktober 2023 18:11 To: Kamailio (SER) - Development Mailing List <sr-dev@lists.kamailio.orgmailto:sr-dev@lists.kamailio.org> Cc: Chaigneau, Nicolas <nicolas.chaigneau@capgemini.commailto:nicolas.chaigneau@capgemini.com> Subject: [sr-dev] Kamailio module http_client - setting timeout in ms - new parameter ?
Hello,
I would like to set a timeout in milliseconds when using Kamailio module http_client. From what I read, the module is accepting a parameter "connection_timeout":
https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_cl...
This is used to set curl option "CURLOPT_TIMEOUT". I would like to set instead curl option "CURLOPT_TIMEOUT_MS".
I think changing the parameter "connection_timeout" from seconds to milliseconds is not a good idea, since it would break existing configurations. What about adding a new parameter "connection_timeout_ms" to the module ?
Curl documentation says that: "If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS are set, the value set last is used." The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so that the current behaviour is kept if the new parameter is not configured.
What do you think ?
Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
Hello,
thank you, will take a look! Regarding backporting it to stable branch, this will be unfortunately not possible as it's a new functionality. Generally speaking, its not necessary to create additional PRs for stable branches, this is usually done with cherry-picking.
Cheers,
Henning
-- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.comhttps://gilawa.com/
From: Chaigneau, Nicolas nicolas.chaigneau@capgemini.com Sent: Donnerstag, 19. Oktober 2023 14:02 To: Henning Westerholt hw@gilawa.com; Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org Subject: RE: Kamailio module http_client - setting timeout in ms - new parameter ?
Hello Henning,
Here is a pull request for this :
https://github.com/kamailio/kamailio/pull/3609
Let me know if it's ok. If it can be merged, I would like to backport the changes to 5.7.x branch. (should I also do a pull request for this branch ?)
Regards, Nicolas.
De : Henning Westerholt <hw@gilawa.commailto:hw@gilawa.com> Envoyé : mardi 17 octobre 2023 19:23 À : Kamailio (SER) - Development Mailing List Cc : Chaigneau, Nicolas Objet : RE: Kamailio module http_client - setting timeout in ms - new parameter ?
Hello Nicolas,
sounds good, an additional parameter while keeping the existing functionality for the existing timeout would work.
Just create a pull request, then developers can review it and maybe some smaller adjustments could be done before a merge.
Thanks,
Henning
-- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.comhttps://gilawa.com/
From: Chaigneau, Nicolas via sr-dev <sr-dev@lists.kamailio.orgmailto:sr-dev@lists.kamailio.org> Sent: Dienstag, 17. Oktober 2023 18:11 To: Kamailio (SER) - Development Mailing List <sr-dev@lists.kamailio.orgmailto:sr-dev@lists.kamailio.org> Cc: Chaigneau, Nicolas <nicolas.chaigneau@capgemini.commailto:nicolas.chaigneau@capgemini.com> Subject: [sr-dev] Kamailio module http_client - setting timeout in ms - new parameter ?
Hello,
I would like to set a timeout in milliseconds when using Kamailio module http_client. From what I read, the module is accepting a parameter "connection_timeout":
https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_cl...
This is used to set curl option "CURLOPT_TIMEOUT". I would like to set instead curl option "CURLOPT_TIMEOUT_MS".
I think changing the parameter "connection_timeout" from seconds to milliseconds is not a good idea, since it would break existing configurations. What about adding a new parameter "connection_timeout_ms" to the module ?
Curl documentation says that: "If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS are set, the value set last is used." The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so that the current behaviour is kept if the new parameter is not configured.
What do you think ?
Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
On 19 Oct 2023, at 14:02, Chaigneau, Nicolas via sr-dev sr-dev@lists.kamailio.org wrote:
Hello Henning,
Here is a pull request for this :
I’ve left some notes.
Let me know if it’s ok. If it can be merged, I would like to backport the changes to 5.7.x branch. (should I also do a pull request for this branch ?)
We do not add new features to old branches. New features are part of new releases.
Thank you for contributing to Kamailio!
/O
Regards, Nicolas.
De : Henning Westerholt <hw@gilawa.com mailto:hw@gilawa.com> Envoyé : mardi 17 octobre 2023 19:23 À : Kamailio (SER) - Development Mailing List Cc : Chaigneau, Nicolas Objet : RE: Kamailio module http_client - setting timeout in ms - new parameter ?
Hello Nicolas,
sounds good, an additional parameter while keeping the existing functionality for the existing timeout would work.
Just create a pull request, then developers can review it and maybe some smaller adjustments could be done before a merge.
Thanks,
Henning
-- Henning Westerholt – https://skalatan.de/blog/ Kamailio services – https://gilawa.com https://gilawa.com/
From: Chaigneau, Nicolas via sr-dev <sr-dev@lists.kamailio.org mailto:sr-dev@lists.kamailio.org> Sent: Dienstag, 17. Oktober 2023 18:11 To: Kamailio (SER) - Development Mailing List <sr-dev@lists.kamailio.org mailto:sr-dev@lists.kamailio.org> Cc: Chaigneau, Nicolas <nicolas.chaigneau@capgemini.com mailto:nicolas.chaigneau@capgemini.com> Subject: [sr-dev] Kamailio module http_client - setting timeout in ms - new parameter ?
Hello,
I would like to set a timeout in milliseconds when using Kamailio module http_client. From what I read, the module is accepting a parameter “connection_timeout”:
https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_cl...
This is used to set curl option “CURLOPT_TIMEOUT”. I would like to set instead curl option “CURLOPT_TIMEOUT_MS”.
I think changing the parameter “connection_timeout” from seconds to milliseconds is not a good idea, since it would break existing configurations. What about adding a new parameter “connection_timeout_ms” to the module ?
Curl documentation says that: “If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS are set, the value set last is used.” The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so that the current behaviour is kept if the new parameter is not configured.
What do you think ?
Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. _______________________________________________ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-leave@lists.kamailio.org mailto:sr-dev-leave@lists.kamailio.org
On 17 Oct 2023, at 18:11, Chaigneau, Nicolas via sr-dev sr-dev@lists.kamailio.org wrote:
Hello,
I would like to set a timeout in milliseconds when using Kamailio module http_client. From what I read, the module is accepting a parameter “connection_timeout”:
https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_cl...
This is used to set curl option “CURLOPT_TIMEOUT”. I would like to set instead curl option “CURLOPT_TIMEOUT_MS”.
I think changing the parameter “connection_timeout” from seconds to milliseconds is not a good idea, since it would break existing configurations. What about adding a new parameter “connection_timeout_ms” to the module ?
Curl documentation says that: “If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS are set, the value set last is used.” The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so that the current behaviour is kept if the new parameter is not configured.
What do you think ?
It is propably a good idea. Looking forward to a patch. :-)
Cheers, /O
-
Chaigneau, Nicolas -
Henning Westerholt -
Olle E. Johansson