#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Added new Added new auth module function auth_algorithm that can be used to dynamically override algorithm parameter value.
#### Note I was not able to test check README, because of this error: ``` /usr/src/orig/kamailio$ make modules-readme modules=modules/auth make -C src/ modules-readme make[1]: Entering directory '/usr/src/orig/kamailio/src' make --no-print-directory -C doc auth.txt xsltproc --novalid \ --nonet \ --novalid \ --stringparam output "auth.d" \ ../../../../doc/docbook/dep.xsl auth.xml xsltproc --novalid \ --xinclude \ ../../../../doc/docbook/txt.xsl auth.xml | lynx -nolist -stdin -dump > auth.txt error : Unknown IO error warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/xhtml/docbook.xsl%22; compilation error: file ../../../../doc/docbook/txt.xsl line 6 element import xsl:import : unable to load http://docbook.sourceforge.net/release/xsl/current/xhtml/docbook.xsl ```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3849
-- Commit Summary --
* Added new auth module function auth_algorithm
-- File Changes --
M src/modules/auth/auth_mod.c (37) M src/modules/auth/doc/auth_functions.xml (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3849.patch https://github.com/kamailio/kamailio/pull/3849.diff
@juha-h pushed 1 commit.
4ccadb7ed3a762ec1d2781e783f760f6de4b588e Format changes
@juha-h pushed 1 commit.
6992d1784aa3e1f96aa3a406f25675178605108d More format changes
The README must not be regenerated locally and part of the commit, it is going to be generated on server and pushed to git repository by a cron job.
One can generate readme locally only for checking it if it is correct, but then reverted before committing.
Of course, if one pushed a regenerated commit is not critical, but by using the server side generation, the READMEs look coherent.
I am going to merge the PR manually for make it consistent with the commit message guidelines.
Daniel-Constantin Mierla writes:
One can generate readme locally only for checking it if it is correct, but then reverted before committing.
That is exactly what I tried to do according to instructions, but generation failed.
Also, there is something wrong with the format check. It shows red even when the Details shows OK:
6992d1784aa3e1f96aa3a406f25675178605108d... PASSED 3bcedc47e381d22521aeb544b0d27180786d7039... PASSED
-- Juha
If you want to test README generation locally, then you are missing some dockbook-relate packages, likely `docbook-xsl`.
Merged manually!
Closed #3849.
If you want to test README generation locally, then you are missing some dockbook-relate packages, likely `docbook-xsl`.
README generation worked after I installed Debian package `docbook-xsl`. For some reason make command as described here [https://www.kamailio.org/wikidocs/devel/module-docbook-readme/%5D() was not able to load it from source repo.
How about the failing format check?
I haven't checked closely, at the first look it seems some spacing issues in one of the commits out of three. Did you run clang-format? I installed the git hooks as suggested by Victor Seva and any clang-format issues are reported and fixed before I can do a commit.
After the first commit. there was format issues that I tried to fix manually and pushed another commit. After that, format check was re-run automatically and one more format issue remained. I fixed also that, push a new commit, and again format check was re-run automatically. Now the format check passed, but still the web page showed that format check failed.
As I said, I haven't looked much into it, not sure what was the reason ...
I installed `pre-commit` along with `clang-format` and before each commit the formatting is checked automatically, simplifying my coding process as I can do it without caring of formatting and it gets fixed at commit time. I sent an email about it a while ago:
- https://kamailio.org/mailman3/hyperkitty/list/sr-users@lists.kamailio.org/me...
You can push --force the new commit with the format fixed squashing previous commits
-
Daniel-Constantin Mierla -
juha-h
-
Victor Seva