If we have multiple Rx_AAR in the script (e.g. for 183, then for UPDATEs) since the second AAR is considered an update, without that patch, the dialog is not unreferenced. That leads to dialog not being deleted since there is a dangling reference which leads to memory leak. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3104#issuecomment-1124706755 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3104/c1124706755(a)github.com>

The commit message has to start with the component name, not with the file name, respectively ims_qos in this case. @alexyosifov: is it something that you can check if it is ok? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3104#issuecomment-1135584211 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3104/c1135584211(a)github.com>

@atanas-wg2 @miconda I have checked locally the changes. The P-CSCF doesn't start correctly if trying to load the ims_qos module: `0(15988) DEBUG: <core> [core/sr_module.c:563]: load_module(): trying to load </usr/local/lib64/kamailio/modules/ims_qos.so>` `0(15988) ERROR: <core> [core/sr_module.c:570]: load_module(): could not open module </usr/local/lib64/kamailio/modules/ims_qos.so>: /usr/local/lib64/kamailio/modules/ims_qos.so: undefined symbol: unref_dlg` `0(15988) CRITICAL: <core> [core/cfg.y:3796]: yyerror_at(): parse error in config file /etc/kamailio_pcscf/kamailio.cfg, line 239, column 12-20: failed to load module` Because of the following warning during compilation: `Warning: rx_aar.c:184:13: warning: implicit declaration of function 'unref_dlg'; did you mean 'unref_cell'? [-Wimplicit-function-declaration] 184 | unref_dlg(data->dlg, 1); | ^~~~~~~~~ ` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3104#issuecomment-1141950700 You are receiving this because you are subscribed to this thread. Message ID: &lt;kamailio/kamailio/pull/3104/c1141950700(a)github.com&gt;