Module: sip-router Branch: master Commit: f369faa6d09f30a48d11fa34cbdb581df6ea01e2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f369faa6...
Author: Henning Westerholt henning.westerholt@1und1.de Committer: Henning Westerholt henning.westerholt@1und1.de Date: Wed Jun 29 22:35:39 2011 +0200
ipops: add a comment about autogenerated files from ragel
---
modules/ipops/ip_parser.c | 4 ++++ modules/ipops/ip_parser.h | 5 +++++ 2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/modules/ipops/ip_parser.c b/modules/ipops/ip_parser.c index 0695fa5..b9e0a1c 100644 --- a/modules/ipops/ip_parser.c +++ b/modules/ipops/ip_parser.c @@ -1,3 +1,7 @@ +/* + * Warning: This file is auto generated from a ragel syntax (ip_parser.rl), + * do not change it! + */
#line 1 "ip_parser.rl" #include "ip_parser.h" diff --git a/modules/ipops/ip_parser.h b/modules/ipops/ip_parser.h index 7b53cc0..23ca248 100644 --- a/modules/ipops/ip_parser.h +++ b/modules/ipops/ip_parser.h @@ -1,3 +1,8 @@ +/* + * Warning: This file is auto generated from a ragel syntax (ip_parser.rl), + * do not change it! + */ + #ifndef ip_parser_h #define ip_parser_h
2011/6/29 Henning Westerholt henning.westerholt@1und1.de:
diff --git a/modules/ipops/ip_parser.c b/modules/ipops/ip_parser.c index 0695fa5..b9e0a1c 100644 --- a/modules/ipops/ip_parser.c +++ b/modules/ipops/ip_parser.c @@ -1,3 +1,7 @@ +/*
- Warning: This file is auto generated from a ragel syntax (ip_parser.rl),
- do not change it!
- */
Hi Henning, the only problem with this warning is that if ip_parser.rl is modified and compile_ip_parser.rl.sh executed, it will generate ip_parser.c without your comment above. The workaround would be adding your comment on top of ip_parser.rl file (but it would be a bit confusing reading it that file :-D).
Well, a better solution would be just to remember adding your comment after regenerating ip_parser.c :)
Cheers.
On Wednesday 29 June 2011, Iñaki Baz Castillo wrote:
[..] Hi Henning, the only problem with this warning is that if ip_parser.rl is modified and compile_ip_parser.rl.sh executed, it will generate ip_parser.c without your comment above.
Hi Inaki,
of course you're right. :-)
The workaround would be adding your comment on top of ip_parser.rl file (but it would be a bit confusing reading it that file :-D).
Well, a better solution would be just to remember adding your comment after regenerating ip_parser.c :)
I don't know the exact ragel syntax, therefore i changed it in the generated files. Feel free to add it to the source, but its fine with me as well if its stays like this now.
Best regards,
Henning
2011/6/30 Henning Westerholt henning.westerholt@1und1.de:
Well, a better solution would be just to remember adding your comment after regenerating ip_parser.c :)
I don't know the exact ragel syntax, therefore i changed it in the generated files. Feel free to add it to the source, but its fine with me as well if its stays like this now.
IMHO it's ok now. If I change the ragel file sometime (or see that somebody changes it) I will remember to add the note into the generated C file.
Cheers.
-
Henning Westerholt -
Iñaki Baz Castillo