Hello all,
I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged.
where do I need to send my public ssh key to get commit access to the sip-router git ?
thanks
Elias
Hi Elias,
On 2/2/10 7:36 PM, Elias Baixas wrote:
Hello all,
I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
thanks! it was hard for me to setup all Java env and start testing. Send the key to me along with desired git username and I will take care of the rest.
Cheers, Daniel
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged.
where do I need to send my public ssh key to get commit access to the sip-router git ?
thanks
Elias
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
El Martes, 2 de Febrero de 2010, Daniel-Constantin Mierla escribió:
it was hard for me to setup all Java env and start testing
Yes, the problem of Java is that... it requires Java! XD
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all,
I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged.
where do I need to send my public ssh key to get commit access to the sip-router git ?
That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
I'd be also happy to do some testing becase I was going to use it this week.
Regarding the ssh, you can send it to either Daniel or myself and we'll give you access.
-Jan
Hello,
On 2/2/10 9:26 PM, Jan Janak wrote:
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all, I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch. it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged. where do I need to send my public ssh key to get commit access to the sip-router git ?That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
I'd be also happy to do some testing becase I was going to use it this week.
Regarding the ssh, you can send it to either Daniel or myself and we'll give you access.
ssh access should be up, hopefully I haven't forgot anything and just works now :-)
Cheers, Daniel
Ok, i've just created ebaixas/fixing_seas, take a look if you will, and lets prepare a merge of my changes into the master.
some things I am unsure about my modifications to tm are:
-backported dlg_add_extra from opensips, which lets me copy [local,remote] Display Name into struct dlg/loc_dname,rem_dname (I just thought that I didn't remember to add the piece of code to free that shared mem from dlg when the dialog is destroyed. TODO)
-backported t_uac_cancel from opensips, which lets me cancel a branch, but also adding some new headers to the CANCEL (the uac cancel function in ser doesn't let adding new headers, and this is needed for AppServer)
-backported build_uac_cancel needed for t_uac_cancel
-in t_reply_with_body changed arguments of type char* to str* and the functions using this accordingly (I think :P )
everything else are changes in seas module itself.
those changes include some important fixes to seas that break the binary-protocol compatibility with the application server. This are needed changes that are not yet published to the public WeSIP/seas-JAIN release. I have uploaded an updated seas-jain compatible with the new protocol to http://www.baixas.net/seas-jain.jar, get it if you need.
at the moment the seas module just compiles with the master sip-router. remains to see if it actually works. this is work I plan to do on the next months, at the moment I can't guarantee everything works as it did/should.
best regards,
Elias
On Tue, Feb 2, 2010 at 9:51 PM, Daniel-Constantin Mierla miconda@gmail.comwrote:
Hello,
On 2/2/10 9:26 PM, Jan Janak wrote:
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all,
I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged.
where do I need to send my public ssh key to get commit access to the sip-router git ?
That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
I'd be also happy to do some testing becase I was going to use it this week.
Regarding the ssh, you can send it to either Daniel or myself and we'll give you access.
ssh access should be up, hopefully I haven't forgot anything and just works now :-)
Cheers, Daniel
Hello,
as Daniel correctly pointed me out I need to clarify my statements on the seas branch commits.
the commits were not actually 'back'ported, but 'forward'ported since they were old commits from openser/kamailio and opensips. Then for the licensing and IP of those changes, the t_uac_cancel was a commit I did myself in the past, so it has BSD license. for the dlg_add_extra commit, it was done by Andrei Pisau on behalf of VozTelecom who agree to license it as BSD, so no problems to integrate those on tm.
Elias
On Wed, Feb 3, 2010 at 1:09 AM, Elias Baixas elias.baixas@voztele.comwrote:
Ok, i've just created ebaixas/fixing_seas, take a look if you will, and lets prepare a merge of my changes into the master.
some things I am unsure about my modifications to tm are:
-backported dlg_add_extra from opensips, which lets me copy [local,remote] Display Name into struct dlg/loc_dname,rem_dname (I just thought that I didn't remember to add the piece of code to free that shared mem from dlg when the dialog is destroyed. TODO)
-backported t_uac_cancel from opensips, which lets me cancel a branch, but also adding some new headers to the CANCEL (the uac cancel function in ser doesn't let adding new headers, and this is needed for AppServer)
-backported build_uac_cancel needed for t_uac_cancel
-in t_reply_with_body changed arguments of type char* to str* and the functions using this accordingly (I think :P )
everything else are changes in seas module itself.
those changes include some important fixes to seas that break the binary-protocol compatibility with the application server. This are needed changes that are not yet published to the public WeSIP/seas-JAIN release. I have uploaded an updated seas-jain compatible with the new protocol to http://www.baixas.net/seas-jain.jar, get it if you need.
at the moment the seas module just compiles with the master sip-router. remains to see if it actually works. this is work I plan to do on the next months, at the moment I can't guarantee everything works as it did/should.
best regards,
Elias
On Tue, Feb 2, 2010 at 9:51 PM, Daniel-Constantin Mierla < miconda@gmail.com> wrote:
Hello,
On 2/2/10 9:26 PM, Jan Janak wrote:
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all,
I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged.
where do I need to send my public ssh key to get commit access to the sip-router git ?
That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
I'd be also happy to do some testing becase I was going to use it this week.
Regarding the ssh, you can send it to either Daniel or myself and we'll give you access.
ssh access should be up, hopefully I haven't forgot anything and just works now :-)
Cheers, Daniel
Hi Jan,
On 2/2/10 9:26 PM, Jan Janak wrote:
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all, I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch. it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged. where do I need to send my public ssh key to get commit access to the sip-router git ?That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
are you still working on this? If not, I will try to review myself and get the code in master.
Thanks, Daniel
I'd be also happy to do some testing becase I was going to use it this week.
Regarding the ssh, you can send it to either Daniel or myself and we'll give you access.
-Jan
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
On Fri, Apr 23, 2010 at 3:55 AM, Daniel-Constantin Mierla miconda@gmail.com wrote:
Hi Jan,
On 2/2/10 9:26 PM, Jan Janak wrote:
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all,
I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged.
where do I need to send my public ssh key to get commit access to the sip-router git ?
That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
are you still working on this? If not, I will try to review myself and get the code in master.
Yes, I had to stop working on it for a while but I returned to it a week ago. I currently have the seas module mostly working (there were issues with process creation as a result of the changes in sip-router and some issues with pipes used for communication with the dispatcher process). There may also be a memory leak somewhere (probably tm), but I haven't found that yet.
The java side seems working (at least with a simple application) (although on Debian Squeeze one has to change a setting in /etc/sysctl.d/bindv6only.conf otherwise the servlet container cannot connect to sip-router). In the java code I did only small changes, removed one unnecessary import and added some more debugging messages).
My deadline is end of the month, so I'll commit whatever I have by then. I think it should work, but if not you can continue fixing.
-Jan
On 4/23/10 10:15 AM, Jan Janak wrote:
On Fri, Apr 23, 2010 at 3:55 AM, Daniel-Constantin Mierla miconda@gmail.com wrote:
Hi Jan,
On 2/2/10 9:26 PM, Jan Janak wrote:
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all, I have been working on the seas module to make it work on sip-router.I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged. where do I need to send my public ssh key to get commit access to the sip-router git ?That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
are you still working on this? If not, I will try to review myself and get the code in master.
Yes, I had to stop working on it for a while but I returned to it a week ago. I currently have the seas module mostly working (there were issues with process creation as a result of the changes in sip-router and some issues with pipes used for communication with the dispatcher process). There may also be a memory leak somewhere (probably tm), but I haven't found that yet.
The java side seems working (at least with a simple application) (although on Debian Squeeze one has to change a setting in /etc/sysctl.d/bindv6only.conf otherwise the servlet container cannot connect to sip-router). In the java code I did only small changes, removed one unnecessary import and added some more debugging messages).
My deadline is end of the month, so I'll commit whatever I have by then. I think it should work, but if not you can continue fixing.
ok, thanks for update.
Daniel
Hi all,
sorry for not having given enough attention to the list.
when Jan publishes his changes, I'll submit a couple of new patches I have regarding the memory-leaks (basically not correctly unref'ing cells in some places in case of CANCELs, or in ac_reply in case of error, and in t_cancel.c:t_uac_cancel), I can send the patch if you need.
Elias
On Fri, Apr 23, 2010 at 10:23 AM, Daniel-Constantin Mierla < miconda@gmail.com> wrote:
On 4/23/10 10:15 AM, Jan Janak wrote:
On Fri, Apr 23, 2010 at 3:55 AM, Daniel-Constantin Mierla miconda@gmail.com wrote:
Hi Jan,
On 2/2/10 9:26 PM, Jan Janak wrote:
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all,
I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged.
where do I need to send my public ssh key to get commit access to the sip-router git ?
That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
are you still working on this? If not, I will try to review myself and get the code in master.
Yes, I had to stop working on it for a while but I returned to it a week ago. I currently have the seas module mostly working (there were issues with process creation as a result of the changes in sip-router and some issues with pipes used for communication with the dispatcher process). There may also be a memory leak somewhere (probably tm), but I haven't found that yet.
The java side seems working (at least with a simple application) (although on Debian Squeeze one has to change a setting in /etc/sysctl.d/bindv6only.conf otherwise the servlet container cannot connect to sip-router). In the java code I did only small changes, removed one unnecessary import and added some more debugging messages).
My deadline is end of the month, so I'll commit whatever I have by then. I think it should work, but if not you can continue fixing.
ok, thanks for update.
Daniel
-- Daniel-Constantin Mierla
Hi Jan,
just a short reminder in case you forgot about seas commits.
Thanks, Daniel
On 5/20/10 3:55 PM, Elias Baixas wrote:
Hi all,
sorry for not having given enough attention to the list.
when Jan publishes his changes, I'll submit a couple of new patches I have regarding the memory-leaks (basically not correctly unref'ing cells in some places in case of CANCELs, or in ac_reply in case of error, and in t_cancel.c:t_uac_cancel), I can send the patch if you need.
Elias
On Fri, Apr 23, 2010 at 10:23 AM, Daniel-Constantin Mierla <miconda@gmail.com mailto:miconda@gmail.com> wrote:
On 4/23/10 10:15 AM, Jan Janak wrote: On Fri, Apr 23, 2010 at 3:55 AM, Daniel-Constantin Mierla <miconda@gmail.com <mailto:miconda@gmail.com>> wrote: Hi Jan, On 2/2/10 9:26 PM, Jan Janak wrote: Hi, On 02-02 19:36, Elias Baixas wrote: Hello all, I have been working on the seas module to make it work on sip-router. I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch. it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged. where do I need to send my public ssh key to get commit access to the sip-router git ? That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places. are you still working on this? If not, I will try to review myself and get the code in master. Yes, I had to stop working on it for a while but I returned to it a week ago. I currently have the seas module mostly working (there were issues with process creation as a result of the changes in sip-router and some issues with pipes used for communication with the dispatcher process). There may also be a memory leak somewhere (probably tm), but I haven't found that yet. The java side seems working (at least with a simple application) (although on Debian Squeeze one has to change a setting in /etc/sysctl.d/bindv6only.conf otherwise the servlet container cannot connect to sip-router). In the java code I did only small changes, removed one unnecessary import and added some more debugging messages). My deadline is end of the month, so I'll commit whatever I have by then. I think it should work, but if not you can continue fixing. ok, thanks for update. Daniel -- Daniel-Constantin Mierla * http://www.asipto.com/ * http://twitter.com/miconda * http://www.linkedin.com/in/danielconstantinmierla
On 4/23/10 10:15 AM, Jan Janak wrote:
On Fri, Apr 23, 2010 at 3:55 AM, Daniel-Constantin Mierla miconda@gmail.com wrote:
Hi Jan,
On 2/2/10 9:26 PM, Jan Janak wrote:
Hi,
On 02-02 19:36, Elias Baixas wrote:
Hello all, I have been working on the seas module to make it work on sip-router.I have my own git branch locally, but I'd like to share it on the sip-router public git so that others can take a look and finally push it to the master branch.
it needs some transaction-module changes, so it needs good review from other more tm-knowledgable coders before it can be finally merged. where do I need to send my public ssh key to get commit access to the sip-router git ?That's great, I actually also started working on making the seas module compile, so if you want you can send the patches to me and I'd be happy to review and commit the changes to tm and other places.
are you still working on this? If not, I will try to review myself and get the code in master.
Yes, I had to stop working on it for a while but I returned to it a week ago. I currently have the seas module mostly working (there were issues with process creation as a result of the changes in sip-router and some issues with pipes used for communication with the dispatcher process). There may also be a memory leak somewhere (probably tm), but I haven't found that yet.
The java side seems working (at least with a simple application) (although on Debian Squeeze one has to change a setting in /etc/sysctl.d/bindv6only.conf otherwise the servlet container cannot connect to sip-router). In the java code I did only small changes, removed one unnecessary import and added some more debugging messages).
My deadline is end of the month, so I'll commit whatever I have by then. I think it should work, but if not you can continue fixing.
Hi Jan, any update on this one?
Thanks, Daniel
-
Daniel-Constantin Mierla -
Elias Baixas -
Iñaki Baz Castillo -
Jan Janak