[kamailio/kamailio] Close parenthesis on error description (#2589)
Close parentheses on error description when *Not enough parameters* on *htable_rpc_delete*. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2589 -- Commit Summary -- * Close parenthesis on error description -- File Changes -- M src/modules/htable/htable.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2589.patch https://github.com/kamailio/kamailio/pull/2589.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2589
You have to format the commit message as per contributions guidelines: * https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com... Like: ``` htable: close parentheses on error description inside htable_rpc_delete ``` If no time to remake the commit, the change can be done by another developer. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2589#issuecomment-747671388
@valenciaj - the remark was about the commit message not being properly formatted, not about the title of the PR. You have to amend (do again) the commit and force push in your branch. Or close this PR and do a new one with the new commit formatted as per contributing guidelines. This only if you want to rework it yourself, otherwise I can make a manual commit in the next days. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2589#issuecomment-754016910
Closed #2589. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2589#event-4166126023
Just for the record, it was fixed in 024c649c3 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2589#issuecomment-2603127815 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/2589/c2603127815@github.com>
participants (3)
-
Daniel-Constantin Mierla -
Henning Westerholt
-
Javier Valencia