17 Dec
2020
17 Dec
'20
9:46 a.m.
Close parentheses on error description when *Not enough parameters* on
*htable_rpc_delete*.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2589
-- Commit Summary --
* Close parenthesis on error description
-- File Changes --
M src/modules/htable/htable.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2589.patch
https://github.com/kamailio/kamailio/pull/2589.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2589
17 Dec
17 Dec
10:06 p.m.
You have to format the commit message as per contributions guidelines:
*
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#co…
Like:
```
htable: close parentheses on error description inside htable_rpc_delete
```
If no time to remake the commit, the change can be done by another developer.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2589#issuecomment-747671388
4 Jan
4 Jan
4:47 p.m.
New subject: [kamailio/kamailio] htable: close parentheses on error description inside htable_rpc_delete (#2589)
@valenciaj - the remark was about the commit message not being properly formatted, not
about the title of the PR. You have to amend (do again) the commit and force push in your
branch. Or close this PR and do a new one with the new commit formatted as per
contributing guidelines.
This only if you want to rework it yourself, otherwise I can make a manual commit in the
next days.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2589#issuecomment-754016910
8:17 p.m.
New subject: [kamailio/kamailio] htable: close parentheses on error description inside htable_rpc_delete (#2589)
Closed #2589.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2589#event-4166126023
1449
days inactive
1467
days old
3 comments
2 participants
participants (2)
-
Daniel-Constantin Mierla -
Javier Valencia