Yes, definitely agree!! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4066#issuecomment-2538390832 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4066/c2538390832(a)github.com>

@linuxmaniac Is this pre-commit using the `cmake-format.py` config file found in `cmake` or it just go by the defaults? If we are fine with the defaults, we can remove the file completely, as it might mess up the format if configured to use the one provided (happened to me that I was already using the one in `cmake` :) ). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4066#issuecomment-2548123033 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4066/c2548123033(a)github.com>

@miconda Sure thing, all the available options, are in that `cmake/cmake-format.py`. We can also use other formats apart from python conf file, like yaml or json. `cmake-format --dump-config [yaml|json|python] > file.ext` will output all the default configs so that we can manually edit it afterwards at out style. So, for now, I will also use the defaults, to have no differences when committing code, until we decide to change them. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4066#issuecomment-2548167264 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4066/c2548167264(a)github.com>

@linuxmaniac @miconda: Question regarding these checks! Are they enforced when pushing directly to master, if someone has not setup locally the pre-commit python module and not being warned? Ideally, when pushing to master, it must not accept code (either cmake or c), that does not conform to the format requested. On pull request we have the checks, so we can know about it. On the direct commit, if the author does not have locally the `pre-commit`, it seems to me that it can push with whatever format. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4066#issuecomment-2551395963 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4066/c2551395963(a)github.com>