Hello, Let me know how i could insert my module (hiops) into Kamailio github project? Also i've had some changes into other Kamailio file sources core path(such as those that i asked before here, with this subject: A bit trick in msg_translator.c source file"), How i could push them to Kamailio project,too? Does it's enough i just pull all file sources and add my module along with all others changes, push them with new branche in Kamailio project? With Regardd.Mojtaba
On 13 Feb 2019, at 21:24, Mojtaba mespio@gmail.com wrote:
Hello, Let me know how i could insert my module (hiops) into Kamailio github project? Also i've had some changes into other Kamailio file sources core path(such as those that i asked before here, with this subject: A bit trick in msg_translator.c source file"), How i could push them to Kamailio project,too? Does it's enough i just pull all file sources and add my module along with all others changes, push them with new branche in Kamailio project? With Regardd.Mojtaba
The best way is to create a clone in your own github account and then produce a merge request to the kamailio project so we can go through and discuss your code.
There are plenty of guides out there on how to produce a merge request.
Make sure you separate commits into small pieces so that you don’t have one large commit on both core and your new module.
And please don’t forget the documentation :-)
Best regards, /Olle
Am Mittwoch, 13. Februar 2019, 21:24:00 CET schrieb Mojtaba:
Let me know how i could insert my module (hiops) into Kamailio github project? Also i've had some changes into other Kamailio file sources core path(such as those that i asked before here, with this subject: A bit trick in msg_translator.c source file"), How i could push them to Kamailio project,too? Does it's enough i just pull all file sources and add my module along with all others changes, push them with new branche in Kamailio project?
Hello Mojtbaba,
additional to the comment from Olle, have a look to this documentation:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
Looking forward to your pull request.
Best regards,
Henning
Sure, I will look into it. Thanks
On Thu, Feb 14, 2019 at 12:52 PM Henning Westerholt hw@kamailio.org wrote:
Am Mittwoch, 13. Februar 2019, 21:24:00 CET schrieb Mojtaba:
Let me know how i could insert my module (hiops) into Kamailio github project? Also i've had some changes into other Kamailio file sources core
path(such
as those that i asked before here, with this subject: A bit trick in msg_translator.c source file"), How i could push them to Kamailio project,too? Does it's enough i just pull all file sources and add my module along
with
all others changes, push them with new branche in Kamailio project?
Hello Mojtbaba,
additional to the comment from Olle, have a look to this documentation:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
Looking forward to your pull request.
Best regards,
Henning
-- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://skalatan.de/services Kamailio security assessment - https://skalatan.de/de/assessment
Hello, I just commited the hiops module in Kamailio project. It just is under developing and will take afew time. Thanks
On Thu, 14 Feb 2019, 13:59 Mojtaba, mespio@gmail.com wrote:
Sure, I will look into it. Thanks
On Thu, Feb 14, 2019 at 12:52 PM Henning Westerholt hw@kamailio.org wrote:
Am Mittwoch, 13. Februar 2019, 21:24:00 CET schrieb Mojtaba:
Let me know how i could insert my module (hiops) into Kamailio github project? Also i've had some changes into other Kamailio file sources core
path(such
as those that i asked before here, with this subject: A bit trick in msg_translator.c source file"), How i could push them to Kamailio project,too? Does it's enough i just pull all file sources and add my module along
with
all others changes, push them with new branche in Kamailio project?
Hello Mojtbaba,
additional to the comment from Olle, have a look to this documentation:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
Looking forward to your pull request.
Best regards,
Henning
-- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://skalatan.de/services Kamailio security assessment - https://skalatan.de/de/assessment
-- --Mojtaba Esfandiari.S
-
Henning Westerholt -
Mojtaba -
Olle E. Johansson