<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2756
-- Commit Summary --
* Add README.md * Merge branch 'master' of github.com:alexyosifov/kamailio * Merge remote-tracking branch 'remote_yosifov/master' * Merge branch 'master' of github.com:alexyosifov/kamailio * smsops: support for 7bit special chars
-- File Changes --
M src/modules/smsops/smsops_impl.c (256)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2756.patch https://github.com/kamailio/kamailio/pull/2756.diff
If no comments from other devs, it can be merged soon.
Hi @alexyosifov ,
a little comment regarding the fill bits, it's just for information. There is a more easy way to perform decoding and encoding of 7bit concatenated sms.
Let me explain
3GPP has added the fill bits for retro compatibility with old devices that doesn't support the concatenated sms and then the UDH header. With this assumption the decoding of entire PDU may be done with the effect of first N ASCII characters (due to udh header) are not valid but the rest is ok. So it's possible to decode the entire user-data pdu as a normal non udh pdu discarding the first N decoded ASCII string. N is equal to the septet of udh header + 1
In encoding the concept is the same, just add N preamble (3GPP recommends N '\n') characters to the ASCII string, encode as 7bit and overwrite the initial octets with the UDH header.
Hope my comment was useful Regards
@riccardv - if you want to do improvements to this part, just do a PR. This one will be merged.
Merged #2756 into master.
-
alexyosifov -
Daniel-Constantin Mierla
-
riccardv