<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x ] Commit message has the format required by CONTRIBUTING guide - [ x] Commits are split per component (core, individual modules, libs, utils, ...) - [x ] Each component has a single commit (if not, squash them into one commit) - [x ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x ] PR should be backported to stable branches - [x ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Add a new parameter validity to jwt_generate(prvkey, alg, claims) in order to set a validity period for generated jwt token. I know branch 5.5 is almost released but I think that this functionality is very important for this new module and I hope it can be added to this release.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2722
-- Commit Summary --
* cplc: add a configuration route before redirected call (key: redirect_route) * pua_dialoginfo: disable publish notifications for subsequent requests (key: publish_dialog_req_within) * Merge branch 'master' of https://github.com/kamailio/kamailio * jwt: token may have a validity period (number of seconds)
-- File Changes --
M src/modules/jwt/doc/jwt.xml (9) M src/modules/jwt/doc/jwt_admin.xml (5) M src/modules/jwt/jwt_mod.c (17)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2722.patch https://github.com/kamailio/kamailio/pull/2722.diff
Closed #2722.
As a generic, but important remark: whenever you make a pull request, first do a rebase and a fast-forward of the origin in your branch, otherwise older commits and unrelated show up in the pull requests. Like you see above commits related to cplc or pua_dialoginfo module.
Regarding the jwt commit, thanks for contributing, however I pushed a different approach to allow setting any numeric claims (grants). The jwt specs list other reserved names like not-before (nbf) with numeric values and actually there can be any other name with numeric values.
The `exp` can be added like:
``` $var(exp) = $Ts + 600; jwt_generate("/path/to/prvkey.pem", "RS256", "exp=$var(exp);caller='$fU';callee='$tU';callid='$ci'"); ```
The README has more details about parameters format.
Thanks for your generic developpement, it is better than my quickly dev and responds to my needs. I note your remark for further pull request.
-
Daniel-Constantin Mierla -
Frédéric Gaisnon