Hi, by inspecting the code it seems there is no problem if "grp" field in table "address" becomes "mediumint" rather than "smallint" (as now).
In my case I use diferent intervals within "grp" value to determine the nature of the source IP of a request (requests from clients, from trusted nodes, from PSTN gateways...) so I need to change it to "mediumint" (and works well).
Could it be changed in the database schema so no manual change would be required?
Regards.
Hello,
On 5/24/11 12:52 PM, Iñaki Baz Castillo wrote:
Hi, by inspecting the code it seems there is no problem if "grp" field in table "address" becomes "mediumint" rather than "smallint" (as now).
In my case I use diferent intervals within "grp" value to determine the nature of the source IP of a request (requests from clients, from trusted nodes, from PSTN gateways...) so I need to change it to "mediumint" (and works well).
Could it be changed in the database schema so no manual change would be required?
I think we should standardize on having 'int' everywhere, these variants of smaller ints are not that portable across databases.
In this case I am not sure what the structure inside the modules stores, but the database driver modules convert such ints to standard int.
Cheers, Daniel
2011/5/24 Daniel-Constantin Mierla daniel@kamailio.org:
I think we should standardize on having 'int' everywhere, these variants of smaller ints are not that portable across databases.
In this case I am not sure what the structure inside the modules stores, but the database driver modules convert such ints to standard int.
Yes, having SMALLINT(5) in a table seems an artificial limitation.
Daniel-Constantin Mierla writes:
I think we should standardize on having 'int' everywhere, these variants of smaller ints are not that portable across databases.
In this case I am not sure what the structure inside the modules stores, but the database driver modules convert such ints to standard int.
it is ok for me to change grp column to int. i think it can be done without changing version of address table.
-- juha
-
Daniel-Constantin Mierla -
Iñaki Baz Castillo -
Juha Heinanen