nathelper readme on this flag tells:
What branch flag should be used by the module to disable NAT pings on a per-registration basis. If the given flag is set for a particular registration, then no NAT pings will be sent at all, regardless of any other conditions.
however, the name of the flag is sipping_disable_bflag, which indicates that it would apply to nat ping via sip requests only.
which way it is? please either fix the name of the flag or readme text.
-- juha
Hey Juha,
did you mean to send this mail? I am confused! ;)
Cheers Jason
On Sat, Mar 9, 2013 at 9:25 PM, Juha Heinanen jh@tutpro.com wrote:
nathelper readme on this flag tells:
What branch flag should be used by the module to disable NAT pings on a per-registration basis. If the given flag is set for a particular registration, then no NAT pings will be sent atall, regardless of any other conditions.
however, the name of the flag is sipping_disable_bflag, which indicates that it would apply to nat ping via sip requests only.
which way it is? please either fix the name of the flag or readme text.
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Jason Penton writes:
did you mean to send this mail? I am confused! ;)
formatting may be obscure (sorry about that). i tried to say that the name of the flag is sipping_disable_bflag, i.e., it refers to ping with a sip method (like other sipping* vars), but based on the description in readme, it claims to have nothing to do with pinging with sip method, but nat ping in general.
please fix either the name of the var or description.
-- juha
Hey Juha,
This is my branch I'm using to build Ro Interface for IMS. I am not concerned about nathelper??? The only code that will move into master when I am done is the ims_ro module......
Cheers Jason
On Mon, Mar 11, 2013 at 9:17 AM, Juha Heinanen jh@tutpro.com wrote:
Jason Penton writes:
did you mean to send this mail? I am confused! ;)
formatting may be obscure (sorry about that). i tried to say that the name of the flag is sipping_disable_bflag, i.e., it refers to ping with a sip method (like other sipping* vars), but based on the description in readme, it claims to have nothing to do with pinging with sip method, but nat ping in general.
please fix either the name of the var or description.
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Jason Penton writes:
This is my branch I'm using to build Ro Interface for IMS. I am not concerned about nathelper??? The only code that will move into master when I am done is the ims_ro module......
the commit was to nathelper module. fine with me if it does not ever end up merged with master.
-- juha
Ahh yes, Ok that was becuase I synced form master (looks like a change from rfuchs). but again, this will only affect my branch.
FYI: commit 6543308deaf3ac029ec7db06f7535883006b1f00 Author: Richard Fuchs rfuchs@sipwise.com Date: Wed Feb 27 11:17:03 2013 -0500
nathelper: add new option sipping_disable_bflag
Cheers Jason
On Mon, Mar 11, 2013 at 9:28 AM, Juha Heinanen jh@tutpro.com wrote:
Jason Penton writes:
This is my branch I'm using to build Ro Interface for IMS. I am not concerned about nathelper??? The only code that will move into master
when
I am done is the ims_ro module......
the commit was to nathelper module. fine with me if it does not ever end up merged with master.
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
i just checked and
4.8. sipping_disable_bflag (integer)
is in current master.
i don't know who put it there, but please either remove the var or fix its name/description.
-- juha
-
Jason Penton -
Jason Penton -
Juha Heinanen