[kamailio/kamailio] $xavp(reg=>max_contacts)=1 < modparam("registrar", "max_contacts", 10) does not work (#2471)
<!-- Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests.
If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:
* http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.
If you submit a feature request (or enhancement) add the description of what you would like to be added.
If there is no content to be filled in a section, the entire section can be removed.
You can delete the comments from the template sections when filling.
You can delete next line and everything above before submitting (it is a comment). -->
### Description
<!-- Explain what you did, what you expected to happen, and what actually happened. --> I'd like to reduce the number of contacts per AOR for certain UAs, while maintaining a default higher limit. ``` modparam("registrar", "max_contacts", 10) modparam("registrar", "xavp_cfg", "reg")
route[REGISTRAR] { if($ua=~"^Yealink") { $xavp(reg=>max_contacts)=1; }
if(!save("location")) { sl_reply_error(); } exit; } ```
### Expected behavior https://www.kamailio.org/docs/modules/stable/modules/registrar#registrar.p.x... states: * max_contacts - the number of maximum contacts to be stored for the current registration AoR. It **overwrites** the 'max_contacts' module parameter value.
I expect that the UA will register with the new contact and have all others removed.
#### Actual observed behavior `$xavp(reg=>max_contacts)` set to a value lower than the `max_contacts` modparam does not achieve the **overwrites** expectation from the documentation.
#### Log Messages
<!-- Check the syslog file and if there are relevant log messages printed by Kamailio, add them next, or attach to issue, or provide a link to download them (e.g., to a pastebin site). -->
``` INFO: registrar [save.c:619]: test_max_contacts(): too many contacts for AOR user@example.com ```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
``` version: kamailio 5.4.1-1.gite1d4ddcb6c.fc32 (x86_64/linux) 09fd6a flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 09fd6a compiled on 00:00:00 Sep 5 2020 with gcc 10.2.1 ```
* **Operating System**:
<!-- Details about the operating system, the type: Linux (e.g.,: Debian 8.4, Ubuntu 16.04, CentOS 7.1, ...), MacOS, xBSD, Solaris, ...; Kernel details (output of `uname -a`) -->
``` Fedora 32, kernel-5.8.4-200.fc32.x86_64 ```
The module behaves in another way, i think. The max_contacts parameter will disallow new registration and also update of existing registrations. But it will not remove old existing registrations by itself. The docs can be always extended to make it more clear, otherwise this is probably a feature request.
@henningw sorry I though I hit the feature request button when creating this.
@amessina No, actually i did a mistake in my reply, you filed it all right as feature request.
Because the registration process in sip is periodical, but each endpoint can select its expires interval, the oldest contact may hit a valid record, for example the case of a user with a fixed end point registering every 3600 seconds and another mobile one that registers every 5 min, but because of losing the wireless connectivity it keeps adding new contacts. That was the discussion where the limit of registration was decided to be done by rejecting new registrations.
Now, if you want to remove certain contacts, the oldest, older or newer, it is possible to do in config right now with reg_fetch_contacts(), then loop through contacts to decide which should be removed and do unregister() using the ruid field.
Note also that there is a flag for save() to store a single contact per user, removing the existing one -- maybe that can fit in some scenarios
Anyhow, if someone wants to make this option in the code controlled via modparam or function params, I am fine with it.
Given that it is already possible via config operations, this feature-request should be closed unless a developer engages in adding it and wants to track the evolution here. Otherwise, a PR with implementation in the C code for a simpler config can be just submitted at any time, no need to have the FR open.
Thank you @miconda. Based on your description, I was misunderstanding the documentation about the usage for this $xavp. I understood the documentation to mean that `$xavp(reg=>max_contacts)=1` would function effectively like `save("location", "0x04")`.
Closed #2471.
-
Anthony Messina -
Daniel-Constantin Mierla
-
Henning Westerholt