while testing latest master, my sip proxy didn't start and produced these errors to syslog:
Jan 19 21:32:18 lohi /usr/bin/sip-proxy[5382]: BUG: <core> [core/select.c:376]: resolve_select(): final node has SEL_PARAM_EXPECTED set (no more parameters available) Jan 19 21:32:18 lohi /usr/bin/sip-proxy[5382]: ERROR: <core> [core/rvalue.c:2879]: fix_rval(): Unable to resolve select
it is very difficult to find what went wrong because no config line number is associated with the errors.
-- juha
I just pushed a patch that should print cfg line and column in such case. Can you test and see if works ok?
Cheers, Daniel
On 19/01/2017 20:35, Juha Heinanen wrote:
while testing latest master, my sip proxy didn't start and produced these errors to syslog:
Jan 19 21:32:18 lohi /usr/bin/sip-proxy[5382]: BUG: <core> [core/select.c:376]: resolve_select(): final node has SEL_PARAM_EXPECTED set (no more parameters available) Jan 19 21:32:18 lohi /usr/bin/sip-proxy[5382]: ERROR: <core> [core/rvalue.c:2879]: fix_rval(): Unable to resolve select
it is very difficult to find what went wrong because no config line number is associated with the errors.
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Daniel-Constantin Mierla writes:
I just pushed a patch that should print cfg line and column in such case. Can you test and see if works ok?
The commit didn't change the syslog output. The commit checks if fix_rval returns negative result:
case RVE_RVAL_OP: ret = fix_rval(&rve->left.rval); if (ret<0) goto error; return ret;
but looks like it always returns 0:
static int fix_rval(struct rvalue* rv) { ... case RV_SEL: if (resolve_select(&rv->v.sel)<0){ ERR("Unable to resolve select\n"); print_select(&rv->v.sel); } return 0;
-- Juha
On 21/01/2017 01:49, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
I just pushed a patch that should print cfg line and column in such case. Can you test and see if works ok?
The commit didn't change the syslog output. The commit checks if fix_rval returns negative result:
case RVE_RVAL_OP: ret = fix_rval(&rve->left.rval); if (ret<0) goto error; return ret;but looks like it always returns 0:
static int fix_rval(struct rvalue* rv) { ... case RV_SEL: if (resolve_select(&rv->v.sel)<0){ ERR("Unable to resolve select\n"); print_select(&rv->v.sel); } return 0;
I pushed another commit for it.
Cheers, Daniel
Daniel-Constantin Mierla writes:
I pushed another commit for it.
Thanks, now I got the line number:
Jan 24 06:45:39 lohi /usr/bin/sip-proxy[8809]: BUG: <core> [core/select.c:376]: resolve_select(): final node has SEL_PARAM_EXPECTED set (no more parameters available) Jan 24 06:45:39 lohi /usr/bin/sip-proxy[8809]: ERROR: <core> [core/rvalue.c:2883]: fix_rval(): Unable to resolve select in cfg at line: 4090 col: 23
-- Juha
-
Daniel-Constantin Mierla -
Juha Heinanen