Module: kamailio Branch: master Commit: ce19d9212feb0ff4b017b5eaa71e4637a71aa4b9 URL: https://github.com/kamailio/kamailio/commit/ce19d9212feb0ff4b017b5eaa71e4637...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: 2019-09-09T08:34:08+02:00
siptrace: turn warn into info message about loading dlg api
- dialog tracking is optional
---
Modified: src/modules/siptrace/siptrace.c
---
Diff: https://github.com/kamailio/kamailio/commit/ce19d9212feb0ff4b017b5eaa71e4637... Patch: https://github.com/kamailio/kamailio/commit/ce19d9212feb0ff4b017b5eaa71e4637...
---
diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 211ddac363..35bfb1c78a 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -335,9 +335,8 @@ static int mod_init(void) }
if (load_dlg_api(&dlgb) < 0) { - LM_WARN("can't load dlg api. Will not install dialog callbacks.\n"); - } - else { + LM_INFO("can't load dlg api. Will not install dialog callbacks.\n"); + } else { if (dlgb.register_dlgcb(NULL, DLGCB_CREATED, trace_dialog, NULL, NULL) != 0) { LM_ERR("failed to register dialog callbacks! Tracing dialogs won't be available\n"); }
Daniel-Constantin Mierla writes:
siptrace: turn warn into info message about loading dlg api
Info is better than warning, but I would prefer no message at all. These kind of things are in README file and don't need to appear in syslog.
The code should check if dialog module is available when tracing of a dialog is attempted and issue an error if that is not the case.
There are lots of other similar cases when a function cannot be executed if required modules are not loaded or if a certain module variable is not set accordingly.
-- Juha
On 09.09.19 08:46, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
siptrace: turn warn into info message about loading dlg api
Info is better than warning, but I would prefer no message at all. These kind of things are in README file and don't need to appear in syslog.
The code should check if dialog module is available when tracing of a dialog is attempted and issue an error if that is not the case.
There are lots of other similar cases when a function cannot be executed if required modules are not loaded or if a certain module variable is not set accordingly.
In this case I guess that the developer followed the pattern in the module for loading tm and sl APIs, when an warning is printed if the their APIs cannot be loaded. However, sl and tm were like requirement to be able to save all the sip traffic. Tracking dialog is for convenience or specific needs.
There will be no message for this case when the way to disable dialog tracking is figured out.
Cheers, Daniel
-
Daniel-Constantin Mierla -
Juha Heinanen