<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> The timeout_socket feature has been added in 2010, but from the look of it it has been designed for the "ngcp-mediaproxy-ng" and never worked with the real RTPProxy. As such both the documentation and the code needs to be adjusted to make it actually useful with the RTPProxy. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3598
-- Commit Summary --
* Make timeout notification useable by allowing a notify tag to * Update rtpproxy module documentation:
-- File Changes --
M src/modules/rtpproxy/doc/rtpproxy.xml (2) M src/modules/rtpproxy/doc/rtpproxy_admin.xml (38) M src/modules/rtpproxy/rtpproxy.c (53)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3598.patch https://github.com/kamailio/kamailio/pull/3598.diff
@sobomax pushed 2 commits.
fd830f2b2bbcb0d1340b0141679697a832a68333 Make timeout notification useable by allowing a notify tag to d2f9b0e5c5397dbc2636f6c484df5ccbc4562193 Update rtpproxy module documentation:
The check fails due to unrelated issue:
` A fatal error occurred: Could not write a relation to a file (eventual cause: IOException "No space left on device") Error: Error running analysis for cpp: Encountered a fatal error while running "/opt/hostedtoolcache/CodeQL/2.15.0/x64/codeql/codeql database run-queries --ram=5897 --threads=2 /home/runner/work/_temp/codeql_databases/cpp --min-disk-free=1024 -v --expect-discarded-cache --no-intra-layer-parallelism". Exit code was 2 and error was: A fatal error occurred: Could not write a relation to a file (eventual cause: IOException "No space left on device"). See the logs for more details.`
@sobomax pushed 2 commits.
bc5f395172a4cb8641098c0e415deeae3b1d95c2 Make timeout notification useable by allowing a notify tag to ea8e9d15752c6d6aa657aa6d9d4012b41d1ff10c Update rtpproxy module documentation:
Thanks!
Is the PR completed? If yes, I would merge it manually to make the commit message follow the contributing guidelines:
- https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
Thanks!
Is the PR completed? If yes, I would merge it manually to make the commit message follow the contributing guidelines:
Hi Daniel, yes, it's complete. Thanks for pointing out, I've updated the commit messages to hopefully conform to the guidelines.
amended the commit messages to use ``rtpproxy:`` as prefix. Thanks! 8ac570943f1dfd47f9d02686cc399d3cd1cdcd92 190ef9a54df33b4d053a4225e9d6257e0a045008
Closed #3598.