- Use heap memory for the reason code instead of the stack memory. - See issue #2981
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2981 (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3137
-- Commit Summary --
* acc: Fix reason code for locally generated replies.
-- File Changes --
M src/modules/acc/acc_logic.c (17)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3137.patch https://github.com/kamailio/kamailio/pull/3137.diff
@linuxmaniac commented on this pull request.
@@ -93,15 +93,18 @@ void env_set_totag(struct cell *t, struct sip_msg *reply)
tmb.t_get_reply_totag(t->uas.request, &acc_env.to_tag); }
-int env_set_reason(struct sip_msg *reply, str *buff) { +int env_set_reason(struct sip_msg *reply, str *buff, int code) { +/*
please don't comment code, just remove it
Indeed, the code that is no longer needed must be removed, otherwise it makes it hard to understand the changes done the patch and in long term the code will become a mess. Comments should be used only to explain the code, if one wants to check a previous version, git history is the right way.
@CFrits pushed 1 commit.
c3647bb9646296731dd6232ffb4c4ed0330d5e27 acc: Remove code which was commented out.
Thanks!
Merged #3137 into master.